)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"66eb1ad575b8b063d7aeb309e65655ca1f8cc40f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixes the 404 error for bookmark url for the api"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Each api returns a bookmark url. The bookmark url does not have"},{"line_number":10,"context_line":"the version string, hence caused 404 \"Resourc could not be found\""},{"line_number":11,"context_line":"error. This patch fixes RootController to allow such url and"},{"line_number":12,"context_line":"directs the request to the current version of the api."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATH%2F%2FRyk%3D","line":10,"updated":"2013-10-18 14:40:26.000000000","message":"typo, s/Resourc/Resource/","commit_id":"3e2d81743ddfddef3c430fbac9bc9f82978f050b"},{"author":{"_account_id":7589,"name":"linggao","email":"linggao@us.ibm.com","username":"linggao"},"change_message_id":"b5b511909efdc63ab4cac397ffb5b185cc462d3f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixes the 404 error for bookmark url for the api"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Each api returns a bookmark url. The bookmark url does not have"},{"line_number":10,"context_line":"the version string, hence caused 404 \"Resourc could not be found\""},{"line_number":11,"context_line":"error. This patch fixes RootController to allow such url and"},{"line_number":12,"context_line":"directs the request to the current version of the api."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATH%2F%2FQ%2F0%3D","line":10,"in_reply_to":"AAAATH%2F%2FRyk%3D","updated":"2013-10-18 19:07:48.000000000","message":"Done","commit_id":"3e2d81743ddfddef3c430fbac9bc9f82978f050b"}],"ironic/api/controllers/root.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"66eb1ad575b8b063d7aeb309e65655ca1f8cc40f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    def _route(self, args):"},{"line_number":89,"context_line":"        \"\"\"Overrides the default routing behavour."},{"line_number":90,"context_line":"        It defaults to the current version of the ironic API if the"},{"line_number":91,"context_line":"        version number is not specified in the url."},{"line_number":92,"context_line":"        \"\"\""},{"line_number":93,"context_line":"        if args[0] and args[0] not in self._versions:"},{"line_number":94,"context_line":"            args \u003d [self._default_version] + args"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FRys%3D","line":91,"updated":"2013-10-18 14:40:26.000000000","message":"Docstring looks a bit squashed, can you put a blank line between the first line and the more elaborated description? http://www.python.org/dev/peps/pep-0257/#multi-line-docstrings","commit_id":"3e2d81743ddfddef3c430fbac9bc9f82978f050b"},{"author":{"_account_id":7589,"name":"linggao","email":"linggao@us.ibm.com","username":"linggao"},"change_message_id":"b5b511909efdc63ab4cac397ffb5b185cc462d3f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    def _route(self, args):"},{"line_number":89,"context_line":"        \"\"\"Overrides the default routing behavour."},{"line_number":90,"context_line":"        It defaults to the current version of the ironic API if the"},{"line_number":91,"context_line":"        version number is not specified in the url."},{"line_number":92,"context_line":"        \"\"\""},{"line_number":93,"context_line":"        if args[0] and args[0] not in self._versions:"},{"line_number":94,"context_line":"            args \u003d [self._default_version] + args"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FQ%2Fw%3D","line":91,"in_reply_to":"AAAATH%2F%2FRys%3D","updated":"2013-10-18 19:07:48.000000000","message":"Done","commit_id":"3e2d81743ddfddef3c430fbac9bc9f82978f050b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"66eb1ad575b8b063d7aeb309e65655ca1f8cc40f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        It defaults to the current version of the ironic API if the"},{"line_number":91,"context_line":"        version number is not specified in the url."},{"line_number":92,"context_line":"        \"\"\""},{"line_number":93,"context_line":"        if args[0] and args[0] not in self._versions:"},{"line_number":94,"context_line":"            args \u003d [self._default_version] + args"},{"line_number":95,"context_line":"        return super(RootController, self)._route(args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FRzQ%3D","line":93,"updated":"2013-10-18 14:40:26.000000000","message":"I don\u0027t think we need a list of versions there since we don\u0027t know if diff versions of the API should coexist.\n\nI think that testing it like args[0] !\u003d self._default_version should be enough.","commit_id":"3e2d81743ddfddef3c430fbac9bc9f82978f050b"},{"author":{"_account_id":7589,"name":"linggao","email":"linggao@us.ibm.com","username":"linggao"},"change_message_id":"b5b511909efdc63ab4cac397ffb5b185cc462d3f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        It defaults to the current version of the ironic API if the"},{"line_number":91,"context_line":"        version number is not specified in the url."},{"line_number":92,"context_line":"        \"\"\""},{"line_number":93,"context_line":"        if args[0] and args[0] not in self._versions:"},{"line_number":94,"context_line":"            args \u003d [self._default_version] + args"},{"line_number":95,"context_line":"        return super(RootController, self)._route(args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FQ%2Fs%3D","line":93,"in_reply_to":"AAAATH%2F%2FRrk%3D","updated":"2013-10-18 19:07:48.000000000","message":"Will keep the same code.","commit_id":"3e2d81743ddfddef3c430fbac9bc9f82978f050b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5fe12f211ac94602998abd643b3245e0e95d5b7e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        It defaults to the current version of the ironic API if the"},{"line_number":91,"context_line":"        version number is not specified in the url."},{"line_number":92,"context_line":"        \"\"\""},{"line_number":93,"context_line":"        if args[0] and args[0] not in self._versions:"},{"line_number":94,"context_line":"            args \u003d [self._default_version] + args"},{"line_number":95,"context_line":"        return super(RootController, self)._route(args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FRrk%3D","line":93,"in_reply_to":"AAAATH%2F%2FRzQ%3D","updated":"2013-10-18 15:06:11.000000000","message":"So forget the comment above, talked on IRC with linggao and seems that more than one version can/will coexist.","commit_id":"3e2d81743ddfddef3c430fbac9bc9f82978f050b"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"dbab84c95e379bb23f359c37ac013d20bb24ff21","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        version number is not specified in the url."},{"line_number":92,"context_line":"        \"\"\""},{"line_number":93,"context_line":"        if args[0] and args[0] not in self._versions:"},{"line_number":94,"context_line":"            args \u003d [self._default_version] + args"},{"line_number":95,"context_line":"        return super(RootController, self)._route(args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FS6E%3D","line":94,"updated":"2013-10-18 07:59:22.000000000","message":"Can be a non valid version be passed in the args? Like v2, so\n\nargs \u003d [ v1, v2, ....]","commit_id":"3e2d81743ddfddef3c430fbac9bc9f82978f050b"},{"author":{"_account_id":7589,"name":"linggao","email":"linggao@us.ibm.com","username":"linggao"},"change_message_id":"e091b693eb6e6bfae418c0f096d9d5a067aa2bb0","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        version number is not specified in the url."},{"line_number":92,"context_line":"        \"\"\""},{"line_number":93,"context_line":"        if args[0] and args[0] not in self._versions:"},{"line_number":94,"context_line":"            args \u003d [self._default_version] + args"},{"line_number":95,"context_line":"        return super(RootController, self)._route(args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FSFo%3D","line":94,"in_reply_to":"AAAATH%2F%2FS6E%3D","updated":"2013-10-18 13:29:36.000000000","message":"Ghe, thanks for the review. \nYes, in that case it will return 404 \"Resource could not be found\" anyway. We do not know if the first element in the path is a version number or not unless it is in _versions. Or unless we check the second element aginst the controllers included in the root controller of  version, that will too much time consuming, not good for performance.","commit_id":"3e2d81743ddfddef3c430fbac9bc9f82978f050b"}]}
