)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"b76512db9cc4caa34c34f4adeff628f7fea9e445","unresolved":false,"context_lines":[{"line_number":17,"context_line":"`ansible_username` and `ansible_key_file` respectively."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ib198c07c1d414c0d78950e5d98a5176e12a7df13"},{"line_number":20,"context_line":"Closes-Bug: #1736409"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df87a7cf_17341edd","line":20,"updated":"2017-12-11 07:24:21.000000000","message":"Will this bug be closed with this patch? Is there any documentation where the new parameters will be added?","commit_id":"da18f559c32023ac4b2c3539d216441854059b2d"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"b6e9f8017c2c63adafc288f17865db55143ba681","unresolved":false,"context_lines":[{"line_number":17,"context_line":"`ansible_username` and `ansible_key_file` respectively."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ib198c07c1d414c0d78950e5d98a5176e12a7df13"},{"line_number":20,"context_line":"Closes-Bug: #1736409"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df87a7cf_91b6f689","line":20,"in_reply_to":"df87a7cf_17341edd","updated":"2017-12-11 15:17:59.000000000","message":"We have not yet merged any docs for ansible deploy, patch is on review and already lists these new options\n\nhttps://review.openstack.org/#/c/525501","commit_id":"da18f559c32023ac4b2c3539d216441854059b2d"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ef56efdcde7d01725e101b8d71240e3250e10459","unresolved":false,"context_lines":[{"line_number":17,"context_line":"`ansible_username` and `ansible_key_file` respectively."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ib198c07c1d414c0d78950e5d98a5176e12a7df13"},{"line_number":20,"context_line":"Closes-Bug: #1736409"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df87a7cf_18fc306e","line":20,"in_reply_to":"df87a7cf_91b6f689","updated":"2017-12-12 06:12:54.000000000","message":"I got it. Thanks.","commit_id":"da18f559c32023ac4b2c3539d216441854059b2d"}],"ironic/conf/ansible.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"f157585f6b74ebd55864ae491332a2589ebc53f5","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    cfg.StrOpt(\u0027default_username\u0027,"},{"line_number":93,"context_line":"               default\u003d\u0027ansible\u0027,"},{"line_number":94,"context_line":"               help\u003d_(\"Name of the user to use for Ansible when connecting \""},{"line_number":95,"context_line":"                      \"to the ramdisk over SSH. It may be overriden \""},{"line_number":96,"context_line":"                      \"by per-node \u0027ansible_username\u0027 option \""},{"line_number":97,"context_line":"                      \"in node\u0027s \u0027driver_info\u0027 field.\")),"},{"line_number":98,"context_line":"    cfg.StrOpt(\u0027default_key_file\u0027,"},{"line_number":99,"context_line":"               help\u003d_(\"Absolute path to the private SSH key file to use \""},{"line_number":100,"context_line":"                      \"by Ansible by default when connecting to the ramdisk \""}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_5a9acbb8","line":97,"range":{"start_line":95,"start_character":48,"end_line":97,"end_character":54},"updated":"2017-12-11 08:41:42.000000000","message":"nit: this sentence is the same on all new options, might be create a var for it?","commit_id":"da18f559c32023ac4b2c3539d216441854059b2d"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"b6e9f8017c2c63adafc288f17865db55143ba681","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    cfg.StrOpt(\u0027default_username\u0027,"},{"line_number":93,"context_line":"               default\u003d\u0027ansible\u0027,"},{"line_number":94,"context_line":"               help\u003d_(\"Name of the user to use for Ansible when connecting \""},{"line_number":95,"context_line":"                      \"to the ramdisk over SSH. It may be overriden \""},{"line_number":96,"context_line":"                      \"by per-node \u0027ansible_username\u0027 option \""},{"line_number":97,"context_line":"                      \"in node\u0027s \u0027driver_info\u0027 field.\")),"},{"line_number":98,"context_line":"    cfg.StrOpt(\u0027default_key_file\u0027,"},{"line_number":99,"context_line":"               help\u003d_(\"Absolute path to the private SSH key file to use \""},{"line_number":100,"context_line":"                      \"by Ansible by default when connecting to the ramdisk \""}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_117f46ab","line":97,"range":{"start_line":95,"start_character":48,"end_line":97,"end_character":54},"in_reply_to":"df87a7cf_5a9acbb8","updated":"2017-12-11 15:17:59.000000000","message":"I\u0027m really not sure how it would work for i18n, so I\u0027d rather leave it as it is.","commit_id":"da18f559c32023ac4b2c3539d216441854059b2d"}],"ironic/drivers/modules/ansible/deploy.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"f157585f6b74ebd55864ae491332a2589ebc53f5","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"def _parse_ansible_driver_info(node, action\u003d\u0027deploy\u0027):"},{"line_number":93,"context_line":"    # TODO(pas-ha) remove in Rocky"},{"line_number":94,"context_line":"    for old, new in DEPRECATED_PROPERTIES.items():"},{"line_number":95,"context_line":"        if old in node.driver_info:"},{"line_number":96,"context_line":"            LOG.warning(\"Driver property \u0027%(old)s\u0027 is deprecated, \""},{"line_number":97,"context_line":"                        \"and will be ignored in Rocky release. \""},{"line_number":98,"context_line":"                        \"Use \u0027%(new)s\u0027 instead.\", old\u003dold, new\u003dnew)"},{"line_number":99,"context_line":"    # TODO(pas-ha) simplify in Rocky"},{"line_number":100,"context_line":"    user \u003d node.driver_info.get("},{"line_number":101,"context_line":"        \u0027ansible_username\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_da625bae","line":98,"range":{"start_line":94,"start_character":4,"end_line":98,"end_character":67},"updated":"2017-12-11 08:41:42.000000000","message":"this will spam log, lets ensure we show this message only once per conductor start.","commit_id":"da18f559c32023ac4b2c3539d216441854059b2d"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"b6e9f8017c2c63adafc288f17865db55143ba681","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"def _parse_ansible_driver_info(node, action\u003d\u0027deploy\u0027):"},{"line_number":93,"context_line":"    # TODO(pas-ha) remove in Rocky"},{"line_number":94,"context_line":"    for old, new in DEPRECATED_PROPERTIES.items():"},{"line_number":95,"context_line":"        if old in node.driver_info:"},{"line_number":96,"context_line":"            LOG.warning(\"Driver property \u0027%(old)s\u0027 is deprecated, \""},{"line_number":97,"context_line":"                        \"and will be ignored in Rocky release. \""},{"line_number":98,"context_line":"                        \"Use \u0027%(new)s\u0027 instead.\", old\u003dold, new\u003dnew)"},{"line_number":99,"context_line":"    # TODO(pas-ha) simplify in Rocky"},{"line_number":100,"context_line":"    user \u003d node.driver_info.get("},{"line_number":101,"context_line":"        \u0027ansible_username\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_913916f3","line":98,"range":{"start_line":94,"start_character":4,"end_line":98,"end_character":67},"in_reply_to":"df87a7cf_da625bae","updated":"2017-12-11 15:17:59.000000000","message":"this actually depend on node but ok, will add some globals to store warned status","commit_id":"da18f559c32023ac4b2c3539d216441854059b2d"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"f157585f6b74ebd55864ae491332a2589ebc53f5","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                             CONF.ansible.default_key_file))"},{"line_number":108,"context_line":"    try:"},{"line_number":109,"context_line":"        playbook \u003d node.driver_info.get(\u0027ansible_%s_playbook\u0027 % action,"},{"line_number":110,"context_line":"                                        getattr(CONF.ansible,"},{"line_number":111,"context_line":"                                                \u0027default_%s_playbook\u0027 % action)"},{"line_number":112,"context_line":"                                        )"},{"line_number":113,"context_line":"    except cfg.NoSuchOptError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_da39fba3","line":110,"updated":"2017-12-11 08:41:42.000000000","message":"might be I\u0027m missing something \u0027action\u0027 can take any of: deploy, clean or shutdown right? and all of them have default in config. When NoSuckOptError is possible here?","commit_id":"da18f559c32023ac4b2c3539d216441854059b2d"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"b6e9f8017c2c63adafc288f17865db55143ba681","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                             CONF.ansible.default_key_file))"},{"line_number":108,"context_line":"    try:"},{"line_number":109,"context_line":"        playbook \u003d node.driver_info.get(\u0027ansible_%s_playbook\u0027 % action,"},{"line_number":110,"context_line":"                                        getattr(CONF.ansible,"},{"line_number":111,"context_line":"                                                \u0027default_%s_playbook\u0027 % action)"},{"line_number":112,"context_line":"                                        )"},{"line_number":113,"context_line":"    except cfg.NoSuchOptError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_4c769172","line":110,"in_reply_to":"df87a7cf_da39fba3","updated":"2017-12-11 15:17:59.000000000","message":"this is more to guard against anyone who might subclass/re-use this driver and add more specific \u0027actions\u0027/playbooks\n\nOTOH I might use getattr with None as default and raise this error if \u0027playbook\u0027 ends up being None or empty (as I do not check that the actual path is there in the first place)","commit_id":"da18f559c32023ac4b2c3539d216441854059b2d"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"6827c0d9c76cb72dc5fff6efbb63c72669a3fb18","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    \u0027ansible_clean_steps_config\u0027: _(\u0027Name of the file with default cleaning \u0027"},{"line_number":74,"context_line":"                                    \u0027steps configuration. Default is %s. \u0027"},{"line_number":75,"context_line":"                                    \u0027Optional.\u0027"},{"line_number":76,"context_line":"                                    ) % CONF.ansible.default_clean_steps_config"},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"COMMON_PROPERTIES \u003d OPTIONAL_PROPERTIES"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_b88ddf2b","line":76,"updated":"2017-12-13 11:00:48.000000000","message":"I\u0027m not sure if including the config values here is going to work as expected, it depends on whether the config file gets loaded before or after this module gets loaded which is non-deterministic, so depending on load order it\u0027ll either populate the default value from the config option or whats in the config file.","commit_id":"0da6247f63c1621e2e5f4081d53110f243008686"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"b945ea6f1f616177029e354768a3fa92f2f21efb","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    \u0027ansible_clean_steps_config\u0027: _(\u0027Name of the file with default cleaning \u0027"},{"line_number":74,"context_line":"                                    \u0027steps configuration. Default is %s. \u0027"},{"line_number":75,"context_line":"                                    \u0027Optional.\u0027"},{"line_number":76,"context_line":"                                    ) % CONF.ansible.default_clean_steps_config"},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"COMMON_PROPERTIES \u003d OPTIONAL_PROPERTIES"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_de33ebf5","line":76,"in_reply_to":"df87a7cf_b88ddf2b","updated":"2017-12-13 12:11:51.000000000","message":"indeed, that would be confusing.. I\u0027ll just remove them all.\n\nIf needed more transparency re active defaults, we could try mangle with those strings in \"get_properties\" method in the driver itself in a followup.","commit_id":"0da6247f63c1621e2e5f4081d53110f243008686"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"643388a02a59c81b085bcad9708661d90b07e757","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    \u0027ansible_clean_playbook\u0027: _(\u0027Name of the Ansible playbook used for \u0027"},{"line_number":66,"context_line":"                                \u0027cleaning. Optional.\u0027),"},{"line_number":67,"context_line":"    \u0027ansible_clean_steps_config\u0027: _(\u0027Name of the file with default cleaning \u0027"},{"line_number":68,"context_line":"                                    \u0027steps configuration. Optional.\u0027),"},{"line_number":69,"context_line":"}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"COMMON_PROPERTIES \u003d OPTIONAL_PROPERTIES"}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_b0d93823","line":68,"updated":"2017-12-15 13:43:09.000000000","message":"I\u0027d prefer we add ansible_playbook_path here as well..","commit_id":"b46f0235a0d8d41ff0e5c6014c34878b82103a67"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"856dba94599711a471c494b692bb1d271db65394","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    \u0027ansible_clean_playbook\u0027: _(\u0027Name of the Ansible playbook used for \u0027"},{"line_number":66,"context_line":"                                \u0027cleaning. Optional.\u0027),"},{"line_number":67,"context_line":"    \u0027ansible_clean_steps_config\u0027: _(\u0027Name of the file with default cleaning \u0027"},{"line_number":68,"context_line":"                                    \u0027steps configuration. Optional.\u0027),"},{"line_number":69,"context_line":"}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"COMMON_PROPERTIES \u003d OPTIONAL_PROPERTIES"}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_b35014d7","line":68,"in_reply_to":"df87a7cf_b0d93823","updated":"2017-12-19 11:13:57.000000000","message":"That\u0027s also an option indeed... Will add.","commit_id":"b46f0235a0d8d41ff0e5c6014c34878b82103a67"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"18f647da395cc7252c7cbeea085512b013ca7830","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    clean_steps_file \u003d node.driver_info.get("},{"line_number":354,"context_line":"        \u0027ansible_clean_steps_config\u0027, CONF.ansible.default_clean_steps_config)"},{"line_number":355,"context_line":"    path \u003d os.path.join(node.driver_info.get(\u0027ansible_playbooks_path\u0027,"},{"line_number":356,"context_line":"                                             CONF.ansible.playbooks_path),"},{"line_number":357,"context_line":"                        os.path.basename(clean_steps_file))"},{"line_number":358,"context_line":"    try:"},{"line_number":359,"context_line":"        with open(path) as f:"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf8cb3f7_d262f716","line":356,"updated":"2017-12-21 12:27:15.000000000","message":"nit: _get_playbooks_path() can be used here.","commit_id":"ce7119eaf3e32ac7d27df11c7f0a1f65159d255f"}],"ironic/tests/unit/drivers/modules/ansible/test_deploy.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ef56efdcde7d01725e101b8d71240e3250e10459","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.assertEqual(\u0027test\u0027, user)"},{"line_number":108,"context_line":"        self.assertEqual(\u0027/path/key\u0027, key)"},{"line_number":109,"context_line":"        self.assertEqual(2, warn_mock.call_count)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test__parse_ansible_driver_info_no_playbook(self):"},{"line_number":112,"context_line":"        self.assertRaises(exception.IronicException,"},{"line_number":113,"context_line":"                          ansible_deploy._parse_ansible_driver_info,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_f814ecea","line":110,"updated":"2017-12-12 06:12:54.000000000","message":"It might be better to call _parse_ansible_driver_info() again and to confirm the call count of warning is not increased.","commit_id":"0da6247f63c1621e2e5f4081d53110f243008686"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"b945ea6f1f616177029e354768a3fa92f2f21efb","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.assertEqual(\u0027test\u0027, user)"},{"line_number":108,"context_line":"        self.assertEqual(\u0027/path/key\u0027, key)"},{"line_number":109,"context_line":"        self.assertEqual(2, warn_mock.call_count)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test__parse_ansible_driver_info_no_playbook(self):"},{"line_number":112,"context_line":"        self.assertRaises(exception.IronicException,"},{"line_number":113,"context_line":"                          ansible_deploy._parse_ansible_driver_info,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_de19ab22","line":110,"in_reply_to":"df87a7cf_f814ecea","updated":"2017-12-13 12:11:51.000000000","message":"Done","commit_id":"0da6247f63c1621e2e5f4081d53110f243008686"}],"releasenotes/notes/ansible-deploy-15da234580ca0c30.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"13f048affad278d2ee46295da0f6f5b215a475f8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      respectively"},{"line_number":22,"context_line":"    - base path for playbooks can be defined in driver_info as well"},{"line_number":23,"context_line":"      (as \u0027ansible_playbooks_path\u0027 field, defaults to the value of"},{"line_number":24,"context_line":"      ``[ansible]/playbooks_path`` from ironic configuration file"},{"line_number":25,"context_line":"    - default playbooks for actions and cleaning steps file can be set in"},{"line_number":26,"context_line":"      ironic configuration file as various ``[ansible]/default_*`` options."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bf8cb3f7_631ebf0d","line":24,"updated":"2017-12-21 14:02:53.000000000","message":"nit: unclosed bracket","commit_id":"ce7119eaf3e32ac7d27df11c7f0a1f65159d255f"}],"releasenotes/notes/ansible-driver-info-deprecations-73b9d5e905931a2e.yaml":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"f157585f6b74ebd55864ae491332a2589ebc53f5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    For nodes using ``ansible`` deploy interface, options"},{"line_number":5,"context_line":"    ``ansible_deploy_username`` and ``ansible_deploy_key_file`` in the"},{"line_number":6,"context_line":"    node\u0027s ``driver_info`` are deprecated and will be ignored"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df87a7cf_ba5bd7f3","line":3,"updated":"2017-12-11 08:41:42.000000000","message":"Please add information about new config options in upgrade section.","commit_id":"da18f559c32023ac4b2c3539d216441854059b2d"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ef56efdcde7d01725e101b8d71240e3250e10459","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    For nodes using ``ansible`` deploy interface, options"},{"line_number":5,"context_line":"    ``ansible_deploy_username`` and ``ansible_deploy_key_file`` in the"},{"line_number":6,"context_line":"    node\u0027s ``driver_info`` are deprecated and will be ignored"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df87a7cf_d8c32837","line":3,"in_reply_to":"df87a7cf_604ef938","updated":"2017-12-12 06:12:54.000000000","message":"Would it be worth merging this release note with the release note for adding ansible deploy interface to show these changes will be released together?","commit_id":"da18f559c32023ac4b2c3539d216441854059b2d"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"b6e9f8017c2c63adafc288f17865db55143ba681","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    For nodes using ``ansible`` deploy interface, options"},{"line_number":5,"context_line":"    ``ansible_deploy_username`` and ``ansible_deploy_key_file`` in the"},{"line_number":6,"context_line":"    node\u0027s ``driver_info`` are deprecated and will be ignored"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df87a7cf_604ef938","line":3,"in_reply_to":"df87a7cf_ba5bd7f3","updated":"2017-12-11 15:17:59.000000000","message":"not actually sure re upgrade, as we do not have any \u0027release\u0027 of ironic with ansible deploy to upgrade from,\nexcept for people using the staging.. but they\u0027d have to switch hw type/interfaces anyway..","commit_id":"da18f559c32023ac4b2c3539d216441854059b2d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"643388a02a59c81b085bcad9708661d90b07e757","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    ``ansible_deploy_username`` and ``ansible_deploy_key_file`` in the"},{"line_number":6,"context_line":"    node\u0027s ``driver_info`` are deprecated and will be ignored"},{"line_number":7,"context_line":"    in the Rocky release."},{"line_number":8,"context_line":"    Instead, use ``ansible_username`` and ``ansible_key_file`` respectively."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df87a7cf_d0d4fceb","line":8,"updated":"2017-12-15 13:43:09.000000000","message":"we haven\u0027t released the ansible deploy, have we? if so, it does not make sense to issue the deprecation warning to me. or you should update the previous release note to mention the difference between in-tree and out-of-tree ansible deploy.","commit_id":"b46f0235a0d8d41ff0e5c6014c34878b82103a67"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"856dba94599711a471c494b692bb1d271db65394","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    ``ansible_deploy_username`` and ``ansible_deploy_key_file`` in the"},{"line_number":6,"context_line":"    node\u0027s ``driver_info`` are deprecated and will be ignored"},{"line_number":7,"context_line":"    in the Rocky release."},{"line_number":8,"context_line":"    Instead, use ``ansible_username`` and ``ansible_key_file`` respectively."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df87a7cf_7337ecb1","line":8,"in_reply_to":"df87a7cf_d0d4fceb","updated":"2017-12-19 11:13:57.000000000","message":"was actually my feeling too. I\u0027ll update the previous note instead","commit_id":"b46f0235a0d8d41ff0e5c6014c34878b82103a67"}]}