)]}'
{"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b2ab93f36f6f79dfbefcffca46e0efe1f6b86430","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        if state[0] \u003d\u003d states.POWER_ON:"},{"line_number":129,"context_line":"            raise loopingcall.LoopingCallDone()"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        if retries[0] \u003e CONF.ipmi.ipmi_power_retry:"},{"line_number":132,"context_line":"            state[0] \u003d states.ERROR"},{"line_number":133,"context_line":"            raise loopingcall.LoopingCallDone()"},{"line_number":134,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FSU4%3D","line":131,"updated":"2013-10-18 12:17:22.000000000","message":"ipmi.ipmi_power_retry overcomplex IMO, maybe something like ipmi.power_retry?\nAnd maybe separate groups for ipmi and native_ipmi?","commit_id":"2693af93e0c0bacaee8e5ad4b99a9e01d973afc0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"bab82be91cd440cd9d0214ed76f4cb276723b377","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        if state[0] \u003d\u003d states.POWER_ON:"},{"line_number":129,"context_line":"            raise loopingcall.LoopingCallDone()"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        if retries[0] \u003e CONF.ipmi.ipmi_power_retry:"},{"line_number":132,"context_line":"            state[0] \u003d states.ERROR"},{"line_number":133,"context_line":"            raise loopingcall.LoopingCallDone()"},{"line_number":134,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FSGI%3D","line":131,"in_reply_to":"AAAATH%2F%2FSU4%3D","updated":"2013-10-18 13:20:18.000000000","message":"+1 for renaming\n\n-1 for having a different group, I think it will be overcomplex. In my understand both are IPMI drivers so they could share the same \u0027ipmi\u0027 group, as well as they share the same \u0027ipmi_\u0027 namespace when looking at driver_info.","commit_id":"2693af93e0c0bacaee8e5ad4b99a9e01d973afc0"}]}
