)]}'
{"ironic/drivers/modules/ansible/playbooks/roles/configure/tasks/grub.yaml":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"51318e724fc4b8118d5b3097be4d883724f57827","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  command: mount -o bind /{{ item }} {{ tmp_rootfs_mount }}/{{ item }}"},{"line_number":49,"context_line":"  with_items:"},{"line_number":50,"context_line":"    - dev"},{"line_number":51,"context_line":"    - sys"},{"line_number":52,"context_line":"    - proc"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- block:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df87a7cf_562e5143","line":51,"range":{"start_line":51,"start_character":2,"end_line":51,"end_character":9},"updated":"2017-12-19 15:26:07.000000000","message":"might be that the bug is here, at least IPA does this thing a bit different\n\nhttps://github.com/openstack/ironic-python-agent/blob/5ee16ee2e8bd41984ceeb3647509b5e5f34e1575/ironic_python_agent/extensions/image.py#L79-L144","commit_id":"653ac747d06a342d95b98d422e62882682f0034a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c996c132be46c0fe1a86a5f4b0d143bddae8feb8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    become: yes"},{"line_number":75,"context_line":"    command: umount {{ tmp_rootfs_mount }}/{{ item }}"},{"line_number":76,"context_line":"    register: task_result"},{"line_number":77,"context_line":"    retries: 10"},{"line_number":78,"context_line":"    delay: 1"},{"line_number":79,"context_line":"    until: task_result.rc \u003d\u003d 0"},{"line_number":80,"context_line":"    with_items:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df87a7cf_760a75d2","line":77,"range":{"start_line":77,"start_character":13,"end_line":77,"end_character":14},"updated":"2017-12-19 15:12:44.000000000","message":"in the IPA we also have retries configure around umount logic, makes reasonable to do the same here. \n\nhttps://github.com/openstack/ironic-python-agent/blob/5ee16ee2e8bd41984ceeb3647509b5e5f34e1575/ironic_python_agent/extensions/image.py#L162","commit_id":"653ac747d06a342d95b98d422e62882682f0034a"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"51318e724fc4b8118d5b3097be4d883724f57827","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- name: mount /sys for chroot"},{"line_number":54,"context_line":"  become: yes"},{"line_number":55,"context_line":"  command: mount -t sysfs sysfs {{ tmp_rootfs_mount }}/sys"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- block:"},{"line_number":58,"context_line":"  - name: get grub version string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df87a7cf_f6d765be","line":55,"range":{"start_line":55,"start_character":26,"end_line":55,"end_character":31},"updated":"2017-12-19 15:26:07.000000000","message":"/sys ?","commit_id":"dd476ccdc645e39bebef8ac57aca3b9d1dbfc0aa"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"db5a3948953fe1e9ed4d02dea63f42ade4e894e6","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- name: mount /sys for chroot"},{"line_number":54,"context_line":"  become: yes"},{"line_number":55,"context_line":"  command: mount -t sysfs sysfs {{ tmp_rootfs_mount }}/sys"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- block:"},{"line_number":58,"context_line":"  - name: get grub version string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df87a7cf_58242a60","line":55,"range":{"start_line":55,"start_character":26,"end_line":55,"end_character":31},"updated":"2017-12-20 09:43:05.000000000","message":"nit: to be consistent with IPA it should be \u0027none\u0027,\nbut according to kernel docs sysfs should be mounted in this way \n\nhttps://github.com/openstack/ironic-python-agent/blob/5ee16ee2e8bd41984ceeb3647509b5e5f34e1575/ironic_python_agent/extensions/image.py#L99\n\nhttps://www.kernel.org/doc/Documentation/filesystems/sysfs.txt","commit_id":"051151832c71162f976a982c9b4a495edca6a490"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"db5a3948953fe1e9ed4d02dea63f42ade4e894e6","unresolved":false,"context_lines":[{"line_number":83,"context_line":"  - name: unmount dirs for chroot"},{"line_number":84,"context_line":"    become: yes"},{"line_number":85,"context_line":"    command: umount {{ tmp_rootfs_mount }}/{{ item }}"},{"line_number":86,"context_line":"    with_items:"},{"line_number":87,"context_line":"      - proc"},{"line_number":88,"context_line":"      - dev"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df87a7cf_b8c1b656","line":86,"updated":"2017-12-20 09:43:05.000000000","message":"why not add retries here? we have them in IPA\nhttps://github.com/openstack/ironic-python-agent/blob/5ee16ee2e8bd41984ceeb3647509b5e5f34e1575/ironic_python_agent/extensions/image.py#L171","commit_id":"051151832c71162f976a982c9b4a495edca6a490"}]}
