)]}'
{"ironic/drivers/pxe.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"51d214819547a9ea4529aa9502d41c0ca28fc4b5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from ironic.drivers import irmc"},{"line_number":24,"context_line":"from ironic.drivers import snmp"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# For backward compatibility"},{"line_number":28,"context_line":"PXEAndCIMCDriver \u003d cisco_ucs.PXEAndCIMCDriver"},{"line_number":29,"context_line":"PXEAndUcsDriver \u003d cisco_ucs.PXEAndUcsDriver"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf8cb3f7_5bcb74a4","line":26,"updated":"2017-12-20 20:25:01.000000000","message":"I am a little concerned that we\u0027re massively changing this file, and wonder if there is any way to do it with-in this file to (a) keep things in the same place, and (b) minimize churn to the file. I feel B is a bit more important as many downstream consumers/customizers modify this file, and while a massive merge conflict might be okay for some, it is going to be a deterrent for others.\n\nThe alternative, that I could see is make these changes as-is, and place a note referencing the bug that drove this change, as well as a release note for operators that are upgrading so they can read the release notes and understand that that they may need to update their downstream driver integration/changes.","commit_id":"a34c174f45c38bd525f40f83c14d0cc763ec9958"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"3fd13b450cc8bc9c03cddc7ff48dbf45c3bf0696","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from ironic.drivers import irmc"},{"line_number":24,"context_line":"from ironic.drivers import snmp"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# For backward compatibility"},{"line_number":28,"context_line":"PXEAndCIMCDriver \u003d cisco_ucs.PXEAndCIMCDriver"},{"line_number":29,"context_line":"PXEAndUcsDriver \u003d cisco_ucs.PXEAndUcsDriver"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf8cb3f7_960471c8","line":26,"in_reply_to":"bf8cb3f7_5bcb74a4","updated":"2017-12-20 21:08:51.000000000","message":"There are other ways to solve the problem I have. For example, we could move imports into the driver __init__ method. Now that we used NamedExtensionManager, it would work.\n\nThat said, not being an ironic developer, I find it a bit concerning that you want to keep the module structure. APIs should be defined and be entrypoints for customization, not actual python file.","commit_id":"a34c174f45c38bd525f40f83c14d0cc763ec9958"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"399b2b797f8427745e8abed523692e764b21acb5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from ironic.drivers import irmc"},{"line_number":24,"context_line":"from ironic.drivers import snmp"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# For backward compatibility"},{"line_number":28,"context_line":"PXEAndCIMCDriver \u003d cisco_ucs.PXEAndCIMCDriver"},{"line_number":29,"context_line":"PXEAndUcsDriver \u003d cisco_ucs.PXEAndUcsDriver"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf8cb3f7_1d14d9f4","line":26,"in_reply_to":"bf8cb3f7_960471c8","updated":"2017-12-22 15:17:18.000000000","message":"My concern is not over the entrypoints locations, but the massive delta in the file. We need to remember, operators are also not developers, and merge conflicts only prevent them moving across versions.\n\nMoving the imports into __init__ kind of sounds like a better idea to me, in the grand scheme of things.","commit_id":"a34c174f45c38bd525f40f83c14d0cc763ec9958"}]}