)]}'
{"ironic/api/__init__.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1507bd0b10d4f786af9667921e47355be77a099c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"               default\u003d1000,"},{"line_number":32,"context_line":"               help\u003d\u0027the maximum number of items returned in a single \u0027"},{"line_number":33,"context_line":"                    \u0027response from a collection resource\u0027),"},{"line_number":34,"context_line":"        cfg.IntOpt(\u0027api_driver_interval\u0027,"},{"line_number":35,"context_line":"               default\u003d120,"},{"line_number":36,"context_line":"               help\u003d\u0027Maximum time since last check-in for drivers\u0027),"},{"line_number":37,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F4gE%3D","line":34,"updated":"2013-10-25 18:10:26.000000000","message":"I dont think this should be an API option, as it will affect internal timeouts and such (eventually, once those are implemented).\n\nPerhaps a manager option?","commit_id":"f55ce670a71b4d12b727bfe89c8943d6618845d0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"779f18a9d4737810ba5d5d049cc81056fdc82721","unresolved":false,"context_lines":[{"line_number":31,"context_line":"               default\u003d1000,"},{"line_number":32,"context_line":"               help\u003d\u0027the maximum number of items returned in a single \u0027"},{"line_number":33,"context_line":"                    \u0027response from a collection resource\u0027),"},{"line_number":34,"context_line":"        cfg.IntOpt(\u0027api_driver_interval\u0027,"},{"line_number":35,"context_line":"               default\u003d120,"},{"line_number":36,"context_line":"               help\u003d\u0027Maximum time since last check-in for drivers\u0027),"},{"line_number":37,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FxU8%3D","line":34,"in_reply_to":"AAAATn%2F%2F4gE%3D","updated":"2013-10-29 10:35:23.000000000","message":"Indeed, I was unsure where to put this option when I was writing this patch. Will change that, ta much!","commit_id":"f55ce670a71b4d12b727bfe89c8943d6618845d0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1507bd0b10d4f786af9667921e47355be77a099c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"opt_group \u003d cfg.OptGroup(name\u003d\u0027api\u0027,"},{"line_number":41,"context_line":"                         title\u003d\u0027Options for the ironic-api service\u0027)"},{"line_number":42,"context_line":"CONF.register_group(opt_group)"},{"line_number":43,"context_line":"CONF.register_opts(API_SERVICE_OPTS)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F4fw%3D","line":43,"updated":"2013-10-25 18:10:26.000000000","message":"I just noticed a bug here\n\nhttps://bugs.launchpad.net/ironic/+bug/1244742","commit_id":"f55ce670a71b4d12b727bfe89c8943d6618845d0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"779f18a9d4737810ba5d5d049cc81056fdc82721","unresolved":false,"context_lines":[{"line_number":40,"context_line":"opt_group \u003d cfg.OptGroup(name\u003d\u0027api\u0027,"},{"line_number":41,"context_line":"                         title\u003d\u0027Options for the ironic-api service\u0027)"},{"line_number":42,"context_line":"CONF.register_group(opt_group)"},{"line_number":43,"context_line":"CONF.register_opts(API_SERVICE_OPTS)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FxVA%3D","line":43,"in_reply_to":"AAAATn%2F%2F4fw%3D","updated":"2013-10-29 10:35:23.000000000","message":"Oh good catch! Will fix that","commit_id":"f55ce670a71b4d12b727bfe89c8943d6618845d0"}],"ironic/tests/api/test_drivers.py":[{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"66eb17c78c88197b9967b48f300ec0fb66d60679","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        self.assertEqual(len(drivers), len(data[\u0027drivers\u0027]))"},{"line_number":32,"context_line":"        # Assert all drivers were listed"},{"line_number":33,"context_line":"        self.assertTrue(all([d[\u0027name\u0027] in drivers for d in data[\u0027drivers\u0027]]))"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FwNY%3D","line":33,"updated":"2013-10-29 14:58:32.000000000","message":"Improvement suggestion:\nassertEqual(sorted(drivers), \n            sorted([d[\u0027name\u0027] for d in data[\u0027drivers\u0027]]))\nThis would give us more meaningful message in case of fail. And it also does length comparison","commit_id":"bd7cdd4071d746655155c4ae65708fe2e669e52b"}]}