)]}'
{"ironic/tests/db/test_nodes.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"369571d16e715f373ac46b8803711e821c4fdf48","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        res_uuids \u003d [r.uuid for r in res]"},{"line_number":340,"context_line":"        self.assertEqual(len(res_uuids), 1)"},{"line_number":341,"context_line":"        self.assertTrue(len(uuids_with_instance) \u003e len(res_uuids))"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    def test_get_unassociated_nodes(self):"},{"line_number":344,"context_line":"        (uuids, uuids_with_instance) \u003d self._create_associated_nodes()"},{"line_number":345,"context_line":"        uuids_without_instance \u003d list(set(uuids) - set(uuids_with_instance))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATX%2F%2F%2FzA%3D","line":342,"updated":"2013-10-23 09:02:52.000000000","message":"Hi Ling, can we have more cases to cover the limit\u003e1, and test more input parameters, I know we are calling _paginate_query method, and it is better that we do some code to integrate testing.","commit_id":"fb878885475824a12ef4179971d264a4daeb167a"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"e6260c29c361bf876351e04522ef934baac80b26","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        res_uuids \u003d [r.uuid for r in res]"},{"line_number":340,"context_line":"        self.assertEqual(len(res_uuids), 1)"},{"line_number":341,"context_line":"        self.assertTrue(len(uuids_with_instance) \u003e len(res_uuids))"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    def test_get_unassociated_nodes(self):"},{"line_number":344,"context_line":"        (uuids, uuids_with_instance) \u003d self._create_associated_nodes()"},{"line_number":345,"context_line":"        uuids_without_instance \u003d list(set(uuids) - set(uuids_with_instance))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F%2F8Y%3D","line":342,"in_reply_to":"AAAATX%2F%2F%2BT0%3D","updated":"2013-10-24 02:05:15.000000000","message":"OK, got it, thanks for your response in such details.","commit_id":"fb878885475824a12ef4179971d264a4daeb167a"},{"author":{"_account_id":7589,"name":"linggao","email":"linggao@us.ibm.com","username":"linggao"},"change_message_id":"c24d3d81434b8f66e1a7db95ccaf7ca3aa0c2069","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        res_uuids \u003d [r.uuid for r in res]"},{"line_number":340,"context_line":"        self.assertEqual(len(res_uuids), 1)"},{"line_number":341,"context_line":"        self.assertTrue(len(uuids_with_instance) \u003e len(res_uuids))"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    def test_get_unassociated_nodes(self):"},{"line_number":344,"context_line":"        (uuids, uuids_with_instance) \u003d self._create_associated_nodes()"},{"line_number":345,"context_line":"        uuids_without_instance \u003d list(set(uuids) - set(uuids_with_instance))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATX%2F%2F%2BT0%3D","line":342,"in_reply_to":"AAAATX%2F%2F%2FzA%3D","updated":"2013-10-23 13:42:16.000000000","message":"Haomeng,  thanks for the comments. \nThe purpose of this unit test is not testing _paginate_query which has been tested by db api unit test and other unit test cases. Rather it tests that the parameters can get to _paginate_query correctly. There are several other parameters such as maker, sort_key, sort_dir for _paginate_query. Testing the combination of these can be huge and no need to do it for every new functions that uses _paginate_query.\nThat\u0027s why I only chose limit to test here.","commit_id":"fb878885475824a12ef4179971d264a4daeb167a"}]}