)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"c97cd2d0dcecfcf076abb061b6c3d2442abb481f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adding condition for setting variable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Need to set variable whole_disk_image_url and"},{"line_number":10,"context_line":"whole_disk_image_checksum in tempest.conf"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Idef1bc876fe440824894332a211af9a10401e49c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f93b717_95d49349","line":10,"updated":"2018-02-02 08:15:56.000000000","message":"I agree with Dmitry. No information is given here about why the change is needed. Also, you can report a bug and add the link here.","commit_id":"58760f33a3abf91d90a53030710b8a110ec1f0e7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5b143293c349d2d90ee39a43e7c540c3e53a9d4e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ankit \u003cankit.dhn31@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-02-09 10:09:02 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding condition for setting variable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Need to set variable whole_disk_image_url and"},{"line_number":10,"context_line":"whole_disk_image_checksum in tempest.conf."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa0c359_caa87b21","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":37},"updated":"2018-02-10 05:28:20.000000000","message":"I think this is still very generic.","commit_id":"dbb080408e49ef0f3283d0b6739b96a004e71c0b"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5b143293c349d2d90ee39a43e7c540c3e53a9d4e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding condition for setting variable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Need to set variable whole_disk_image_url and"},{"line_number":10,"context_line":"whole_disk_image_checksum in tempest.conf."},{"line_number":11,"context_line":"Also setting the ping_timeout for standalone ironic"},{"line_number":12,"context_line":"like we are setting ssh_timeout in case node is"},{"line_number":13,"context_line":"taking more time for becoming active"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa0c359_8a64b323","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":51},"updated":"2018-02-10 05:28:20.000000000","message":"I think you need to give context of the scenario you are testing and how this changes are required for the same. May be opening a bug and adding the relevant log snippets of the failures would be useful.","commit_id":"dbb080408e49ef0f3283d0b6739b96a004e71c0b"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"b571213abb36f646002b093079290a20d9dc97c4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"of standalone ironic and IPXE is disabled."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also setting the ping_timeout for standalone ironic"},{"line_number":14,"context_line":"like we are setting ssh_timeout in case node is"},{"line_number":15,"context_line":"taking more time for becoming active"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Idef1bc876fe440824894332a211af9a10401e49c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa0c359_70bac36e","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":31},"updated":"2018-02-19 08:04:51.000000000","message":"It would be better to set ping_timeout with the same way as setting ssh_timeout though I\u0027m afraid I haven\u0027t found where we set ssh_timeout yet.","commit_id":"4224d7e7ac9059309dc4b4a592a3de22a1e316f2"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"e2600d47cd76311e6b6001793cb198efb458e887","unresolved":false,"context_lines":[{"line_number":11,"context_line":"of standalone ironic and IPXE is disabled."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also setting the ping_timeout for standalone ironic"},{"line_number":14,"context_line":"like we are setting ssh_timeout in case node is"},{"line_number":15,"context_line":"taking more time for becoming active"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Idef1bc876fe440824894332a211af9a10401e49c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf659307_feb3474c","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":31},"in_reply_to":"3fa0c359_70bac36e","updated":"2018-04-05 11:00:43.000000000","message":"ssh_timeout is being set in devstack project https://github.com/openstack-dev/devstack/blob/master/lib/tempest#L427. \nBut now we do set ironic related configuration in\nironic(devstack/lib/ironic) because ironic plugin is removed from devstack project and moved in ironic.","commit_id":"4224d7e7ac9059309dc4b4a592a3de22a1e316f2"}],"devstack/lib/ironic":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"d83583a4f4da487b673f66b485b86c604cf5dcbe","unresolved":false,"context_lines":[{"line_number":2311,"context_line":"    image_uuid\u003d$(openstack image show $IRONIC_PARTITIONED_IMAGE_NAME -f value -c id)"},{"line_number":2312,"context_line":"    iniset $TEMPEST_CONFIG baremetal partition_image_ref $image_uuid"},{"line_number":2313,"context_line":""},{"line_number":2314,"context_line":"    if [[ -n \"${IRONIC_HTTP_SERVER}\" || \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]] ; then"},{"line_number":2315,"context_line":"        iniset $TEMPEST_CONFIG baremetal whole_disk_image_url \"http://$IRONIC_HTTP_SERVER:$IRONIC_HTTP_PORT/${IRONIC_WHOLEDISK_IMAGE_NAME}.img\""},{"line_number":2316,"context_line":"        iniset $TEMPEST_CONFIG baremetal whole_disk_image_checksum $(md5sum $FILES/${IRONIC_WHOLEDISK_IMAGE_NAME}.img)"},{"line_number":2317,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa0c359_565ef4e6","line":2314,"updated":"2018-02-05 03:09:15.000000000","message":"This fix doesn\u0027t seem necessary because it seems that tests which require those parameters are skipped[1][2] if ipxe is not enabled. Additionally, it seems that IRONIC_HTTP_SERVER never gets empty here with a quick glance.\n\n[1] https://github.com/openstack/ironic-tempest-plugin/blob/master/ironic_tempest_plugin/tests/scenario/ironic_standalone/test_basic_ops.py#L51\n[2] https://github.com/openstack/ironic-tempest-plugin/blob/master/ironic_tempest_plugin/tests/scenario/ironic_standalone/test_basic_ops.py#L99","commit_id":"58760f33a3abf91d90a53030710b8a110ec1f0e7"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"b571213abb36f646002b093079290a20d9dc97c4","unresolved":false,"context_lines":[{"line_number":2317,"context_line":"    image_uuid\u003d$(openstack image show $IRONIC_PARTITIONED_IMAGE_NAME -f value -c id)"},{"line_number":2318,"context_line":"    iniset $TEMPEST_CONFIG baremetal partition_image_ref $image_uuid"},{"line_number":2319,"context_line":""},{"line_number":2320,"context_line":"    if [[ -n \"${IRONIC_HTTP_SERVER}\" || \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]] ; then"},{"line_number":2321,"context_line":"        iniset $TEMPEST_CONFIG baremetal whole_disk_image_url \"http://$IRONIC_HTTP_SERVER:$IRONIC_HTTP_PORT/${IRONIC_WHOLEDISK_IMAGE_NAME}.img\""},{"line_number":2322,"context_line":"        iniset $TEMPEST_CONFIG baremetal whole_disk_image_checksum $(md5sum $FILES/${IRONIC_WHOLEDISK_IMAGE_NAME}.img)"},{"line_number":2323,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa0c359_90618f3c","line":2320,"updated":"2018-02-19 08:04:51.000000000","message":"You can just remove this line to set these parameters regardless of enabling iPXE because IRONIC_HTTP_SERVER always has a value[1][2][3].\n\n[1] https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L404\n[2] https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L120\n[3] https://github.com/openstack-dev/devstack/blob/master/stackrc#L846","commit_id":"4224d7e7ac9059309dc4b4a592a3de22a1e316f2"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"e2600d47cd76311e6b6001793cb198efb458e887","unresolved":false,"context_lines":[{"line_number":2317,"context_line":"    image_uuid\u003d$(openstack image show $IRONIC_PARTITIONED_IMAGE_NAME -f value -c id)"},{"line_number":2318,"context_line":"    iniset $TEMPEST_CONFIG baremetal partition_image_ref $image_uuid"},{"line_number":2319,"context_line":""},{"line_number":2320,"context_line":"    if [[ -n \"${IRONIC_HTTP_SERVER}\" || \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]] ; then"},{"line_number":2321,"context_line":"        iniset $TEMPEST_CONFIG baremetal whole_disk_image_url \"http://$IRONIC_HTTP_SERVER:$IRONIC_HTTP_PORT/${IRONIC_WHOLEDISK_IMAGE_NAME}.img\""},{"line_number":2322,"context_line":"        iniset $TEMPEST_CONFIG baremetal whole_disk_image_checksum $(md5sum $FILES/${IRONIC_WHOLEDISK_IMAGE_NAME}.img)"},{"line_number":2323,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf659307_3e469f23","line":2320,"in_reply_to":"3fa0c359_90618f3c","updated":"2018-04-05 11:00:43.000000000","message":"Done","commit_id":"4224d7e7ac9059309dc4b4a592a3de22a1e316f2"}]}
