)]}'
{"ironic/common/driver_factory.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6080b5da209e752cd6ed337a6b96fd4d6e777aa9","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        # For non hardware types we need to set a fallback for the network"},{"line_number":183,"context_line":"        # interface however hardware_types specify their own defaults if not in"},{"line_number":184,"context_line":"        # the config file."},{"line_number":185,"context_line":"        if (CONF.dhcp.dhcp_provider \u003d\u003d \u0027neutron\u0027 and"},{"line_number":186,"context_line":"                \u0027flat\u0027 in CONF.enabled_network_interfaces):"},{"line_number":187,"context_line":"            additional_defaults[\u0027network\u0027] \u003d \u0027flat\u0027"},{"line_number":188,"context_line":"        elif \u0027noop\u0027 in CONF.enabled_network_interfaces:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_5912a4b3","line":185,"updated":"2018-02-05 08:18:48.000000000","message":"I wonder if we may have out-of-tree dhcp provided, behaving similarly to the \u0027neutron\u0027 one.. maybe we should check for dhcp_provided !\u003d \u0027none\u0027 instead?","commit_id":"763945d1508932c6c82344dbaed2393584d0a7b3"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1bdcda733d1251e92e5d8f16e30045fee5e7354a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        # For non hardware types we need to set a fallback for the network"},{"line_number":183,"context_line":"        # interface however hardware_types specify their own defaults if not in"},{"line_number":184,"context_line":"        # the config file."},{"line_number":185,"context_line":"        if (CONF.dhcp.dhcp_provider \u003d\u003d \u0027neutron\u0027 and"},{"line_number":186,"context_line":"                \u0027flat\u0027 in CONF.enabled_network_interfaces):"},{"line_number":187,"context_line":"            additional_defaults[\u0027network\u0027] \u003d \u0027flat\u0027"},{"line_number":188,"context_line":"        elif \u0027noop\u0027 in CONF.enabled_network_interfaces:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_5263361b","line":185,"in_reply_to":"3fa0c359_5912a4b3","updated":"2018-02-06 11:55:44.000000000","message":"I\u0027m not sure we can guarantee any compatibility between an unknown dhcp provider and the flat network interface for classic drivers what this is here for. (supported types handles that for us for on hardware types)\n\nSo I think getting someone to manually set the network_interface on the node if they are using a classic driver + out of tree DHCP provider is safe.\n\nOnly possibility where it might cause issues is if someone is using classic drivers + an API version that is too old to allow them to set the network_interface field.\n\nEither way we can follow up for that change :)","commit_id":"763945d1508932c6c82344dbaed2393584d0a7b3"}],"releasenotes/notes/only_default_flat_network_if_enabled-b5c6ea415239a53c.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6080b5da209e752cd6ed337a6b96fd4d6e777aa9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Fixes a bug seen when no ``default_network_interface`` is set, because the"},{"line_number":5,"context_line":"    conductor tries use the ``flat`` network interface instead even if it is"},{"line_number":6,"context_line":"    not included in the conductor\u0027s ``enabled_network_interfaces`` config"},{"line_number":7,"context_line":"    option.  Resulting in `Failed to register hardware types` error. See"},{"line_number":8,"context_line":"    https://bugs.launchpad.net/ironic/+bug/1744332 for more information."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa0c359_f9261017","line":7,"updated":"2018-02-05 08:18:48.000000000","message":"nit: s/. R/, r/ ? I mean, I\u0027d split the sentences somewhere else.","commit_id":"763945d1508932c6c82344dbaed2393584d0a7b3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"18f5d71a76d99070ff75b46e1dcc9ec37dcd6db5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Fixes a bug seen when no ``default_network_interface`` is set, because the"},{"line_number":5,"context_line":"    conductor tries use the ``flat`` network interface instead even if it is"},{"line_number":6,"context_line":"    not included in the conductor\u0027s ``enabled_network_interfaces`` config"},{"line_number":7,"context_line":"    option.  Resulting in `Failed to register hardware types` error. See"},{"line_number":8,"context_line":"    https://bugs.launchpad.net/ironic/+bug/1744332 for more information."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa0c359_99e31e34","line":7,"in_reply_to":"3fa0c359_f9261017","updated":"2018-02-06 18:21:56.000000000","message":"+1, but we can live with it.","commit_id":"763945d1508932c6c82344dbaed2393584d0a7b3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6080b5da209e752cd6ed337a6b96fd4d6e777aa9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    conductor tries use the ``flat`` network interface instead even if it is"},{"line_number":6,"context_line":"    not included in the conductor\u0027s ``enabled_network_interfaces`` config"},{"line_number":7,"context_line":"    option.  Resulting in `Failed to register hardware types` error. See"},{"line_number":8,"context_line":"    https://bugs.launchpad.net/ironic/+bug/1744332 for more information."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa0c359_19241c0d","line":8,"updated":"2018-02-05 08:18:48.000000000","message":"nit: I\u0027d prefer the link formatted as `bug 1744332 \u003chttps://...\u003e`_","commit_id":"763945d1508932c6c82344dbaed2393584d0a7b3"}]}