)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"8cd1f2519b8c8d50b5539d7c336e28424963750c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"IRONIC_CONF_DIR\u003d${IRONIC_CONF_DIR:-/etc/ironic}"},{"line_number":68,"context_line":"IRONIC_CONF_FILE\u003d$IRONIC_CONF_DIR/ironic.conf"},{"line_number":69,"context_line":"IRONIC_ROOTWRAP_CONF\u003d$IRONIC_CONF_DIR/rootwrap.conf"},{"line_number":70,"context_line":"IRONIC_POLICY_JSON\u003d$IRONIC_CONF_DIR/policy.json"},{"line_number":71,"context_line":"if is_suse; then"},{"line_number":72,"context_line":"    IRONIC_WSGI_DIR\u003d${IRONIC_WSGI_DIR:-/srv/www/htdocs/ironic}"},{"line_number":73,"context_line":"else"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5f93b717_0b297299","side":"PARENT","line":70,"range":{"start_line":70,"start_character":19,"end_line":70,"end_character":47},"updated":"2018-01-31 18:29:29.000000000","message":"I would probably leave this variable, make it empty by default..","commit_id":"eeeff800b3594a0f153634cbbf5a7837858965e6"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"8cd1f2519b8c8d50b5539d7c336e28424963750c","unresolved":false,"context_lines":[{"line_number":1109,"context_line":"function configure_ironic_api {"},{"line_number":1110,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT auth_strategy $IRONIC_AUTH_STRATEGY"},{"line_number":1111,"context_line":"    configure_auth_token_middleware $IRONIC_CONF_FILE ironic $IRONIC_AUTH_CACHE_DIR/api"},{"line_number":1112,"context_line":"    iniset $IRONIC_CONF_FILE oslo_policy policy_file $IRONIC_POLICY_JSON"},{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"    iniset_rpc_backend ironic $IRONIC_CONF_FILE"},{"line_number":1115,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5f93b717_fe164649","side":"PARENT","line":1112,"range":{"start_line":1112,"start_character":4,"end_line":1112,"end_character":72},"updated":"2018-01-31 18:29:29.000000000","message":"... and leave this line, but wrapped in a condition \"if $IRONIC_POLICY_JSON is not empty\"\n\nThis would allow to override the default policy file with a custom one for any testing purposes if someone needs it.","commit_id":"eeeff800b3594a0f153634cbbf5a7837858965e6"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"f2b69dca9ac945af4adf1d4370af358194a09b5d","unresolved":false,"context_lines":[{"line_number":1109,"context_line":"function configure_ironic_api {"},{"line_number":1110,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT auth_strategy $IRONIC_AUTH_STRATEGY"},{"line_number":1111,"context_line":"    configure_auth_token_middleware $IRONIC_CONF_FILE ironic $IRONIC_AUTH_CACHE_DIR/api"},{"line_number":1112,"context_line":"    iniset $IRONIC_CONF_FILE oslo_policy policy_file $IRONIC_POLICY_JSON"},{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"    iniset_rpc_backend ironic $IRONIC_CONF_FILE"},{"line_number":1115,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5f93b717_3e96ee94","side":"PARENT","line":1112,"range":{"start_line":1112,"start_character":4,"end_line":1112,"end_character":72},"in_reply_to":"5f93b717_fe164649","updated":"2018-01-31 18:34:25.000000000","message":"We can certainly do that if we think someone will need it. However, we never allowed that before, because we always copied the in-repo policy.json to the location in $IRONIC_POLICY_JSON. So until someone says they need it, I\u0027m inclined to just leave this as-is.","commit_id":"eeeff800b3594a0f153634cbbf5a7837858965e6"}],"etc/ironic/README-policy.yaml.txt":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e9b17f82830014c78d2e83627528f6f1c4cbd937","unresolved":false,"context_lines":[{"line_number":1,"context_line":"To generate the sample policy.yaml file, run the following command from the top"},{"line_number":2,"context_line":"level of repo:"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"    tox -egenpolicy"},{"line_number":5,"context_line":""}],"source_content_type":"text/plain","patch_set":4,"id":"5f93b717_01536f18","line":2,"updated":"2018-02-01 21:45:02.000000000","message":"nit s/of repo/of the repo/","commit_id":"2acbbeedf7b3a5dadb8ee83bf15a24a18546b90f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"88e3a07d5656c6e585ca137ba2230d3900b1b9d9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"To generate the sample policy.yaml file, run the following command from the top"},{"line_number":2,"context_line":"level of repo:"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"    tox -egenpolicy"},{"line_number":5,"context_line":""}],"source_content_type":"text/plain","patch_set":4,"id":"5f93b717_418bb766","line":2,"in_reply_to":"5f93b717_01536f18","updated":"2018-02-02 12:01:17.000000000","message":"Done","commit_id":"2acbbeedf7b3a5dadb8ee83bf15a24a18546b90f"}],"releasenotes/notes/remove-policy-json-be92ffdba7bda951.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e9b17f82830014c78d2e83627528f6f1c4cbd937","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5f93b717_017ccf80","line":7,"updated":"2018-02-01 21:45:02.000000000","message":"shouldn\u0027t we mention that we\u0027ve removed the .sample files? in \u0027other\u0027 ? (I know, you have readme\u0027s there, and release notes might be somewhat useless...)","commit_id":"2acbbeedf7b3a5dadb8ee83bf15a24a18546b90f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"88e3a07d5656c6e585ca137ba2230d3900b1b9d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5f93b717_619a73b9","line":7,"in_reply_to":"5f93b717_017ccf80","updated":"2018-02-02 12:01:17.000000000","message":"I\u0027m not sure, I could. The reason for mentioning policy is that packagers/deployers are known to copy this in via automation. I guess they could copy the samples, but I hope they don\u0027t.\n\nI don\u0027t mind adding a note :)","commit_id":"2acbbeedf7b3a5dadb8ee83bf15a24a18546b90f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"729ae9e134f68bb4c2a3d84459a6c23507e2fca6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    The sample configuration can be found `here"},{"line_number":13,"context_line":"    \u003chttps://docs.openstack.org/ironic/latest/configuration/sample-config.html\u003e`_"},{"line_number":14,"context_line":"    and the sample policy file can be found `here"},{"line_number":15,"context_line":"    https://docs.openstack.org/ironic/latest/configuration/sample-policy.html\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f93b717_e108c392","line":15,"updated":"2018-02-01 22:19:32.000000000","message":"I suspect you\u0027re missing a \u003c. \n\ns/https/\u003chttps/","commit_id":"32a6d421c50d69c9bdcfa43c19cccb3a7f9079d3"}]}