)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"99193f49d265985406dde66440233b33fe7c32db","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ryota MIBU \u003cr-mibu@cq.jp.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-10-25 21:16:17 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure ipmitool module is not to hang with empty password"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related-Bug: #1237802"},{"line_number":10,"context_line":"Change-Id: I4906d68da46831cb343102f14aef653c79923b2b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2F55g%3D","line":7,"updated":"2013-10-25 13:23:00.000000000","message":"Please format the commit message according to the guide here\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_GIT_commit_message_structure","commit_id":"c3c346897627987d54788b303d04b0de9500c054"}],"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"99193f49d265985406dde66440233b33fe7c32db","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        with os.fdopen(fd, \"w\") as f:"},{"line_number":53,"context_line":"            # NOTE(r-mibu): Since ipmitool hangs with an empty password file,"},{"line_number":54,"context_line":"            #               we have to write \u0027\\0\u0027 if password was empty."},{"line_number":55,"context_line":"            # see https://bugs.launchpad.net/nova/+bug/1237802 for more details"},{"line_number":56,"context_line":"            f.write(password or b\"\\0\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        yield path"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F508%3D","line":55,"updated":"2013-10-25 13:23:00.000000000","message":"Hmm it\u0027s a bit weird the manpage says:\n\n-f \u003cpassword_file\u003e\n    Specifies a file containing the remote server password. If this option is absent,\n    or if password_file is empty, the password will default to NULL. \n\nAlso in Ironic password seems to be mandatory (look at like 72), if it can be null we should make it optional as well.","commit_id":"c3c346897627987d54788b303d04b0de9500c054"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"20b6e65a41eda7d97a0792f6d38ec0c35456bee6","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        with os.fdopen(fd, \"w\") as f:"},{"line_number":53,"context_line":"            # NOTE(r-mibu): Since ipmitool hangs with an empty password file,"},{"line_number":54,"context_line":"            #               we have to write \u0027\\0\u0027 if password was empty."},{"line_number":55,"context_line":"            # see https://bugs.launchpad.net/nova/+bug/1237802 for more details"},{"line_number":56,"context_line":"            f.write(password or b\"\\0\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        yield path"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fv5o%3D","line":55,"in_reply_to":"AAAATn%2F%2F1tM%3D","updated":"2013-10-29 15:34:35.000000000","message":"@Ryota,\n\nthat\u0027s a very good point. Empty password is a valid option for IPMI, which probably is not supported at multiple layers in ironic code right now.\n\nEmpty username does not seem valid to me.\n\nNon-supplied username or password is valid for ipmitool, but also not supported by Ironic. Is this important? If so, please open a bug report so we can track and discuss that work.","commit_id":"c3c346897627987d54788b303d04b0de9500c054"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"214ef915d1a48ddb719820858582b839fa1cfda7","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        with os.fdopen(fd, \"w\") as f:"},{"line_number":53,"context_line":"            # NOTE(r-mibu): Since ipmitool hangs with an empty password file,"},{"line_number":54,"context_line":"            #               we have to write \u0027\\0\u0027 if password was empty."},{"line_number":55,"context_line":"            # see https://bugs.launchpad.net/nova/+bug/1237802 for more details"},{"line_number":56,"context_line":"            f.write(password or b\"\\0\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        yield path"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F1tM%3D","line":55,"in_reply_to":"AAAATn%2F%2F508%3D","updated":"2013-10-28 06:29:46.000000000","message":"Right, this does not work due to \"InvalidParameterValue\".\n\nI don\u0027t know why ipmitool ignores empty file while it accepts -P \u0027\u0027. IMHO, as password, the empty string \u0027\u0027 is different from \"Not supplied\". Maybe we should discuss that empty password (and username) can be acceptable.","commit_id":"c3c346897627987d54788b303d04b0de9500c054"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"01070ecd3b43a18fa020539b5427755860e69112","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        with os.fdopen(fd, \"w\") as f:"},{"line_number":53,"context_line":"            # NOTE(r-mibu): Since ipmitool hangs with an empty password file,"},{"line_number":54,"context_line":"            #               we have to write \u0027\\0\u0027 if password was empty."},{"line_number":55,"context_line":"            # see https://bugs.launchpad.net/nova/+bug/1237802 for more details"},{"line_number":56,"context_line":"            f.write(password or b\"\\0\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        yield path"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fs7A%3D","line":55,"in_reply_to":"AAAATn%2F%2Fv5o%3D","updated":"2013-10-30 08:32:04.000000000","message":"Empty username is an option of IPMI for anonymous login.\n\nEmpty password and username are not so important. I just know only one product that has a default password is empty. Admins can set username and password to the machine management system, or maybe they should.\n\nI think the problem is hanging in executing ipmitool, so I don\u0027t have a strong opinion on empty password. It could be an item in wishlist. I will drop this change, and note this as a bug comment.","commit_id":"c3c346897627987d54788b303d04b0de9500c054"}]}