)]}'
{"ironic/objects/node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1184638659cb8988aa6dd6be3729bbbc348c85f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            try:"},{"line_number":150,"context_line":"                int_value \u003d int(value)"},{"line_number":151,"context_line":"                if int_value \u003c 0:"},{"line_number":152,"context_line":"                    raise ValueError"},{"line_number":153,"context_line":"            except ValueError:"},{"line_number":154,"context_line":"                msg \u003d ((\u0027%(param)s\u003d%(value)s\u0027) %"},{"line_number":155,"context_line":"                       {\u0027param\u0027: param, \u0027value\u0027: value})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_ffc3ae87","line":152,"updated":"2018-01-31 12:34:51.000000000","message":"raising classes is IIRC not recommended. maybe rework this as:\n\n try:\n   int_value \u003d int(value)\n except (ValueError, TypeError):\n   int_value \u003d None\n\n if int_value is None or int_value \u003c 0:\n   ...\n\nside note: do we have unit tests for it?","commit_id":"c789a088b166c5d74ec67b771f9ccbe6f3f6be27"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6ece1d7c7c201ca9f261d451e60b478d9ee84eb6","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            try:"},{"line_number":150,"context_line":"                int_value \u003d int(value)"},{"line_number":151,"context_line":"                if int_value \u003c 0:"},{"line_number":152,"context_line":"                    raise ValueError"},{"line_number":153,"context_line":"            except ValueError:"},{"line_number":154,"context_line":"                msg \u003d ((\u0027%(param)s\u003d%(value)s\u0027) %"},{"line_number":155,"context_line":"                       {\u0027param\u0027: param, \u0027value\u0027: value})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_85b57880","line":152,"in_reply_to":"5f93b717_ffc3ae87","updated":"2018-01-31 14:44:44.000000000","message":"oh, right. Well, what about changing it to raise ValueError(\u0027\u0027) ?","commit_id":"c789a088b166c5d74ec67b771f9ccbe6f3f6be27"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"56eb6017af855c34edfe2fdfbe00875d9de63a41","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                int_value \u003d int(value)"},{"line_number":151,"context_line":"                if int_value \u003c 0:"},{"line_number":152,"context_line":"                    raise ValueError(\"Value must be non-negative\")"},{"line_number":153,"context_line":"            except (ValueError, TypeError):"},{"line_number":154,"context_line":"                msg \u003d ((\u0027%(param)s\u003d%(value)s\u0027) %"},{"line_number":155,"context_line":"                       {\u0027param\u0027: param, \u0027value\u0027: value})"},{"line_number":156,"context_line":"                invalid_msgs_list.append(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_67f610da","line":153,"updated":"2018-02-01 14:47:08.000000000","message":"OH, you added TypeError. I guess it could be some weird type...?","commit_id":"a61ee9429ad13a662e2c0f8158446d6a7aa3df42"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f7f12e2958f106c59e27882df37510797833d27c","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                int_value \u003d int(value)"},{"line_number":151,"context_line":"                if int_value \u003c 0:"},{"line_number":152,"context_line":"                    raise ValueError(\"Value must be non-negative\")"},{"line_number":153,"context_line":"            except (ValueError, TypeError):"},{"line_number":154,"context_line":"                msg \u003d ((\u0027%(param)s\u003d%(value)s\u0027) %"},{"line_number":155,"context_line":"                       {\u0027param\u0027: param, \u0027value\u0027: value})"},{"line_number":156,"context_line":"                invalid_msgs_list.append(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_a7b3b8e8","line":153,"in_reply_to":"5f93b717_67f610da","updated":"2018-02-01 14:54:22.000000000","message":"int({}) gives a TypeError, so this is a bit safer..","commit_id":"a61ee9429ad13a662e2c0f8158446d6a7aa3df42"}]}