)]}'
{"ironic/drivers/modules/oneview/common.py":[{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"9b8b5548cb1ce92e3d643f68106376d930dd0864","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # NOTE(nicodemos) Ignore the CA certificate if it\u0027s an insecure connection"},{"line_number":100,"context_line":"    if insecure and ssl_certificate:"},{"line_number":101,"context_line":"        LOG.warning(\"Doing an insecure connection with OneView, the CA \""},{"line_number":102,"context_line":"                    \"certificate file: %s will be ignored.\", ssl_certificate)"},{"line_number":103,"context_line":"        ssl_certificate \u003d None"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_b5f8027b","line":101,"updated":"2018-01-30 17:53:15.000000000","message":"I\u0027m ok with this. It\u0027d be noisy but at least it\u0027d hardly go unnoticed by the admin. Setting an certificate but explicitly choosing to open an insecure connection seems a mistake for me...","commit_id":"b6b3f55ea4586e790bb78c58f18817f548dfe876"},{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"9b8b5548cb1ce92e3d643f68106376d930dd0864","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        profile_uri \u003d task.node.driver_info.get(\u0027applied_server_profile_uri\u0027)"},{"line_number":294,"context_line":"        oneview_client.server_profiles.get(profile_uri)"},{"line_number":295,"context_line":"    except client_exception.HPOneViewException as exc:"},{"line_number":296,"context_line":"        LOG.error("},{"line_number":297,"context_line":"            \"Failed to get server profile: %(profile)s from OneView appliance \""},{"line_number":298,"context_line":"            \"for node %(node)s. Error: %(message)s\", {"},{"line_number":299,"context_line":"                \"profile\": profile_uri,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_751cbac0","line":296,"updated":"2018-01-30 17:53:15.000000000","message":"Should we change here to LOG.exception too?","commit_id":"b6b3f55ea4586e790bb78c58f18817f548dfe876"},{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"9b8b5548cb1ce92e3d643f68106376d930dd0864","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        hardware \u003d jsonutils.loads(ilo_client.get(ilo_path).text)"},{"line_number":320,"context_line":"        hardware_mac \u003d hardware[\u0027HostCorrelation\u0027][\u0027HostMACAddress\u0027][0]"},{"line_number":321,"context_line":"    except redfish.JsonDecodingError as exc:"},{"line_number":322,"context_line":"        LOG.error(\"Failed in JSON object getting path: %s\", ilo_path)"},{"line_number":323,"context_line":"        raise exception.OneViewError(error\u003dexc)"},{"line_number":324,"context_line":"    except (ValueError, TypeError, IndexError) as exc:"},{"line_number":325,"context_line":"        LOG.exception("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_551f3eb6","line":322,"updated":"2018-01-30 17:53:15.000000000","message":"Should we change here to LOG.exception too?","commit_id":"b6b3f55ea4586e790bb78c58f18817f548dfe876"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b7cae870a339228c4125627589dee5a38b6dad3a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        raise exception.OneViewError(error\u003dmsg)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # NOTE(nicodemos) Ignore the CA certificate if it\u0027s an insecure connection"},{"line_number":100,"context_line":"    if insecure and ssl_certificate:"},{"line_number":101,"context_line":"        LOG.warning(\"Doing an insecure connection with OneView, the CA \""},{"line_number":102,"context_line":"                    \"certificate file: %s will be ignored.\", ssl_certificate)"},{"line_number":103,"context_line":"        ssl_certificate \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_7fa1def7","line":100,"updated":"2018-01-31 12:32:01.000000000","message":"I wonder if we should have a global guard to avoid logging this too many times","commit_id":"3c73b7818eeec4387aa9b95919d8fabcdea5f6e2"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"9754b52969c132619bca7d9a0c68896e51fef386","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        raise exception.OneViewError(error\u003dmsg)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # NOTE(nicodemos) Ignore the CA certificate if it\u0027s an insecure connection"},{"line_number":100,"context_line":"    if insecure and ssl_certificate:"},{"line_number":101,"context_line":"        LOG.warning(\"Doing an insecure connection with OneView, the CA \""},{"line_number":102,"context_line":"                    \"certificate file: %s will be ignored.\", ssl_certificate)"},{"line_number":103,"context_line":"        ssl_certificate \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_c8071582","line":100,"in_reply_to":"5f93b717_7fa1def7","updated":"2018-01-31 15:06:47.000000000","message":"Ricardo talked about this in the first patchset.","commit_id":"3c73b7818eeec4387aa9b95919d8fabcdea5f6e2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"960ffc688f396f614ade677cfd5d9892c3ba3f6b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        raise exception.OneViewError(error\u003dmsg)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # NOTE(nicodemos) Ignore the CA certificate if it\u0027s an insecure connection"},{"line_number":100,"context_line":"    if insecure and ssl_certificate:"},{"line_number":101,"context_line":"        LOG.warning(\"Doing an insecure connection with OneView, the CA \""},{"line_number":102,"context_line":"                    \"certificate file: %s will be ignored.\", ssl_certificate)"},{"line_number":103,"context_line":"        ssl_certificate \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_39292de5","line":100,"in_reply_to":"5f93b717_c8071582","updated":"2018-01-31 16:36:35.000000000","message":"I\u0027m fine with not, it would be one of those messages where spamming would be a good thing(tm)","commit_id":"3c73b7818eeec4387aa9b95919d8fabcdea5f6e2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b7cae870a339228c4125627589dee5a38b6dad3a","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # NOTE(nicodemos) Ignore the CA certificate if it\u0027s an insecure connection"},{"line_number":100,"context_line":"    if insecure and ssl_certificate:"},{"line_number":101,"context_line":"        LOG.warning(\"Doing an insecure connection with OneView, the CA \""},{"line_number":102,"context_line":"                    \"certificate file: %s will be ignored.\", ssl_certificate)"},{"line_number":103,"context_line":"        ssl_certificate \u003d None"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_1fa21afd","line":101,"updated":"2018-01-31 12:32:01.000000000","message":"+1","commit_id":"3c73b7818eeec4387aa9b95919d8fabcdea5f6e2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"39978f7d31eecd95ffd14361642335ad627f8e76","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # NOTE(nicodemos) Ignore the CA certificate if it\u0027s an insecure connection"},{"line_number":100,"context_line":"    if insecure and ssl_certificate:"},{"line_number":101,"context_line":"        LOG.warning(\"Doing an insecure connection with OneView, the CA \""},{"line_number":102,"context_line":"                    \"certificate file: %s will be ignored.\", ssl_certificate)"},{"line_number":103,"context_line":"        ssl_certificate \u003d None"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_7a9ca269","line":101,"range":{"start_line":101,"start_character":21,"end_line":101,"end_character":26},"updated":"2018-01-30 20:27:29.000000000","message":"nit: s/Doing/Performing/ ?","commit_id":"3c73b7818eeec4387aa9b95919d8fabcdea5f6e2"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"9754b52969c132619bca7d9a0c68896e51fef386","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # NOTE(nicodemos) Ignore the CA certificate if it\u0027s an insecure connection"},{"line_number":100,"context_line":"    if insecure and ssl_certificate:"},{"line_number":101,"context_line":"        LOG.warning(\"Doing an insecure connection with OneView, the CA \""},{"line_number":102,"context_line":"                    \"certificate file: %s will be ignored.\", ssl_certificate)"},{"line_number":103,"context_line":"        ssl_certificate \u003d None"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_08d89d1b","line":101,"in_reply_to":"5f93b717_1fa21afd","updated":"2018-01-31 15:06:47.000000000","message":"Done","commit_id":"3c73b7818eeec4387aa9b95919d8fabcdea5f6e2"}],"ironic/drivers/modules/oneview/management.py":[{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"9b8b5548cb1ce92e3d643f68106376d930dd0864","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    boot \u003d response.dict.get(\u0027Boot\u0027, {})"},{"line_number":110,"context_line":"    if boot:"},{"line_number":111,"context_line":"        onetime_boot \u003d boot.get(\u0027BootSourceOverrideEnabled\u0027)"},{"line_number":112,"context_line":"    return onetime_boot \u003d\u003d \u0027Once\u0027"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"def set_boot_device(task):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_15f21671","line":112,"updated":"2018-01-30 17:53:15.000000000","message":"onetime_boot may not be defined here, right?","commit_id":"b6b3f55ea4586e790bb78c58f18817f548dfe876"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b7cae870a339228c4125627589dee5a38b6dad3a","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    boot \u003d response.dict.get(\u0027Boot\u0027, {})"},{"line_number":111,"context_line":"    if boot:"},{"line_number":112,"context_line":"        onetime_boot \u003d boot.get(\u0027BootSourceOverrideEnabled\u0027)"},{"line_number":113,"context_line":"    return onetime_boot \u003d\u003d \u0027Once\u0027"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"def set_boot_device(task):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_3fa7d60d","line":113,"updated":"2018-01-31 12:32:01.000000000","message":"if \u0027Boot\u0027 is missing, then onetime_boot will be None and this will return False. Is it your intention here? Or should we assume it to be one time by default?","commit_id":"3c73b7818eeec4387aa9b95919d8fabcdea5f6e2"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"9754b52969c132619bca7d9a0c68896e51fef386","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    boot \u003d response.dict.get(\u0027Boot\u0027, {})"},{"line_number":111,"context_line":"    if boot:"},{"line_number":112,"context_line":"        onetime_boot \u003d boot.get(\u0027BootSourceOverrideEnabled\u0027)"},{"line_number":113,"context_line":"    return onetime_boot \u003d\u003d \u0027Once\u0027"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"def set_boot_device(task):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_88590d8f","line":113,"in_reply_to":"5f93b717_3fa7d60d","updated":"2018-01-31 15:06:47.000000000","message":"it\u0027s the intention be False.","commit_id":"3c73b7818eeec4387aa9b95919d8fabcdea5f6e2"},{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"0f1d5eb49fa6ba33fbc9b32fed741b950b446147","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    boot \u003d response.dict.get(\u0027Boot\u0027, {})"},{"line_number":110,"context_line":"    if boot:"},{"line_number":111,"context_line":"        onetime_boot \u003d boot.get(\u0027BootSourceOverrideEnabled\u0027)"},{"line_number":112,"context_line":"    return onetime_boot \u003d\u003d \u0027Once\u0027"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"def set_boot_device(task):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f93b717_4802203f","line":112,"updated":"2018-01-31 17:49:04.000000000","message":"Adding more info: from iLO this can be one of [\u0027\u0027, \u0027Disabled\u0027, \u0027Once\u0027, \u0027Continuous\u0027]. In OneView hardware type we play with the \u0027Once\u0027 value to check (and to perform) one-time boot ops. This check should be enough...","commit_id":"c924a374c4467ab347858c17563ac7a6d3767271"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dc55d4a209b95841f714c0d5f2aae18fd78d9c0a","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    boot \u003d response.dict.get(\u0027Boot\u0027, {})"},{"line_number":110,"context_line":"    if boot:"},{"line_number":111,"context_line":"        onetime_boot \u003d boot.get(\u0027BootSourceOverrideEnabled\u0027)"},{"line_number":112,"context_line":"    return onetime_boot \u003d\u003d \u0027Once\u0027"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"def set_boot_device(task):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f93b717_3772917c","line":112,"in_reply_to":"5f93b717_4802203f","updated":"2018-01-31 20:37:17.000000000","message":"That is what I was thinking, and that definitely works.","commit_id":"c924a374c4467ab347858c17563ac7a6d3767271"}],"ironic/tests/unit/drivers/modules/oneview/test_inspect.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"39978f7d31eecd95ffd14361642335ad627f8e76","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @mock.patch.object("},{"line_number":47,"context_line":"        oneview_common, \u0027validate_oneview_resources_compatibility\u0027,"},{"line_number":48,"context_line":"        autospect\u003dTrue)"},{"line_number":49,"context_line":"    def test_validate(self, mock_validate):"},{"line_number":50,"context_line":"        self.config(enabled\u003dFalse, group\u003d\u0027inspector\u0027)"},{"line_number":51,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_baa46aa7","line":48,"updated":"2018-01-30 20:27:29.000000000","message":"nit: we typically wrap these to try and keep some of the parameters on the initial line.","commit_id":"3c73b7818eeec4387aa9b95919d8fabcdea5f6e2"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"9754b52969c132619bca7d9a0c68896e51fef386","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @mock.patch.object("},{"line_number":47,"context_line":"        oneview_common, \u0027validate_oneview_resources_compatibility\u0027,"},{"line_number":48,"context_line":"        autospect\u003dTrue)"},{"line_number":49,"context_line":"    def test_validate(self, mock_validate):"},{"line_number":50,"context_line":"        self.config(enabled\u003dFalse, group\u003d\u0027inspector\u0027)"},{"line_number":51,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_e80c51a6","line":48,"in_reply_to":"5f93b717_baa46aa7","updated":"2018-01-31 15:06:47.000000000","message":"Done","commit_id":"3c73b7818eeec4387aa9b95919d8fabcdea5f6e2"}]}