)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d43b09618d09dd3f9b4b88ddda5f84db0ae216ff","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Create pxe config over IPv6 network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When node whose boot mode is uefi boots from IPv6 network, ironic will"},{"line_number":10,"context_line":"create pxe config file 3ffe\\:501\\:ffff\\:101\\:\\:10e.conf for this host."},{"line_number":11,"context_line":"while host wants is 3ffe:501:ffff:101:0:0:0:10e.conf."},{"line_number":12,"context_line":"Now we will create pxe config by mac, if mac is 11:22:33:44:55:66, pxe"},{"line_number":13,"context_line":"config file will be named grub.cfg-01-11-22-33-44-55-66-"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa0c359_39ff9868","line":10,"updated":"2018-02-05 08:15:14.000000000","message":"why cannot we fix the file name instead of switching to MAC?","commit_id":"81b3b26e96a3d6066b50fd374ead493f18e27f9e"},{"author":{"_account_id":18480,"name":"zhengy","email":"zhengy23@163.com","username":"zhengyong"},"change_message_id":"34e48d09d53bf57bb6c742d850a18d66fc13bb99","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Create pxe config over IPv6 network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When node whose boot mode is uefi boots from IPv6 network, ironic will"},{"line_number":10,"context_line":"create pxe config file 3ffe\\:501\\:ffff\\:101\\:\\:10e.conf for this host."},{"line_number":11,"context_line":"while host wants is 3ffe:501:ffff:101:0:0:0:10e.conf."},{"line_number":12,"context_line":"Now we will create pxe config by mac, if mac is 11:22:33:44:55:66, pxe"},{"line_number":13,"context_line":"config file will be named grub.cfg-01-11-22-33-44-55-66-"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa0c359_91bc7c6a","line":10,"in_reply_to":"3fa0c359_39ff9868","updated":"2018-02-05 13:41:11.000000000","message":"when testing I create pxe config file named 3ffe:501:ffff:101:0:0:0:10e.conf in work directory of tftp server, actually it is 3ffe\\:501\\:ffff\\:101\\:0\\:0\\:0\\:10e.conf which you can execuate \u0027ls\u0027 to see. And host booting from pxe can not download it, maybe it is because of \"\\\" in filename. so I use pxe config file named by mac","commit_id":"81b3b26e96a3d6066b50fd374ead493f18e27f9e"}],"ironic/common/pxe_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d43b09618d09dd3f9b4b88ddda5f84db0ae216ff","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        mac_file_name \u003d hw_type + mac_file_name"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        if int(CONF.pxe.ip_version) \u003d\u003d 6:"},{"line_number":147,"context_line":"            mac_file_name \u003d \u0027grub.cfg-\u0027 + mac_file_name + \u0027-\u0027"},{"line_number":148,"context_line":"            return os.path.join(get_root_dir(),"},{"line_number":149,"context_line":"                                UEFI_PXE_CFG_DIR_NAME,"},{"line_number":150,"context_line":"                                mac_file_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_5904e47b","line":147,"updated":"2018-02-05 08:15:14.000000000","message":"nit: I\u0027d prefer \u0027grub-cfg-%s-\u0027 % mac_file_name","commit_id":"81b3b26e96a3d6066b50fd374ead493f18e27f9e"},{"author":{"_account_id":18480,"name":"zhengy","email":"zhengy23@163.com","username":"zhengyong"},"change_message_id":"34e48d09d53bf57bb6c742d850a18d66fc13bb99","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        mac_file_name \u003d hw_type + mac_file_name"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        if int(CONF.pxe.ip_version) \u003d\u003d 6:"},{"line_number":147,"context_line":"            mac_file_name \u003d \u0027grub.cfg-\u0027 + mac_file_name + \u0027-\u0027"},{"line_number":148,"context_line":"            return os.path.join(get_root_dir(),"},{"line_number":149,"context_line":"                                UEFI_PXE_CFG_DIR_NAME,"},{"line_number":150,"context_line":"                                mac_file_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_71453070","line":147,"in_reply_to":"3fa0c359_5904e47b","updated":"2018-02-05 13:41:11.000000000","message":"\"mac_file_name \u003d \u0027grub.cfg-%s-\u0027 %mac_file_name\" is more efficient, I will fix this.","commit_id":"81b3b26e96a3d6066b50fd374ead493f18e27f9e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d43b09618d09dd3f9b4b88ddda5f84db0ae216ff","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    pxe_config \u003d utils.render_template(template, params)"},{"line_number":270,"context_line":"    utils.write_to_file(pxe_config_file_path, pxe_config)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    if int(CONF.pxe.ip_version) \u003d\u003d 4 and is_uefi_boot_mode and \\"},{"line_number":273,"context_line":"            not CONF.pxe.ipxe_enabled:"},{"line_number":274,"context_line":"        _link_ip_address_pxe_configs(task, hex_form)"},{"line_number":275,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_f9f8507d","line":272,"updated":"2018-02-05 08:15:14.000000000","message":"please use brackets for multi-line statements instead of \\\n\nactually, I think we need a helper function now, something like:\n\n if _use_ip_address_pxe_config():\n   ...","commit_id":"81b3b26e96a3d6066b50fd374ead493f18e27f9e"},{"author":{"_account_id":18480,"name":"zhengy","email":"zhengy23@163.com","username":"zhengyong"},"change_message_id":"34e48d09d53bf57bb6c742d850a18d66fc13bb99","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    pxe_config \u003d utils.render_template(template, params)"},{"line_number":270,"context_line":"    utils.write_to_file(pxe_config_file_path, pxe_config)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    if int(CONF.pxe.ip_version) \u003d\u003d 4 and is_uefi_boot_mode and \\"},{"line_number":273,"context_line":"            not CONF.pxe.ipxe_enabled:"},{"line_number":274,"context_line":"        _link_ip_address_pxe_configs(task, hex_form)"},{"line_number":275,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_f4904e98","line":272,"in_reply_to":"3fa0c359_f9f8507d","updated":"2018-02-05 13:41:11.000000000","message":"using brackets is better, thks","commit_id":"81b3b26e96a3d6066b50fd374ead493f18e27f9e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d43b09618d09dd3f9b4b88ddda5f84db0ae216ff","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    is_uefi_boot_mode \u003d (deploy_utils.get_boot_mode_for_deploy(task.node) \u003d\u003d"},{"line_number":304,"context_line":"                         \u0027uefi\u0027)"},{"line_number":305,"context_line":"    if int(CONF.pxe.ip_version) \u003d\u003d 4 and is_uefi_boot_mode \\"},{"line_number":306,"context_line":"            and not CONF.pxe.ipxe_enabled:"},{"line_number":307,"context_line":"        api \u003d dhcp_factory.DHCPFactory().provider"},{"line_number":308,"context_line":"        ip_addresses \u003d api.get_ip_addresses(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_19f65c91","line":305,"updated":"2018-02-05 08:15:14.000000000","message":"ditto","commit_id":"81b3b26e96a3d6066b50fd374ead493f18e27f9e"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"d6481050ab8461315c4be7a051fb36cdf8235667","unresolved":false,"context_lines":[{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"PXE_CFG_DIR_NAME \u003d \u0027pxelinux.cfg\u0027"},{"line_number":35,"context_line":"# BOOTX64.EFI from Centos7.4 loads pxe config file in directory EFI/BOOT"},{"line_number":36,"context_line":"UEFI_PXE_CFG_DIR_NAME \u003d \u0027EFI/BOOT\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"DHCP_CLIENT_ID \u003d \u002761\u0027  # rfc2132"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_fa5a374e","line":35,"updated":"2018-02-07 15:18:54.000000000","message":"I might be misinterpreting but are you implying that this is only the proper config for centos (and I would assume rhel/fedora)? If so this could be problematic.","commit_id":"53303b28a3d10e0b523b67523b85b2f3c2217ca9"},{"author":{"_account_id":18480,"name":"zhengy","email":"zhengy23@163.com","username":"zhengyong"},"change_message_id":"1a910cd870d837479e9760b719a14f579f2a6504","unresolved":false,"context_lines":[{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"PXE_CFG_DIR_NAME \u003d \u0027pxelinux.cfg\u0027"},{"line_number":35,"context_line":"# BOOTX64.EFI from Centos7.4 loads pxe config file in directory EFI/BOOT"},{"line_number":36,"context_line":"UEFI_PXE_CFG_DIR_NAME \u003d \u0027EFI/BOOT\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"DHCP_CLIENT_ID \u003d \u002761\u0027  # rfc2132"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_5149702e","line":35,"in_reply_to":"3fa0c359_fa5a374e","updated":"2018-02-12 03:29:11.000000000","message":"thank you, there is one problem here. I just test BOOTX64.EFI getting from centos, actually according to different BOOTX64.EFI,\nUEFI_PXE_CFG_DIR_NAME may be different.  I will put variable UEFI_PXE_CFG_DIR_NAME in ironic config","commit_id":"53303b28a3d10e0b523b67523b85b2f3c2217ca9"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"d6481050ab8461315c4be7a051fb36cdf8235667","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    \"\"\""},{"line_number":64,"context_line":"    root_dir \u003d get_root_dir()"},{"line_number":65,"context_line":"    node_dir \u003d os.path.join(root_dir, node_uuid)"},{"line_number":66,"context_line":"    if int(CONF.pxe.ip_version) \u003d\u003d 4:"},{"line_number":67,"context_line":"        pxe_dir \u003d os.path.join(root_dir, PXE_CFG_DIR_NAME)"},{"line_number":68,"context_line":"    else:"},{"line_number":69,"context_line":"        pxe_dir \u003d os.path.join(root_dir, UEFI_PXE_CFG_DIR_NAME)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_5a2b2bea","line":66,"updated":"2018-02-07 15:18:54.000000000","message":"I would use string comparison rather than converting to int for the changes you made.","commit_id":"53303b28a3d10e0b523b67523b85b2f3c2217ca9"},{"author":{"_account_id":18480,"name":"zhengy","email":"zhengy23@163.com","username":"zhengyong"},"change_message_id":"1a910cd870d837479e9760b719a14f579f2a6504","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    \"\"\""},{"line_number":64,"context_line":"    root_dir \u003d get_root_dir()"},{"line_number":65,"context_line":"    node_dir \u003d os.path.join(root_dir, node_uuid)"},{"line_number":66,"context_line":"    if int(CONF.pxe.ip_version) \u003d\u003d 4:"},{"line_number":67,"context_line":"        pxe_dir \u003d os.path.join(root_dir, PXE_CFG_DIR_NAME)"},{"line_number":68,"context_line":"    else:"},{"line_number":69,"context_line":"        pxe_dir \u003d os.path.join(root_dir, UEFI_PXE_CFG_DIR_NAME)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_91ce18b2","line":66,"in_reply_to":"3fa0c359_5a2b2bea","updated":"2018-02-12 03:29:11.000000000","message":"fix this later","commit_id":"53303b28a3d10e0b523b67523b85b2f3c2217ca9"}]}