)]}'
{"ironic/drivers/modules/irmc/boot.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f31158c88018b8c7466bd5bd3c5255303577d2a7","unresolved":false,"context_lines":[{"line_number":1042,"context_line":"        if deploy_utils.is_secure_boot_requested(task.node):"},{"line_number":1043,"context_line":"            irmc_common.set_secure_boot_mode(task.node, enable\u003dFalse)"},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        _remove_share_file(_get_iso_name(task.node, label\u003d\u0027boot\u0027))"},{"line_number":1046,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":1047,"context_line":"        driver_internal_info.pop(\u0027irmc_boot_iso\u0027, None)"},{"line_number":1048,"context_line":"        driver_internal_info.pop(\u0027root_uuid_or_disk_id\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_e01aecc3","line":1045,"updated":"2018-02-14 04:32:32.000000000","message":"Is it necessary to remove boot_iso at rescue? I wonder if we can reuse it at unrescue.","commit_id":"1d820a4f6958136fe3786233f7390e5271e6a784"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"d176e55271875fd14b30de8df4465952bd6c0a0d","unresolved":false,"context_lines":[{"line_number":1042,"context_line":"        if deploy_utils.is_secure_boot_requested(task.node):"},{"line_number":1043,"context_line":"            irmc_common.set_secure_boot_mode(task.node, enable\u003dFalse)"},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        _remove_share_file(_get_iso_name(task.node, label\u003d\u0027boot\u0027))"},{"line_number":1046,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":1047,"context_line":"        driver_internal_info.pop(\u0027irmc_boot_iso\u0027, None)"},{"line_number":1048,"context_line":"        driver_internal_info.pop(\u0027root_uuid_or_disk_id\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_9cb20094","line":1045,"in_reply_to":"3fa0c359_e01aecc3","updated":"2018-03-12 09:27:39.000000000","message":"We can reuse the file at unrescue. But when trying to implement this, I see it reduces the readability of the code and increase the complexity. So I vote for leaving it unchanged.","commit_id":"1d820a4f6958136fe3786233f7390e5271e6a784"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f31158c88018b8c7466bd5bd3c5255303577d2a7","unresolved":false,"context_lines":[{"line_number":1045,"context_line":"        _remove_share_file(_get_iso_name(task.node, label\u003d\u0027boot\u0027))"},{"line_number":1046,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":1047,"context_line":"        driver_internal_info.pop(\u0027irmc_boot_iso\u0027, None)"},{"line_number":1048,"context_line":"        driver_internal_info.pop(\u0027root_uuid_or_disk_id\u0027, None)"},{"line_number":1049,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":1050,"context_line":"        task.node.save()"},{"line_number":1051,"context_line":"        _cleanup_vmedia_boot(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_408160c2","line":1048,"updated":"2018-02-14 04:32:32.000000000","message":"At least, we shouldn\u0027t remove root_uuid_or_disk_id at rescuing. This parameter is required at L1019 when unrescuing. We cannot set this value again because this parameter can be got at only deploying.","commit_id":"1d820a4f6958136fe3786233f7390e5271e6a784"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2daf711ccd9fc8ff0c70234d0813d89fcbcd08be","unresolved":false,"context_lines":[{"line_number":1045,"context_line":"        _remove_share_file(_get_iso_name(task.node, label\u003d\u0027boot\u0027))"},{"line_number":1046,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":1047,"context_line":"        driver_internal_info.pop(\u0027irmc_boot_iso\u0027, None)"},{"line_number":1048,"context_line":"        driver_internal_info.pop(\u0027root_uuid_or_disk_id\u0027, None)"},{"line_number":1049,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":1050,"context_line":"        task.node.save()"},{"line_number":1051,"context_line":"        _cleanup_vmedia_boot(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_832a127c","line":1048,"in_reply_to":"3fa0c359_408160c2","updated":"2018-02-14 10:58:09.000000000","message":"+1.","commit_id":"1d820a4f6958136fe3786233f7390e5271e6a784"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"d176e55271875fd14b30de8df4465952bd6c0a0d","unresolved":false,"context_lines":[{"line_number":1045,"context_line":"        _remove_share_file(_get_iso_name(task.node, label\u003d\u0027boot\u0027))"},{"line_number":1046,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":1047,"context_line":"        driver_internal_info.pop(\u0027irmc_boot_iso\u0027, None)"},{"line_number":1048,"context_line":"        driver_internal_info.pop(\u0027root_uuid_or_disk_id\u0027, None)"},{"line_number":1049,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":1050,"context_line":"        task.node.save()"},{"line_number":1051,"context_line":"        _cleanup_vmedia_boot(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_5cac6833","line":1048,"in_reply_to":"3fa0c359_408160c2","updated":"2018-03-12 09:27:39.000000000","message":"Done","commit_id":"1d820a4f6958136fe3786233f7390e5271e6a784"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"d176e55271875fd14b30de8df4465952bd6c0a0d","unresolved":false,"context_lines":[{"line_number":1045,"context_line":"        _remove_share_file(_get_iso_name(task.node, label\u003d\u0027boot\u0027))"},{"line_number":1046,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":1047,"context_line":"        driver_internal_info.pop(\u0027irmc_boot_iso\u0027, None)"},{"line_number":1048,"context_line":"        driver_internal_info.pop(\u0027root_uuid_or_disk_id\u0027, None)"},{"line_number":1049,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":1050,"context_line":"        task.node.save()"},{"line_number":1051,"context_line":"        _cleanup_vmedia_boot(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_7ca7ec50","line":1048,"in_reply_to":"3fa0c359_832a127c","updated":"2018-03-12 09:27:39.000000000","message":"Done","commit_id":"1d820a4f6958136fe3786233f7390e5271e6a784"}],"releasenotes/notes/rescue-interface-for-irmc-hardware-type-17e38197849748e0.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0784c10ee3947b9b23e4154941c052d0adfa92f0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for rescue interface ``agent`` for ``irmc`` hardware type"},{"line_number":5,"context_line":"    when corresponding boot interface being used is ``irmc-virtual-media``."},{"line_number":6,"context_line":"    The supported values of rescue interface for ``irmc`` hardware type"},{"line_number":7,"context_line":"    are ``agent`` and ``no-rescue``. The default value is ``no-rescue``."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df7087c5_9cce5c80","line":5,"updated":"2018-03-13 09:40:42.000000000","message":"nit: s/being used//","commit_id":"a560d60b1f17fbae9b4bc6ab4f3053029e41a239"}]}