)]}'
{"ironic/drivers/modules/ipxe_config.template":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"56cd525b44dd124b6becb3e28dc7cd9e7d4742ca","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":":deploy"},{"line_number":6,"context_line":"imgfree"},{"line_number":7,"context_line":"kernel {% if pxe_options.ipxe_timeout \u003e 0 %}--timeout {{ pxe_options.ipxe_timeout }} {% endif %}{{ pxe_options.deployment_aki_path }} selinux\u003d0 troubleshoot\u003d0 text {{ pxe_options.pxe_append_params|default(\"\", true) }} ip\u003d${ip}:${next-server}:${gateway}:${netmask} BOOTIF\u003d${mac} ipa-api-url\u003d{{ pxe_options[\u0027ipa-api-url\u0027] }} initrd\u003d{{ pxe_options.initrd_filename|default(\"deploy_ramdisk\") }} coreos.configdrive\u003d0 || goto deploy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"initrd {% if pxe_options.ipxe_timeout \u003e 0 %}--timeout {{ pxe_options.ipxe_timeout }} {% endif %}{{ pxe_options.deployment_ari_path }} || goto deploy"},{"line_number":10,"context_line":"boot"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3fa0c359_4169c6f6","line":7,"range":{"start_line":7,"start_character":361,"end_line":7,"end_character":386},"updated":"2018-02-21 08:00:26.000000000","message":"Do we need to use pass the \u0027true\u0027 to default(); like default(\"deploy_ramdisk\", true)? \nMay not be required as this variable would be either defined or un-defined.","commit_id":"0d4adcfd9f383fa12e51d1b770b07ad56b723eae"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"281143a3b03a93d1bc0b6a8f7bc610652de5263f","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":":deploy"},{"line_number":6,"context_line":"imgfree"},{"line_number":7,"context_line":"kernel {% if pxe_options.ipxe_timeout \u003e 0 %}--timeout {{ pxe_options.ipxe_timeout }} {% endif %}{{ pxe_options.deployment_aki_path }} selinux\u003d0 troubleshoot\u003d0 text {{ pxe_options.pxe_append_params|default(\"\", true) }} ip\u003d${ip}:${next-server}:${gateway}:${netmask} BOOTIF\u003d${mac} ipa-api-url\u003d{{ pxe_options[\u0027ipa-api-url\u0027] }} initrd\u003d{{ pxe_options.initrd_filename|default(\"deploy_ramdisk\") }} coreos.configdrive\u003d0 || goto deploy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"initrd {% if pxe_options.ipxe_timeout \u003e 0 %}--timeout {{ pxe_options.ipxe_timeout }} {% endif %}{{ pxe_options.deployment_ari_path }} || goto deploy"},{"line_number":10,"context_line":"boot"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3fa0c359_04ec2c8d","line":7,"range":{"start_line":7,"start_character":361,"end_line":7,"end_character":386},"in_reply_to":"3fa0c359_4169c6f6","updated":"2018-02-21 08:41:14.000000000","message":"This sounds better just in case.","commit_id":"0d4adcfd9f383fa12e51d1b770b07ad56b723eae"}],"ironic/tests/unit/drivers/ipxe_config_boot_from_volume.template":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5063b94d207962c9f1044cbe3d1db227a3ca939a","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":":deploy"},{"line_number":6,"context_line":"imgfree"},{"line_number":7,"context_line":"kernel http://1.2.3.4:1234/deploy_kernel selinux\u003d0 troubleshoot\u003d0 text test_param ip\u003d${ip}:${next-server}:${gateway}:${netmask} BOOTIF\u003d${mac} ipa-api-url\u003dhttp://192.168.122.184:6385 initrd\u003d coreos.configdrive\u003d0 || goto deploy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"initrd http://1.2.3.4:1234/deploy_ramdisk || goto deploy"},{"line_number":10,"context_line":"boot"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3fa0c359_d272e67c","line":7,"range":{"start_line":7,"start_character":182,"end_line":7,"end_character":189},"updated":"2018-02-16 04:37:53.000000000","message":"Won\u0027t this cause error when ipxe reads this config and does not find any value in RHS?","commit_id":"83a23b1357b5aef260175d0dc67f75e9052e6ae8"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"64ccb0064df85b0d2a71ba9dba0c6a645b25468a","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":":deploy"},{"line_number":6,"context_line":"imgfree"},{"line_number":7,"context_line":"kernel http://1.2.3.4:1234/deploy_kernel selinux\u003d0 troubleshoot\u003d0 text test_param ip\u003d${ip}:${next-server}:${gateway}:${netmask} BOOTIF\u003d${mac} ipa-api-url\u003dhttp://192.168.122.184:6385 initrd\u003d coreos.configdrive\u003d0 || goto deploy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"initrd http://1.2.3.4:1234/deploy_ramdisk || goto deploy"},{"line_number":10,"context_line":"boot"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3fa0c359_125b6e87","line":7,"range":{"start_line":7,"start_character":182,"end_line":7,"end_character":189},"in_reply_to":"3fa0c359_d272e67c","updated":"2018-02-16 05:28:59.000000000","message":"I\u0027m not sure if this causes error. But, this doesn\u0027t matter. This code doesn\u0027t run because the boot line is replaced with \u0027goto boot_iscsi\u0027[1][2] after the template is rendered.\n\n[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L604\n[2] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/deploy_utils.py#L295","commit_id":"83a23b1357b5aef260175d0dc67f75e9052e6ae8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ca5f21121774879574ffebed3581cc8b92dac77d","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":":deploy"},{"line_number":6,"context_line":"imgfree"},{"line_number":7,"context_line":"kernel http://1.2.3.4:1234/deploy_kernel selinux\u003d0 troubleshoot\u003d0 text test_param ip\u003d${ip}:${next-server}:${gateway}:${netmask} BOOTIF\u003d${mac} ipa-api-url\u003dhttp://192.168.122.184:6385 initrd\u003d coreos.configdrive\u003d0 || goto deploy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"initrd http://1.2.3.4:1234/deploy_ramdisk || goto deploy"},{"line_number":10,"context_line":"boot"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3fa0c359_f9d1c558","line":7,"updated":"2018-02-20 09:11:53.000000000","message":"is it really intended to be empty? looks a bit weird to me","commit_id":"bc696da56b0ee7274e5010e0ea0b99f5a5b0399f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"5e73454620417acedf972bc1558b480c65fdbf51","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":":deploy"},{"line_number":6,"context_line":"imgfree"},{"line_number":7,"context_line":"kernel http://1.2.3.4:1234/deploy_kernel selinux\u003d0 troubleshoot\u003d0 text test_param ip\u003d${ip}:${next-server}:${gateway}:${netmask} BOOTIF\u003d${mac} ipa-api-url\u003dhttp://192.168.122.184:6385 initrd\u003d coreos.configdrive\u003d0 || goto deploy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"initrd http://1.2.3.4:1234/deploy_ramdisk || goto deploy"},{"line_number":10,"context_line":"boot"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3fa0c359_c23ddb8e","line":7,"in_reply_to":"3fa0c359_47ba4f0a","updated":"2018-02-21 02:05:41.000000000","message":"I fixed to always set the parameter for avoiding the confusion.\n\nThis confusion may be caused because a iPXE config for iSCSI boot is build by the same template and methods with other deployments. In netboot case, a config script is rendered when booting deploy kernel and ramdisk[1], and the first line is replaced with \u0027goto boot_partition\u0027 later[2][3]. For iSCSI boot, the first line is replaced with \u0027goto boot_iscsi\u0027[4] soon after rendered[5]. This file is an expected result of rendering the template before the initial line is not replaced.\n\n[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L529\n[2] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L642\n[3] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L279\n[4] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L603\n[5] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L601","commit_id":"bc696da56b0ee7274e5010e0ea0b99f5a5b0399f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"9f5f846d20ab629b59d099022e4700cf190a6d60","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":":deploy"},{"line_number":6,"context_line":"imgfree"},{"line_number":7,"context_line":"kernel http://1.2.3.4:1234/deploy_kernel selinux\u003d0 troubleshoot\u003d0 text test_param ip\u003d${ip}:${next-server}:${gateway}:${netmask} BOOTIF\u003d${mac} ipa-api-url\u003dhttp://192.168.122.184:6385 initrd\u003d coreos.configdrive\u003d0 || goto deploy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"initrd http://1.2.3.4:1234/deploy_ramdisk || goto deploy"},{"line_number":10,"context_line":"boot"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3fa0c359_47ba4f0a","line":7,"in_reply_to":"3fa0c359_f9d1c558","updated":"2018-02-20 12:57:06.000000000","message":"+1","commit_id":"bc696da56b0ee7274e5010e0ea0b99f5a5b0399f"}],"ironic/tests/unit/drivers/ipxe_config_boot_from_volume_no_volumes.template":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5063b94d207962c9f1044cbe3d1db227a3ca939a","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":":deploy"},{"line_number":6,"context_line":"imgfree"},{"line_number":7,"context_line":"kernel http://1.2.3.4:1234/deploy_kernel selinux\u003d0 troubleshoot\u003d0 text test_param ip\u003d${ip}:${next-server}:${gateway}:${netmask} BOOTIF\u003d${mac} ipa-api-url\u003dhttp://192.168.122.184:6385 initrd\u003d coreos.configdrive\u003d0 || goto deploy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"initrd http://1.2.3.4:1234/deploy_ramdisk || goto deploy"},{"line_number":10,"context_line":"boot"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3fa0c359_926c5e9d","line":7,"range":{"start_line":7,"start_character":182,"end_line":7,"end_character":190},"updated":"2018-02-16 04:37:53.000000000","message":"Won\u0027t this cause error when ipxe reads this config and does not find any value in RHS?","commit_id":"83a23b1357b5aef260175d0dc67f75e9052e6ae8"}],"releasenotes/notes/bug-1749860-457292cf62e18a0e.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04d028a3c323816c2c308c38aa93fc91f1cad1ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a bug to fail to rescue a node due to timeout by getting a node"},{"line_number":5,"context_line":"    stuck in ``rescue wait`` state. This bug was caused because a kernel"},{"line_number":6,"context_line":"    parameter in an iPXE configuration script was set wrongly for rescuing. See"},{"line_number":7,"context_line":"    `bug 174980 \u003chttps://bugs.launchpad.net/ironic/+bug/1749860\u003e`_ for details."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa0c359_1c1fd870","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":23},"updated":"2018-02-19 12:08:46.000000000","message":"\"a bug to fail\" is not quite correct. I suggest something like \"Fixes rescue timeout due to incorrect kernel parameter in the iPXE script. See bug ... for details.\"","commit_id":"7f56eb4b39ed7691c0f07b5d18cef1f0c4359298"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"3a491a8db22c2d38454582b0f403b6b0ae25a49b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a bug to fail to rescue a node due to timeout by getting a node"},{"line_number":5,"context_line":"    stuck in ``rescue wait`` state. This bug was caused because a kernel"},{"line_number":6,"context_line":"    parameter in an iPXE configuration script was set wrongly for rescuing. See"},{"line_number":7,"context_line":"    `bug 174980 \u003chttps://bugs.launchpad.net/ironic/+bug/1749860\u003e`_ for details."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa0c359_c72434c9","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":23},"in_reply_to":"3fa0c359_1c1fd870","updated":"2018-02-19 17:51:10.000000000","message":"Done\n\nThank you for the suggestion.","commit_id":"7f56eb4b39ed7691c0f07b5d18cef1f0c4359298"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ca5f21121774879574ffebed3581cc8b92dac77d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes rescue timeout due to incorrect kernel parameter in the iPXE script."},{"line_number":5,"context_line":"    See `bug 174980 \u003chttps://bugs.launchpad.net/ironic/+bug/1749860\u003e`_ for"},{"line_number":6,"context_line":"    details."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa0c359_99c0c17e","line":5,"range":{"start_line":5,"start_character":13,"end_line":5,"end_character":19},"updated":"2018-02-20 09:11:53.000000000","message":"1749860 (missing 6)","commit_id":"bc696da56b0ee7274e5010e0ea0b99f5a5b0399f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"5e73454620417acedf972bc1558b480c65fdbf51","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes rescue timeout due to incorrect kernel parameter in the iPXE script."},{"line_number":5,"context_line":"    See `bug 174980 \u003chttps://bugs.launchpad.net/ironic/+bug/1749860\u003e`_ for"},{"line_number":6,"context_line":"    details."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa0c359_a248cf2c","line":5,"range":{"start_line":5,"start_character":13,"end_line":5,"end_character":19},"in_reply_to":"3fa0c359_99c0c17e","updated":"2018-02-21 02:05:41.000000000","message":"Done\nThanks.","commit_id":"bc696da56b0ee7274e5010e0ea0b99f5a5b0399f"}]}