)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"3cf8c74a364c98125dc60eb4739959a53e54bc68","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This is the fix for bug 1236623. Currently we used $my_ip as the"},{"line_number":10,"context_line":"tftp_server, but we do need a dedicated config option especially"},{"line_number":11,"context_line":"when the provisioning network and public network for nova are"},{"line_number":12,"context_line":"different."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4b619319cee55c974027a2c4667230a6a499628f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2FcvQ%3D","line":12,"updated":"2013-11-06 01:13:09.000000000","message":"The nova network is irrelevant here. But for multi-network machines we may still have problem so the option is needed.","commit_id":"867b70e831e28e08d9d4e1450ca4d4e1a01fa4f6"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"ebf2830e19c179c3340be05562100d06c3d34f54","unresolved":false,"context_lines":[{"line_number":11,"context_line":"when the provisioning network and public network for nova are"},{"line_number":12,"context_line":"different."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4b619319cee55c974027a2c4667230a6a499628f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2FkJk%3D","line":14,"updated":"2013-11-01 08:46:15.000000000","message":"Jing, we should follow \"Summary of GIT commit message structure\" to add below line to link a defect(if required) at the very end:\n\nCloses-Bug: #1236623\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"867b70e831e28e08d9d4e1450ca4d4e1a01fa4f6"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"9832c03edaf2eeb00d880a460ced9189b64ee992","unresolved":false,"context_lines":[{"line_number":11,"context_line":"when the provisioning network and public network for nova are"},{"line_number":12,"context_line":"different."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4b619319cee55c974027a2c4667230a6a499628f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2Bhyg%3D","line":14,"updated":"2013-11-25 03:43:11.000000000","message":"Jing, I understand this patch can not close #1236623,  because we have to do patch in \u0027tripleo\u0027 for this defect, so add this line in the end of commit message.\n\nPartial-Bug: #1236623","commit_id":"6048d47f3c9e24aee75f76da00129f34d22ed557"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"1b6fc656770ab317d33219f8c60d2c6683e210b1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                default\u003d0),"},{"line_number":60,"context_line":"    cfg.StrOpt(\u0027tftp_server\u0027,"},{"line_number":61,"context_line":"               default\u003d\u0027$my_ip\u0027,"},{"line_number":62,"context_line":"               help\u003d\u0027Ironic compute node\\\u0027s tftp server hostname or ip\u0027),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027tftp_root\u0027,"},{"line_number":64,"context_line":"               default\u003d\u0027/tftpboot\u0027,"},{"line_number":65,"context_line":"               help\u003d\u0027Ironic compute node\\\u0027s tftp root path\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FkJE%3D","line":62,"updated":"2013-11-01 08:48:20.000000000","message":"If these new code are called/refereed by Ironic other code, we have to add unittest code to cover the change.","commit_id":"867b70e831e28e08d9d4e1450ca4d4e1a01fa4f6"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"3cf8c74a364c98125dc60eb4739959a53e54bc68","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                default\u003d0),"},{"line_number":60,"context_line":"    cfg.StrOpt(\u0027tftp_server\u0027,"},{"line_number":61,"context_line":"               default\u003d\u0027$my_ip\u0027,"},{"line_number":62,"context_line":"               help\u003d\u0027Ironic compute node\\\u0027s tftp server hostname or ip\u0027),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027tftp_root\u0027,"},{"line_number":64,"context_line":"               default\u003d\u0027/tftpboot\u0027,"},{"line_number":65,"context_line":"               help\u003d\u0027Ironic compute node\\\u0027s tftp root path\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fcvg%3D","line":62,"in_reply_to":"AAAATn%2F%2FkJE%3D","updated":"2013-11-06 01:13:09.000000000","message":"This must be ip only, not a hostname. hostname from PXE bootstrap is not reliable IME\n\nHowever, there is a bigger problem - this setting is not being used anywhere. This needs to either\n\n  A) be queryable by nova so that it can tell Neutron what PXE server details to use. \n\nor\n\n B) be given the Neutron port(s) for the instance and then tell Neutron to update the PXE config for those ports.\n\nEither way, more work is needed.","commit_id":"867b70e831e28e08d9d4e1450ca4d4e1a01fa4f6"}]}