)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"6a09438d0dac5c1cbbddfc2becbd695f795781d2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"API accepts UUID for ports only"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The MAC address may be changed, so it is not unsuitable to accept MAC"},{"line_number":10,"context_line":"as filter."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I249a984545ff50efb73e1ce8702be5407c15ebb7"},{"line_number":13,"context_line":"Closes-Bug: 1246816"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2FaRc%3D","line":10,"updated":"2013-11-06 23:49:10.000000000","message":"You have a double negative here: your commit message says the opposite to your code.\n\nI think \"The MAC address may be changed, so it is not suitable to accept MAC as a filter.\"","commit_id":"1c8abfc5a99b9f692f0a7b12f39f01579802b3cd"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"4c29935c1499a495943534e770ad10681fc7f123","unresolved":false,"context_lines":[{"line_number":7,"context_line":"API accepts UUID for ports only"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The MAC address may be changed, so it is not unsuitable to accept MAC"},{"line_number":10,"context_line":"as filter."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I249a984545ff50efb73e1ce8702be5407c15ebb7"},{"line_number":13,"context_line":"Closes-Bug: 1246816"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2FaHk%3D","line":10,"in_reply_to":"AAAATn%2F%2FaRc%3D","updated":"2013-11-07 01:53:11.000000000","message":"yes, have some confusing here, will change, thank you lifeless.","commit_id":"1c8abfc5a99b9f692f0a7b12f39f01579802b3cd"}],"ironic/api/controllers/v1/port.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"35f41a8711d9784cd0d0ad8ea4ff03f93f810115","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        if (not (uuidutils.is_uuid_like(uuid)"},{"line_number":205,"context_line":"              or utils.is_int_like(uuid))):"},{"line_number":206,"context_line":"            raise exception.InvalidUUID(uuid\u003duuid)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        rpc_port \u003d objects.Port.get_by_uuid(pecan.request.context, uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeK8%3D","line":205,"updated":"2013-11-05 09:33:30.000000000","message":"Haomeng, I talked with Lucas in chat, we should not expose db id via api.","commit_id":"37b6ca216d722c273cd0c5e5624f23d6b3ac5a45"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"ee8833ece165fd084f99d3b45478b03c0c360a20","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        if (not (uuidutils.is_uuid_like(uuid)"},{"line_number":205,"context_line":"              or utils.is_int_like(uuid))):"},{"line_number":206,"context_line":"            raise exception.InvalidUUID(uuid\u003duuid)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        rpc_port \u003d objects.Port.get_by_uuid(pecan.request.context, uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FcgM%3D","line":205,"in_reply_to":"AAAATn%2F%2FeFc%3D","updated":"2013-11-06 03:21:35.000000000","message":"Done","commit_id":"37b6ca216d722c273cd0c5e5624f23d6b3ac5a45"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c86dd3e785e598e3a5d55804941cb35c7b47c2a1","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        if (not (uuidutils.is_uuid_like(uuid)"},{"line_number":205,"context_line":"              or utils.is_int_like(uuid))):"},{"line_number":206,"context_line":"            raise exception.InvalidUUID(uuid\u003duuid)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        rpc_port \u003d objects.Port.get_by_uuid(pecan.request.context, uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fdq8%3D","line":205,"in_reply_to":"AAAATn%2F%2FeFc%3D","updated":"2013-11-05 14:07:34.000000000","message":"ok, thank you Devananda.","commit_id":"37b6ca216d722c273cd0c5e5624f23d6b3ac5a45"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"34caf7b9d44a1f0d15ca32ea5bf8c5fd0968e3cc","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        if (not (uuidutils.is_uuid_like(uuid)"},{"line_number":205,"context_line":"              or utils.is_int_like(uuid))):"},{"line_number":206,"context_line":"            raise exception.InvalidUUID(uuid\u003duuid)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        rpc_port \u003d objects.Port.get_by_uuid(pecan.request.context, uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeFc%3D","line":205,"in_reply_to":"AAAATn%2F%2FeK8%3D","updated":"2013-11-05 10:05:19.000000000","message":"This should only be checking is_uuid_like.","commit_id":"37b6ca216d722c273cd0c5e5624f23d6b3ac5a45"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c86dd3e785e598e3a5d55804941cb35c7b47c2a1","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        if (not (uuidutils.is_uuid_like(uuid)"},{"line_number":205,"context_line":"              or utils.is_int_like(uuid))):"},{"line_number":206,"context_line":"            raise exception.InvalidUUID(uuid\u003duuid)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        rpc_port \u003d objects.Port.get_by_uuid(pecan.request.context, uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FdrA%3D","line":205,"in_reply_to":"AAAATn%2F%2FeK8%3D","updated":"2013-11-05 14:07:34.000000000","message":"Yuriy, got it, will remove id-like here, thanks for your comments.","commit_id":"37b6ca216d722c273cd0c5e5624f23d6b3ac5a45"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"35f41a8711d9784cd0d0ad8ea4ff03f93f810115","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        \"\"\"Update an existing port.\"\"\""},{"line_number":239,"context_line":"        if self._from_nodes:"},{"line_number":240,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        port \u003d objects.Port.get_by_uuid(pecan.request.context, uuid)"},{"line_number":243,"context_line":"        port_dict \u003d port.as_dict()"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeME%3D","line":241,"updated":"2013-11-05 09:33:30.000000000","message":"And what about patch?","commit_id":"37b6ca216d722c273cd0c5e5624f23d6b3ac5a45"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c86dd3e785e598e3a5d55804941cb35c7b47c2a1","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        \"\"\"Update an existing port.\"\"\""},{"line_number":239,"context_line":"        if self._from_nodes:"},{"line_number":240,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        port \u003d objects.Port.get_by_uuid(pecan.request.context, uuid)"},{"line_number":243,"context_line":"        port_dict \u003d port.as_dict()"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fdqs%3D","line":241,"in_reply_to":"AAAATn%2F%2FeME%3D","updated":"2013-11-05 14:07:34.000000000","message":"Good point, will add more case to cover all RUD cases","commit_id":"37b6ca216d722c273cd0c5e5624f23d6b3ac5a45"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"35f41a8711d9784cd0d0ad8ea4ff03f93f810115","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        \"\"\"Delete a port.\"\"\""},{"line_number":287,"context_line":"        if self._from_nodes:"},{"line_number":288,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        pecan.request.dbapi.destroy_port(port_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FeKo%3D","line":289,"updated":"2013-11-05 09:33:30.000000000","message":"And destroy?","commit_id":"37b6ca216d722c273cd0c5e5624f23d6b3ac5a45"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c86dd3e785e598e3a5d55804941cb35c7b47c2a1","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        \"\"\"Delete a port.\"\"\""},{"line_number":287,"context_line":"        if self._from_nodes:"},{"line_number":288,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        pecan.request.dbapi.destroy_port(port_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fdqw%3D","line":289,"in_reply_to":"AAAATn%2F%2FeKo%3D","updated":"2013-11-05 14:07:34.000000000","message":"Good point, will add more case to cover all RUD cases","commit_id":"37b6ca216d722c273cd0c5e5624f23d6b3ac5a45"},{"author":{"_account_id":6530,"name":"craigtracey","email":"craigtracey@gmail.com","username":"craigtracey"},"change_message_id":"23528a43923ad797f68e7eda32a07dc213ea29f1","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        if self._from_nodes:"},{"line_number":290,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        if not uuidutils.is_uuid_like(port_id):"},{"line_number":293,"context_line":"            raise exception.InvalidUUID(uuid\u003dport_id)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        pecan.request.dbapi.destroy_port(port_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FXFI%3D","line":292,"updated":"2013-11-08 08:04:35.000000000","message":"This is ambiguous as this variable is still named port_id.  If we are planning on filtering on uuid, we should make this \u0027uuid\u0027 just as in the other methods.","commit_id":"ebe03a912dcc8ac725d1930b4919b4250ea860de"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c5f0c238682c062b67ca862b0a1b99aa27f3e812","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        if self._from_nodes:"},{"line_number":290,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        if not uuidutils.is_uuid_like(port_id):"},{"line_number":293,"context_line":"            raise exception.InvalidUUID(uuid\u003dport_id)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        pecan.request.dbapi.destroy_port(port_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FW%2F8%3D","line":292,"in_reply_to":"AAAATn%2F%2FXFI%3D","updated":"2013-11-08 08:46:16.000000000","message":"ok, I scanned the code, no any call to reference this \u0027port_id\u0027 identifier, so we can change it to uuid directly.\n\ncraigtracey, thanks for your comments.","commit_id":"ebe03a912dcc8ac725d1930b4919b4250ea860de"},{"author":{"_account_id":6530,"name":"craigtracey","email":"craigtracey@gmail.com","username":"craigtracey"},"change_message_id":"23528a43923ad797f68e7eda32a07dc213ea29f1","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        if not uuidutils.is_uuid_like(port_id):"},{"line_number":293,"context_line":"            raise exception.InvalidUUID(uuid\u003dport_id)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        pecan.request.dbapi.destroy_port(port_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FXFE%3D","line":295,"updated":"2013-11-08 08:04:35.000000000","message":"This will not work as dbapi is expecting to filter the port by address, not uuid.","commit_id":"ebe03a912dcc8ac725d1930b4919b4250ea860de"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c5f0c238682c062b67ca862b0a1b99aa27f3e812","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        if not uuidutils.is_uuid_like(port_id):"},{"line_number":293,"context_line":"            raise exception.InvalidUUID(uuid\u003dport_id)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        pecan.request.dbapi.destroy_port(port_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FW%2F4%3D","line":295,"in_reply_to":"AAAATn%2F%2FXFE%3D","updated":"2013-11-08 08:46:16.000000000","message":"craigtracey, our db layer code supports both uuid and macadd:\n\nhttps://github.com/openstack/ironic/blob/master/ironic/db/sqlalchemy/api.py#L106 \n\nSo it should work for uuid as input, how do you think?","commit_id":"ebe03a912dcc8ac725d1930b4919b4250ea860de"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"1abf879c0896c78242ff5983409e70bcdd1cbe5f","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        if self._from_nodes:"},{"line_number":202,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        if not uuidutils.is_uuid_like(uuid):"},{"line_number":205,"context_line":"            raise exception.InvalidUUID(uuid\u003duuid)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        rpc_port \u003d objects.Port.get_by_uuid(pecan.request.context, uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FTPg%3D","line":204,"updated":"2013-11-11 12:45:10.000000000","message":"This is not the solution. Method Port.get_by_uuid should return port by uuid. Not by mac address on something else. Maybe method db.api.get_port_by_uuid should be added.","commit_id":"dca91f7f4e5042e88a00782e8530cd781d2104cb"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"16e4b03d8a1435b5219ed8b7dfafff8dd27e2102","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        if self._from_nodes:"},{"line_number":202,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        if not uuidutils.is_uuid_like(uuid):"},{"line_number":205,"context_line":"            raise exception.InvalidUUID(uuid\u003duuid)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        rpc_port \u003d objects.Port.get_by_uuid(pecan.request.context, uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FQ1I%3D","line":204,"in_reply_to":"AAAATn%2F%2FTPg%3D","updated":"2013-11-12 03:20:07.000000000","message":"ok, we will remove the \u0027address\u0027 input supporting from  Port.get_by_uuid, that is the fix from the \u0027root\u0027 for this issue I think, good comments.","commit_id":"dca91f7f4e5042e88a00782e8530cd781d2104cb"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"1abf879c0896c78242ff5983409e70bcdd1cbe5f","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        if not uuidutils.is_uuid_like(uuid):"},{"line_number":293,"context_line":"            raise exception.InvalidUUID(uuid\u003duuid)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        pecan.request.dbapi.destroy_port(uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FTO4%3D","line":295,"updated":"2013-11-11 12:45:10.000000000","message":"same","commit_id":"dca91f7f4e5042e88a00782e8530cd781d2104cb"}]}
