)]}'
{"ironic/db/sqlalchemy/api.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"002eaa0c214515b0a0ccfe36904d639f37e366f5","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        return result"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    @objects.objectify(objects.Node)"},{"line_number":290,"context_line":"    def get_node_by_instance(self, instance):"},{"line_number":291,"context_line":"        if not uuidutils.is_uuid_like(instance):"},{"line_number":292,"context_line":"            raise exception.InvalidUUID(uuid\u003dinstance)"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fc54%3D","line":290,"updated":"2013-11-05 22:21:47.000000000","message":"Sorry it\u0027s not a comment about what you are really trying to fix here, but I think we should rename this method to get_node_by_instance_uuid() (and the parameter also should be instance_uuid), get_node_by_instance() imo kinda suggest that we are passing an instance object to it which is not true.\n\nAnyone thoughts ?","commit_id":"287ed32d971152ecc845e3702afd857bca263c1d"},{"author":{"_account_id":7589,"name":"linggao","email":"linggao@us.ibm.com","username":"linggao"},"change_message_id":"10ae1f9986babb18298b42785770f2fc9106a82e","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        return result"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    @objects.objectify(objects.Node)"},{"line_number":290,"context_line":"    def get_node_by_instance(self, instance):"},{"line_number":291,"context_line":"        if not uuidutils.is_uuid_like(instance):"},{"line_number":292,"context_line":"            raise exception.InvalidUUID(uuid\u003dinstance)"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fap4%3D","line":290,"in_reply_to":"AAAATn%2F%2Fa%2Bw%3D","updated":"2013-11-06 19:06:42.000000000","message":"Should name change be done in a different patch?","commit_id":"287ed32d971152ecc845e3702afd857bca263c1d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0e21382c520db30095f110c53d1800b5f8c9766f","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        return result"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    @objects.objectify(objects.Node)"},{"line_number":290,"context_line":"    def get_node_by_instance(self, instance):"},{"line_number":291,"context_line":"        if not uuidutils.is_uuid_like(instance):"},{"line_number":292,"context_line":"            raise exception.InvalidUUID(uuid\u003dinstance)"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FadM%3D","line":290,"in_reply_to":"AAAATn%2F%2Fap4%3D","updated":"2013-11-06 21:12:48.000000000","message":"Yes that would be even better, then you could add this patch to depend on ur new patch. \n\nhttps://wiki.openstack.org/wiki/Gerrit_Workflow#Add_dependency","commit_id":"287ed32d971152ecc845e3702afd857bca263c1d"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"e18172f2aea0fb50467080d9553b7fc8ac38e8cc","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        return result"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    @objects.objectify(objects.Node)"},{"line_number":290,"context_line":"    def get_node_by_instance(self, instance):"},{"line_number":291,"context_line":"        if not uuidutils.is_uuid_like(instance):"},{"line_number":292,"context_line":"            raise exception.InvalidUUID(uuid\u003dinstance)"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fa%2Bw%3D","line":290,"in_reply_to":"AAAATn%2F%2Fc54%3D","updated":"2013-11-06 16:04:32.000000000","message":"Vote for renaming :) get_node_by_instance_uuid seems more clear to me","commit_id":"287ed32d971152ecc845e3702afd857bca263c1d"}],"ironic/tests/db/test_nodes.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"8625551edd877f622ad53de546b353251307f6eb","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                          \u002712345678-9999-0000-bbbb-123456789012\u0027)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def test_get_node_by_instance_invalid_uuid(self):"},{"line_number":134,"context_line":"        self._create_test_node("},{"line_number":135,"context_line":"                instance_uuid\u003d\u002712345678-9999-0000-aaaa-123456789012\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        self.assertRaises(exception.InvalidUUID,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FdtA%3D","line":134,"updated":"2013-11-05 13:36:56.000000000","message":"node creation is redundant here","commit_id":"418239be51827dcef24e984e4062c6eef4bb51db"},{"author":{"_account_id":7589,"name":"linggao","email":"linggao@us.ibm.com","username":"linggao"},"change_message_id":"c81bc4009aa4b830d279a5002e74ae4ba8f27fdb","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                          \u002712345678-9999-0000-bbbb-123456789012\u0027)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def test_get_node_by_instance_invalid_uuid(self):"},{"line_number":134,"context_line":"        self._create_test_node("},{"line_number":135,"context_line":"                instance_uuid\u003d\u002712345678-9999-0000-aaaa-123456789012\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        self.assertRaises(exception.InvalidUUID,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FdrM%3D","line":134,"in_reply_to":"AAAATn%2F%2FdtA%3D","updated":"2013-11-05 14:03:07.000000000","message":"Done, thanks.","commit_id":"418239be51827dcef24e984e4062c6eef4bb51db"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"e18172f2aea0fb50467080d9553b7fc8ac38e8cc","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        res \u003d self.dbapi.get_node_by_instance(n[\u0027instance_uuid\u0027])"},{"line_number":127,"context_line":"        self.assertEqual(n[\u0027uuid\u0027], res[\u0027uuid\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self.assertRaises(exception.InstanceNotFound,"},{"line_number":130,"context_line":"                          self.dbapi.get_node_by_instance,"},{"line_number":131,"context_line":"                          \u002712345678-9999-0000-bbbb-123456789012\u0027)"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fa%2Fo%3D","line":129,"updated":"2013-11-06 16:04:32.000000000","message":"What if we move this assert to a separate UT? My thoughts is that this is a separate scenario - test_get_node_by_instance_not_found() for example","commit_id":"287ed32d971152ecc845e3702afd857bca263c1d"},{"author":{"_account_id":7589,"name":"linggao","email":"linggao@us.ibm.com","username":"linggao"},"change_message_id":"646644d8cc267ab44f8127dda42b132cb609e1cd","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        res \u003d self.dbapi.get_node_by_instance(n[\u0027instance_uuid\u0027])"},{"line_number":127,"context_line":"        self.assertEqual(n[\u0027uuid\u0027], res[\u0027uuid\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self.assertRaises(exception.InstanceNotFound,"},{"line_number":130,"context_line":"                          self.dbapi.get_node_by_instance,"},{"line_number":131,"context_line":"                          \u002712345678-9999-0000-bbbb-123456789012\u0027)"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FaoU%3D","line":129,"in_reply_to":"AAAATn%2F%2Fa%2Fo%3D","updated":"2013-11-06 19:24:59.000000000","message":"Done. But it was not my fault :-).","commit_id":"287ed32d971152ecc845e3702afd857bca263c1d"}]}