)]}'
{"ironic/common/pxe_utils.py":[{"author":{"_account_id":18480,"name":"zhengy","email":"zhengy23@163.com","username":"zhengyong"},"change_message_id":"e4a71bd92aebd3d8959be4e3ec860e6a71e3c8c8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"DHCP_TFTP_SERVER_ADDRESS \u003d \u0027150\u0027  # rfc5859"},{"line_number":41,"context_line":"DHCP_IPXE_ENCAP_OPTS \u003d \u0027175\u0027  # Tentatively Assigned"},{"line_number":42,"context_line":"DHCP_TFTP_PATH_PREFIX \u003d \u0027210\u0027  # rfc5071"},{"line_number":43,"context_line":"DHCPV6_BOOTFILE_URL \u003d \u002759\u0027  # rfc5970"},{"line_number":44,"context_line":"DEPLOY_KERNEL_RAMDISK_LABELS \u003d [\u0027deploy_kernel\u0027, \u0027deploy_ramdisk\u0027]"},{"line_number":45,"context_line":"RESCUE_KERNEL_RAMDISK_LABELS \u003d [\u0027rescue_kernel\u0027, \u0027rescue_ramdisk\u0027]"},{"line_number":46,"context_line":"KERNEL_RAMDISK_LABELS \u003d {\u0027deploy\u0027: DEPLOY_KERNEL_RAMDISK_LABELS,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_456992f6","line":43,"updated":"2018-03-15 01:08:06.000000000","message":"I tested with option \"DHCPV6_BOOTFILE_URL \u003d \u0027bootfile-url\" works well, but \"DHCPV6_BOOTFILE_URL \u003d \u002759\"  make pxe boot failed. You tested DHCPV6_BOOTFILE_URL \u003d \u002759\u0027 ok?","commit_id":"98cbf9ab2b5dd2c794e12e95b421c4c749cf7f08"},{"author":{"_account_id":18480,"name":"zhengy","email":"zhengy23@163.com","username":"zhengyong"},"change_message_id":"f18d884dc4d9368e2e12a182a79d461eddca0c35","unresolved":false,"context_lines":[{"line_number":40,"context_line":"DHCP_TFTP_SERVER_ADDRESS \u003d \u0027150\u0027  # rfc5859"},{"line_number":41,"context_line":"DHCP_IPXE_ENCAP_OPTS \u003d \u0027175\u0027  # Tentatively Assigned"},{"line_number":42,"context_line":"DHCP_TFTP_PATH_PREFIX \u003d \u0027210\u0027  # rfc5071"},{"line_number":43,"context_line":"DHCPV6_BOOTFILE_URL \u003d \u002759\u0027  # rfc5970"},{"line_number":44,"context_line":"DEPLOY_KERNEL_RAMDISK_LABELS \u003d [\u0027deploy_kernel\u0027, \u0027deploy_ramdisk\u0027]"},{"line_number":45,"context_line":"RESCUE_KERNEL_RAMDISK_LABELS \u003d [\u0027rescue_kernel\u0027, \u0027rescue_ramdisk\u0027]"},{"line_number":46,"context_line":"KERNEL_RAMDISK_LABELS \u003d {\u0027deploy\u0027: DEPLOY_KERNEL_RAMDISK_LABELS,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_476323ac","line":43,"in_reply_to":"5f7c97a3_407028db","updated":"2018-07-27 01:34:55.000000000","message":"very strange, I don\u0027t know why","commit_id":"98cbf9ab2b5dd2c794e12e95b421c4c749cf7f08"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"9fa137b9293412594a8b88f930fb85729c8dec43","unresolved":false,"context_lines":[{"line_number":40,"context_line":"DHCP_TFTP_SERVER_ADDRESS \u003d \u0027150\u0027  # rfc5859"},{"line_number":41,"context_line":"DHCP_IPXE_ENCAP_OPTS \u003d \u0027175\u0027  # Tentatively Assigned"},{"line_number":42,"context_line":"DHCP_TFTP_PATH_PREFIX \u003d \u0027210\u0027  # rfc5071"},{"line_number":43,"context_line":"DHCPV6_BOOTFILE_URL \u003d \u002759\u0027  # rfc5970"},{"line_number":44,"context_line":"DEPLOY_KERNEL_RAMDISK_LABELS \u003d [\u0027deploy_kernel\u0027, \u0027deploy_ramdisk\u0027]"},{"line_number":45,"context_line":"RESCUE_KERNEL_RAMDISK_LABELS \u003d [\u0027rescue_kernel\u0027, \u0027rescue_ramdisk\u0027]"},{"line_number":46,"context_line":"KERNEL_RAMDISK_LABELS \u003d {\u0027deploy\u0027: DEPLOY_KERNEL_RAMDISK_LABELS,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_407028db","line":43,"in_reply_to":"df7087c5_456992f6","updated":"2018-06-06 10:38:07.000000000","message":"Same here\n   DHCPV6_BOOTFILE_URL \u003d \u0027bootfile-url\u0027\nworked for me 59 didn\u0027t","commit_id":"98cbf9ab2b5dd2c794e12e95b421c4c749cf7f08"},{"author":{"_account_id":18480,"name":"zhengy","email":"zhengy23@163.com","username":"zhengyong"},"change_message_id":"e4a71bd92aebd3d8959be4e3ec860e6a71e3c8c8","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        # and \"]\" characters. (https://tools.ietf.org/html/rfc5970)"},{"line_number":217,"context_line":"        tftp_server \u003d \u0027[\u0027 + CONF.pxe.tftp_server + \u0027]\u0027"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    return \u0027tftp://\u0027 + tftp_server + get_root_dir() + \u0027/\u0027 + boot_file"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"def create_pxe_config(task, pxe_options, template\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_25349efb","line":219,"updated":"2018-03-15 01:08:06.000000000","message":"I prefer \u0027%\u0027 rather than \u0027+\u0027 to format string, \nMore efficient","commit_id":"98cbf9ab2b5dd2c794e12e95b421c4c749cf7f08"},{"author":{"_account_id":18480,"name":"zhengy","email":"zhengy23@163.com","username":"zhengyong"},"change_message_id":"e4a71bd92aebd3d8959be4e3ec860e6a71e3c8c8","unresolved":false,"context_lines":[{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    # NOTE(hjensas): Add bootfile-url option if ipversion 6."},{"line_number":407,"context_line":"    # https://bugs.launchpad.net/ironic/+bug/1744620"},{"line_number":408,"context_line":"    if int(CONF.pxe.ip_version) \u003d\u003d 6:"},{"line_number":409,"context_line":"        dhcp_opts.append({\u0027opt_name\u0027: DHCPV6_BOOTFILE_URL,"},{"line_number":410,"context_line":"                          \u0027opt_value\u0027: get_pxe_boot_file_url(boot_file)})"},{"line_number":411,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_659136f1","line":408,"updated":"2018-03-15 01:08:06.000000000","message":"when I tested under IPv6 network, only option \u0027DHCPV6_BOOTFILE_URL\u0027 is needed, other options such as \u0027DHCP_BOOTFILE_NAME\u0027 for IPv4 will make pxe boot failed.","commit_id":"98cbf9ab2b5dd2c794e12e95b421c4c749cf7f08"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"9fa137b9293412594a8b88f930fb85729c8dec43","unresolved":false,"context_lines":[{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    # NOTE(hjensas): Add bootfile-url option if ipversion 6."},{"line_number":407,"context_line":"    # https://bugs.launchpad.net/ironic/+bug/1744620"},{"line_number":408,"context_line":"    if int(CONF.pxe.ip_version) \u003d\u003d 6:"},{"line_number":409,"context_line":"        dhcp_opts.append({\u0027opt_name\u0027: DHCPV6_BOOTFILE_URL,"},{"line_number":410,"context_line":"                          \u0027opt_value\u0027: get_pxe_boot_file_url(boot_file)})"},{"line_number":411,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_205e4c45","line":408,"in_reply_to":"df7087c5_659136f1","updated":"2018-06-06 10:38:07.000000000","message":"Yup, I had to wrap server-ip-address above in\n    if int(CONF.pxe.ip_version) \u003d\u003d 4:","commit_id":"98cbf9ab2b5dd2c794e12e95b421c4c749cf7f08"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"9fa137b9293412594a8b88f930fb85729c8dec43","unresolved":false,"context_lines":[{"line_number":407,"context_line":"    # https://bugs.launchpad.net/ironic/+bug/1744620"},{"line_number":408,"context_line":"    if int(CONF.pxe.ip_version) \u003d\u003d 6:"},{"line_number":409,"context_line":"        dhcp_opts.append({\u0027opt_name\u0027: DHCPV6_BOOTFILE_URL,"},{"line_number":410,"context_line":"                          \u0027opt_value\u0027: get_pxe_boot_file_url(boot_file)})"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    # Append the IP version for all the configuration options"},{"line_number":413,"context_line":"    for opt in dhcp_opts:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_c329a289","line":410,"updated":"2018-06-06 10:38:07.000000000","message":"To allow for ipxe chain-loading so \n    dhcp_opts.append({\u0027opt_name\u0027: \"tag:!ipxe,\"+DHCPV6_BOOTFILE_URL, \u0027opt_value\u0027: get_pxe_boot_file_url(boot_file)})\n    dhcp_opts.append({\u0027opt_name\u0027: \"tag:ipxe,\"+DHCPV6_BOOTFILE_URL, \u0027opt_value\u0027: \u0027http://...\u0027})","commit_id":"98cbf9ab2b5dd2c794e12e95b421c4c749cf7f08"},{"author":{"_account_id":18480,"name":"zhengy","email":"zhengy23@163.com","username":"zhengyong"},"change_message_id":"f18d884dc4d9368e2e12a182a79d461eddca0c35","unresolved":false,"context_lines":[{"line_number":407,"context_line":"    # https://bugs.launchpad.net/ironic/+bug/1744620"},{"line_number":408,"context_line":"    if int(CONF.pxe.ip_version) \u003d\u003d 6:"},{"line_number":409,"context_line":"        dhcp_opts.append({\u0027opt_name\u0027: DHCPV6_BOOTFILE_URL,"},{"line_number":410,"context_line":"                          \u0027opt_value\u0027: get_pxe_boot_file_url(boot_file)})"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    # Append the IP version for all the configuration options"},{"line_number":413,"context_line":"    for opt in dhcp_opts:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_676e5f98","line":410,"in_reply_to":"5f7c97a3_c329a289","updated":"2018-07-27 01:34:55.000000000","message":"I did not test ipxe with ipv6 yet","commit_id":"98cbf9ab2b5dd2c794e12e95b421c4c749cf7f08"}]}