)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"80933fd72093127885b764394296d30a5533f0b3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"enables user to pass parameters to IPA running from iLO vmedia."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ied9d5f7735ec7ce22d98ca384f732fef16b85be7"},{"line_number":17,"context_line":"Closes-Bug: #1758030"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf659307_5c420d40","line":17,"updated":"2018-03-28 20:54:23.000000000","message":"If you revise this, you\u0027ll want to change this to \"Story\" instead of \"Closes-Bug\"","commit_id":"8861a29d219ee449e708166fb8bbc66930128627"}],"ironic/conf/ilo.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"be8939ed076269d87922b83190b253b971b717a1","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                      \u0027\"auto\" for backward compatibility. When \"auto\" is \u0027"},{"line_number":85,"context_line":"                      \u0027specified, default boot mode will be selected based \u0027"},{"line_number":86,"context_line":"                      \u0027on boot mode settings on the system.\u0027)),"},{"line_number":87,"context_line":"    cfg.DictOpt(\u0027append_params\u0027,"},{"line_number":88,"context_line":"                default\u003d{},"},{"line_number":89,"context_line":"                help\u003d_(\u0027Additional append parameters for baremetal iLO \u0027"},{"line_number":90,"context_line":"                       \u0027boot.\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_ec0b338b","line":87,"range":{"start_line":87,"start_character":17,"end_line":87,"end_character":30},"updated":"2018-03-22 12:43:09.000000000","message":"iLO drivers support both PXE and vmedia based provisioning. Will it be better to call it \u0027vmedia_append_params\u0027 as it applies only to vmedia?","commit_id":"c1a039fb575cc365244a33f9aa05d62029e12250"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"be8939ed076269d87922b83190b253b971b717a1","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    cfg.DictOpt(\u0027append_params\u0027,"},{"line_number":88,"context_line":"                default\u003d{},"},{"line_number":89,"context_line":"                help\u003d_(\u0027Additional append parameters for baremetal iLO \u0027"},{"line_number":90,"context_line":"                       \u0027boot.\u0027)),"},{"line_number":91,"context_line":"]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_4ccc9f69","line":90,"range":{"start_line":90,"start_character":24,"end_line":90,"end_character":28},"updated":"2018-03-22 12:43:09.000000000","message":"s/ \u0027boot\u0027 / \u0027virtual media boot\u0027/","commit_id":"c1a039fb575cc365244a33f9aa05d62029e12250"}],"ironic/drivers/modules/ilo/boot.py":[{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"8d158d9f5a499b420e10784245e36f5ae32dfce5","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            iso \u003d node.driver_info[\u0027ilo_deploy_iso\u0027]"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        # Append optional params"},{"line_number":478,"context_line":"        ramdisk_params.update(CONF.ilo.vmedia_append_params)"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        ilo_common.setup_vmedia(task, iso, ramdisk_params)"},{"line_number":481,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_fd786690","line":478,"updated":"2018-04-03 10:41:22.000000000","message":"What is the intended behaviour when vmedia_append_params has ramdisk parameters which conflict with the ones already in ramdisk_params at this point?\n\nIn the current implementation vmedia_append_params will \noverride and stomp on any params already in ramdisk_params. \ne.g.\n\n  vmedia_append_params \u003d {\"BOOTIF\": \"thing\"}\n  ramdisk_parmas \u003d {\"BOOTIF\": \"otherthing\"}\n\n  ramdisk_params.update(vmedia_append_params)\n\n  print(ramdisk_params)\n  {\"BOOTIF\": \"thing\"}\n\nIs this the indented behaviour?","commit_id":"222d44250e631e44fc352006bde999bf7c4eee47"}],"releasenotes/notes/add-ilo-append-params-d37f00808a364e40.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"be8939ed076269d87922b83190b253b971b717a1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - A new configuration option ``[ilo]append_params`` has been"},{"line_number":4,"context_line":"    added. It enables users to pass additional parameters to IPA"},{"line_number":5,"context_line":"    when iLO driver is used. iLO driver uses vmedia to pass"},{"line_number":6,"context_line":"    parameters to running IPA so ``[pxe]pxe_append_params`` will"},{"line_number":7,"context_line":"    not work."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df7087c5_8c95d734","line":5,"range":{"start_line":5,"start_character":29,"end_line":5,"end_character":40},"updated":"2018-03-22 12:43:09.000000000","message":"ditto","commit_id":"c1a039fb575cc365244a33f9aa05d62029e12250"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"be8939ed076269d87922b83190b253b971b717a1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - A new configuration option ``[ilo]append_params`` has been"},{"line_number":4,"context_line":"    added. It enables users to pass additional parameters to IPA"},{"line_number":5,"context_line":"    when iLO driver is used. iLO driver uses vmedia to pass"},{"line_number":6,"context_line":"    parameters to running IPA so ``[pxe]pxe_append_params`` will"},{"line_number":7,"context_line":"    not work."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df7087c5_6c7ba327","line":5,"range":{"start_line":5,"start_character":9,"end_line":5,"end_character":19},"updated":"2018-03-22 12:43:09.000000000","message":"s/ \u0027iLO driver\u0027 / \u0027``ilo-virtual-media`` boot interface\u0027 /","commit_id":"c1a039fb575cc365244a33f9aa05d62029e12250"}]}
