)]}'
{"ironic/drivers/modules/xclarity/common.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"32db0c82bab460b2f14ae8f86adb4bada79ab5c5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \u0027xclarity_client.exceptions\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"REQUIRED_ON_DRIVER_INFO \u003d {"},{"line_number":31,"context_line":"    \u0027xclarity_hardware_id\u0027: _(\"XClarity Server Hardware ID. \""},{"line_number":32,"context_line":"                              \"Required in driver_info.\"),"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_b496ce92","line":31,"updated":"2018-03-29 13:45:52.000000000","message":"out of scope of the patch but... when I was grepping to see what was being used from the node.driver_info, the code is getting \u0027server_hardware_id\u0027, not \u0027xclarity_hardware_id\u0027 :-(","commit_id":"de457dfb6d72c8bee37ca1f28ea3676871331771"},{"author":{"_account_id":25547,"name":"jiapei","email":"jiapeish@gmail.com","username":"jeremy.jia"},"change_message_id":"6a0314e5631e0f8efc9480c90af49ff793f5cfe2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \u0027xclarity_client.exceptions\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"REQUIRED_ON_DRIVER_INFO \u003d {"},{"line_number":31,"context_line":"    \u0027xclarity_hardware_id\u0027: _(\"XClarity Server Hardware ID. \""},{"line_number":32,"context_line":"                              \"Required in driver_info.\"),"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_cb975590","line":31,"in_reply_to":"bf659307_b496ce92","updated":"2018-04-10 07:31:53.000000000","message":"Yes, this should be \u0027server_hardware_id\u0027. Actually, XClarity is a software, it doesn\u0027t have hardware id. It is the XClarity managed server\u0027s hardware id that is required here.","commit_id":"de457dfb6d72c8bee37ca1f28ea3676871331771"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"32db0c82bab460b2f14ae8f86adb4bada79ab5c5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                              \"Required in driver_info.\"),"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"COMMON_PROPERTIES \u003d {"},{"line_number":36,"context_line":"    \u0027xclarity_manager_ip\u0027: _(\"IP address of the XClarity node.\"),"},{"line_number":37,"context_line":"    \u0027xclarity_username\u0027: _(\"Username for the XClarity with administrator \""},{"line_number":38,"context_line":"                           \"privileges.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_14869a67","line":35,"updated":"2018-03-29 13:45:52.000000000","message":"there seems to be something wrong with the xclarity code. I believe that these properties are meant to be specified in the node.driver_info. But I did a quick grep of the code, and I don\u0027t see that these are needed -- I don\u0027t see any code trying to access these. Am I missing something?","commit_id":"de457dfb6d72c8bee37ca1f28ea3676871331771"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5ae2c304fc9f650830676e955fc5fa1a217ddef4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                              \"Required in driver_info.\"),"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"COMMON_PROPERTIES \u003d {"},{"line_number":36,"context_line":"    \u0027xclarity_manager_ip\u0027: _(\"IP address of the XClarity node.\"),"},{"line_number":37,"context_line":"    \u0027xclarity_username\u0027: _(\"Username for the XClarity with administrator \""},{"line_number":38,"context_line":"                           \"privileges.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_31ed02b7","line":35,"in_reply_to":"bf659307_1114909f","updated":"2018-04-11 01:09:25.000000000","message":"We can amend the spec, but if they all have to be defined in the .conf file, then that severely impacts the ability to have more than one xclairty server in the mix until we have a concept of locality pinning.","commit_id":"de457dfb6d72c8bee37ca1f28ea3676871331771"},{"author":{"_account_id":25547,"name":"jiapei","email":"jiapeish@gmail.com","username":"jeremy.jia"},"change_message_id":"e1fc5f5600b26cdd7a6ff02b32c0701a4e1e2341","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                              \"Required in driver_info.\"),"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"COMMON_PROPERTIES \u003d {"},{"line_number":36,"context_line":"    \u0027xclarity_manager_ip\u0027: _(\"IP address of the XClarity node.\"),"},{"line_number":37,"context_line":"    \u0027xclarity_username\u0027: _(\"Username for the XClarity with administrator \""},{"line_number":38,"context_line":"                           \"privileges.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_232fea3f","line":35,"in_reply_to":"bf659307_1114909f","updated":"2018-04-11 12:53:22.000000000","message":"We have supposed that nodes are managed by a xclarity. So the parameters are defined in the .conf file. But it seems better to specify the xclarity info in driver_info, then it is also consistent with the xclarity spec.","commit_id":"de457dfb6d72c8bee37ca1f28ea3676871331771"},{"author":{"_account_id":25547,"name":"jiapei","email":"jiapeish@gmail.com","username":"jeremy.jia"},"change_message_id":"6a0314e5631e0f8efc9480c90af49ff793f5cfe2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                              \"Required in driver_info.\"),"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"COMMON_PROPERTIES \u003d {"},{"line_number":36,"context_line":"    \u0027xclarity_manager_ip\u0027: _(\"IP address of the XClarity node.\"),"},{"line_number":37,"context_line":"    \u0027xclarity_username\u0027: _(\"Username for the XClarity with administrator \""},{"line_number":38,"context_line":"                           \"privileges.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_8602af0a","line":35,"in_reply_to":"bf659307_14869a67","updated":"2018-04-10 07:31:53.000000000","message":"These properties\u0027 values are configured in the conf/xclarity.py, user writes the xclarity\u0027s manager_ip, username, password and port in the CONF file. \n\nHere we just describe the meaning of these properties, so that user will get notice when get_properties() is called.","commit_id":"de457dfb6d72c8bee37ca1f28ea3676871331771"},{"author":{"_account_id":25547,"name":"jiapei","email":"jiapeish@gmail.com","username":"jeremy.jia"},"change_message_id":"e1fc5f5600b26cdd7a6ff02b32c0701a4e1e2341","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                              \"Required in driver_info.\"),"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"COMMON_PROPERTIES \u003d {"},{"line_number":36,"context_line":"    \u0027xclarity_manager_ip\u0027: _(\"IP address of the XClarity node.\"),"},{"line_number":37,"context_line":"    \u0027xclarity_username\u0027: _(\"Username for the XClarity with administrator \""},{"line_number":38,"context_line":"                           \"privileges.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_e3b25206","line":35,"in_reply_to":"bf659307_31ed02b7","updated":"2018-04-11 12:53:22.000000000","message":"I think we can modify the code, keep COMMON_PROPERTIES as empty, leave the .conf file as empty. And modify xclarity_client to call driver_info.","commit_id":"de457dfb6d72c8bee37ca1f28ea3676871331771"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6d85bed50582c80ec0bca0882e6d3530b704b9fb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                              \"Required in driver_info.\"),"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"COMMON_PROPERTIES \u003d {"},{"line_number":36,"context_line":"    \u0027xclarity_manager_ip\u0027: _(\"IP address of the XClarity node.\"),"},{"line_number":37,"context_line":"    \u0027xclarity_username\u0027: _(\"Username for the XClarity with administrator \""},{"line_number":38,"context_line":"                           \"privileges.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_1114909f","line":35,"in_reply_to":"bf659307_8602af0a","updated":"2018-04-10 12:44:24.000000000","message":"get_properties() is used for the API request to show what can be specified in a node\u0027s driver_info field [1]. Not for the configuration options available.\n\nSo you don\u0027t want to provide a way to override/specify the xclarity information per node? The info must be the same for all nodes using xclarity?\n\nI took a look at the xclarity spec [2], and it mentions there that these are required in the node\u0027s driver_info fields :-(\n\n[1] https://developer.openstack.org/api-ref/baremetal/#show-driver-properties\n[2] https://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/xclarity-driver.html#other-deployer-impact","commit_id":"de457dfb6d72c8bee37ca1f28ea3676871331771"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"13bc007f320901e6f403c5e711aa75be53c512dc","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            ip\u003dCONF.xclarity.manager_ip,"},{"line_number":62,"context_line":"            username\u003dCONF.xclarity.username,"},{"line_number":63,"context_line":"            password\u003dCONF.xclarity.password,"},{"line_number":64,"context_line":"            port\u003dCONF.xclarity.port"},{"line_number":65,"context_line":"        )"},{"line_number":66,"context_line":"    except xclarity_client_exceptions.XClarityError as exc:"},{"line_number":67,"context_line":"        msg \u003d (_(\"Error getting connection to XClarity manager IP: %(ip)s. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_744fd633","line":64,"updated":"2018-03-29 13:50:16.000000000","message":"My guess...\n\nThere needs to be some code used in some validate()-like method, to check whether node.driver_info has the required info (x_hardware_id), and whether the optional (the COMMON_PROPERTIES) are correct wrt format/values.\n\nThen I think here, some code needs to be written to use either node.driver_info[X] or CONF.xclarity.X.","commit_id":"de457dfb6d72c8bee37ca1f28ea3676871331771"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5ae2c304fc9f650830676e955fc5fa1a217ddef4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            ip\u003dCONF.xclarity.manager_ip,"},{"line_number":62,"context_line":"            username\u003dCONF.xclarity.username,"},{"line_number":63,"context_line":"            password\u003dCONF.xclarity.password,"},{"line_number":64,"context_line":"            port\u003dCONF.xclarity.port"},{"line_number":65,"context_line":"        )"},{"line_number":66,"context_line":"    except xclarity_client_exceptions.XClarityError as exc:"},{"line_number":67,"context_line":"        msg \u003d (_(\"Error getting connection to XClarity manager IP: %(ip)s. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_513f5624","line":64,"in_reply_to":"bf659307_19d2805d","updated":"2018-04-11 01:09:25.000000000","message":"I think we ought to if there is no intent to load the configuration on a per-node basis.","commit_id":"de457dfb6d72c8bee37ca1f28ea3676871331771"},{"author":{"_account_id":25547,"name":"jiapei","email":"jiapeish@gmail.com","username":"jeremy.jia"},"change_message_id":"e1fc5f5600b26cdd7a6ff02b32c0701a4e1e2341","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            ip\u003dCONF.xclarity.manager_ip,"},{"line_number":62,"context_line":"            username\u003dCONF.xclarity.username,"},{"line_number":63,"context_line":"            password\u003dCONF.xclarity.password,"},{"line_number":64,"context_line":"            port\u003dCONF.xclarity.port"},{"line_number":65,"context_line":"        )"},{"line_number":66,"context_line":"    except xclarity_client_exceptions.XClarityError as exc:"},{"line_number":67,"context_line":"        msg \u003d (_(\"Error getting connection to XClarity manager IP: %(ip)s. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_238b6a1f","line":64,"in_reply_to":"bf659307_513f5624","updated":"2018-04-11 12:53:22.000000000","message":"Will do.","commit_id":"de457dfb6d72c8bee37ca1f28ea3676871331771"},{"author":{"_account_id":25547,"name":"jiapei","email":"jiapeish@gmail.com","username":"jeremy.jia"},"change_message_id":"6a0314e5631e0f8efc9480c90af49ff793f5cfe2","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            ip\u003dCONF.xclarity.manager_ip,"},{"line_number":62,"context_line":"            username\u003dCONF.xclarity.username,"},{"line_number":63,"context_line":"            password\u003dCONF.xclarity.password,"},{"line_number":64,"context_line":"            port\u003dCONF.xclarity.port"},{"line_number":65,"context_line":"        )"},{"line_number":66,"context_line":"    except xclarity_client_exceptions.XClarityError as exc:"},{"line_number":67,"context_line":"        msg \u003d (_(\"Error getting connection to XClarity manager IP: %(ip)s. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_19d2805d","line":64,"in_reply_to":"bf659307_744fd633","updated":"2018-04-10 07:31:53.000000000","message":"Actually, we have some check code to validate server_hardware_id, the check code is in the function get_server_hardware_id(). \n\nFor the COMMON_PROPERTIES, like manager_ip, username, and port, these are manually configured in the CONF file, so we don\u0027t check them. \n\nThe properties we add in COMMON_PROPERTIES are just a notice to help user understand the meaning of the parameters. I think we can delete them and keep COMMON_PROPERTIES as {} if it seems redundant...","commit_id":"de457dfb6d72c8bee37ca1f28ea3676871331771"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"8ad51cea577661abb4b60025cb7f3a575a6f501e","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"REQUIRED_ON_DRIVER_INFO \u003d {"},{"line_number":31,"context_line":"    \u0027server_hardware_id\u0027: _(\"XClarity managed Server Hardware ID. \""},{"line_number":32,"context_line":"                            \"Required in driver_info.\"),"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"COMMON_PROPERTIES \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_e216ec55","line":32,"updated":"2018-04-10 14:46:42.000000000","message":"I know this was asked for in this patch, but I looked back at the history of how this got here: https://review.openstack.org/#/c/519427/26/ironic/drivers/modules/xclarity/common.py\n\nI don\u0027t know if it\u0027s written down, but I do seem to remember some convention about vendor-specific parameters like this being prefixed with the driver name. So I tend to think this should indeed be `xclarity_hardware_id`, and the other code using it should be fixed.","commit_id":"b3edd2012ddd0d9ccbfa75d31de2304c333bf267"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"bbbf7654ed3da0a8719f8020a0d126fecbbed072","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"REQUIRED_ON_DRIVER_INFO \u003d {"},{"line_number":31,"context_line":"    \u0027server_hardware_id\u0027: _(\"XClarity managed Server Hardware ID. \""},{"line_number":32,"context_line":"                            \"Required in driver_info.\"),"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"COMMON_PROPERTIES \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_9d04154c","line":32,"in_reply_to":"bf659307_31d422e9","updated":"2018-04-11 11:54:11.000000000","message":"Ah, fair point. Still probably better not to change the name (and fix the other locations it\u0027s used), as that\u0027s a user-visible thing.","commit_id":"b3edd2012ddd0d9ccbfa75d31de2304c333bf267"},{"author":{"_account_id":25547,"name":"jiapei","email":"jiapeish@gmail.com","username":"jeremy.jia"},"change_message_id":"e1fc5f5600b26cdd7a6ff02b32c0701a4e1e2341","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"REQUIRED_ON_DRIVER_INFO \u003d {"},{"line_number":31,"context_line":"    \u0027server_hardware_id\u0027: _(\"XClarity managed Server Hardware ID. \""},{"line_number":32,"context_line":"                            \"Required in driver_info.\"),"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"COMMON_PROPERTIES \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_e29b3ac6","line":32,"in_reply_to":"bf659307_31d422e9","updated":"2018-04-11 12:53:22.000000000","message":"Well, it looks more clear prefixed with xclarity_, I\u0027ll keep it as \"xclarity_hardware_id\".","commit_id":"b3edd2012ddd0d9ccbfa75d31de2304c333bf267"},{"author":{"_account_id":25547,"name":"jiapei","email":"jiapeish@gmail.com","username":"jeremy.jia"},"change_message_id":"e1fc5f5600b26cdd7a6ff02b32c0701a4e1e2341","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"REQUIRED_ON_DRIVER_INFO \u003d {"},{"line_number":31,"context_line":"    \u0027server_hardware_id\u0027: _(\"XClarity managed Server Hardware ID. \""},{"line_number":32,"context_line":"                            \"Required in driver_info.\"),"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"COMMON_PROPERTIES \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_407c5482","line":32,"in_reply_to":"bf659307_9d04154c","updated":"2018-04-11 12:53:22.000000000","message":"Thanks Jim, I\u0027ll change the name in the following patch set.","commit_id":"b3edd2012ddd0d9ccbfa75d31de2304c333bf267"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5ae2c304fc9f650830676e955fc5fa1a217ddef4","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"REQUIRED_ON_DRIVER_INFO \u003d {"},{"line_number":31,"context_line":"    \u0027server_hardware_id\u0027: _(\"XClarity managed Server Hardware ID. \""},{"line_number":32,"context_line":"                            \"Required in driver_info.\"),"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"COMMON_PROPERTIES \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_31d422e9","line":32,"in_reply_to":"bf659307_e216ec55","updated":"2018-04-11 01:09:25.000000000","message":"Great find Jim. I concur as it provides naming similarity, however we also let oneview folks use \"server_hardware_uri\"... so.. I think this becomes coders choice in all honesty. Shortest path with minimal disagreements.","commit_id":"b3edd2012ddd0d9ccbfa75d31de2304c333bf267"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e7eb9fa54b501b22cb84b3529f631e67218fee36","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        hardware_id \u003d get_server_hardware_id(node)"},{"line_number":132,"context_line":"        return xclarity_client.is_node_managed(hardware_id)"},{"line_number":133,"context_line":"    except exception.MissingParameterValue:"},{"line_number":134,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_74305ae9","line":134,"updated":"2018-04-10 12:56:36.000000000","message":"Sigh. This isn\u0027t correct. The exception needs to be raised, if this is being called from a validate().  See the validate API request [1] and please make sure that the xclarity_client.is_node_managed() call is quick [2].\n\n[1] https://developer.openstack.org/api-ref/baremetal/#validate-node\n[2] https://github.com/openstack/ironic/blob/3e92382d2ebbc65b9240f8620afede86cf57ba7e/ironic/drivers/base.py#L225-L226","commit_id":"b3edd2012ddd0d9ccbfa75d31de2304c333bf267"},{"author":{"_account_id":25547,"name":"jiapei","email":"jiapeish@gmail.com","username":"jeremy.jia"},"change_message_id":"e1fc5f5600b26cdd7a6ff02b32c0701a4e1e2341","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        hardware_id \u003d get_server_hardware_id(node)"},{"line_number":132,"context_line":"        return xclarity_client.is_node_managed(hardware_id)"},{"line_number":133,"context_line":"    except exception.MissingParameterValue:"},{"line_number":134,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_60a8781f","line":134,"in_reply_to":"bf659307_11ed5eef","updated":"2018-04-11 12:53:22.000000000","message":"I checked the validate call, it just passes in, so should I fix that and update a new patch set? Or we just fix the parameter name?","commit_id":"b3edd2012ddd0d9ccbfa75d31de2304c333bf267"},{"author":{"_account_id":25547,"name":"jiapei","email":"jiapeish@gmail.com","username":"jeremy.jia"},"change_message_id":"e1fc5f5600b26cdd7a6ff02b32c0701a4e1e2341","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        hardware_id \u003d get_server_hardware_id(node)"},{"line_number":132,"context_line":"        return xclarity_client.is_node_managed(hardware_id)"},{"line_number":133,"context_line":"    except exception.MissingParameterValue:"},{"line_number":134,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_80f7cc59","line":134,"in_reply_to":"bf659307_74305ae9","updated":"2018-04-11 12:53:22.000000000","message":"My fault. This shouldn\u0027t be just return False. And  the xclarity_client.is_node_managed() call is quick enough, it just check whether the hardware_id is in xclarity\u0027s managed server list.\n\nShould I fix this in the next patch set or create a bug for this?","commit_id":"b3edd2012ddd0d9ccbfa75d31de2304c333bf267"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5ae2c304fc9f650830676e955fc5fa1a217ddef4","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        hardware_id \u003d get_server_hardware_id(node)"},{"line_number":132,"context_line":"        return xclarity_client.is_node_managed(hardware_id)"},{"line_number":133,"context_line":"    except exception.MissingParameterValue:"},{"line_number":134,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_11ed5eef","line":134,"in_reply_to":"bf659307_74305ae9","updated":"2018-04-11 01:09:25.000000000","message":"Well, if it was used outside of validate, I would say the validate calls need to be updated, but it looks like it just passes in. Sadly this is an easy mistake to make.\n\nPresumably unit testing will need to be fixed as well.","commit_id":"b3edd2012ddd0d9ccbfa75d31de2304c333bf267"}]}