)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"e6358653fd40a62520286081c7f157b021d4b2f6","unresolved":false,"context_lines":[{"line_number":1605,"context_line":"    bridge_mac\u003d$(ip link show dev $IRONIC_VM_NETWORK_BRIDGE | grep -Eo \"ether [A-Za-z0-9:]+\"|sed \"s/ether\\ //\")"},{"line_number":1606,"context_line":""},{"line_number":1607,"context_line":"    for vm_name in $(_ironic_bm_vm_names); do"},{"line_number":1608,"context_line":"        # The su appears to be important here for picking up the stack user\u0027s"},{"line_number":1609,"context_line":"        # new libvirt group abilities that allow it to speak to virsh."},{"line_number":1610,"context_line":"        # We pass through PATH explicitly as sudo has a tendency to sanitize it"},{"line_number":1611,"context_line":"        # from the env even with -E."}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f6a8fd7_8d574803","line":1608,"updated":"2018-04-18 11:46:01.000000000","message":"This is surprising that sudo does not pick up all secondary groups from /etc/group... The sudo man page says:\n\n    By default, the sudoers policy will initialize the \n    group vector to the list of groups the target user is \n    a member of.\n\nCould you please elaborate a bit on this? Perhaps a comment explaining the deal would help understanding the problem to  those who follow us.","commit_id":"bdbeefd07860ac8a986e55caebf97f5a7c2d932e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"443ecc26c1e3ced0e4e16fc9f42f180b49e6d67c","unresolved":false,"context_lines":[{"line_number":1605,"context_line":"    bridge_mac\u003d$(ip link show dev $IRONIC_VM_NETWORK_BRIDGE | grep -Eo \"ether [A-Za-z0-9:]+\"|sed \"s/ether\\ //\")"},{"line_number":1606,"context_line":""},{"line_number":1607,"context_line":"    for vm_name in $(_ironic_bm_vm_names); do"},{"line_number":1608,"context_line":"        # The su appears to be important here for picking up the stack user\u0027s"},{"line_number":1609,"context_line":"        # new libvirt group abilities that allow it to speak to virsh."},{"line_number":1610,"context_line":"        # We pass through PATH explicitly as sudo has a tendency to sanitize it"},{"line_number":1611,"context_line":"        # from the env even with -E."}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f6a8fd7_069c3f0d","line":1608,"in_reply_to":"9f6a8fd7_806fe190","updated":"2018-04-20 11:05:53.000000000","message":"I\u0027d feel better if we\u0027d switch to sudo. ;-)","commit_id":"bdbeefd07860ac8a986e55caebf97f5a7c2d932e"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b44a44479e6da5c0a03eb9bea484c08f9becb54c","unresolved":false,"context_lines":[{"line_number":1605,"context_line":"    bridge_mac\u003d$(ip link show dev $IRONIC_VM_NETWORK_BRIDGE | grep -Eo \"ether [A-Za-z0-9:]+\"|sed \"s/ether\\ //\")"},{"line_number":1606,"context_line":""},{"line_number":1607,"context_line":"    for vm_name in $(_ironic_bm_vm_names); do"},{"line_number":1608,"context_line":"        # The su appears to be important here for picking up the stack user\u0027s"},{"line_number":1609,"context_line":"        # new libvirt group abilities that allow it to speak to virsh."},{"line_number":1610,"context_line":"        # We pass through PATH explicitly as sudo has a tendency to sanitize it"},{"line_number":1611,"context_line":"        # from the env even with -E."}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f6a8fd7_806fe190","line":1608,"in_reply_to":"9f6a8fd7_8d574803","updated":"2018-04-19 23:30:44.000000000","message":"I was mostly trying to explain why the old code is written this way rather than a sudo -u, however we can probably just switch to sudo -u if you want.","commit_id":"bdbeefd07860ac8a986e55caebf97f5a7c2d932e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"e6358653fd40a62520286081c7f157b021d4b2f6","unresolved":false,"context_lines":[{"line_number":1607,"context_line":"    for vm_name in $(_ironic_bm_vm_names); do"},{"line_number":1608,"context_line":"        # The su appears to be important here for picking up the stack user\u0027s"},{"line_number":1609,"context_line":"        # new libvirt group abilities that allow it to speak to virsh."},{"line_number":1610,"context_line":"        # We pass through PATH explicitly as sudo has a tendency to sanitize it"},{"line_number":1611,"context_line":"        # from the env even with -E."},{"line_number":1612,"context_line":"        sudo -E su -p $STACK_USER -c \"PATH\u003d$PATH $IRONIC_SCRIPTS_DIR/create-node.sh -n $vm_name \\"},{"line_number":1613,"context_line":"            -c $IRONIC_VM_SPECS_CPU -m $IRONIC_VM_SPECS_RAM -d $IRONIC_VM_SPECS_DISK \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f6a8fd7_8da50807","line":1610,"range":{"start_line":1610,"start_character":45,"end_line":1610,"end_character":65},"updated":"2018-04-18 11:46:01.000000000","message":"Is this a non-deterministic behaviour? If sudo always behave that way I\u0027d suggest changing the wording accordingly.","commit_id":"bdbeefd07860ac8a986e55caebf97f5a7c2d932e"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b44a44479e6da5c0a03eb9bea484c08f9becb54c","unresolved":false,"context_lines":[{"line_number":1607,"context_line":"    for vm_name in $(_ironic_bm_vm_names); do"},{"line_number":1608,"context_line":"        # The su appears to be important here for picking up the stack user\u0027s"},{"line_number":1609,"context_line":"        # new libvirt group abilities that allow it to speak to virsh."},{"line_number":1610,"context_line":"        # We pass through PATH explicitly as sudo has a tendency to sanitize it"},{"line_number":1611,"context_line":"        # from the env even with -E."},{"line_number":1612,"context_line":"        sudo -E su -p $STACK_USER -c \"PATH\u003d$PATH $IRONIC_SCRIPTS_DIR/create-node.sh -n $vm_name \\"},{"line_number":1613,"context_line":"            -c $IRONIC_VM_SPECS_CPU -m $IRONIC_VM_SPECS_RAM -d $IRONIC_VM_SPECS_DISK \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f6a8fd7_c012b909","line":1610,"range":{"start_line":1610,"start_character":45,"end_line":1610,"end_character":65},"in_reply_to":"9f6a8fd7_8da50807","updated":"2018-04-19 23:30:44.000000000","message":"It depends on your sudoers config. Some distros do this by default, others don\u0027t and individual users can change it as they please as well.\n\nI can update it to \"We pass through PATH explicitly as sudo is often configed to sanitize PATH from the environment even with -E\".","commit_id":"bdbeefd07860ac8a986e55caebf97f5a7c2d932e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"443ecc26c1e3ced0e4e16fc9f42f180b49e6d67c","unresolved":false,"context_lines":[{"line_number":1607,"context_line":"    for vm_name in $(_ironic_bm_vm_names); do"},{"line_number":1608,"context_line":"        # The su appears to be important here for picking up the stack user\u0027s"},{"line_number":1609,"context_line":"        # new libvirt group abilities that allow it to speak to virsh."},{"line_number":1610,"context_line":"        # We pass through PATH explicitly as sudo has a tendency to sanitize it"},{"line_number":1611,"context_line":"        # from the env even with -E."},{"line_number":1612,"context_line":"        sudo -E su -p $STACK_USER -c \"PATH\u003d$PATH $IRONIC_SCRIPTS_DIR/create-node.sh -n $vm_name \\"},{"line_number":1613,"context_line":"            -c $IRONIC_VM_SPECS_CPU -m $IRONIC_VM_SPECS_RAM -d $IRONIC_VM_SPECS_DISK \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f6a8fd7_a66a33ea","line":1610,"range":{"start_line":1610,"start_character":45,"end_line":1610,"end_character":65},"in_reply_to":"9f6a8fd7_c012b909","updated":"2018-04-20 11:05:53.000000000","message":"+1 for the latter explanation - it makes so much sense to me.","commit_id":"bdbeefd07860ac8a986e55caebf97f5a7c2d932e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"e6358653fd40a62520286081c7f157b021d4b2f6","unresolved":false,"context_lines":[{"line_number":2361,"context_line":""},{"line_number":2362,"context_line":"    local vm_name"},{"line_number":2363,"context_line":"    for vm_name in $(_ironic_bm_vm_names); do"},{"line_number":2364,"context_line":"        # The su appears to be important here for picking up the stack user\u0027s"},{"line_number":2365,"context_line":"        # new libvirt group abilities that allow it to speak to virsh."},{"line_number":2366,"context_line":"        # We pass through PATH explicitly as sudo has a tendency to sanitize it"},{"line_number":2367,"context_line":"        # from the env even with -E."}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f6a8fd7_0d4b3859","line":2364,"updated":"2018-04-18 11:46:01.000000000","message":"ditto","commit_id":"bdbeefd07860ac8a986e55caebf97f5a7c2d932e"}]}