)]}'
{"ironic/tests/unit/drivers/modules/ilo/test_firmware_processor.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"f924cfaf3a0960ac3faf6fe10c230a742cccc5d9","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    def test__download_file_based_fw_to_copies_file_to_target("},{"line_number":377,"context_line":"            self, file_image_service_mock, open_mock):"},{"line_number":378,"context_line":"        # | GIVEN |"},{"line_number":379,"context_line":"        fd_mock \u003d mock.MagicMock(spec\u003dio.BytesIO)"},{"line_number":380,"context_line":"        open_mock.return_value \u003d fd_mock"},{"line_number":381,"context_line":"        fd_mock.__enter__.return_value \u003d fd_mock"},{"line_number":382,"context_line":"        any_file_based_firmware_file \u003d \u0027file:///tmp/any_file_path\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_f1678a4c","line":379,"updated":"2018-04-11 01:11:42.000000000","message":"This seems like a functional change... I\u0027m sure it works, since it\u0027s just a mock, but I\u0027m not sure we want to do this?","commit_id":"6b91ba21df3f60e8362ef86b90de93e73e317b20"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"6daaaf9b99085adbbce44b786a7177868e4963eb","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    def test__download_file_based_fw_to_copies_file_to_target("},{"line_number":377,"context_line":"            self, file_image_service_mock, open_mock):"},{"line_number":378,"context_line":"        # | GIVEN |"},{"line_number":379,"context_line":"        fd_mock \u003d mock.MagicMock(spec\u003dio.BytesIO)"},{"line_number":380,"context_line":"        open_mock.return_value \u003d fd_mock"},{"line_number":381,"context_line":"        fd_mock.__enter__.return_value \u003d fd_mock"},{"line_number":382,"context_line":"        any_file_based_firmware_file \u003d \u0027file:///tmp/any_file_path\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_fca0c1f6","line":379,"in_reply_to":"bf659307_f1678a4c","updated":"2018-04-11 01:21:02.000000000","message":"Probably repeating what you know. Basically \u0027spec\u003dio.BytesIO\u0027 is telling mock to use the methods defined by io.BytesIO as the allowed methods for the mock. So if someone calls fd.blah() it should fail since that is not a defined method.\n\nSo the methods defined appear to be read(), readl(), readinto(), write(), getvalue(), and raw()","commit_id":"6b91ba21df3f60e8362ef86b90de93e73e317b20"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"06014916a22cf3706492565a1f3831306a14563e","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    def test__download_file_based_fw_to_copies_file_to_target("},{"line_number":377,"context_line":"            self, file_image_service_mock, open_mock):"},{"line_number":378,"context_line":"        # | GIVEN |"},{"line_number":379,"context_line":"        fd_mock \u003d mock.MagicMock(spec\u003dio.BytesIO)"},{"line_number":380,"context_line":"        open_mock.return_value \u003d fd_mock"},{"line_number":381,"context_line":"        fd_mock.__enter__.return_value \u003d fd_mock"},{"line_number":382,"context_line":"        any_file_based_firmware_file \u003d \u0027file:///tmp/any_file_path\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_5d6afd80","line":379,"in_reply_to":"bf659307_fca0c1f6","updated":"2018-04-11 11:34:04.000000000","message":"Yep, I knew that much. After reading the docs, this seems roughly equivalent, and less confusing overall :)","commit_id":"6b91ba21df3f60e8362ef86b90de93e73e317b20"}]}