)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"0bd79db3b3a23a25ebfeffc4bd8d2b57654bdb9e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove too large configdrive for handling error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When configdrive is too large, a node object cannot be saved to DB. If"},{"line_number":10,"context_line":"it happens, the node cannot moved to DEPLOYFAIL because saving the node"},{"line_number":11,"context_line":"is prevented again by the large configdrive in the object. In this"},{"line_number":12,"context_line":"case, the node gets stuck in DEPLOYING, which doesn\u0027t allow any state"},{"line_number":13,"context_line":"transition."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf659307_1c8c67d5","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":33},"updated":"2018-04-12 11:41:09.000000000","message":"nit: cannot be moved","commit_id":"14d7005ffb761f2472dd3b1f03d870b756aa3919"}],"ironic/conductor/manager.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"0bd79db3b3a23a25ebfeffc4bd8d2b57654bdb9e","unresolved":false,"context_lines":[{"line_number":2786,"context_line":"             config drive to swift or radosgw."},{"line_number":2787,"context_line":"    :raises: ConfigInvalid if required keystone authorization credentials"},{"line_number":2788,"context_line":"             with swift are missing."},{"line_number":2789,"context_line":""},{"line_number":2790,"context_line":""},{"line_number":2791,"context_line":"    \"\"\""},{"line_number":2792,"context_line":"    if CONF.deploy.configdrive_use_object_store:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_ff188576","line":2789,"range":{"start_line":2789,"start_character":0,"end_line":2789,"end_character":0},"updated":"2018-04-12 11:41:09.000000000","message":"Does it now raise `db_exception.DBDataError` as well?","commit_id":"14d7005ffb761f2472dd3b1f03d870b756aa3919"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"0bd79db3b3a23a25ebfeffc4bd8d2b57654bdb9e","unresolved":false,"context_lines":[{"line_number":2811,"context_line":"    i_info \u003d node.instance_info"},{"line_number":2812,"context_line":"    i_info[\u0027configdrive\u0027] \u003d configdrive"},{"line_number":2813,"context_line":"    node.instance_info \u003d i_info"},{"line_number":2814,"context_line":"    node.save()"},{"line_number":2815,"context_line":""},{"line_number":2816,"context_line":""},{"line_number":2817,"context_line":"@METRICS.timer(\u0027do_node_deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_7f56b5d0","line":2814,"range":{"start_line":2814,"start_character":0,"end_line":2814,"end_character":15},"updated":"2018-04-12 11:41:09.000000000","message":"nit: technically, you do not need to `.save` if you are using the object store","commit_id":"14d7005ffb761f2472dd3b1f03d870b756aa3919"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"26dd7899018e6943403b9864348e8d621e82ee79","unresolved":false,"context_lines":[{"line_number":2811,"context_line":"    i_info \u003d node.instance_info"},{"line_number":2812,"context_line":"    i_info[\u0027configdrive\u0027] \u003d configdrive"},{"line_number":2813,"context_line":"    node.instance_info \u003d i_info"},{"line_number":2814,"context_line":"    node.save()"},{"line_number":2815,"context_line":""},{"line_number":2816,"context_line":""},{"line_number":2817,"context_line":"@METRICS.timer(\u0027do_node_deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_f01752ed","line":2814,"range":{"start_line":2814,"start_character":0,"end_line":2814,"end_character":15},"in_reply_to":"bf659307_65a146f7","updated":"2018-04-12 13:42:09.000000000","message":"Can Swift URL length hits DB column size limit?","commit_id":"14d7005ffb761f2472dd3b1f03d870b756aa3919"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"9b9311bec18f341cb40c487200991da61576488d","unresolved":false,"context_lines":[{"line_number":2811,"context_line":"    i_info \u003d node.instance_info"},{"line_number":2812,"context_line":"    i_info[\u0027configdrive\u0027] \u003d configdrive"},{"line_number":2813,"context_line":"    node.instance_info \u003d i_info"},{"line_number":2814,"context_line":"    node.save()"},{"line_number":2815,"context_line":""},{"line_number":2816,"context_line":""},{"line_number":2817,"context_line":"@METRICS.timer(\u0027do_node_deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_65a146f7","line":2814,"range":{"start_line":2814,"start_character":0,"end_line":2814,"end_character":15},"in_reply_to":"bf659307_7f56b5d0","updated":"2018-04-12 13:06:22.000000000","message":"Nope, this is mandatory for the exception handling when configdrive hits db limits","commit_id":"14d7005ffb761f2472dd3b1f03d870b756aa3919"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"971da033c076c7cb18cad0412e4d73ffc3e000fd","unresolved":false,"context_lines":[{"line_number":2811,"context_line":"    i_info \u003d node.instance_info"},{"line_number":2812,"context_line":"    i_info[\u0027configdrive\u0027] \u003d configdrive"},{"line_number":2813,"context_line":"    node.instance_info \u003d i_info"},{"line_number":2814,"context_line":"    node.save()"},{"line_number":2815,"context_line":""},{"line_number":2816,"context_line":""},{"line_number":2817,"context_line":"@METRICS.timer(\u0027do_node_deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_f6b18745","line":2814,"range":{"start_line":2814,"start_character":0,"end_line":2814,"end_character":15},"in_reply_to":"bf659307_f01752ed","updated":"2018-04-12 16:17:45.000000000","message":"The swift url is a composite of container/key, I couldn\u0027t say it\u0027s impossible, but from what I saw, it\u0027s quite unlikely, unless we really have a very very long key.\nI\u0027m not sure if there is a limit on the swift side, anyway it doesn\u0027t matter for what we are doing here, it can handle :)","commit_id":"14d7005ffb761f2472dd3b1f03d870b756aa3919"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"46cc2ecd19c79b850d34380a57e744a84493f098","unresolved":false,"context_lines":[{"line_number":2811,"context_line":"    i_info \u003d node.instance_info"},{"line_number":2812,"context_line":"    i_info[\u0027configdrive\u0027] \u003d configdrive"},{"line_number":2813,"context_line":"    node.instance_info \u003d i_info"},{"line_number":2814,"context_line":"    node.save()"},{"line_number":2815,"context_line":""},{"line_number":2816,"context_line":""},{"line_number":2817,"context_line":"@METRICS.timer(\u0027do_node_deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_b6b216e4","line":2814,"range":{"start_line":2814,"start_character":0,"end_line":2814,"end_character":15},"in_reply_to":"bf659307_f6b18745","updated":"2018-04-13 11:06:29.000000000","message":"Sure! I just wanted to note that we could perhaps save some cycles by skipping the `node.save()` dance when using Swift.","commit_id":"14d7005ffb761f2472dd3b1f03d870b756aa3919"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"9b9311bec18f341cb40c487200991da61576488d","unresolved":false,"context_lines":[{"line_number":2820,"context_line":"    \"\"\"Prepare the environment and deploy a node.\"\"\""},{"line_number":2821,"context_line":"    node \u003d task.node"},{"line_number":2822,"context_line":""},{"line_number":2823,"context_line":"    def handle_failure(e, task, logmsg, errmsg):"},{"line_number":2824,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":2825,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":2826,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_25226e53","line":2823,"range":{"start_line":2823,"start_character":4,"end_line":2823,"end_character":48},"updated":"2018-04-12 13:06:22.000000000","message":"you need to add traceback arg here to match unit test, or adjust unit test.","commit_id":"14d7005ffb761f2472dd3b1f03d870b756aa3919"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"a222aad4fc83458afd91817b6b27ff71fd1fe1e8","unresolved":false,"context_lines":[{"line_number":2820,"context_line":"    \"\"\"Prepare the environment and deploy a node.\"\"\""},{"line_number":2821,"context_line":"    node \u003d task.node"},{"line_number":2822,"context_line":""},{"line_number":2823,"context_line":"    def handle_failure(e, task, logmsg, errmsg):"},{"line_number":2824,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":2825,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":2826,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_eb2192b5","line":2823,"range":{"start_line":2823,"start_character":4,"end_line":2823,"end_character":48},"in_reply_to":"bf659307_25226e53","updated":"2018-04-13 04:49:08.000000000","message":"Done","commit_id":"14d7005ffb761f2472dd3b1f03d870b756aa3919"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c128c6a2b48c9a889eb089c29b683a26f56bd296","unresolved":false,"context_lines":[{"line_number":2820,"context_line":"    \"\"\"Prepare the environment and deploy a node.\"\"\""},{"line_number":2821,"context_line":"    node \u003d task.node"},{"line_number":2822,"context_line":""},{"line_number":2823,"context_line":"    def handle_failure(e, task, logmsg, errmsg, traceback\u003dFalse):"},{"line_number":2824,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":2825,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":2826,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_c03812a1","line":2823,"updated":"2018-04-13 21:45:36.000000000","message":"this isn\u0027t part of the code being backported. We should leave this as it was, and change L2861 so this parameter isn\u0027t needed.\n\nOr backport the code that had the change to traceback\u003dFalse but that might be more involved.\n\nOtherwise, the code will be in a weird state cuz there are other handle_failure() calls that could/should have traceback\u003dTrue that don\u0027t, and we can\u0027t update those here since this is meant to be a backport.","commit_id":"504aa1d778f61f9dd10d0c4e769c041d2f21cc20"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"4b50372e6e1ab1b0f18c0322b6170562b5dc6219","unresolved":false,"context_lines":[{"line_number":2820,"context_line":"    \"\"\"Prepare the environment and deploy a node.\"\"\""},{"line_number":2821,"context_line":"    node \u003d task.node"},{"line_number":2822,"context_line":""},{"line_number":2823,"context_line":"    def handle_failure(e, task, logmsg, errmsg, traceback\u003dFalse):"},{"line_number":2824,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":2825,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":2826,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_fdcf1226","line":2823,"in_reply_to":"bf659307_c03812a1","updated":"2018-04-24 13:58:01.000000000","message":"Done","commit_id":"504aa1d778f61f9dd10d0c4e769c041d2f21cc20"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"a7b3e6af1fe774e8463ad27815a6540e3c3f50de","unresolved":false,"context_lines":[{"line_number":2824,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":2825,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":2826,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"},{"line_number":2827,"context_line":"        LOG.error(logmsg, args)"},{"line_number":2828,"context_line":"        node.last_error \u003d errmsg % e"},{"line_number":2829,"context_line":""},{"line_number":2830,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_851a48c3","line":2827,"range":{"start_line":2827,"start_character":8,"end_line":2827,"end_character":31},"updated":"2018-04-13 00:33:20.000000000","message":"for consistency let\u0027s pass this arg to LOG.error","commit_id":"504aa1d778f61f9dd10d0c4e769c041d2f21cc20"}]}
