)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"7959dd269ccd59b322c60a948753721e190fbea5","unresolved":false,"context_lines":[{"line_number":1964,"context_line":"                    --driver-info drac_password\u003d$bmc_passwd \\"},{"line_number":1965,"context_line":"                    --driver-info drac_username\u003d$bmc_username\""},{"line_number":1966,"context_line":"            elif is_deployed_by_redfish; then"},{"line_number":1967,"context_line":"                node_options+\u003d\" --driver-info redfish_address\u003dhtts://$bmc_address \\"},{"line_number":1968,"context_line":"                    --driver-info redfish_system_id\u003d/redfish/v1/Systems/$node_name \\"},{"line_number":1969,"context_line":"                    --driver-info redfish_password\u003d$bmc_passwd \\"},{"line_number":1970,"context_line":"                    --driver-info redfish_username\u003d$bmc_username\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9f6a8fd7_42c9b523","line":1967,"range":{"start_line":1967,"start_character":62,"end_line":1967,"end_character":66},"updated":"2018-04-20 19:57:02.000000000","message":"https, with a \u0027p\u0027","commit_id":"920d9ed895137b3a1f80c7235b1f168bb1564126"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"96d0ebe4130447a91cb1f868830a40649eee7cfc","unresolved":false,"context_lines":[{"line_number":1964,"context_line":"                    --driver-info drac_password\u003d$bmc_passwd \\"},{"line_number":1965,"context_line":"                    --driver-info drac_username\u003d$bmc_username\""},{"line_number":1966,"context_line":"            elif is_deployed_by_redfish; then"},{"line_number":1967,"context_line":"                node_options+\u003d\" --driver-info redfish_address\u003dhtts://$bmc_address \\"},{"line_number":1968,"context_line":"                    --driver-info redfish_system_id\u003d/redfish/v1/Systems/$node_name \\"},{"line_number":1969,"context_line":"                    --driver-info redfish_password\u003d$bmc_passwd \\"},{"line_number":1970,"context_line":"                    --driver-info redfish_username\u003d$bmc_username\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9f6a8fd7_0ab3b54e","line":1967,"range":{"start_line":1967,"start_character":62,"end_line":1967,"end_character":66},"in_reply_to":"9f6a8fd7_42c9b523","updated":"2018-04-23 15:42:54.000000000","message":"Good catch. I\u0027m now suspecting the results. Fixed and rerunning CI","commit_id":"920d9ed895137b3a1f80c7235b1f168bb1564126"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"7959dd269ccd59b322c60a948753721e190fbea5","unresolved":false,"context_lines":[{"line_number":1964,"context_line":"                    --driver-info drac_password\u003d$bmc_passwd \\"},{"line_number":1965,"context_line":"                    --driver-info drac_username\u003d$bmc_username\""},{"line_number":1966,"context_line":"            elif is_deployed_by_redfish; then"},{"line_number":1967,"context_line":"                node_options+\u003d\" --driver-info redfish_address\u003dhtts://$bmc_address \\"},{"line_number":1968,"context_line":"                    --driver-info redfish_system_id\u003d/redfish/v1/Systems/$node_name \\"},{"line_number":1969,"context_line":"                    --driver-info redfish_password\u003d$bmc_passwd \\"},{"line_number":1970,"context_line":"                    --driver-info redfish_username\u003d$bmc_username\""},{"line_number":1971,"context_line":"            elif is_deployed_by_irmc; then"},{"line_number":1972,"context_line":"                node_options+\u003d\" --driver-info irmc_address\u003d$bmc_address \\"},{"line_number":1973,"context_line":"                    --driver-info irmc_password\u003d$bmc_passwd \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9f6a8fd7_02e89d79","line":1970,"range":{"start_line":1967,"start_character":0,"end_line":1970,"end_character":65},"updated":"2018-04-20 19:57:02.000000000","message":"Should TLS verification be disabled?\n\n    --driver-info redfish_verify_ca\u003dFalse","commit_id":"920d9ed895137b3a1f80c7235b1f168bb1564126"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"96d0ebe4130447a91cb1f868830a40649eee7cfc","unresolved":false,"context_lines":[{"line_number":1964,"context_line":"                    --driver-info drac_password\u003d$bmc_passwd \\"},{"line_number":1965,"context_line":"                    --driver-info drac_username\u003d$bmc_username\""},{"line_number":1966,"context_line":"            elif is_deployed_by_redfish; then"},{"line_number":1967,"context_line":"                node_options+\u003d\" --driver-info redfish_address\u003dhtts://$bmc_address \\"},{"line_number":1968,"context_line":"                    --driver-info redfish_system_id\u003d/redfish/v1/Systems/$node_name \\"},{"line_number":1969,"context_line":"                    --driver-info redfish_password\u003d$bmc_passwd \\"},{"line_number":1970,"context_line":"                    --driver-info redfish_username\u003d$bmc_username\""},{"line_number":1971,"context_line":"            elif is_deployed_by_irmc; then"},{"line_number":1972,"context_line":"                node_options+\u003d\" --driver-info irmc_address\u003d$bmc_address \\"},{"line_number":1973,"context_line":"                    --driver-info irmc_password\u003d$bmc_passwd \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9f6a8fd7_ca8a9d68","line":1970,"range":{"start_line":1967,"start_character":0,"end_line":1970,"end_character":65},"in_reply_to":"9f6a8fd7_02e89d79","updated":"2018-04-23 15:42:54.000000000","message":"I can. Fixed","commit_id":"920d9ed895137b3a1f80c7235b1f168bb1564126"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ca3e13fe8a6164c4ba1d17cdf2b77d4e025a7ca7","unresolved":false,"context_lines":[{"line_number":789,"context_line":"        pip_install_gr \"sushy\""},{"line_number":790,"context_line":"    fi"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"    if use_library_from_git \"sushy-tools\"; then"},{"line_number":793,"context_line":"        git_clone_by_name \"sushy-tools\""},{"line_number":794,"context_line":"        setup_dev_lib \"sushy-tools\""},{"line_number":795,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f6a8fd7_2ad23901","line":792,"updated":"2018-04-23 15:58:25.000000000","message":"sushy-tools is not needed if we don\u0027t use the emulator, let\u0027s move it under the \u0027if\u0027 block","commit_id":"3ba0da97b56805574b826ec3de4ab545b0ad5453"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ca3e13fe8a6164c4ba1d17cdf2b77d4e025a7ca7","unresolved":false,"context_lines":[{"line_number":1965,"context_line":"                    --driver-info drac_username\u003d$bmc_username\""},{"line_number":1966,"context_line":"            elif is_deployed_by_redfish; then"},{"line_number":1967,"context_line":"                node_options+\u003d\" --driver-info redfish_address\u003dhttps://$bmc_address \\"},{"line_number":1968,"context_line":"                    --driver-info redfish_system_id\u003d/redfish/v1/Systems/$node_name \\"},{"line_number":1969,"context_line":"                    --driver-info redfish_password\u003d$bmc_passwd \\"},{"line_number":1970,"context_line":"                    --driver-info redfish_username\u003d$bmc_username \\"},{"line_number":1971,"context_line":"                    --driver-info redfish_verify_ca\u003dFalse\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f6a8fd7_4acf6d55","line":1968,"updated":"2018-04-23 15:58:25.000000000","message":"note: this assume that node_name is used as system ID, I wonder if it\u0027s always the case..","commit_id":"3ba0da97b56805574b826ec3de4ab545b0ad5453"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"5a031a5392ec644fd4e9cd7dead83b577447d4c3","unresolved":false,"context_lines":[{"line_number":1965,"context_line":"                    --driver-info drac_username\u003d$bmc_username\""},{"line_number":1966,"context_line":"            elif is_deployed_by_redfish; then"},{"line_number":1967,"context_line":"                node_options+\u003d\" --driver-info redfish_address\u003dhttps://$bmc_address \\"},{"line_number":1968,"context_line":"                    --driver-info redfish_system_id\u003d/redfish/v1/Systems/$node_name \\"},{"line_number":1969,"context_line":"                    --driver-info redfish_password\u003d$bmc_passwd \\"},{"line_number":1970,"context_line":"                    --driver-info redfish_username\u003d$bmc_username \\"},{"line_number":1971,"context_line":"                    --driver-info redfish_verify_ca\u003dFalse\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f6a8fd7_682a742c","line":1968,"in_reply_to":"9f6a8fd7_4acf6d55","updated":"2018-04-23 20:36:44.000000000","message":"I don\u0027t have an answer. Will check with RPioso","commit_id":"3ba0da97b56805574b826ec3de4ab545b0ad5453"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"1092f94b021ea5af5b23c3334ca3cd7bc416a11e","unresolved":false,"context_lines":[{"line_number":1965,"context_line":"                    --driver-info drac_username\u003d$bmc_username\""},{"line_number":1966,"context_line":"            elif is_deployed_by_redfish; then"},{"line_number":1967,"context_line":"                node_options+\u003d\" --driver-info redfish_address\u003dhttps://$bmc_address \\"},{"line_number":1968,"context_line":"                    --driver-info redfish_system_id\u003d/redfish/v1/Systems/$node_name \\"},{"line_number":1969,"context_line":"                    --driver-info redfish_password\u003d$bmc_passwd \\"},{"line_number":1970,"context_line":"                    --driver-info redfish_username\u003d$bmc_username \\"},{"line_number":1971,"context_line":"                    --driver-info redfish_verify_ca\u003dFalse\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f6a8fd7_a48186c5","line":1968,"in_reply_to":"9f6a8fd7_682a742c","updated":"2018-04-24 14:49:36.000000000","message":"Please consider adding a new field to the hardware information file.","commit_id":"3ba0da97b56805574b826ec3de4ab545b0ad5453"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"bed89c2c9c2152e9b2e7a19541d97089dc1948d4","unresolved":false,"context_lines":[{"line_number":111,"context_line":"#"},{"line_number":112,"context_line":"# * irmc:"},{"line_number":113,"context_line":"#   \u003cBMC address\u003e \u003cMAC address\u003e \u003cBMC username\u003e \u003cBMC password\u003e"},{"line_number":114,"context_line":"#"},{"line_number":115,"context_line":"IRONIC_HWINFO_FILE\u003d${IRONIC_HWINFO_FILE:-$IRONIC_DATA_DIR/hardware_info}"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"# Set up defaults for functional / integration testing"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f6a8fd7_d42d3695","line":114,"updated":"2018-04-25 08:40:10.000000000","message":"It would be helpful to add information here later.","commit_id":"7784f40f9da12c4eb7a832484f8fac1f2a317b44"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"99cd83a4657270937c6f0efc6a7e847c041aece5","unresolved":false,"context_lines":[{"line_number":1970,"context_line":"                    --driver-info redfish_system_id\u003d$bmc_redfish_system_id \\"},{"line_number":1971,"context_line":"                    --driver-info redfish_password\u003d$bmc_passwd \\"},{"line_number":1972,"context_line":"                    --driver-info redfish_username\u003d$bmc_username \\"},{"line_number":1973,"context_line":"                    --driver-info redfish_verify_ca\u003dFalse\""},{"line_number":1974,"context_line":"            elif is_deployed_by_irmc; then"},{"line_number":1975,"context_line":"                node_options+\u003d\" --driver-info irmc_address\u003d$bmc_address \\"},{"line_number":1976,"context_line":"                    --driver-info irmc_password\u003d$bmc_passwd \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f6a8fd7_635d9b13","line":1973,"range":{"start_line":1973,"start_character":34,"end_line":1973,"end_character":57},"updated":"2018-04-24 22:54:50.000000000","message":"While we\u0027re at it, how about we make this configurable via the hardware information file, just like the other node options being set by this statement?","commit_id":"7784f40f9da12c4eb7a832484f8fac1f2a317b44"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a19fb9b8deba7cc2211a05ec50110c7894ef56d8","unresolved":false,"context_lines":[{"line_number":1970,"context_line":"                    --driver-info redfish_system_id\u003d$bmc_redfish_system_id \\"},{"line_number":1971,"context_line":"                    --driver-info redfish_password\u003d$bmc_passwd \\"},{"line_number":1972,"context_line":"                    --driver-info redfish_username\u003d$bmc_username \\"},{"line_number":1973,"context_line":"                    --driver-info redfish_verify_ca\u003dFalse\""},{"line_number":1974,"context_line":"            elif is_deployed_by_irmc; then"},{"line_number":1975,"context_line":"                node_options+\u003d\" --driver-info irmc_address\u003d$bmc_address \\"},{"line_number":1976,"context_line":"                    --driver-info irmc_password\u003d$bmc_passwd \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f6a8fd7_34ab5775","line":1973,"range":{"start_line":1973,"start_character":34,"end_line":1973,"end_character":57},"in_reply_to":"9f6a8fd7_635d9b13","updated":"2018-04-25 03:26:52.000000000","message":"+1. But I think this is not a must requirement for testing redfish interface.","commit_id":"7784f40f9da12c4eb7a832484f8fac1f2a317b44"}]}