)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2ef56d1b425d9484dfbb1e3232567c23092acee4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"operators to select from MySQL (InnoDB) or"},{"line_number":14,"context_line":"MySQL Cluster (NDB) as the storage engine backend."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Since NDB has a smaller max row size than InnoDB,"},{"line_number":17,"context_line":"convert some column types to avoid exceeding the"},{"line_number":18,"context_line":"limit.  The original column types are preserved when"},{"line_number":19,"context_line":"using InnoDB."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f6a8fd7_72e8cc7b","line":16,"range":{"start_line":16,"start_character":16,"end_line":16,"end_character":48},"updated":"2018-04-27 03:26:20.000000000","message":"In the node table we have instnace_info which is a field we recently moved from text to mediumtext. Does this impact usability because there is a basically an embedded blob that is encoded which is house in instance_info (hence why we made the field larger, in order to handle a larger configuration drive up to what we should store for users).","commit_id":"c1453e21b93d6faf591a5ccace98c199534c2c47"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4cbcd94f3cfb795f8b78b4d8f57e0b6e878dfc41","unresolved":false,"context_lines":[{"line_number":13,"context_line":"operators to select from MySQL (InnoDB) or"},{"line_number":14,"context_line":"MySQL Cluster (NDB) as the storage engine backend."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Since NDB has a smaller max row size than InnoDB,"},{"line_number":17,"context_line":"convert some column types to avoid exceeding the"},{"line_number":18,"context_line":"limit.  The original column types are preserved when"},{"line_number":19,"context_line":"using InnoDB."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_637013dc","line":16,"updated":"2019-03-04 14:11:42.000000000","message":"It would be good to actually mention the max row size for NDB, so that we understand why you change some fields, but not the other.","commit_id":"c1453e21b93d6faf591a5ccace98c199534c2c47"},{"author":{"_account_id":26089,"name":"Gerry Buteau","email":"gerry.buteau@oracle.com","username":"gbuteau"},"change_message_id":"5788399abae0a4abf866e9ed53608f2c53ef5b94","unresolved":false,"context_lines":[{"line_number":13,"context_line":"operators to select from MySQL (InnoDB) or"},{"line_number":14,"context_line":"MySQL Cluster (NDB) as the storage engine backend."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Since NDB has a smaller max row size than InnoDB,"},{"line_number":17,"context_line":"convert some column types to avoid exceeding the"},{"line_number":18,"context_line":"limit.  The original column types are preserved when"},{"line_number":19,"context_line":"using InnoDB."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f6a8fd7_08782ff6","line":16,"range":{"start_line":16,"start_character":16,"end_line":16,"end_character":48},"in_reply_to":"9f6a8fd7_72e8cc7b","updated":"2018-04-27 20:26:22.000000000","message":"Hi Julia, thanks for your review and consideration.  There is no impact to max row size for any blob type (incl. text types).  Blobs only contribute a few bytes to the max row size for length and a reference to the actual data.  Blob data is stored external to the row in the storage engine.  So switching the type from text to mediumtext will have no effect wrt this change.","commit_id":"c1453e21b93d6faf591a5ccace98c199534c2c47"}],"ironic/db/sqlalchemy/models.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4cbcd94f3cfb795f8b78b4d8f57e0b6e878dfc41","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    #             filter on it more efficiently, even though it is"},{"line_number":132,"context_line":"    #             user-settable, and would otherwise be in node.properties."},{"line_number":133,"context_line":"    instance_uuid \u003d Column(String(36), nullable\u003dTrue)"},{"line_number":134,"context_line":"    name \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":135,"context_line":"    chassis_id \u003d Column(Integer, ForeignKey(\u0027chassis.id\u0027), nullable\u003dTrue)"},{"line_number":136,"context_line":"    power_state \u003d Column(String(15), nullable\u003dTrue)"},{"line_number":137,"context_line":"    target_power_state \u003d Column(String(15), nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_037d87b1","line":134,"updated":"2019-03-04 14:11:42.000000000","message":"Why not change this?","commit_id":"c1453e21b93d6faf591a5ccace98c199534c2c47"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4cbcd94f3cfb795f8b78b4d8f57e0b6e878dfc41","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    last_error \u003d Column(Text, nullable\u003dTrue)"},{"line_number":142,"context_line":"    instance_info \u003d Column(db_types.JsonEncodedDict(mysql_as_long\u003dTrue))"},{"line_number":143,"context_line":"    properties \u003d Column(db_types.JsonEncodedDict)"},{"line_number":144,"context_line":"    driver \u003d Column(String(255))"},{"line_number":145,"context_line":"    driver_info \u003d Column(db_types.JsonEncodedDict)"},{"line_number":146,"context_line":"    driver_internal_info \u003d Column(db_types.JsonEncodedDict)"},{"line_number":147,"context_line":"    clean_step \u003d Column(db_types.JsonEncodedDict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_237a0bba","line":144,"updated":"2019-03-04 14:11:42.000000000","message":"and this? And models other than Node?","commit_id":"c1453e21b93d6faf591a5ccace98c199534c2c47"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4cbcd94f3cfb795f8b78b4d8f57e0b6e878dfc41","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    driver_info \u003d Column(db_types.JsonEncodedDict)"},{"line_number":146,"context_line":"    driver_internal_info \u003d Column(db_types.JsonEncodedDict)"},{"line_number":147,"context_line":"    clean_step \u003d Column(db_types.JsonEncodedDict)"},{"line_number":148,"context_line":"    resource_class \u003d Column(String(80), nullable\u003dTrue)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    raid_config \u003d Column(db_types.JsonEncodedDict)"},{"line_number":151,"context_line":"    target_raid_config \u003d Column(db_types.JsonEncodedDict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_c348df8b","line":148,"updated":"2019-03-04 14:11:42.000000000","message":"Is 80 small enough?","commit_id":"c1453e21b93d6faf591a5ccace98c199534c2c47"}]}