)]}'
{"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6e6fba96cf914852a623d52e719e4edb8129c676","unresolved":false,"context_lines":[{"line_number":126,"context_line":"# https://www.intel.com/content/dam/www/public/us/en/documents/product-briefs/ipmi-second-gen-interface-spec-v2-rev1-1.pdf"},{"line_number":127,"context_line":"# https://github.com/scottjg/ipmitool/blob/master/lib/ipmi_strings.c#L367"},{"line_number":128,"context_line":"#"},{"line_number":129,"context_line":"# Note(TheJulia): The `insufficient resources` string is hardcoded in"},{"line_number":130,"context_line":"# ipmitool\u0027s lanplus driver and is substituted in return for the error"},{"line_number":131,"context_line":"# code received from the IPMI controller.  As of 1.8.15, no"},{"line_number":132,"context_line":"# internationalization support appears to be in ipmitool which means the"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_fd98c01b","line":129,"range":{"start_line":129,"start_character":22,"end_line":129,"end_character":46},"updated":"2018-05-10 02:46:08.000000000","message":"Isn\u0027t this Note applicable to other failure messages as well? If so, we need to update this note accordingly.","commit_id":"5c52eee3b4b6e21985ce2da5df69e4a391697920"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"be6bce286f06d49a3ed8f5570bde24ae0d82c0e0","unresolved":false,"context_lines":[{"line_number":126,"context_line":"# https://www.intel.com/content/dam/www/public/us/en/documents/product-briefs/ipmi-second-gen-interface-spec-v2-rev1-1.pdf"},{"line_number":127,"context_line":"# https://github.com/scottjg/ipmitool/blob/master/lib/ipmi_strings.c#L367"},{"line_number":128,"context_line":"#"},{"line_number":129,"context_line":"# Note(TheJulia): The `insufficient resources` string is hardcoded in"},{"line_number":130,"context_line":"# ipmitool\u0027s lanplus driver and is substituted in return for the error"},{"line_number":131,"context_line":"# code received from the IPMI controller.  As of 1.8.15, no"},{"line_number":132,"context_line":"# internationalization support appears to be in ipmitool which means the"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_0b5d16e8","line":129,"range":{"start_line":129,"start_character":22,"end_line":129,"end_character":46},"in_reply_to":"5f7c97a3_fd98c01b","updated":"2018-05-11 09:30:53.000000000","message":"Done","commit_id":"5c52eee3b4b6e21985ce2da5df69e4a391697920"}],"ironic/tests/unit/drivers/modules/test_ipmitool.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"93077714ef1051226c5ab9d15118b025aaf42b1f","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"class IPMIToolPrivateMethodTestCaseMeta(type):"},{"line_number":342,"context_line":"    \"\"\"Generate and inject parametrized test cases\"\"\""},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    ipmitool_errors \u003d ["},{"line_number":345,"context_line":"        \u0027insufficient resources for session\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_61006bac","line":342,"range":{"start_line":342,"start_character":4,"end_line":342,"end_character":53},"updated":"2018-05-11 12:11:29.000000000","message":"?","commit_id":"1eedc4796ae71ba6884c9ea69c8e87c160d97f11"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"dbdf890872e25d46f1d5f1ef24f375bcc1af55a6","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"class IPMIToolPrivateMethodTestCaseMeta(type):"},{"line_number":342,"context_line":"    \"\"\"Generate and inject parametrized test cases\"\"\""},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    ipmitool_errors \u003d ["},{"line_number":345,"context_line":"        \u0027insufficient resources for session\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_e10b1b7a","line":342,"range":{"start_line":342,"start_character":4,"end_line":342,"end_character":53},"in_reply_to":"5f7c97a3_61006bac","updated":"2018-05-11 12:34:33.000000000","message":"Done","commit_id":"1eedc4796ae71ba6884c9ea69c8e87c160d97f11"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"57912860920d3b57d006f65016a7498b66149787","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        \u0027BMC initialization in progress\u0027"},{"line_number":350,"context_line":"    ]"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    def __new__(mcs, name, bases, dict):"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        def gen_test_methods(message):"},{"line_number":355,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_e111db5e","line":352,"range":{"start_line":352,"start_character":34,"end_line":352,"end_character":38},"updated":"2018-05-11 12:58:33.000000000","message":"Can we change this name, please? Shouldn\u0027t be overriding builtins.","commit_id":"1233f75bb23efb817e420f6aa30f4f42f37bae80"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"90f38db2eca8d02c03798a5650c791b9ceb2afdf","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        \u0027BMC initialization in progress\u0027"},{"line_number":350,"context_line":"    ]"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    def __new__(mcs, name, bases, dict):"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        def gen_test_methods(message):"},{"line_number":355,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_29ced92c","line":352,"range":{"start_line":352,"start_character":34,"end_line":352,"end_character":38},"in_reply_to":"5f7c97a3_e111db5e","updated":"2018-05-11 13:38:11.000000000","message":"Indeed! I need more coffee.","commit_id":"1233f75bb23efb817e420f6aa30f4f42f37bae80"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"57912860920d3b57d006f65016a7498b66149787","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        return type.__new__(mcs, name, bases, dict)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"@six.add_metaclass(IPMIToolPrivateMethodTestCaseMeta)"},{"line_number":446,"context_line":"class IPMIToolPrivateMethodTestCase(db_base.DbTestCase):"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_4121afaf","line":445,"updated":"2018-05-11 12:58:33.000000000","message":"I kinda hate that we\u0027re using metaclasses for this, I think it\u0027s going to confuse the hell out of people later. I understand why you\u0027re doing it, but would rather just do it the long way for readability.","commit_id":"1233f75bb23efb817e420f6aa30f4f42f37bae80"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5c3cef406e94bbecf0621f0a2bd472fc614d3b66","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        return type.__new__(mcs, name, bases, dict)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"@six.add_metaclass(IPMIToolPrivateMethodTestCaseMeta)"},{"line_number":446,"context_line":"class IPMIToolPrivateMethodTestCase(db_base.DbTestCase):"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_aea95090","line":445,"in_reply_to":"5f7c97a3_09751dcb","updated":"2018-05-15 12:21:41.000000000","message":"+1. I agree with Jim. We should give higher preference to readability and simplicity.","commit_id":"1233f75bb23efb817e420f6aa30f4f42f37bae80"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"c13229a153e20a6f1f3fde35e8ba8fdb019762f1","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        return type.__new__(mcs, name, bases, dict)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"@six.add_metaclass(IPMIToolPrivateMethodTestCaseMeta)"},{"line_number":446,"context_line":"class IPMIToolPrivateMethodTestCase(db_base.DbTestCase):"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_eccc6f6b","line":445,"in_reply_to":"5f7c97a3_09751dcb","updated":"2018-05-11 14:05:14.000000000","message":"Yeah, I see you point...\n\nOn the other hand, as `err_msg` count goes up, the amount of methods we add manually grow 3 times faster.\n\nI have no problems with doing it either way though, just wondering what the rest of the team feels better with? ;-)","commit_id":"1233f75bb23efb817e420f6aa30f4f42f37bae80"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"90f38db2eca8d02c03798a5650c791b9ceb2afdf","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        return type.__new__(mcs, name, bases, dict)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"@six.add_metaclass(IPMIToolPrivateMethodTestCaseMeta)"},{"line_number":446,"context_line":"class IPMIToolPrivateMethodTestCase(db_base.DbTestCase):"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_89684d1d","line":445,"in_reply_to":"5f7c97a3_4121afaf","updated":"2018-05-11 13:38:11.000000000","message":"Well, is not this the primary purpose of the metaclass as a language feature -- to construct a class by machine from pieces?\n\nI does not feel like a hack or something foreign to an average coder exerising Python, no?\n\nThe long way you have in mind - how that would look like conceptually?","commit_id":"1233f75bb23efb817e420f6aa30f4f42f37bae80"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"f5908887d7890e55edc1877a1929e9f7b0c2e965","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        return type.__new__(mcs, name, bases, dict)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"@six.add_metaclass(IPMIToolPrivateMethodTestCaseMeta)"},{"line_number":446,"context_line":"class IPMIToolPrivateMethodTestCase(db_base.DbTestCase):"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_09751dcb","line":445,"in_reply_to":"5f7c97a3_89684d1d","updated":"2018-05-11 13:44:38.000000000","message":"Right, I think most people could figure it out, but there\u0027s much more cognitive overhead. Say I make a patch and one of the generated tests begins failing. I can\u0027t just grep the failing test name in the code, so I wind up jumping down to this class. I overlook the decorator, start looking through the methods, don\u0027t see anything. Get super confused, ask on IRC, keep looking. Eventually see it, figure out what\u0027s happening here, and fix it. Meanwhile someone in IRC gets curious and goes looking to help, also finds it and replies to me, I tell them I find it. Suddenly we\u0027ve spent a total of 10-20 minutes just to find a test. Still a small amount of time, but it adds up as it keeps happening.\n\nThe long way would be something like:\n\n    def _test__exec_ipmitool_exception_retry(self, mock_things, err_msg\u003d\"\"):\n        # actual test code here\n\n    def test__exec_ipmitool_exception_retry_insufficient_resources(self):\n        self._test__exec_ipmitool_exception_retry(err_msg\u003d\"insufficient resources for session\")\n\n    def test__exec_and_so_on_and_so_forth...","commit_id":"1233f75bb23efb817e420f6aa30f4f42f37bae80"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9e8f62d36cdd7873dd481ead7e2ae8994e647bc4","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        return type.__new__(mcs, name, bases, dict)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"@six.add_metaclass(IPMIToolPrivateMethodTestCaseMeta)"},{"line_number":446,"context_line":"class IPMIToolPrivateMethodTestCase(db_base.DbTestCase):"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_bea4064c","line":445,"in_reply_to":"5f7c97a3_aea95090","updated":"2018-05-16 14:36:58.000000000","message":"I think this is a really valid use case for this style, although it would likely click for someone reading it if there were a few in-line notes.","commit_id":"1233f75bb23efb817e420f6aa30f4f42f37bae80"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"f4220158da35b49734d9c8bf8a2e46395c7b3e68","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        return type.__new__(mcs, name, bases, dict)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"@six.add_metaclass(IPMIToolPrivateMethodTestCaseMeta)"},{"line_number":446,"context_line":"class IPMIToolPrivateMethodTestCase(db_base.DbTestCase):"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a34a6680","line":445,"in_reply_to":"5f7c97a3_bea4064c","updated":"2018-06-06 11:16:36.000000000","message":"Some in-line notes added","commit_id":"1233f75bb23efb817e420f6aa30f4f42f37bae80"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"de15b8e7400e34dc6cd5bf75bff3a8999b05d164","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        return type.__new__(mcs, name, bases, dict)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"@six.add_metaclass(IPMIToolPrivateMethodTestCaseMeta)"},{"line_number":446,"context_line":"class IPMIToolPrivateMethodTestCase(db_base.DbTestCase):"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_b856b129","line":445,"in_reply_to":"5f7c97a3_eccc6f6b","updated":"2018-05-11 17:04:18.000000000","message":"Yeah, I\u0027m going to wait for more opinions. :)","commit_id":"1233f75bb23efb817e420f6aa30f4f42f37bae80"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9e8f62d36cdd7873dd481ead7e2ae8994e647bc4","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"class IPMIToolPrivateMethodTestCaseMeta(type):"},{"line_number":342,"context_line":"    \"\"\"Generate and inject parametrized test cases\"\"\""},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    ipmitool_errors \u003d ["},{"line_number":345,"context_line":"        \u0027insufficient resources for session\u0027,"},{"line_number":346,"context_line":"        \u0027Node busy\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_9e57ca26","line":343,"updated":"2018-05-16 14:36:58.000000000","message":"It might be good to put an inline note to hint that this is iterated below to generate the methods.","commit_id":"372907e4f9d4b6928280111b45b021722c3a2cfa"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"f4220158da35b49734d9c8bf8a2e46395c7b3e68","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"class IPMIToolPrivateMethodTestCaseMeta(type):"},{"line_number":342,"context_line":"    \"\"\"Generate and inject parametrized test cases\"\"\""},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    ipmitool_errors \u003d ["},{"line_number":345,"context_line":"        \u0027insufficient resources for session\u0027,"},{"line_number":346,"context_line":"        \u0027Node busy\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_63444e75","line":343,"in_reply_to":"5f7c97a3_9e57ca26","updated":"2018-06-06 11:16:36.000000000","message":"Some in-line notes added","commit_id":"372907e4f9d4b6928280111b45b021722c3a2cfa"}],"releasenotes/notes/add-more-retryable-ipmitool-errors-1c9351a89ff0ec1a.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b7a17e2e9aa82774898ec3363c324beeead67f8b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Adds some more ``ipmitool`` error messages to be treated as retryable"},{"line_number":4,"context_line":"    by ironic. This should make IPMI-based communicaton with BMC more"},{"line_number":5,"context_line":"    reliable by making ironic retrying failed IPMI commands."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_a99e9351","line":3,"updated":"2018-05-09 18:52:45.000000000","message":"nit: maybe mention the message? and the fact that we\u0027re talking about the IPMI hardware type?","commit_id":"5c52eee3b4b6e21985ce2da5df69e4a391697920"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6e6fba96cf914852a623d52e719e4edb8129c676","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Adds some more ``ipmitool`` error messages to be treated as retryable"},{"line_number":4,"context_line":"    by ironic. This should make IPMI-based communicaton with BMC more"},{"line_number":5,"context_line":"    reliable by making ironic retrying failed IPMI commands."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_dd638419","line":3,"in_reply_to":"5f7c97a3_a99e9351","updated":"2018-05-10 02:46:08.000000000","message":"+1","commit_id":"5c52eee3b4b6e21985ce2da5df69e4a391697920"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"be6bce286f06d49a3ed8f5570bde24ae0d82c0e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Adds some more ``ipmitool`` error messages to be treated as retryable"},{"line_number":4,"context_line":"    by ironic. This should make IPMI-based communicaton with BMC more"},{"line_number":5,"context_line":"    reliable by making ironic retrying failed IPMI commands."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_901637f1","line":3,"in_reply_to":"5f7c97a3_a99e9351","updated":"2018-05-11 09:30:53.000000000","message":"Done","commit_id":"5c52eee3b4b6e21985ce2da5df69e4a391697920"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"be6bce286f06d49a3ed8f5570bde24ae0d82c0e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Adds some more ``ipmitool`` error messages to be treated as retryable"},{"line_number":4,"context_line":"    by ironic. This should make IPMI-based communicaton with BMC more"},{"line_number":5,"context_line":"    reliable by making ironic retrying failed IPMI commands."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_30d5e31c","line":3,"in_reply_to":"5f7c97a3_dd638419","updated":"2018-05-11 09:30:53.000000000","message":"Done","commit_id":"5c52eee3b4b6e21985ce2da5df69e4a391697920"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"93077714ef1051226c5ab9d15118b025aaf42b1f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Adds more ``ipmitool`` error messages to be treated as retryable by the"},{"line_number":4,"context_line":"    IPMI hardware type. Specifically, ``Node busy``, ``Timeout``,"},{"line_number":5,"context_line":"    ``Out of space`` and ``BMC initialization in progress`` reporting"},{"line_number":6,"context_line":"    emitted by ``ipmitool`` will cause ironic to retry IPMI command."},{"line_number":7,"context_line":"    This change should improve the reliability of IPMI-based communicaton"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_41da0f4c","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":22},"updated":"2018-05-11 12:11:29.000000000","message":"s/hardware type/interface/ since it is re-used and supported by multiple via base hardware.","commit_id":"1eedc4796ae71ba6884c9ea69c8e87c160d97f11"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"dbdf890872e25d46f1d5f1ef24f375bcc1af55a6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Adds more ``ipmitool`` error messages to be treated as retryable by the"},{"line_number":4,"context_line":"    IPMI hardware type. Specifically, ``Node busy``, ``Timeout``,"},{"line_number":5,"context_line":"    ``Out of space`` and ``BMC initialization in progress`` reporting"},{"line_number":6,"context_line":"    emitted by ``ipmitool`` will cause ironic to retry IPMI command."},{"line_number":7,"context_line":"    This change should improve the reliability of IPMI-based communicaton"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_61d86b1d","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":22},"in_reply_to":"5f7c97a3_41da0f4c","updated":"2018-05-11 12:34:33.000000000","message":"Done","commit_id":"1eedc4796ae71ba6884c9ea69c8e87c160d97f11"}]}
