)]}'
{"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"d71bd6bdfec6f400e17dfdec8a02a51cccddde7e","unresolved":false,"context_lines":[{"line_number":868,"context_line":"            try:"},{"line_number":869,"context_line":"                pecan.request.rpcapi.remove_node_traits("},{"line_number":870,"context_line":"                    context, node.id, traits, topic\u003dtopic)"},{"line_number":871,"context_line":"            except exception.NodeTraitNotFound:"},{"line_number":872,"context_line":"                # NOTE(hshiina): Internal node ID should not be exposed."},{"line_number":873,"context_line":"                raise exception.NodeTraitNotFound(node_id\u003dself.node_ident,"},{"line_number":874,"context_line":"                                                  trait\u003dtrait)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c33427e1","line":871,"range":{"start_line":871,"start_character":29,"end_line":871,"end_character":46},"updated":"2018-05-22 15:28:12.000000000","message":"Would it make sense to catch `IronicException` (e.g. the base one) and override `node_id` to make sure that other exceptions (current or future) won\u0027t leak in the same way?","commit_id":"49cedaa63b0b952330c7c26e4d9bbe65af3a1077"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"6f1a728fc4226142f6d1825d7776d47af674a7da","unresolved":false,"context_lines":[{"line_number":868,"context_line":"            try:"},{"line_number":869,"context_line":"                pecan.request.rpcapi.remove_node_traits("},{"line_number":870,"context_line":"                    context, node.id, traits, topic\u003dtopic)"},{"line_number":871,"context_line":"            except exception.NodeTraitNotFound:"},{"line_number":872,"context_line":"                # NOTE(hshiina): Internal node ID should not be exposed."},{"line_number":873,"context_line":"                raise exception.NodeTraitNotFound(node_id\u003dself.node_ident,"},{"line_number":874,"context_line":"                                                  trait\u003dtrait)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_dbf887c5","line":871,"range":{"start_line":871,"start_character":29,"end_line":871,"end_character":46},"in_reply_to":"5f7c97a3_c33427e1","updated":"2018-05-23 05:39:15.000000000","message":"It seems difficult to replace node_id embedded into a message because it may cause an unexpected result to replace node.id, which is just an integer value.","commit_id":"49cedaa63b0b952330c7c26e4d9bbe65af3a1077"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4a000980794c2c5532d809eaa6b94215aa0278b8","unresolved":false,"context_lines":[{"line_number":870,"context_line":"                    context, node.id, traits, topic\u003dtopic)"},{"line_number":871,"context_line":"            except exception.NodeTraitNotFound:"},{"line_number":872,"context_line":"                # NOTE(hshiina): Internal node ID should not be exposed."},{"line_number":873,"context_line":"                raise exception.NodeTraitNotFound(node_id\u003dself.node_ident,"},{"line_number":874,"context_line":"                                                  trait\u003dtrait)"},{"line_number":875,"context_line":"        notify.emit_end_notification(context, node, \u0027update\u0027,"},{"line_number":876,"context_line":"                                     chassis_uuid\u003dchassis_uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_edaa6483","line":873,"updated":"2018-05-23 10:13:42.000000000","message":"I think we don\u0027t use names in exceptions, let\u0027s maybe use node.uuid instead?","commit_id":"2066ba59a7dcc7e94e2bbafcbd644910410a3a4c"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"d2db7353365762da1ddb196a87678778b1c42160","unresolved":false,"context_lines":[{"line_number":870,"context_line":"                    context, node.id, traits, topic\u003dtopic)"},{"line_number":871,"context_line":"            except exception.NodeTraitNotFound:"},{"line_number":872,"context_line":"                # NOTE(hshiina): Internal node ID should not be exposed."},{"line_number":873,"context_line":"                raise exception.NodeTraitNotFound(node_id\u003dself.node_ident,"},{"line_number":874,"context_line":"                                                  trait\u003dtrait)"},{"line_number":875,"context_line":"        notify.emit_end_notification(context, node, \u0027update\u0027,"},{"line_number":876,"context_line":"                                     chassis_uuid\u003dchassis_uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_43ac808b","line":873,"in_reply_to":"5f7c97a3_edaa6483","updated":"2018-05-24 02:51:20.000000000","message":"Done","commit_id":"2066ba59a7dcc7e94e2bbafcbd644910410a3a4c"}],"releasenotes/notes/bug-2002062-959b865ced05b746.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"42fbc19109c64dca1b8647a56d096f27c3bd0f50","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a bug to expose an internal node ID in an error message when"},{"line_number":5,"context_line":"    requested to delete a trait which doesn\u0027t exist. See"},{"line_number":6,"context_line":"    `bug 2002062 \u003chttps://storyboard.openstack.org/#!/story/2002062\u003e`_ for"},{"line_number":7,"context_line":"    details."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_fe4be383","line":4,"range":{"start_line":4,"start_character":16,"end_line":4,"end_character":25},"updated":"2018-05-24 05:28:19.000000000","message":"Should it be \u0027that exposes\u0027?","commit_id":"f84177240fbb9ebea2c5a3337bb4fe95b37eca56"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f3972ca0817a77e0ab87a8f96de5c36fae9d8ee9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a bug to expose an internal node ID in an error message when"},{"line_number":5,"context_line":"    requested to delete a trait which doesn\u0027t exist. See"},{"line_number":6,"context_line":"    `bug 2002062 \u003chttps://storyboard.openstack.org/#!/story/2002062\u003e`_ for"},{"line_number":7,"context_line":"    details."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_2790504a","line":4,"range":{"start_line":4,"start_character":16,"end_line":4,"end_character":25},"in_reply_to":"5f7c97a3_fe4be383","updated":"2018-05-27 12:50:34.000000000","message":"Done","commit_id":"f84177240fbb9ebea2c5a3337bb4fe95b37eca56"}]}
