)]}'
{"ironic/api/controllers/v1/types.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"1580199a58ed77d3db7649b4ef951510187e1b62","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                    % self.max_length"},{"line_number":95,"context_line":"            raise ValueError(error)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        if self.pattern is not None and not self.pattern.search(value):"},{"line_number":98,"context_line":"            error \u003d \u0027Value should match the pattern %s\u0027 % self.pattern"},{"line_number":99,"context_line":"            raise ValueError(error)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BxH0%3D","line":97,"updated":"2013-11-20 13:54:15.000000000","message":"I think match() needed here instead of search()","commit_id":"d26f2346352187b53783b3869d4b4ca92d3ff9b9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a1da124558cc6b1a78e70a1d2eef166ec8ed1ecf","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                    % self.max_length"},{"line_number":95,"context_line":"            raise ValueError(error)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        if self.pattern is not None and not self.pattern.search(value):"},{"line_number":98,"context_line":"            error \u003d \u0027Value should match the pattern %s\u0027 % self.pattern"},{"line_number":99,"context_line":"            raise ValueError(error)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BwZE%3D","line":97,"in_reply_to":"AAAATn%2F%2BxH0%3D","updated":"2013-11-20 16:54:57.000000000","message":"I think we can just force our regex to search at beginning of the string for this one.\n\ne.g: \u0027^(/[\\w-]+)+$\u0027","commit_id":"d26f2346352187b53783b3869d4b4ca92d3ff9b9"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"1580199a58ed77d3db7649b4ef951510187e1b62","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            raise ValueError(error)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        if self.pattern is not None and not self.pattern.search(value):"},{"line_number":98,"context_line":"            error \u003d \u0027Value should match the pattern %s\u0027 % self.pattern"},{"line_number":99,"context_line":"            raise ValueError(error)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        return value"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BxHM%3D","line":98,"updated":"2013-11-20 13:54:15.000000000","message":"self.pattern is RegexObject. Do you mean self.pattern.pattern?","commit_id":"d26f2346352187b53783b3869d4b4ca92d3ff9b9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a1da124558cc6b1a78e70a1d2eef166ec8ed1ecf","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            raise ValueError(error)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        if self.pattern is not None and not self.pattern.search(value):"},{"line_number":98,"context_line":"            error \u003d \u0027Value should match the pattern %s\u0027 % self.pattern"},{"line_number":99,"context_line":"            raise ValueError(error)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        return value"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BwZA%3D","line":98,"in_reply_to":"AAAATn%2F%2BxHM%3D","updated":"2013-11-20 16:54:57.000000000","message":"I copied this class as-is from WSME, I will fix it here and on WSME as well.\n\nhttps://github.com/stackforge/wsme/blob/master/wsme/types.py#L220\n\nThanks!","commit_id":"d26f2346352187b53783b3869d4b4ca92d3ff9b9"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"1580199a58ed77d3db7649b4ef951510187e1b62","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        return []"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @staticmethod"},{"line_number":123,"context_line":"    def sanitize_attrs(attrs):"},{"line_number":124,"context_line":"        sanitized_list \u003d []"},{"line_number":125,"context_line":"        for attr in attrs:"},{"line_number":126,"context_line":"            if not attr.startswith(\u0027/\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BxE0%3D","line":123,"updated":"2013-11-20 13:54:15.000000000","message":"nit:\n\nreturn [attr if attr.startswith(\u0027/\u0027) else \u0027/\u0027 + attr for attr in attrs]","commit_id":"d26f2346352187b53783b3869d4b4ca92d3ff9b9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a1da124558cc6b1a78e70a1d2eef166ec8ed1ecf","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        return []"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @staticmethod"},{"line_number":123,"context_line":"    def sanitize_attrs(attrs):"},{"line_number":124,"context_line":"        sanitized_list \u003d []"},{"line_number":125,"context_line":"        for attr in attrs:"},{"line_number":126,"context_line":"            if not attr.startswith(\u0027/\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BwaE%3D","line":123,"in_reply_to":"AAAATn%2F%2BxE0%3D","updated":"2013-11-20 16:54:57.000000000","message":"awesome, ta much!","commit_id":"d26f2346352187b53783b3869d4b4ca92d3ff9b9"}],"ironic/tests/api/test_ports.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1c8701f06f46b1006865a6693436876548150e0d","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        result \u003d self.get_json(\u0027/ports/%s\u0027 % self.pdict[\u0027uuid\u0027])"},{"line_number":162,"context_line":"        self.assertEqual(result[\u0027address\u0027], address)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    # FIXME (lucasagomes): https://bugs.launchpad.net/ironic/+bug/1252343"},{"line_number":165,"context_line":"    #def test_replace_address_already_exist(self):"},{"line_number":166,"context_line":"    #    pdict1 \u003d post_get_test_port(address\u003d\u0027AA:AA:AA:AA:AA:AA\u0027,"},{"line_number":167,"context_line":"    #                                uuid\u003dutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F9%2BXk%3D","line":164,"updated":"2013-12-03 21:27:18.000000000","message":"This could use some more explanation -- the referenced bug is already marked as \"Fixed\", so I don\u0027t understand what this FIXME is about.","commit_id":"7423b1f8f02148ca479944ec5eff503521fa40fc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2f3440662ef25e3a8e7a1ae6106c95fba725bc04","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        result \u003d self.get_json(\u0027/ports/%s\u0027 % self.pdict[\u0027uuid\u0027])"},{"line_number":162,"context_line":"        self.assertEqual(result[\u0027address\u0027], address)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    # FIXME (lucasagomes): https://bugs.launchpad.net/ironic/+bug/1252343"},{"line_number":165,"context_line":"    #def test_replace_address_already_exist(self):"},{"line_number":166,"context_line":"    #    pdict1 \u003d post_get_test_port(address\u003d\u0027AA:AA:AA:AA:AA:AA\u0027,"},{"line_number":167,"context_line":"    #                                uuid\u003dutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F97uk%3D","line":164,"in_reply_to":"AAAATn%2F9%2BXk%3D","updated":"2013-12-04 09:59:26.000000000","message":"Ah sorry, I spotted this bug when I was doing this patch so I reported it, but the bug got fixed/merged faster than this patch itself :) So I\u0027m going to rebase and uncomment this test.\n\nThanks for pointing it out :)","commit_id":"7423b1f8f02148ca479944ec5eff503521fa40fc"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"9c76cf36b8c90d59a85fc39059e3a112c68003e1","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def test_replace_address_already_exist(self):"},{"line_number":167,"context_line":"        pdict1 \u003d post_get_test_port(address\u003d\u0027AA:AA:AA:AA:AA:AA\u0027,"},{"line_number":168,"context_line":"                                    uuid\u003dutils.generate_uuid())"},{"line_number":169,"context_line":"        self.post_json(\u0027/ports\u0027, pdict1)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        pdict2 \u003d post_get_test_port(address\u003d\u0027BB:BB:BB:BB:BB:BB\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAATn%2F9s%2FQ%3D","line":168,"updated":"2013-12-06 23:04:00.000000000","message":"Lucas, how do you think can we add more case to test if our code can handle the existing address with different capital/lowercase?","commit_id":"d2ee9881d613da1da315f561ba2255574d3b5463"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"5cf0d8c83266b3b094ddcaf69a9179220674f1d3","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def test_replace_address_already_exist(self):"},{"line_number":167,"context_line":"        pdict1 \u003d post_get_test_port(address\u003d\u0027AA:AA:AA:AA:AA:AA\u0027,"},{"line_number":168,"context_line":"                                    uuid\u003dutils.generate_uuid())"},{"line_number":169,"context_line":"        self.post_json(\u0027/ports\u0027, pdict1)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        pdict2 \u003d post_get_test_port(address\u003d\u0027BB:BB:BB:BB:BB:BB\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAATn%2F9ibg%3D","line":168,"in_reply_to":"AAAATn%2F9m9Y%3D","updated":"2013-12-10 13:34:19.000000000","message":"Great, thank you Lucas.","commit_id":"d2ee9881d613da1da315f561ba2255574d3b5463"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6c72548537deaa85b0d88fc3570b4f93fd37b714","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def test_replace_address_already_exist(self):"},{"line_number":167,"context_line":"        pdict1 \u003d post_get_test_port(address\u003d\u0027AA:AA:AA:AA:AA:AA\u0027,"},{"line_number":168,"context_line":"                                    uuid\u003dutils.generate_uuid())"},{"line_number":169,"context_line":"        self.post_json(\u0027/ports\u0027, pdict1)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        pdict2 \u003d post_get_test_port(address\u003d\u0027BB:BB:BB:BB:BB:BB\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAATn%2F9m9Y%3D","line":168,"in_reply_to":"AAAATn%2F9ocU%3D","updated":"2013-12-09 18:13:04.000000000","message":"Hi Haomeng, I addressed the problem with the normalization in another patch: https://review.openstack.org/#/c/60890","commit_id":"d2ee9881d613da1da315f561ba2255574d3b5463"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"20b92e40bad583eaf9a4572519d8d987a6f64f99","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def test_replace_address_already_exist(self):"},{"line_number":167,"context_line":"        pdict1 \u003d post_get_test_port(address\u003d\u0027AA:AA:AA:AA:AA:AA\u0027,"},{"line_number":168,"context_line":"                                    uuid\u003dutils.generate_uuid())"},{"line_number":169,"context_line":"        self.post_json(\u0027/ports\u0027, pdict1)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        pdict2 \u003d post_get_test_port(address\u003d\u0027BB:BB:BB:BB:BB:BB\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAATn%2F9ocU%3D","line":168,"in_reply_to":"AAAATn%2F9s%2FQ%3D","updated":"2013-12-09 14:24:09.000000000","message":"That\u0027s a good point, we don\u0027t have any code to normalize the address I bet it\u0027s going to fail since we have no code (afaict) to normalize the address. Do you think the API should do it?","commit_id":"d2ee9881d613da1da315f561ba2255574d3b5463"}]}
