)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8be3c7dc79b7160fbbd622825e87d099457e78cf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nguyen Van Trung \u003ctrungnv@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-23 10:45:20 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make method to the public which support for RAID configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit will make the public for _notify_conductor_resume_clean method."},{"line_number":10,"context_line":"Currently, Drac is using this method for resume cleaning of RAID"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_cc48b888","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":62},"updated":"2018-05-24 16:00:46.000000000","message":"nit: The first line of a commit message should be limited to 52 characters. Please see https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"362df07a4d856b1af9fee2400741e9cdf8998f76"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"4e3732828308cf39ebbe1913777019b60956c017","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nguyen Van Trung \u003ctrungnv@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-23 10:45:20 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make method to the public which support for RAID configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit will make the public for _notify_conductor_resume_clean method."},{"line_number":10,"context_line":"Currently, Drac is using this method for resume cleaning of RAID"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_d9bcf3dd","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":62},"in_reply_to":"5f7c97a3_cc48b888","updated":"2018-05-25 02:19:18.000000000","message":"Done","commit_id":"362df07a4d856b1af9fee2400741e9cdf8998f76"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8be3c7dc79b7160fbbd622825e87d099457e78cf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make method to the public which support for RAID configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit will make the public for _notify_conductor_resume_clean method."},{"line_number":10,"context_line":"Currently, Drac is using this method for resume cleaning of RAID"},{"line_number":11,"context_line":"configuration [1]."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_6c5f2441","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":75},"updated":"2018-05-24 16:00:46.000000000","message":"nit: The lines in a commit message that are subsequent to the first should be wrapped at 72 characters. Please see https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"362df07a4d856b1af9fee2400741e9cdf8998f76"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"4e3732828308cf39ebbe1913777019b60956c017","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make method to the public which support for RAID configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit will make the public for _notify_conductor_resume_clean method."},{"line_number":10,"context_line":"Currently, Drac is using this method for resume cleaning of RAID"},{"line_number":11,"context_line":"configuration [1]."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_f9c1af55","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":75},"in_reply_to":"5f7c97a3_6c5f2441","updated":"2018-05-25 02:19:18.000000000","message":"Done","commit_id":"362df07a4d856b1af9fee2400741e9cdf8998f76"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8be3c7dc79b7160fbbd622825e87d099457e78cf","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Currently, Drac is using this method for resume cleaning of RAID"},{"line_number":11,"context_line":"configuration [1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change also is going to fix for RAID configuration via iRMC driver [2]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/drac/raid.py#L892"},{"line_number":16,"context_line":"[2] https://review.openstack.org/#/c/512979"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_8c5ac04d","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":76},"updated":"2018-05-24 16:00:46.000000000","message":"nit: Same as above.","commit_id":"362df07a4d856b1af9fee2400741e9cdf8998f76"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"4e3732828308cf39ebbe1913777019b60956c017","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Currently, Drac is using this method for resume cleaning of RAID"},{"line_number":11,"context_line":"configuration [1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change also is going to fix for RAID configuration via iRMC driver [2]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/drac/raid.py#L892"},{"line_number":16,"context_line":"[2] https://review.openstack.org/#/c/512979"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_39716745","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":76},"in_reply_to":"5f7c97a3_8c5ac04d","updated":"2018-05-25 02:19:18.000000000","message":"Done","commit_id":"362df07a4d856b1af9fee2400741e9cdf8998f76"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8be3c7dc79b7160fbbd622825e87d099457e78cf","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change also is going to fix for RAID configuration via iRMC driver [2]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/drac/raid.py#L892"},{"line_number":16,"context_line":"[2] https://review.openstack.org/#/c/512979"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ifd10dd88d65306049119588e6088359a5d38c158"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_ec30140a","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":92},"updated":"2018-05-24 16:00:46.000000000","message":"This should be a permalink, https://github.com/openstack/ironic/blob/580d4338e2bce8e557a5007fcba85e157f0b8d60/ironic/drivers/modules/drac/raid.py#L892, because the line number on master could become incorrect over time as changes are made to the file.","commit_id":"362df07a4d856b1af9fee2400741e9cdf8998f76"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"4e3732828308cf39ebbe1913777019b60956c017","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change also is going to fix for RAID configuration via iRMC driver [2]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/drac/raid.py#L892"},{"line_number":16,"context_line":"[2] https://review.openstack.org/#/c/512979"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ifd10dd88d65306049119588e6088359a5d38c158"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_1974ab35","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":92},"in_reply_to":"5f7c97a3_ec30140a","updated":"2018-05-25 02:19:18.000000000","message":"Done","commit_id":"362df07a4d856b1af9fee2400741e9cdf8998f76"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8be3c7dc79b7160fbbd622825e87d099457e78cf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nguyen Van Trung \u003ctrungnv@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-23 10:45:20 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make method to the public which support for RAID configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit will make the public for _notify_conductor_resume_clean method."},{"line_number":10,"context_line":"Currently, Drac is using this method for resume cleaning of RAID"},{"line_number":11,"context_line":"configuration [1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change also is going to fix for RAID configuration via iRMC driver [2]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/drac/raid.py#L892"},{"line_number":16,"context_line":"[2] https://review.openstack.org/#/c/512979"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ifd10dd88d65306049119588e6088359a5d38c158"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_2c2e0ca5","line":18,"range":{"start_line":7,"start_character":0,"end_line":18,"end_character":52},"updated":"2018-05-24 16:00:46.000000000","message":"The following is for your consideration. It is a draft edit of the entire commit message.\n\nMake method public to support out-of-band cleaning\n\nThis makes the _notify_conductor_resume_clean method public by removing\nthe leading underscore from its name. The idrac hardware type\u0027s RAID\nconfiguration out-of-band cleaning has been using it [1].\n\nThe method is going to be used by the RAID configuration support that is\nbeing added to the iRMC hardware type [2].\n\n[1] https://github.com/openstack/ironic/blob/580d4338e2bce8e557a5007fcba85e157f0b8d60/ironic/drivers/modules/drac/raid.py#L892\n[2] https://review.openstack.org/#/c/5129\n\nChange-Id: Ifd10dd88d65306049119588e6088359a5d38c158","commit_id":"362df07a4d856b1af9fee2400741e9cdf8998f76"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"4e3732828308cf39ebbe1913777019b60956c017","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nguyen Van Trung \u003ctrungnv@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-23 10:45:20 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make method to the public which support for RAID configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit will make the public for _notify_conductor_resume_clean method."},{"line_number":10,"context_line":"Currently, Drac is using this method for resume cleaning of RAID"},{"line_number":11,"context_line":"configuration [1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change also is going to fix for RAID configuration via iRMC driver [2]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/drac/raid.py#L892"},{"line_number":16,"context_line":"[2] https://review.openstack.org/#/c/512979"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ifd10dd88d65306049119588e6088359a5d38c158"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_797b5f27","line":18,"range":{"start_line":7,"start_character":0,"end_line":18,"end_character":52},"in_reply_to":"5f7c97a3_2c2e0ca5","updated":"2018-05-25 02:19:18.000000000","message":"Done","commit_id":"362df07a4d856b1af9fee2400741e9cdf8998f76"}],"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"a378ee85ec3fd652d1af8ad9f1732046c5d82ecf","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    task.node.save()"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def notify_conductor_resume_clean(task):"},{"line_number":156,"context_line":"    LOG.debug(\u0027Sending RPC to conductor to resume cleaning for node %s\u0027,"},{"line_number":157,"context_line":"              task.node.uuid)"},{"line_number":158,"context_line":"    uuid \u003d task.node.uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_392290ba","line":155,"updated":"2018-05-30 08:33:18.000000000","message":"It slightly looks weird that an OOB RAID interface calls a method in agent_base_vendor because the RAID interface is not related to agent. I prefer moving this method to a file appropriate for this kind of utility methods though I have no idea now.","commit_id":"9d209a6d804c951003a7aa9a0f7d52497e9883af"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"555e289c0157a1f0142270b8deab7fccdb859a92","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    task.node.save()"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def notify_conductor_resume_clean(task):"},{"line_number":156,"context_line":"    LOG.debug(\u0027Sending RPC to conductor to resume cleaning for node %s\u0027,"},{"line_number":157,"context_line":"              task.node.uuid)"},{"line_number":158,"context_line":"    uuid \u003d task.node.uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_04cfa9b0","line":155,"in_reply_to":"5f7c97a3_337b567b","updated":"2018-06-06 05:07:48.000000000","message":"+1","commit_id":"9d209a6d804c951003a7aa9a0f7d52497e9883af"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c245383bfc88d76be0273652b63a4094f4f30b63","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    task.node.save()"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def notify_conductor_resume_clean(task):"},{"line_number":156,"context_line":"    LOG.debug(\u0027Sending RPC to conductor to resume cleaning for node %s\u0027,"},{"line_number":157,"context_line":"              task.node.uuid)"},{"line_number":158,"context_line":"    uuid \u003d task.node.uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_337b567b","line":155,"in_reply_to":"5f7c97a3_392290ba","updated":"2018-06-01 19:50:35.000000000","message":"+1, something to consider I think.","commit_id":"9d209a6d804c951003a7aa9a0f7d52497e9883af"}]}