)]}'
{"ironic/tests/base.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5622941392a398dd31d15374a84abe626170904f","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                values.append(\u0027no-%s\u0027 % iface)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"            self.config(**{\u0027enabled_%s_interfaces\u0027 % iface: values,"},{"line_number":153,"context_line":"                           \u0027default_%s_interface\u0027 % iface: default})"},{"line_number":154,"context_line":"        self.config(enabled_network_interfaces\u003d[\u0027flat\u0027, \u0027noop\u0027, \u0027neutron\u0027])"},{"line_number":155,"context_line":"        self.set_defaults(host\u003d\u0027fake-mini\u0027,"},{"line_number":156,"context_line":"                          debug\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_76000e03","line":153,"range":{"start_line":153,"start_character":59,"end_line":153,"end_character":66},"updated":"2018-05-30 16:05:47.000000000","message":"nit - these are none already, also default is unused, so it can be just none here","commit_id":"df3713cb6bbdbe1bde4443780edf1aad438ffd7b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ebf24dc5b226a1c1fa2f51929cc23e6a8153ede","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                values.append(\u0027no-%s\u0027 % iface)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"            self.config(**{\u0027enabled_%s_interfaces\u0027 % iface: values,"},{"line_number":153,"context_line":"                           \u0027default_%s_interface\u0027 % iface: default})"},{"line_number":154,"context_line":"        self.config(enabled_network_interfaces\u003d[\u0027flat\u0027, \u0027noop\u0027, \u0027neutron\u0027])"},{"line_number":155,"context_line":"        self.set_defaults(host\u003d\u0027fake-mini\u0027,"},{"line_number":156,"context_line":"                          debug\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_61a92622","line":153,"range":{"start_line":153,"start_character":59,"end_line":153,"end_character":66},"in_reply_to":"5f7c97a3_76000e03","updated":"2018-05-30 16:16:58.000000000","message":"For some reason sometimes they\u0027re not properly cleaned up between tests.. Anyway, this bit was here before the change.","commit_id":"df3713cb6bbdbe1bde4443780edf1aad438ffd7b"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"a54ec7b130496ae8d22ff4aeabc13f0d76f0839a","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                values.append(\u0027pxe\u0027)"},{"line_number":146,"context_line":"            elif iface \u003d\u003d \u0027storage\u0027:"},{"line_number":147,"context_line":"                values.append(\u0027noop\u0027)"},{"line_number":148,"context_line":"            elif iface not in {\u0027power\u0027, \u0027management\u0027}:"},{"line_number":149,"context_line":"                values.append(\u0027no-%s\u0027 % iface)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"            self.config(**{\u0027enabled_%s_interfaces\u0027 % iface: values,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_3fcaf019","line":148,"range":{"start_line":148,"start_character":31,"end_line":148,"end_character":52},"updated":"2018-06-06 11:00:10.000000000","message":"nit: \u0027network\u0027 is necessary here if L153 is removed.","commit_id":"2dca50e4383d152bbd7a2b9c30d9222186d99bf8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"319d176fef1ee80a517d18d1e433e0078d29a1af","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                values.append(\u0027pxe\u0027)"},{"line_number":146,"context_line":"            elif iface \u003d\u003d \u0027storage\u0027:"},{"line_number":147,"context_line":"                values.append(\u0027noop\u0027)"},{"line_number":148,"context_line":"            elif iface not in {\u0027power\u0027, \u0027management\u0027}:"},{"line_number":149,"context_line":"                values.append(\u0027no-%s\u0027 % iface)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"            self.config(**{\u0027enabled_%s_interfaces\u0027 % iface: values,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_72a3b601","line":148,"range":{"start_line":148,"start_character":31,"end_line":148,"end_character":52},"in_reply_to":"5f7c97a3_3fcaf019","updated":"2018-06-06 14:08:20.000000000","message":"Done","commit_id":"2dca50e4383d152bbd7a2b9c30d9222186d99bf8"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"a54ec7b130496ae8d22ff4aeabc13f0d76f0839a","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"            self.config(**{\u0027enabled_%s_interfaces\u0027 % iface: values,"},{"line_number":152,"context_line":"                           \u0027default_%s_interface\u0027 % iface: None})"},{"line_number":153,"context_line":"        self.config(enabled_network_interfaces\u003d[\u0027flat\u0027, \u0027noop\u0027, \u0027neutron\u0027])"},{"line_number":154,"context_line":"        self.set_defaults(host\u003d\u0027fake-mini\u0027,"},{"line_number":155,"context_line":"                          debug\u003dTrue)"},{"line_number":156,"context_line":"        self.set_defaults(connection\u003d\"sqlite://\","}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_df965c3f","line":153,"updated":"2018-06-06 11:00:10.000000000","message":"nit: This is redundant. \u0027enabled_network_interfaces\u0027 is set in the loop above.","commit_id":"2dca50e4383d152bbd7a2b9c30d9222186d99bf8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"319d176fef1ee80a517d18d1e433e0078d29a1af","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"            self.config(**{\u0027enabled_%s_interfaces\u0027 % iface: values,"},{"line_number":152,"context_line":"                           \u0027default_%s_interface\u0027 % iface: None})"},{"line_number":153,"context_line":"        self.config(enabled_network_interfaces\u003d[\u0027flat\u0027, \u0027noop\u0027, \u0027neutron\u0027])"},{"line_number":154,"context_line":"        self.set_defaults(host\u003d\u0027fake-mini\u0027,"},{"line_number":155,"context_line":"                          debug\u003dTrue)"},{"line_number":156,"context_line":"        self.set_defaults(connection\u003d\"sqlite://\","}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_92a6920f","line":153,"in_reply_to":"5f7c97a3_df965c3f","updated":"2018-06-06 14:08:20.000000000","message":"Done","commit_id":"2dca50e4383d152bbd7a2b9c30d9222186d99bf8"}],"ironic/tests/unit/api/controllers/v1/test_driver.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"a54ec7b130496ae8d22ff4aeabc13f0d76f0839a","unresolved":false,"context_lines":[{"line_number":467,"context_line":"    def test_driver_properties_fake(self, mock_topic, mock_properties):"},{"line_number":468,"context_line":"        # Can get driver properties for fake driver."},{"line_number":469,"context_line":"        driver._DRIVER_PROPERTIES \u003d {}"},{"line_number":470,"context_line":"        driver_name \u003d \u0027fake\u0027"},{"line_number":471,"context_line":"        mock_topic.return_value \u003d \u0027fake_topic\u0027"},{"line_number":472,"context_line":"        mock_properties.return_value \u003d {\u0027prop1\u0027: \u0027Property 1. Required.\u0027}"},{"line_number":473,"context_line":"        data \u003d self.get_json(\u0027/drivers/%s/properties\u0027 % driver_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_23965696","line":470,"updated":"2018-06-06 11:00:10.000000000","message":"I wonder if this would be fixed.","commit_id":"2dca50e4383d152bbd7a2b9c30d9222186d99bf8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"319d176fef1ee80a517d18d1e433e0078d29a1af","unresolved":false,"context_lines":[{"line_number":467,"context_line":"    def test_driver_properties_fake(self, mock_topic, mock_properties):"},{"line_number":468,"context_line":"        # Can get driver properties for fake driver."},{"line_number":469,"context_line":"        driver._DRIVER_PROPERTIES \u003d {}"},{"line_number":470,"context_line":"        driver_name \u003d \u0027fake\u0027"},{"line_number":471,"context_line":"        mock_topic.return_value \u003d \u0027fake_topic\u0027"},{"line_number":472,"context_line":"        mock_properties.return_value \u003d {\u0027prop1\u0027: \u0027Property 1. Required.\u0027}"},{"line_number":473,"context_line":"        data \u003d self.get_json(\u0027/drivers/%s/properties\u0027 % driver_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_52a8fad7","line":470,"in_reply_to":"5f7c97a3_23965696","updated":"2018-06-06 14:08:20.000000000","message":"I don\u0027t think so, everything is completely mocked in this test","commit_id":"2dca50e4383d152bbd7a2b9c30d9222186d99bf8"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"a54ec7b130496ae8d22ff4aeabc13f0d76f0839a","unresolved":false,"context_lines":[{"line_number":501,"context_line":"        # only one RPC-conductor call will be made and the info cached"},{"line_number":502,"context_line":"        # for subsequent requests"},{"line_number":503,"context_line":"        driver._DRIVER_PROPERTIES \u003d {}"},{"line_number":504,"context_line":"        driver_name \u003d \u0027fake\u0027"},{"line_number":505,"context_line":"        mock_topic.return_value \u003d \u0027fake_topic\u0027"},{"line_number":506,"context_line":"        mock_properties.return_value \u003d {\u0027prop1\u0027: \u0027Property 1. Required.\u0027}"},{"line_number":507,"context_line":"        data \u003d self.get_json(\u0027/drivers/%s/properties\u0027 % driver_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_e38ffe72","line":504,"updated":"2018-06-06 11:00:10.000000000","message":"How about this?","commit_id":"2dca50e4383d152bbd7a2b9c30d9222186d99bf8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"319d176fef1ee80a517d18d1e433e0078d29a1af","unresolved":false,"context_lines":[{"line_number":501,"context_line":"        # only one RPC-conductor call will be made and the info cached"},{"line_number":502,"context_line":"        # for subsequent requests"},{"line_number":503,"context_line":"        driver._DRIVER_PROPERTIES \u003d {}"},{"line_number":504,"context_line":"        driver_name \u003d \u0027fake\u0027"},{"line_number":505,"context_line":"        mock_topic.return_value \u003d \u0027fake_topic\u0027"},{"line_number":506,"context_line":"        mock_properties.return_value \u003d {\u0027prop1\u0027: \u0027Property 1. Required.\u0027}"},{"line_number":507,"context_line":"        data \u003d self.get_json(\u0027/drivers/%s/properties\u0027 % driver_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_927f7265","line":504,"in_reply_to":"5f7c97a3_e38ffe72","updated":"2018-06-06 14:08:20.000000000","message":"Ditto, it\u0027s not the same \"fake\" driver. I can change it to \"test\" to avoid confusion.","commit_id":"2dca50e4383d152bbd7a2b9c30d9222186d99bf8"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ae6ef33db3bcbf4f96b0d0d30ef2957b217608b7","unresolved":false,"context_lines":[{"line_number":467,"context_line":"    def test_driver_properties_fake(self, mock_topic, mock_properties):"},{"line_number":468,"context_line":"        # Can get driver properties for fake driver."},{"line_number":469,"context_line":"        driver._DRIVER_PROPERTIES \u003d {}"},{"line_number":470,"context_line":"        driver_name \u003d \u0027test\u0027"},{"line_number":471,"context_line":"        mock_topic.return_value \u003d \u0027fake_topic\u0027"},{"line_number":472,"context_line":"        mock_properties.return_value \u003d {\u0027prop1\u0027: \u0027Property 1. Required.\u0027}"},{"line_number":473,"context_line":"        data \u003d self.get_json(\u0027/drivers/%s/properties\u0027 % driver_name)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_fa90f844","line":470,"updated":"2018-06-06 17:13:52.000000000","message":"How does this work?","commit_id":"7fcca34de6347b1f5c5eb76a292e7f50086a135a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"effc60626c5d152dcb6f656610df4dc7cb7074a1","unresolved":false,"context_lines":[{"line_number":467,"context_line":"    def test_driver_properties_fake(self, mock_topic, mock_properties):"},{"line_number":468,"context_line":"        # Can get driver properties for fake driver."},{"line_number":469,"context_line":"        driver._DRIVER_PROPERTIES \u003d {}"},{"line_number":470,"context_line":"        driver_name \u003d \u0027test\u0027"},{"line_number":471,"context_line":"        mock_topic.return_value \u003d \u0027fake_topic\u0027"},{"line_number":472,"context_line":"        mock_properties.return_value \u003d {\u0027prop1\u0027: \u0027Property 1. Required.\u0027}"},{"line_number":473,"context_line":"        data \u003d self.get_json(\u0027/drivers/%s/properties\u0027 % driver_name)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_5ad9ecf1","line":470,"in_reply_to":"5f7c97a3_fa90f844","updated":"2018-06-06 17:15:22.000000000","message":"The code path is completely mocked here IIUC, so no check on the driver reality is done.","commit_id":"7fcca34de6347b1f5c5eb76a292e7f50086a135a"}],"ironic/tests/unit/api/controllers/v1/test_node.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"a54ec7b130496ae8d22ff4aeabc13f0d76f0839a","unresolved":false,"context_lines":[{"line_number":1201,"context_line":""},{"line_number":1202,"context_line":"    def test_get_nodes_by_driver_invalid_api_version(self):"},{"line_number":1203,"context_line":"        response \u003d self.get_json("},{"line_number":1204,"context_line":"            \u0027/nodes?driver\u003dfake\u0027,"},{"line_number":1205,"context_line":"            headers\u003d{api_base.Version.string: str(api_v1.min_version())},"},{"line_number":1206,"context_line":"            expect_errors\u003dTrue)"},{"line_number":1207,"context_line":"        self.assertEqual(http_client.NOT_ACCEPTABLE, response.status_code)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_63dbee4e","line":1204,"range":{"start_line":1204,"start_character":27,"end_line":1204,"end_character":31},"updated":"2018-06-06 11:00:10.000000000","message":"nit: There is \u0027fake\u0027 driver though it doesn\u0027t matter.","commit_id":"2dca50e4383d152bbd7a2b9c30d9222186d99bf8"}],"ironic/tests/unit/common/test_driver_factory.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5622941392a398dd31d15374a84abe626170904f","unresolved":false,"context_lines":[{"line_number":420,"context_line":"    def test_get_hardware_type_missing(self):"},{"line_number":421,"context_line":"        self.config(enabled_drivers\u003d[\u0027fake_agent\u0027])"},{"line_number":422,"context_line":"        self.assertRaises(exception.DriverNotFound,"},{"line_number":423,"context_line":"                          # \"fake\" is a classic driver"},{"line_number":424,"context_line":"                          driver_factory.get_hardware_type, \u0027fake_agent\u0027)"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def test_get_driver_or_hardware_type(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_41d74a4c","line":423,"range":{"start_line":423,"start_character":29,"end_line":423,"end_character":33},"updated":"2018-05-30 16:05:47.000000000","message":"fake_agent","commit_id":"df3713cb6bbdbe1bde4443780edf1aad438ffd7b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ebf24dc5b226a1c1fa2f51929cc23e6a8153ede","unresolved":false,"context_lines":[{"line_number":420,"context_line":"    def test_get_hardware_type_missing(self):"},{"line_number":421,"context_line":"        self.config(enabled_drivers\u003d[\u0027fake_agent\u0027])"},{"line_number":422,"context_line":"        self.assertRaises(exception.DriverNotFound,"},{"line_number":423,"context_line":"                          # \"fake\" is a classic driver"},{"line_number":424,"context_line":"                          driver_factory.get_hardware_type, \u0027fake_agent\u0027)"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def test_get_driver_or_hardware_type(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_e16a16eb","line":423,"range":{"start_line":423,"start_character":29,"end_line":423,"end_character":33},"in_reply_to":"5f7c97a3_41d74a4c","updated":"2018-05-30 16:16:58.000000000","message":"Done","commit_id":"df3713cb6bbdbe1bde4443780edf1aad438ffd7b"}],"ironic/tests/unit/conductor/test_manager.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"a54ec7b130496ae8d22ff4aeabc13f0d76f0839a","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        self._test_associate_node(states.POWER_ON)"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"    def test_update_node_invalid_driver(self):"},{"line_number":551,"context_line":"        existing_driver \u003d \u0027fake\u0027"},{"line_number":552,"context_line":"        wrong_driver \u003d \u0027wrong-driver\u0027"},{"line_number":553,"context_line":"        node \u003d obj_utils.create_test_node(self.context,"},{"line_number":554,"context_line":"                                          driver\u003dexisting_driver,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_e3485e5d","line":551,"updated":"2018-06-06 11:00:10.000000000","message":"Should we fix it, too?","commit_id":"2dca50e4383d152bbd7a2b9c30d9222186d99bf8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"319d176fef1ee80a517d18d1e433e0078d29a1af","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        self._test_associate_node(states.POWER_ON)"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"    def test_update_node_invalid_driver(self):"},{"line_number":551,"context_line":"        existing_driver \u003d \u0027fake\u0027"},{"line_number":552,"context_line":"        wrong_driver \u003d \u0027wrong-driver\u0027"},{"line_number":553,"context_line":"        node \u003d obj_utils.create_test_node(self.context,"},{"line_number":554,"context_line":"                                          driver\u003dexisting_driver,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_12b92214","line":551,"in_reply_to":"5f7c97a3_e3485e5d","updated":"2018-06-06 14:08:20.000000000","message":"I guess it does not matter for this test, but lemme fix it.","commit_id":"2dca50e4383d152bbd7a2b9c30d9222186d99bf8"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"a54ec7b130496ae8d22ff4aeabc13f0d76f0839a","unresolved":false,"context_lines":[{"line_number":7336,"context_line":"        task \u003d task_manager.TaskManager(self.context, node.uuid)"},{"line_number":7337,"context_line":"        mock_acquire.side_effect \u003d self._get_acquire_side_effect(task)"},{"line_number":7338,"context_line":"        mock_abort.side_effect \u003d exception.UnsupportedDriverExtension("},{"line_number":7339,"context_line":"            driver\u003d\u0027fake\u0027, extension\u003d\u0027inspect\u0027)"},{"line_number":7340,"context_line":"        self._start_service()"},{"line_number":7341,"context_line":"        exc \u003d self.assertRaises(messaging.rpc.ExpectedException,"},{"line_number":7342,"context_line":"                                self.service.do_provisioning_action,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_032f9a88","line":7339,"range":{"start_line":7339,"start_character":12,"end_line":7339,"end_character":25},"updated":"2018-06-06 11:00:10.000000000","message":"nit: I saw a similar message fixed somewhere in this patch.","commit_id":"2dca50e4383d152bbd7a2b9c30d9222186d99bf8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"319d176fef1ee80a517d18d1e433e0078d29a1af","unresolved":false,"context_lines":[{"line_number":7336,"context_line":"        task \u003d task_manager.TaskManager(self.context, node.uuid)"},{"line_number":7337,"context_line":"        mock_acquire.side_effect \u003d self._get_acquire_side_effect(task)"},{"line_number":7338,"context_line":"        mock_abort.side_effect \u003d exception.UnsupportedDriverExtension("},{"line_number":7339,"context_line":"            driver\u003d\u0027fake\u0027, extension\u003d\u0027inspect\u0027)"},{"line_number":7340,"context_line":"        self._start_service()"},{"line_number":7341,"context_line":"        exc \u003d self.assertRaises(messaging.rpc.ExpectedException,"},{"line_number":7342,"context_line":"                                self.service.do_provisioning_action,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_124e0238","line":7339,"range":{"start_line":7339,"start_character":12,"end_line":7339,"end_character":25},"in_reply_to":"5f7c97a3_032f9a88","updated":"2018-06-06 14:08:20.000000000","message":"Done","commit_id":"2dca50e4383d152bbd7a2b9c30d9222186d99bf8"}],"ironic/tests/unit/drivers/test_utils.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5622941392a398dd31d15374a84abe626170904f","unresolved":false,"context_lines":[{"line_number":365,"context_line":"                        \u0027second_method\u0027: self.b,"},{"line_number":366,"context_line":"                        \u0027third_method_sync\u0027: self.b,"},{"line_number":367,"context_line":"                        \u0027fourth_method_shared_lock\u0027: self.b}"},{"line_number":368,"context_line":"        self.vendor \u003d driver_utils.MixinVendorInterface(self.mapping)"},{"line_number":369,"context_line":"        self.node \u003d obj_utils.create_test_node(self.context,"},{"line_number":370,"context_line":"                                               driver\u003d\u0027fake-hardware\u0027)"},{"line_number":371,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_0101526a","line":368,"updated":"2018-05-30 16:05:47.000000000","message":"iirc hardware types do not support mixin vendor interfaces, so why add this?","commit_id":"df3713cb6bbdbe1bde4443780edf1aad438ffd7b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ebf24dc5b226a1c1fa2f51929cc23e6a8153ede","unresolved":false,"context_lines":[{"line_number":365,"context_line":"                        \u0027second_method\u0027: self.b,"},{"line_number":366,"context_line":"                        \u0027third_method_sync\u0027: self.b,"},{"line_number":367,"context_line":"                        \u0027fourth_method_shared_lock\u0027: self.b}"},{"line_number":368,"context_line":"        self.vendor \u003d driver_utils.MixinVendorInterface(self.mapping)"},{"line_number":369,"context_line":"        self.node \u003d obj_utils.create_test_node(self.context,"},{"line_number":370,"context_line":"                                               driver\u003d\u0027fake-hardware\u0027)"},{"line_number":371,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_41518a35","line":368,"in_reply_to":"5f7c97a3_0101526a","updated":"2018-05-30 16:16:58.000000000","message":"We don\u0027t use mixin vendor interfaces with hardware types, but somebody probably might. I guess this class has to go through formal deprecation to be removed.","commit_id":"df3713cb6bbdbe1bde4443780edf1aad438ffd7b"}]}
