)]}'
{"doc/source/admin/notifications.rst":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3e096f453e2f4e0a1582519ec0c139a7d6dae2db","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    \"payload\":{"},{"line_number":133,"context_line":"        \"ironic_object.namespace\":\"ironic\","},{"line_number":134,"context_line":"        \"ironic_object.name\":\"NodeCRUDPayload\","},{"line_number":135,"context_line":"        \"ironic_object.version\":\"1.5\","},{"line_number":136,"context_line":"        \"ironic_object.data\":{"},{"line_number":137,"context_line":"            \"chassis_uuid\": \"db0eef9d-45b2-4dc0-94a8-fc283c01171f\","},{"line_number":138,"context_line":"            \"clean_step\": None,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_cc8b0f1c","line":135,"updated":"2018-06-06 13:16:10.000000000","message":"this should be 1.7. Not sure why it was stuck at 1.4","commit_id":"88a4c04bb5147a219403e2e5964f7ecdf2323fa3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0c715c3f6bfb251a88bd5220d82e156a78972990","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    \"payload\":{"},{"line_number":133,"context_line":"        \"ironic_object.namespace\":\"ironic\","},{"line_number":134,"context_line":"        \"ironic_object.name\":\"NodeCRUDPayload\","},{"line_number":135,"context_line":"        \"ironic_object.version\":\"1.5\","},{"line_number":136,"context_line":"        \"ironic_object.data\":{"},{"line_number":137,"context_line":"            \"chassis_uuid\": \"db0eef9d-45b2-4dc0-94a8-fc283c01171f\","},{"line_number":138,"context_line":"            \"clean_step\": None,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_573a2cc4","line":135,"in_reply_to":"5f7c97a3_cc8b0f1c","updated":"2018-06-06 13:23:04.000000000","message":"My bad. This is 1.5.","commit_id":"88a4c04bb5147a219403e2e5964f7ecdf2323fa3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3e096f453e2f4e0a1582519ec0c139a7d6dae2db","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            \"instance_uuid\": None,"},{"line_number":150,"context_line":"            \"last_error\": None,"},{"line_number":151,"context_line":"            \"maintenance\": False,"},{"line_number":152,"context_line":"            \"maintenance_reason\": None,"},{"line_number":153,"context_line":"            \"boot_interface\": \"pxe\","},{"line_number":154,"context_line":"            \"console_interface\": \"no-console\","},{"line_number":155,"context_line":"            \"deploy_interface\": \"iscsi\","}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_8c85170a","line":152,"updated":"2018-06-06 13:16:10.000000000","message":"we should add fault here","commit_id":"88a4c04bb5147a219403e2e5964f7ecdf2323fa3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3e096f453e2f4e0a1582519ec0c139a7d6dae2db","unresolved":false,"context_lines":[{"line_number":580,"context_line":"    \"payload\":{"},{"line_number":581,"context_line":"        \"ironic_object.namespace\":\"ironic\","},{"line_number":582,"context_line":"        \"ironic_object.name\":\"NodeCorrectedPowerStatePayload\","},{"line_number":583,"context_line":"        \"ironic_object.version\":\"1.6\","},{"line_number":584,"context_line":"        \"ironic_object.data\":{"},{"line_number":585,"context_line":"            \"clean_step\": None,"},{"line_number":586,"context_line":"            \"console_enabled\": False,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_6cfe7b6c","line":583,"updated":"2018-06-06 13:16:10.000000000","message":"1.7","commit_id":"88a4c04bb5147a219403e2e5964f7ecdf2323fa3"}],"ironic/tests/unit/api/controllers/v1/test_node.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3e096f453e2f4e0a1582519ec0c139a7d6dae2db","unresolved":false,"context_lines":[{"line_number":1308,"context_line":"                                 headers\u003d{api_base.Version.string: \"1.42\"})"},{"line_number":1309,"context_line":"            uuids \u003d [n[\u0027uuid\u0027] for n in data[\u0027nodes\u0027]]"},{"line_number":1310,"context_line":"            self.assertIn(node1.uuid, uuids)"},{"line_number":1311,"context_line":"            self.assertNotIn(node2.uuid, uuids)"},{"line_number":1312,"context_line":"            data \u003d self.get_json(base_url + \u0027?fault\u003dclean failure\u0027,"},{"line_number":1313,"context_line":"                                 headers\u003d{api_base.Version.string: \"1.42\"})"},{"line_number":1314,"context_line":"            uuids \u003d [n[\u0027uuid\u0027] for n in data[\u0027nodes\u0027]]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_ecfb6b44","line":1311,"updated":"2018-06-06 13:16:10.000000000","message":"we can actually be more exact and replace these two with self.assertEqual([node1.uuid], uuids) ?","commit_id":"88a4c04bb5147a219403e2e5964f7ecdf2323fa3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3e096f453e2f4e0a1582519ec0c139a7d6dae2db","unresolved":false,"context_lines":[{"line_number":1316,"context_line":"            self.assertNotIn(node1.uuid, uuids)"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"    def test_get_nodes_by_fault_not_allowed(self):"},{"line_number":1319,"context_line":"        for url in (\u0027/nodes?fault\u003dtest\u0027, \u0027/nodes/detail?fault\u003dtest\u0027):"},{"line_number":1320,"context_line":"            response \u003d self.get_json("},{"line_number":1321,"context_line":"                url, headers\u003d{api_base.Version.string: \"1.41\"},"},{"line_number":1322,"context_line":"                expect_errors\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_0c4907b6","line":1319,"updated":"2018-06-06 13:16:10.000000000","message":"makes me wonder if we should also check the value of fault, there are only a few possible values, and it would be good to give the user feedback if the value is unacceptable. Otherwise I suspect what will happen is that they\u0027ll specify some string and get 0 nodes back, and not know that it was due to a bad value.","commit_id":"88a4c04bb5147a219403e2e5964f7ecdf2323fa3"}]}