)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"729293db97c2371e7c7009948f06c132f51577be","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SQLite backend used in unit tests, but unique constraint for \u0027address\u0027"},{"line_number":10,"context_line":"column in \u0027ports\u0027 table not working for this backend. Patch fix this"},{"line_number":11,"context_line":"and also unit tests which violates \u0027address\u0027 UC."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1252343"},{"line_number":14,"context_line":"Change-Id: I761e480c99f1687531cf4c64a64c02faa7e4fb73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2BoFU%3D","line":11,"updated":"2013-11-22 10:07:25.000000000","message":"maybe it makes a sense to split this patch?","commit_id":"b334510ce541f8579ee249218491d549920550e8"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e3a6291a0a94b5e996e09f2948136d4c89b1d97b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SQLite backend used in unit tests, but unique constraint for \u0027address\u0027"},{"line_number":10,"context_line":"column in \u0027ports\u0027 table not working for this backend. Patch fix this"},{"line_number":11,"context_line":"and also unit tests which violates \u0027address\u0027 UC."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1252343"},{"line_number":14,"context_line":"Change-Id: I761e480c99f1687531cf4c64a64c02faa7e4fb73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2BnpI%3D","line":11,"in_reply_to":"AAAATn%2F%2BoFU%3D","updated":"2013-11-22 11:41:15.000000000","message":"This is not a big patch, I think no sense.","commit_id":"b334510ce541f8579ee249218491d549920550e8"}],"ironic/db/sqlalchemy/migrate_repo/versions/001_init.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"a13d8b68bc3e4482bf70568243c21eb65e2d23c7","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                            name\u003d\u0027iface_address_ux\u0027),"},{"line_number":86,"context_line":"    ]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    if migrate_engine.name \u003d\u003d \u0027mysql\u0027 or migrate_engine.name \u003d\u003d \u0027postgresql\u0027:"},{"line_number":89,"context_line":"        for index in indexes:"},{"line_number":90,"context_line":"            index.create(migrate_engine)"},{"line_number":91,"context_line":"        for index in uniques:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Bowk%3D","side":"PARENT","line":88,"updated":"2013-11-22 06:33:45.000000000","message":"Yuriy Zveryanskyy, I think it better we add new support for \u0027sqlite\u0027 database in the condition, else, if we have no such if-branch, that mean we support all database, but we can not test all database type out, how do you think?","commit_id":"01a43e71980cb8aaf45d24d8b7665a15766a31ad"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"ae8675cdfa96c276f610b6d745b15c3abd02a85a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                            name\u003d\u0027iface_address_ux\u0027),"},{"line_number":86,"context_line":"    ]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    if migrate_engine.name \u003d\u003d \u0027mysql\u0027 or migrate_engine.name \u003d\u003d \u0027postgresql\u0027:"},{"line_number":89,"context_line":"        for index in indexes:"},{"line_number":90,"context_line":"            index.create(migrate_engine)"},{"line_number":91,"context_line":"        for index in uniques:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BoL0%3D","side":"PARENT","line":88,"in_reply_to":"AAAATn%2F%2Bowk%3D","updated":"2013-11-22 09:23:31.000000000","message":"Agree with backends separation for this.","commit_id":"01a43e71980cb8aaf45d24d8b7665a15766a31ad"}],"ironic/db/sqlalchemy/migrate_repo/versions/014_add_address_uc_sqlite.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"27a15d36521dd372d2a899db44fb8370538f1f8d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"# -*- encoding: utf-8 -*-"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BaNQ%3D","line":3,"updated":"2013-11-26 12:16:17.000000000","message":"Missing copyright claim here.","commit_id":"1a0b0a6355246256ecc47e537098a7cbf965d810"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"e94aa86d6e9b71ca92a04d6858fdfcc7f83287d7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"# -*- encoding: utf-8 -*-"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BZ1Q%3D","line":3,"in_reply_to":"AAAATn%2F%2BaEw%3D","updated":"2013-11-26 13:52:13.000000000","message":"Yuriy, ok, that is fine for me.","commit_id":"1a0b0a6355246256ecc47e537098a7cbf965d810"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"6f279d9f1cc23a7948efaaa73b98b9a07c471b32","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"# -*- encoding: utf-8 -*-"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BaEw%3D","line":3,"in_reply_to":"AAAATn%2F%2BaNQ%3D","updated":"2013-11-26 12:45:19.000000000","message":"Haomeng, copyright notice is not required.\n\nhttps://wiki.openstack.org/wiki/LegalIssuesFAQ","commit_id":"1a0b0a6355246256ecc47e537098a7cbf965d810"}],"ironic/tests/db/sqlalchemy/test_migrations.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"729293db97c2371e7c7009948f06c132f51577be","unresolved":false,"context_lines":[{"line_number":656,"context_line":"            {\u0027address\u0027: \u0027address1\u0027, \u0027node_id\u0027: 1, \u0027uuid\u0027: \u0027uuu-222\u0027,"},{"line_number":657,"context_line":"             \u0027extra\u0027: \u0027extra3\u0027})"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        # test recreate old UC"},{"line_number":660,"context_line":"        ports_data \u003d {\u0027address\u0027: \u0027BB:BB:AA:AA:AA:AA\u0027, \u0027extra\u0027: \u0027extra1\u0027}"},{"line_number":661,"context_line":"        ports.insert().values(ports_data).execute()"},{"line_number":662,"context_line":"        self.assertRaises(sqlalchemy.exc.IntegrityError,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BoEg%3D","line":659,"updated":"2013-11-22 10:07:25.000000000","message":"We are recreate old UC only in SQLite, so maybe it makes a sense to this check seems to be a little redundant for another backends.","commit_id":"b334510ce541f8579ee249218491d549920550e8"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e3a6291a0a94b5e996e09f2948136d4c89b1d97b","unresolved":false,"context_lines":[{"line_number":656,"context_line":"            {\u0027address\u0027: \u0027address1\u0027, \u0027node_id\u0027: 1, \u0027uuid\u0027: \u0027uuu-222\u0027,"},{"line_number":657,"context_line":"             \u0027extra\u0027: \u0027extra3\u0027})"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        # test recreate old UC"},{"line_number":660,"context_line":"        ports_data \u003d {\u0027address\u0027: \u0027BB:BB:AA:AA:AA:AA\u0027, \u0027extra\u0027: \u0027extra1\u0027}"},{"line_number":661,"context_line":"        ports.insert().values(ports_data).execute()"},{"line_number":662,"context_line":"        self.assertRaises(sqlalchemy.exc.IntegrityError,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BnpU%3D","line":659,"in_reply_to":"AAAATn%2F%2BoEg%3D","updated":"2013-11-22 11:41:15.000000000","message":"Agree.","commit_id":"b334510ce541f8579ee249218491d549920550e8"}]}