)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"4e3f5d07def7f6dbdeea3ce21f8e7a8ac8ec0cd2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dmitry Tantsur \u003cdivius.inside@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-22 17:26:04 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove the iDrac classic drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This removes the pxe_drac and pxe_drac_inspector classic drivers."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_c8dab677","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":16},"updated":"2018-06-22 22:56:16.000000000","message":"nit: How about \u0027Dell EMC iDRAC\u0027 or \u0027iDRAC\u0027, instead? Seems like the name should be correct in the obituary ;)","commit_id":"7fa14b027492352b8faf1e662fedbbbe5b0e4835"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5a74a92722c8533a10668f66b0e55800912a523f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dmitry Tantsur \u003cdivius.inside@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-22 17:26:04 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove the iDrac classic drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This removes the pxe_drac and pxe_drac_inspector classic drivers."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_61fe06b0","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":16},"in_reply_to":"5f7c97a3_c8dab677","updated":"2018-06-25 12:31:54.000000000","message":"Done","commit_id":"7fa14b027492352b8faf1e662fedbbbe5b0e4835"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"4e3f5d07def7f6dbdeea3ce21f8e7a8ac8ec0cd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f7c97a3_4bc54009","line":12,"updated":"2018-06-22 22:56:16.000000000","message":"Should this be linked to a story and task?","commit_id":"7fa14b027492352b8faf1e662fedbbbe5b0e4835"}],"devstack/lib/ironic":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"4e3f5d07def7f6dbdeea3ce21f8e7a8ac8ec0cd2","unresolved":false,"context_lines":[{"line_number":293,"context_line":"#"},{"line_number":294,"context_line":"# Additional valid choices if IRONIC_IS_HARDWARE \u003d\u003d true are:"},{"line_number":295,"context_line":"# ``pxe_iscsi_cimc``, ``pxe_agent_cimc``, ``pxe_ucs``, ``pxe_cimc``,"},{"line_number":296,"context_line":"# ``*_pxe_oneview`` and ``pxe_drac``"},{"line_number":297,"context_line":"IRONIC_DEPLOY_DRIVER\u003d${IRONIC_DEPLOY_DRIVER:-pxe_ipmitool}"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"# If the requested driver is not yet enable, enable it, if it is not it will fail anyway"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_8b1598e8","line":296,"range":{"start_line":296,"start_character":24,"end_line":296,"end_character":36},"updated":"2018-06-22 22:56:16.000000000","message":"Not any more :(","commit_id":"7fa14b027492352b8faf1e662fedbbbe5b0e4835"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5a74a92722c8533a10668f66b0e55800912a523f","unresolved":false,"context_lines":[{"line_number":293,"context_line":"#"},{"line_number":294,"context_line":"# Additional valid choices if IRONIC_IS_HARDWARE \u003d\u003d true are:"},{"line_number":295,"context_line":"# ``pxe_iscsi_cimc``, ``pxe_agent_cimc``, ``pxe_ucs``, ``pxe_cimc``,"},{"line_number":296,"context_line":"# ``*_pxe_oneview`` and ``pxe_drac``"},{"line_number":297,"context_line":"IRONIC_DEPLOY_DRIVER\u003d${IRONIC_DEPLOY_DRIVER:-pxe_ipmitool}"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"# If the requested driver is not yet enable, enable it, if it is not it will fail anyway"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_e123f656","line":296,"range":{"start_line":296,"start_character":24,"end_line":296,"end_character":36},"in_reply_to":"5f7c97a3_8b1598e8","updated":"2018-06-25 12:31:54.000000000","message":"Done","commit_id":"7fa14b027492352b8faf1e662fedbbbe5b0e4835"}],"doc/source/admin/drivers/idrac.rst":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"4e3f5d07def7f6dbdeea3ce21f8e7a8ac8ec0cd2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"Overview"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"iDRAC_ hardware is supported by the ``idrac`` hardware type. It is also"},{"line_number":9,"context_line":"supported by the standard ``ipmi`` hardware type, though with a smaller"},{"line_number":10,"context_line":"feature set."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. TODO(dtantsur): supported hardware"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_a812dafb","line":10,"range":{"start_line":8,"start_character":61,"end_line":10,"end_character":12},"updated":"2018-06-22 22:56:16.000000000","message":"While we\u0027re at it, could we mention that it\u0027s supported by the redfish hardware type?","commit_id":"7fa14b027492352b8faf1e662fedbbbe5b0e4835"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5a74a92722c8533a10668f66b0e55800912a523f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"Overview"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"iDRAC_ hardware is supported by the ``idrac`` hardware type. It is also"},{"line_number":9,"context_line":"supported by the standard ``ipmi`` hardware type, though with a smaller"},{"line_number":10,"context_line":"feature set."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. TODO(dtantsur): supported hardware"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_811242fc","line":10,"range":{"start_line":8,"start_character":61,"end_line":10,"end_character":12},"in_reply_to":"5f7c97a3_a812dafb","updated":"2018-06-25 12:31:54.000000000","message":"Please follow-up with unrelated changes.","commit_id":"7fa14b027492352b8faf1e662fedbbbe5b0e4835"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"4e3f5d07def7f6dbdeea3ce21f8e7a8ac8ec0cd2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Enabling"},{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"All iDRAC drivers require the ``python-dracclient`` library to be installed,"},{"line_number":18,"context_line":"for example::"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d1.3.0\u0027"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_489f8664","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":75},"updated":"2018-06-22 22:56:16.000000000","message":"Hrm, actually, only the idrac hardware type requires that.","commit_id":"7fa14b027492352b8faf1e662fedbbbe5b0e4835"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5a74a92722c8533a10668f66b0e55800912a523f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Enabling"},{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"All iDRAC drivers require the ``python-dracclient`` library to be installed,"},{"line_number":18,"context_line":"for example::"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d1.3.0\u0027"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_21d32e3a","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":75},"in_reply_to":"5f7c97a3_489f8664","updated":"2018-06-25 12:31:54.000000000","message":"Done","commit_id":"7fa14b027492352b8faf1e662fedbbbe5b0e4835"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"4e3f5d07def7f6dbdeea3ce21f8e7a8ac8ec0cd2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"the Ironic power state poll interval to 70 seconds.  See"},{"line_number":67,"context_line":"``[conductor]sync_power_state_interval`` in ``/etc/ironic/ironic.conf``."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":".. _iDRAC: http://www.dell.com/learn/us/en/15/solutions/integrated-dell-remote-access-controller-idrac"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_ab6df42f","line":69,"range":{"start_line":69,"start_character":11,"end_line":69,"end_character":102},"updated":"2018-06-22 22:56:16.000000000","message":"This gets redirected to https://www.dell.com/en-us/work/learn/openmanage-embedded-technology","commit_id":"7fa14b027492352b8faf1e662fedbbbe5b0e4835"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5a74a92722c8533a10668f66b0e55800912a523f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"the Ironic power state poll interval to 70 seconds.  See"},{"line_number":67,"context_line":"``[conductor]sync_power_state_interval`` in ``/etc/ironic/ironic.conf``."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":".. _iDRAC: http://www.dell.com/learn/us/en/15/solutions/integrated-dell-remote-access-controller-idrac"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_01dcf242","line":69,"range":{"start_line":69,"start_character":11,"end_line":69,"end_character":102},"in_reply_to":"5f7c97a3_ab6df42f","updated":"2018-06-25 12:31:54.000000000","message":"Please follow-up with unrelated changes.","commit_id":"7fa14b027492352b8faf1e662fedbbbe5b0e4835"}],"doc/source/install/enabling-drivers.rst":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"e0abd0b0dde5df4b76c68cb847e7cf5bd3f4cddf","unresolved":false,"context_lines":[{"line_number":311,"context_line":".. code-block:: ini"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    [DEFAULT]"},{"line_number":314,"context_line":"    enabled_drivers \u003d pxe_ipmitool"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"The names in this comma-separated list are entry point names of the drivers."},{"line_number":317,"context_line":"They have to be available at conductor start-up, and all dependencies must"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_36bcd1da","line":314,"range":{"start_line":314,"start_character":4,"end_line":314,"end_character":34},"updated":"2018-06-25 14:42:35.000000000","message":"I thought that we deprecate classic drivers. Not sure why we keep pxe_ipmitool then.","commit_id":"3e2323406978b5446e7036a9f779d2c78b919e07"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5590a7023bba7c9308560dc9b531694d5728e35f","unresolved":false,"context_lines":[{"line_number":311,"context_line":".. code-block:: ini"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    [DEFAULT]"},{"line_number":314,"context_line":"    enabled_drivers \u003d pxe_ipmitool"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"The names in this comma-separated list are entry point names of the drivers."},{"line_number":317,"context_line":"They have to be available at conductor start-up, and all dependencies must"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_d65a3d4e","line":314,"range":{"start_line":314,"start_character":4,"end_line":314,"end_character":34},"in_reply_to":"5f7c97a3_36bcd1da","updated":"2018-06-25 14:56:36.000000000","message":"it will be removed in its turn :)","commit_id":"3e2323406978b5446e7036a9f779d2c78b919e07"}],"ironic/tests/unit/drivers/test_drac.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"4e3f5d07def7f6dbdeea3ce21f8e7a8ac8ec0cd2","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        driver \u003d drac_drivers.PXEDracDriver()"},{"line_number":151,"context_line":"        self._validate_interfaces(driver)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def test___init___try_import_dracclient_failure(self, mock_try_import):"},{"line_number":154,"context_line":"        mock_try_import.return_value \u003d False"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        self.assertRaises(exception.DriverLoadError,"},{"line_number":157,"context_line":"                          drac_drivers.PXEDracDriver)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_pxe_drac_inspector_driver(self, mock_try_import):"},{"line_number":160,"context_line":"        self.config(enabled\u003dTrue, group\u003d\u0027inspector\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_cb6710ea","side":"PARENT","line":157,"range":{"start_line":153,"start_character":0,"end_line":157,"end_character":53},"updated":"2018-06-22 22:56:16.000000000","message":"The removal of this makes me wonder if this test should be added to class IDRACHardwareTestCase. All of the modules in .../ironic/drivers/modules/drac directly or indirectly import the dracclient. Thoughts?","commit_id":"9c7729d6b78598fbb8cae3ea366072978a98a68b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5a74a92722c8533a10668f66b0e55800912a523f","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        driver \u003d drac_drivers.PXEDracDriver()"},{"line_number":151,"context_line":"        self._validate_interfaces(driver)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def test___init___try_import_dracclient_failure(self, mock_try_import):"},{"line_number":154,"context_line":"        mock_try_import.return_value \u003d False"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        self.assertRaises(exception.DriverLoadError,"},{"line_number":157,"context_line":"                          drac_drivers.PXEDracDriver)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_pxe_drac_inspector_driver(self, mock_try_import):"},{"line_number":160,"context_line":"        self.config(enabled\u003dTrue, group\u003d\u0027inspector\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_01839204","side":"PARENT","line":157,"range":{"start_line":153,"start_character":0,"end_line":157,"end_character":53},"in_reply_to":"5f7c97a3_cb6710ea","updated":"2018-06-25 12:31:54.000000000","message":"yeah, but the import happens at module import time, making it tricky to unit test. The specific hardware interfaces to not check the import result, and this probably should be fixed eventually","commit_id":"9c7729d6b78598fbb8cae3ea366072978a98a68b"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"4e3f5d07def7f6dbdeea3ce21f8e7a8ac8ec0cd2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2017 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_28348a48","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2018-06-22 22:56:16.000000000","message":"2017-2018","commit_id":"7fa14b027492352b8faf1e662fedbbbe5b0e4835"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5a74a92722c8533a10668f66b0e55800912a523f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2017 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_81e7a20f","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"5f7c97a3_28348a48","updated":"2018-06-25 12:31:54.000000000","message":"I cannot update your copyright, since I\u0027m not the Dell EMC employee","commit_id":"7fa14b027492352b8faf1e662fedbbbe5b0e4835"}],"releasenotes/notes/no-classic-idrac-4fbf1ba66c35fb4a.yaml":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"4e3f5d07def7f6dbdeea3ce21f8e7a8ac8ec0cd2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The deprecated iDrac classic drivers ``pxe_drac`` and"},{"line_number":5,"context_line":"    ``pxe_drac_inspector`` have been removed. Please use the ``idrac``"},{"line_number":6,"context_line":"    hardware type."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_4b99c0cd","line":4,"range":{"start_line":4,"start_character":19,"end_line":4,"end_character":24},"updated":"2018-06-22 22:56:16.000000000","message":"Ditto, as commented about in the commit message.","commit_id":"7fa14b027492352b8faf1e662fedbbbe5b0e4835"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5a74a92722c8533a10668f66b0e55800912a523f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The deprecated iDrac classic drivers ``pxe_drac`` and"},{"line_number":5,"context_line":"    ``pxe_drac_inspector`` have been removed. Please use the ``idrac``"},{"line_number":6,"context_line":"    hardware type."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_01b152e0","line":4,"range":{"start_line":4,"start_character":19,"end_line":4,"end_character":24},"in_reply_to":"5f7c97a3_4b99c0cd","updated":"2018-06-25 12:31:54.000000000","message":"Done","commit_id":"7fa14b027492352b8faf1e662fedbbbe5b0e4835"}]}