)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"97cb978bb4b85f00b96536060e139e1f949983b8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to update the node\u0027s copy. However, it is possible that the"},{"line_number":12,"context_line":"node\u0027s driver_internal_info is modified after the copy is made."},{"line_number":13,"context_line":"This patch changes it to use the current node\u0027s driver_internal_info."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I92ad67b58343e5c6c1cca916269f134a5c78dcc6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_e0bb02c1","line":14,"updated":"2018-06-23 10:24:12.000000000","message":"Any story to link to? We may want this backported","commit_id":"8effd90f96bbdf27eb454b6282c575449f39027a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"146078c0d59e31cbcb804a8623517ff8b872639f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to update the node\u0027s copy. However, it is possible that the"},{"line_number":12,"context_line":"node\u0027s driver_internal_info is modified after the copy is made."},{"line_number":13,"context_line":"This patch changes it to use the current node\u0027s driver_internal_info."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I92ad67b58343e5c6c1cca916269f134a5c78dcc6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_3614d19f","line":14,"in_reply_to":"5f7c97a3_e0bb02c1","updated":"2018-06-25 14:47:35.000000000","message":"+1, I\u0027m thinking we need to go ahead and backport this because it does seem like a fundamental error, albeit small since we\u0027ve not found it or had reports of it yet.","commit_id":"8effd90f96bbdf27eb454b6282c575449f39027a"}],"ironic/conductor/manager.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"eedbed31e7cd377203eea174cc737631f331300a","unresolved":false,"context_lines":[{"line_number":1264,"context_line":"            # Save which step we\u0027re about to start so we can restart"},{"line_number":1265,"context_line":"            # if necessary"},{"line_number":1266,"context_line":"            node.clean_step \u003d step"},{"line_number":1267,"context_line":"            driver_internal_info \u003d node.driver_internal_info"},{"line_number":1268,"context_line":"            driver_internal_info[\u0027clean_step_index\u0027] \u003d step_index + ind"},{"line_number":1269,"context_line":"            node.driver_internal_info \u003d driver_internal_info"},{"line_number":1270,"context_line":"            node.save()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_6c5fd60e","line":1267,"updated":"2018-06-25 15:43:52.000000000","message":"does this cover the case when inside the execute_clean_step call the code does\n\n dii \u003d task.node.driver_internal_info\n dii[\u0027abc\u0027] \u003d 123\n task.node.driver_internal_info \u003d dii\n\n? If so, the assignment as it was before should work right? as driver_internal_info here is still the same reference as dii inside the execute_clean_step? or you want to cover the case of someone doing\n\n dii \u003d copy.deepcopy(task.node.driver_internal_info)\n ...\n task.node.driver_internal_info \u003d dii","commit_id":"8effd90f96bbdf27eb454b6282c575449f39027a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"18d7d687db7707c696821a46e7542096d626bacf","unresolved":false,"context_lines":[{"line_number":1264,"context_line":"            # Save which step we\u0027re about to start so we can restart"},{"line_number":1265,"context_line":"            # if necessary"},{"line_number":1266,"context_line":"            node.clean_step \u003d step"},{"line_number":1267,"context_line":"            driver_internal_info \u003d node.driver_internal_info"},{"line_number":1268,"context_line":"            driver_internal_info[\u0027clean_step_index\u0027] \u003d step_index + ind"},{"line_number":1269,"context_line":"            node.driver_internal_info \u003d driver_internal_info"},{"line_number":1270,"context_line":"            node.save()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4f2e8cfa","line":1267,"in_reply_to":"5f7c97a3_6c5fd60e","updated":"2018-06-25 16:43:18.000000000","message":"Not a dumb question :) Discussed with Vladyslav on irc [1]. Yes, if the code in the invoked method does a deepcopy OR if the code does a node.save().\n\n[1] http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2018-06-25.log.html#t2018-06-25T16:21:10","commit_id":"8effd90f96bbdf27eb454b6282c575449f39027a"}],"tox.ini":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fd0a2a9f3f5cd37f41c9c8b41e8a572bc68365af","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    -r{toxinidir}/driver-requirements.txt"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[testenv:genstates]"},{"line_number":26,"context_line":"basepython \u003d python2"},{"line_number":27,"context_line":"deps \u003d {[testenv]deps}"},{"line_number":28,"context_line":"    pydot2"},{"line_number":29,"context_line":"commands \u003d {toxinidir}/tools/states_to_dot.py -f {toxinidir}/doc/source/images/states.svg --format svg"}],"source_content_type":"text/x-properties","patch_set":2,"id":"5f7c97a3_7aad3182","line":26,"range":{"start_line":26,"start_character":13,"end_line":26,"end_character":20},"updated":"2018-06-26 14:04:02.000000000","message":"We shouldn\u0027t be changing our base python back to python2. We should remain on python3.","commit_id":"dad5f1f584b24d8a340e6fbaa2aff67a1b5cc07d"}]}