)]}'
{"ironic/common/pxe_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cd7651f414cbc6a11a7ccf3f35c3a4fa2e973665","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    \"\"\""},{"line_number":134,"context_line":"    mac_file_name \u003d mac.replace(\u0027:\u0027, delimiter).lower()"},{"line_number":135,"context_line":"    if not (CONF.pxe.ipxe_enabled or CONF.pxe.uefi_use_mac_address):"},{"line_number":136,"context_line":"        hw_type \u003d \u002701-\u0027"},{"line_number":137,"context_line":"        if client_id:"},{"line_number":138,"context_line":"            hw_type \u003d \u002720-\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a922aa52","line":135,"range":{"start_line":135,"start_character":33,"end_line":135,"end_character":67},"updated":"2018-07-09 17:40:16.000000000","message":"User reported that the hw_type is still posted with grub (which is not really documented anywhere anyway. We should prepend with \"01-\" as well.","commit_id":"7d6ae9bdcae3852bb122c933d4472dcc21bd39b8"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"962181594f0d9ca20756b4ba854e0a0dc2e593d3","unresolved":false,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    if is_uefi_boot_mode and not CONF.pxe.ipxe_enabled:"},{"line_number":263,"context_line":"        # Always write the mac addresses"},{"line_number":264,"context_line":"        _link_mac_pxe_configs(task)"},{"line_number":265,"context_line":"        try:"},{"line_number":266,"context_line":"            _link_ip_address_pxe_configs(task, hex_form)"},{"line_number":267,"context_line":"        # NOTE(TheJulia): The IP address support will fail if the"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_d5706faa","line":264,"range":{"start_line":264,"start_character":8,"end_line":264,"end_character":34},"updated":"2018-07-25 10:23:29.000000000","message":"nit: this line seems to duplicate line #279. Could they be merged perhaps by narrowing down the condition at line #262?","commit_id":"eef2e968f37c8c83d2ada182af1e6e4c078452bb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"34ec4b56f46afbb757cac8349d623dab5aada93a","unresolved":false,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    if is_uefi_boot_mode and not CONF.pxe.ipxe_enabled:"},{"line_number":263,"context_line":"        # Always write the mac addresses"},{"line_number":264,"context_line":"        _link_mac_pxe_configs(task)"},{"line_number":265,"context_line":"        try:"},{"line_number":266,"context_line":"            _link_ip_address_pxe_configs(task, hex_form)"},{"line_number":267,"context_line":"        # NOTE(TheJulia): The IP address support will fail if the"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_107b55bf","line":264,"range":{"start_line":264,"start_character":8,"end_line":264,"end_character":34},"in_reply_to":"5f7c97a3_d5706faa","updated":"2018-07-25 11:57:38.000000000","message":"Good point, I\u0027ll try and follow-up on this since it seems like the wording needs to be updated.","commit_id":"eef2e968f37c8c83d2ada182af1e6e4c078452bb"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"962181594f0d9ca20756b4ba854e0a0dc2e593d3","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        try:"},{"line_number":266,"context_line":"            _link_ip_address_pxe_configs(task, hex_form)"},{"line_number":267,"context_line":"        # NOTE(TheJulia): The IP address support will fail if the"},{"line_number":268,"context_line":"        # dhcp_provider interface is set to none. This will result"},{"line_number":269,"context_line":"        # in the MAC addresses and DHCP files being written, and"},{"line_number":270,"context_line":"        # we can remove IP address creation for the grub use"},{"line_number":271,"context_line":"        # case, considering that will ease removal of elilo support."}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_b57b7378","line":268,"range":{"start_line":268,"start_character":50,"end_line":268,"end_character":66},"updated":"2018-07-25 10:23:29.000000000","message":"nit: The wording is a bit confusing to me. It can be read like if IP address support fails, then the files are written down...","commit_id":"eef2e968f37c8c83d2ada182af1e6e4c078452bb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"34ec4b56f46afbb757cac8349d623dab5aada93a","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        try:"},{"line_number":266,"context_line":"            _link_ip_address_pxe_configs(task, hex_form)"},{"line_number":267,"context_line":"        # NOTE(TheJulia): The IP address support will fail if the"},{"line_number":268,"context_line":"        # dhcp_provider interface is set to none. This will result"},{"line_number":269,"context_line":"        # in the MAC addresses and DHCP files being written, and"},{"line_number":270,"context_line":"        # we can remove IP address creation for the grub use"},{"line_number":271,"context_line":"        # case, considering that will ease removal of elilo support."}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_307691d7","line":268,"range":{"start_line":268,"start_character":50,"end_line":268,"end_character":66},"in_reply_to":"5f7c97a3_b57b7378","updated":"2018-07-25 11:57:38.000000000","message":"I\u0027ll try to rework it when I write a follow-up.","commit_id":"eef2e968f37c8c83d2ada182af1e6e4c078452bb"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"962181594f0d9ca20756b4ba854e0a0dc2e593d3","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        # NOTE(TheJulia): The IP address support will fail if the"},{"line_number":268,"context_line":"        # dhcp_provider interface is set to none. This will result"},{"line_number":269,"context_line":"        # in the MAC addresses and DHCP files being written, and"},{"line_number":270,"context_line":"        # we can remove IP address creation for the grub use"},{"line_number":271,"context_line":"        # case, considering that will ease removal of elilo support."},{"line_number":272,"context_line":"        except exception.FailedToGetIPaddressesOnPort as e:"},{"line_number":273,"context_line":"            if CONF.dhcp.dhcp_provider !\u003d \u0027none\u0027:"},{"line_number":274,"context_line":"                with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_15e1072c","line":271,"range":{"start_line":270,"start_character":44,"end_line":271,"end_character":14},"updated":"2018-07-25 10:23:29.000000000","message":"Just wondering, since grub is mentioned as a condition (?), is there a need to check that grub is being used like we have on line #240?","commit_id":"eef2e968f37c8c83d2ada182af1e6e4c078452bb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"34ec4b56f46afbb757cac8349d623dab5aada93a","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        # NOTE(TheJulia): The IP address support will fail if the"},{"line_number":268,"context_line":"        # dhcp_provider interface is set to none. This will result"},{"line_number":269,"context_line":"        # in the MAC addresses and DHCP files being written, and"},{"line_number":270,"context_line":"        # we can remove IP address creation for the grub use"},{"line_number":271,"context_line":"        # case, considering that will ease removal of elilo support."},{"line_number":272,"context_line":"        except exception.FailedToGetIPaddressesOnPort as e:"},{"line_number":273,"context_line":"            if CONF.dhcp.dhcp_provider !\u003d \u0027none\u0027:"},{"line_number":274,"context_line":"                with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_90b20596","line":271,"range":{"start_line":270,"start_character":44,"end_line":271,"end_character":14},"in_reply_to":"5f7c97a3_15e1072c","updated":"2018-07-25 11:57:38.000000000","message":"I don\u0027t think so, I feel like a bunch of this code needs to be refactored. It is on my todo list to try and get a bunch of UEFI standalone jobs running over the next couple weeks so we can feel confident in major uefi and pxe changes next cycle.","commit_id":"eef2e968f37c8c83d2ada182af1e6e4c078452bb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eda0cff05c9384895d4c5764b714eb9ba5775260","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        # we can remove IP address creation for the grub use"},{"line_number":271,"context_line":"        # case, considering that will ease removal of elilo support."},{"line_number":272,"context_line":"        except exception.FailedToGetIPaddressesOnPort as e:"},{"line_number":273,"context_line":"            if CONF.dhcp.dhcp_provider !\u003d \u0027none\u0027:"},{"line_number":274,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":275,"context_line":"                    LOG.error(\u0027Unable to create boot config, IP address \u0027"},{"line_number":276,"context_line":"                              \u0027was unable to be retrieved. %(error)s\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_81fc10b7","line":273,"range":{"start_line":273,"start_character":12,"end_line":273,"end_character":49},"updated":"2018-07-24 15:20:18.000000000","message":"I don\u0027t quite like hardcoding entry point names.. but I guess this all is pending deprecation of dhcp providers?","commit_id":"eef2e968f37c8c83d2ada182af1e6e4c078452bb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d98d988c03ab14eccd1007f497eec00a271eb0c1","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        # we can remove IP address creation for the grub use"},{"line_number":271,"context_line":"        # case, considering that will ease removal of elilo support."},{"line_number":272,"context_line":"        except exception.FailedToGetIPaddressesOnPort as e:"},{"line_number":273,"context_line":"            if CONF.dhcp.dhcp_provider !\u003d \u0027none\u0027:"},{"line_number":274,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":275,"context_line":"                    LOG.error(\u0027Unable to create boot config, IP address \u0027"},{"line_number":276,"context_line":"                              \u0027was unable to be retrieved. %(error)s\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_3ccd2392","line":273,"range":{"start_line":273,"start_character":12,"end_line":273,"end_character":49},"in_reply_to":"5f7c97a3_81fc10b7","updated":"2018-07-24 15:57:08.000000000","message":"and or not. We\u0027ve already got it hard coded elsewhere in the file :( Once we remove elilo, the ip addresses can go away.","commit_id":"eef2e968f37c8c83d2ada182af1e6e4c078452bb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eda0cff05c9384895d4c5764b714eb9ba5775260","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        # case, considering that will ease removal of elilo support."},{"line_number":272,"context_line":"        except exception.FailedToGetIPaddressesOnPort as e:"},{"line_number":273,"context_line":"            if CONF.dhcp.dhcp_provider !\u003d \u0027none\u0027:"},{"line_number":274,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":275,"context_line":"                    LOG.error(\u0027Unable to create boot config, IP address \u0027"},{"line_number":276,"context_line":"                              \u0027was unable to be retrieved. %(error)s\u0027,"},{"line_number":277,"context_line":"                              {\u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_415a78f5","line":274,"updated":"2018-07-24 15:20:18.000000000","message":"nit: another option:\n\n with excutils.save_and_reraise_exception() as exc:\n     exc.reraise \u003d CONF.dhcp.dhcp_provider !\u003d \u0027none\u0027\n     LOG.error(...)","commit_id":"eef2e968f37c8c83d2ada182af1e6e4c078452bb"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"962181594f0d9ca20756b4ba854e0a0dc2e593d3","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        # case, considering that will ease removal of elilo support."},{"line_number":272,"context_line":"        except exception.FailedToGetIPaddressesOnPort as e:"},{"line_number":273,"context_line":"            if CONF.dhcp.dhcp_provider !\u003d \u0027none\u0027:"},{"line_number":274,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":275,"context_line":"                    LOG.error(\u0027Unable to create boot config, IP address \u0027"},{"line_number":276,"context_line":"                              \u0027was unable to be retrieved. %(error)s\u0027,"},{"line_number":277,"context_line":"                              {\u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_1adff4d7","line":274,"in_reply_to":"5f7c97a3_415a78f5","updated":"2018-07-25 10:23:29.000000000","message":"or perhaps it can be like this:\n\nwith excutils.save_and_reraise_exception(\n    reraise\u003dCONF.dhcp.dhcp_provider !\u003d \u0027none\u0027):\n   ...","commit_id":"eef2e968f37c8c83d2ada182af1e6e4c078452bb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"21631bfe4abd91e1e1f7102e6f7148638e79972f","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    pxe_config_file_path \u003d get_pxe_config_file_path(task.node.uuid)"},{"line_number":92,"context_line":"    for port in task.ports:"},{"line_number":93,"context_line":"        client_id \u003d port.extra.get(\u0027client-id\u0027)"},{"line_number":94,"context_line":"        # Syslinux, ipxe, depending on settings."},{"line_number":95,"context_line":"        create_link(_get_pxe_mac_path(port.address, client_id\u003dclient_id))"},{"line_number":96,"context_line":"        # Grub2 MAC address only"},{"line_number":97,"context_line":"        create_link(_get_pxe_grub_mac_path(port.address))"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_d4945ee9","line":94,"updated":"2018-08-01 11:36:44.000000000","message":"nit: iPXE","commit_id":"b464a195bb066cc78a05bf27752a1773672e73e5"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c8ded1f5865224ab0495b60c2e95d5214a461d2c","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    if is_uefi_boot_mode and not CONF.pxe.ipxe_enabled:"},{"line_number":269,"context_line":"        # Always write the mac addresses"},{"line_number":270,"context_line":"        _link_mac_pxe_configs(task)"},{"line_number":271,"context_line":"        try:"},{"line_number":272,"context_line":"            _link_ip_address_pxe_configs(task, hex_form)"},{"line_number":273,"context_line":"        # NOTE(TheJulia): The IP address support will fail if the"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_5bc60044","line":270,"updated":"2018-08-03 14:13:00.000000000","message":"why not move it out of the if and remove else?","commit_id":"b464a195bb066cc78a05bf27752a1773672e73e5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e68db2175a1470e8005b6cc3c8a70aa85588c7de","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    if is_uefi_boot_mode and not CONF.pxe.ipxe_enabled:"},{"line_number":269,"context_line":"        # Always write the mac addresses"},{"line_number":270,"context_line":"        _link_mac_pxe_configs(task)"},{"line_number":271,"context_line":"        try:"},{"line_number":272,"context_line":"            _link_ip_address_pxe_configs(task, hex_form)"},{"line_number":273,"context_line":"        # NOTE(TheJulia): The IP address support will fail if the"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_d603c774","line":270,"in_reply_to":"5f7c97a3_5bc60044","updated":"2018-08-03 14:59:06.000000000","message":"easy follow up, great catch!","commit_id":"b464a195bb066cc78a05bf27752a1773672e73e5"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c8ded1f5865224ab0495b60c2e95d5214a461d2c","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        except exception.FailedToGetIPaddressesOnPort as e:"},{"line_number":279,"context_line":"            if CONF.dhcp.dhcp_provider !\u003d \u0027none\u0027:"},{"line_number":280,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":281,"context_line":"                    LOG.error(\u0027Unable to create boot config, IP address \u0027"},{"line_number":282,"context_line":"                              \u0027was unable to be retrieved. %(error)s\u0027,"},{"line_number":283,"context_line":"                              {\u0027error\u0027: e})"},{"line_number":284,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_7b2dfcfa","line":281,"range":{"start_line":281,"start_character":24,"end_line":281,"end_character":29},"updated":"2018-08-03 14:13:00.000000000","message":"nit - LOG.exception, then we don\u0027t need to explicitly pass error to the LOG call","commit_id":"b464a195bb066cc78a05bf27752a1773672e73e5"}],"ironic/tests/unit/common/test_pxe_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a81b0c306809f22615ff145bc7b7b68fd7c6775f","unresolved":false,"context_lines":[{"line_number":863,"context_line":"            unlink_calls \u003d ["},{"line_number":864,"context_line":"                mock.call(\u0027/tftpboot/10.10.0.1.conf\u0027),"},{"line_number":865,"context_line":"                mock.call(\u0027/tftpboot/0A0A0001.conf\u0027),"},{"line_number":866,"context_line":"                mock.call(\u0027/tftpboot/pxelinux.cfg/01-%s\u0027 %"},{"line_number":867,"context_line":"                          address.replace(\u0027:\u0027, \u0027-\u0027))"},{"line_number":868,"context_line":"            ]"},{"line_number":869,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_99d0d2f6","line":866,"updated":"2018-07-26 13:04:29.000000000","message":"06:01:30.561715 IP 192.168.122.132.25309 \u003e 192.168.122.1.tftp:  62 RRQ \"/tftpboot/52:54:00:a4:3e:e4.conf\" octet blksize 1024 tsize 0\n\t0x0000:  4500 005a 2414 0000 ff11 21a8 c0a8 7a84  E..Z$.....!...z.\n\t0x0010:  c0a8 7a01 62dd 0045 0046 8afc 0001 2f74  ..z.b..E.F..../t\n\t0x0020:  6674 7062 6f6f 742f 3532 3a35 343a 3030  ftpboot/52:54:00\n\t0x0030:  3a61 343a 3365 3a65 342e 636f 6e66 006f  :a4:3e:e4.conf.o\n\t0x0040:  6374 6574 0062 6c6b 7369 7a65 0031 3032  ctet.blksize.102\n\t0x0050:  3400 7473 697a 6500 3000                 4.tsize.0.","commit_id":"eef2e968f37c8c83d2ada182af1e6e4c078452bb"}]}
