)]}'
{"ironic/common/release_mappings.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bbc4e5d7290a1827f4c3e111fe18e41569aaa73d","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        \u0027api\u0027: \u00271.43\u0027,"},{"line_number":104,"context_line":"        \u0027rpc\u0027: \u00271.44\u0027,"},{"line_number":105,"context_line":"        \u0027objects\u0027: {"},{"line_number":106,"context_line":"            \u0027Node\u0027: [\u00271.24\u0027, \u00271.25\u0027],"},{"line_number":107,"context_line":"            \u0027Conductor\u0027: [\u00271.2\u0027],"},{"line_number":108,"context_line":"            \u0027Chassis\u0027: [\u00271.3\u0027],"},{"line_number":109,"context_line":"            \u0027Port\u0027: [\u00271.8\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_6cafe99c","line":106,"range":{"start_line":106,"start_character":20,"end_line":106,"end_character":37},"updated":"2018-07-06 09:14:54.000000000","message":"Sorry, I don\u0027t quite remember, shouldn\u0027t we have only one version here?","commit_id":"213152007942bf05381c5c4eeba5a2fee4d18b4a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"37a83ca7dc457d72eb172b6ff22e9771760ba16e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        \u0027api\u0027: \u00271.43\u0027,"},{"line_number":104,"context_line":"        \u0027rpc\u0027: \u00271.44\u0027,"},{"line_number":105,"context_line":"        \u0027objects\u0027: {"},{"line_number":106,"context_line":"            \u0027Node\u0027: [\u00271.24\u0027, \u00271.25\u0027],"},{"line_number":107,"context_line":"            \u0027Conductor\u0027: [\u00271.2\u0027],"},{"line_number":108,"context_line":"            \u0027Chassis\u0027: [\u00271.3\u0027],"},{"line_number":109,"context_line":"            \u0027Port\u0027: [\u00271.8\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_6ea1f894","line":106,"range":{"start_line":106,"start_character":20,"end_line":106,"end_character":37},"in_reply_to":"5f7c97a3_1901d439","updated":"2018-07-09 16:59:27.000000000","message":"The list is because the objects (nodes) have a \u0027version\u0027 associated with them in the DB. Which is a string. So I need to compare/check (via mysql) exact version strings for possible values of the node.version. (vs eg checking for \u003e 1.23, \u003c\u003d1.25.)\n\nThe RPC version is above, 1.44; no list here cuz the oslo.messaging code can check for \u003c\u003d 1.44.","commit_id":"213152007942bf05381c5c4eeba5a2fee4d18b4a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f6972593ea5c36d8426dffb7208b441f4b6a8c8d","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        \u0027api\u0027: \u00271.43\u0027,"},{"line_number":104,"context_line":"        \u0027rpc\u0027: \u00271.44\u0027,"},{"line_number":105,"context_line":"        \u0027objects\u0027: {"},{"line_number":106,"context_line":"            \u0027Node\u0027: [\u00271.24\u0027, \u00271.25\u0027],"},{"line_number":107,"context_line":"            \u0027Conductor\u0027: [\u00271.2\u0027],"},{"line_number":108,"context_line":"            \u0027Chassis\u0027: [\u00271.3\u0027],"},{"line_number":109,"context_line":"            \u0027Port\u0027: [\u00271.8\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f6a2e796","line":106,"range":{"start_line":106,"start_character":20,"end_line":106,"end_character":37},"in_reply_to":"5f7c97a3_6cafe99c","updated":"2018-07-06 12:38:39.000000000","message":"No, we need all the possible versions; that\u0027s why it is a list. (I know, I forgot about that when I reviewed a patch, then fixed it with another patch.)\n\nAlthough... I just looked at the comments above (L43-44) and it sez it should be ordered from latest to older. I don\u0027t recall why I put that there :-(; my guess is because it might be slighly more efficient when iterating/comparing, if we assume that most objects are in the latest version, not oldest version (from a particular release).","commit_id":"213152007942bf05381c5c4eeba5a2fee4d18b4a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ed4f30f5b5a5b2a04eec5f25e66c991e8bd4e936","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        \u0027api\u0027: \u00271.43\u0027,"},{"line_number":104,"context_line":"        \u0027rpc\u0027: \u00271.44\u0027,"},{"line_number":105,"context_line":"        \u0027objects\u0027: {"},{"line_number":106,"context_line":"            \u0027Node\u0027: [\u00271.24\u0027, \u00271.25\u0027],"},{"line_number":107,"context_line":"            \u0027Conductor\u0027: [\u00271.2\u0027],"},{"line_number":108,"context_line":"            \u0027Chassis\u0027: [\u00271.3\u0027],"},{"line_number":109,"context_line":"            \u0027Port\u0027: [\u00271.8\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_1901d439","line":106,"range":{"start_line":106,"start_character":20,"end_line":106,"end_character":37},"in_reply_to":"5f7c97a3_f6a2e796","updated":"2018-07-06 13:36:05.000000000","message":"Don\u0027t we use these version to fix the RPC version on upgrade? If yes, why do we need a list?\n\nI also wonder why grenade fails here.","commit_id":"213152007942bf05381c5c4eeba5a2fee4d18b4a"}]}