)]}'
{"zuul.d/ironic-jobs.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e3d1b285cce8bc1e2eee7e66a0fee55b506225b1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        IRONIC_INSPECTOR_BUILD_RAMDISK: False"},{"line_number":40,"context_line":"        IRONIC_RAMDISK_TYPE: tinyipa"},{"line_number":41,"context_line":"        IRONIC_TEMPEST_BUILD_TIMEOUT: 600"},{"line_number":42,"context_line":"        IRONIC_TEMPEST_WHOLE_DISK_IMAGE: False"},{"line_number":43,"context_line":"        IRONIC_VM_COUNT: 1"},{"line_number":44,"context_line":"        IRONIC_VM_EPHEMERAL_DISK: 1"},{"line_number":45,"context_line":"        IRONIC_VM_LOG_DIR: \u0027{{ devstack_base_dir }}/ironic-bm-logs\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_8d48fab3","line":42,"updated":"2018-07-21 21:53:47.000000000","message":"I\u0027m not sure this make sense in that only the job had this set. Seems like it shouldn\u0027t be set globally unless it is a true default...","commit_id":"70b7e1cc571d0bba0dccee7464534ec1fed7d3bb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5516d74025b2be224d0ebe88dcd16b010c4ff3fb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        IRONIC_INSPECTOR_BUILD_RAMDISK: False"},{"line_number":40,"context_line":"        IRONIC_RAMDISK_TYPE: tinyipa"},{"line_number":41,"context_line":"        IRONIC_TEMPEST_BUILD_TIMEOUT: 600"},{"line_number":42,"context_line":"        IRONIC_TEMPEST_WHOLE_DISK_IMAGE: False"},{"line_number":43,"context_line":"        IRONIC_VM_COUNT: 1"},{"line_number":44,"context_line":"        IRONIC_VM_EPHEMERAL_DISK: 1"},{"line_number":45,"context_line":"        IRONIC_VM_LOG_DIR: \u0027{{ devstack_base_dir }}/ironic-bm-logs\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_59bcc7b4","line":42,"in_reply_to":"5f7c97a3_63448174","updated":"2018-07-23 21:43:53.000000000","message":"Thanks for the explanation Derek, sounds good to me!","commit_id":"70b7e1cc571d0bba0dccee7464534ec1fed7d3bb"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"e3c6acd3e3067a82b78e2f83a4daf264498b0c88","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        IRONIC_INSPECTOR_BUILD_RAMDISK: False"},{"line_number":40,"context_line":"        IRONIC_RAMDISK_TYPE: tinyipa"},{"line_number":41,"context_line":"        IRONIC_TEMPEST_BUILD_TIMEOUT: 600"},{"line_number":42,"context_line":"        IRONIC_TEMPEST_WHOLE_DISK_IMAGE: False"},{"line_number":43,"context_line":"        IRONIC_VM_COUNT: 1"},{"line_number":44,"context_line":"        IRONIC_VM_EPHEMERAL_DISK: 1"},{"line_number":45,"context_line":"        IRONIC_VM_LOG_DIR: \u0027{{ devstack_base_dir }}/ironic-bm-logs\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_63448174","line":42,"in_reply_to":"5f7c97a3_8d48fab3","updated":"2018-07-23 11:36:29.000000000","message":"7 of the legacy jobs had it explicitly set to True and 7 had it set to False. (I think only 1 hadn\u0027t set it). The default in devstack/common_settings varies depending on the value of $IRONIC_VM_EPHEMERAL_DISK. So I thought it best so also explicitly set it in order to avoid introducing ambiguity. So I\u0027ve set it to False in the parent, when all the jobs are migrated 7 of them will have it set to True e.g. https://review.openstack.org/#/c/583546/2/zuul.d/ironic-jobs.yaml","commit_id":"70b7e1cc571d0bba0dccee7464534ec1fed7d3bb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e3d1b285cce8bc1e2eee7e66a0fee55b506225b1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        IRONIC_VM_EPHEMERAL_DISK: 1"},{"line_number":45,"context_line":"        IRONIC_VM_LOG_DIR: \u0027{{ devstack_base_dir }}/ironic-bm-logs\u0027"},{"line_number":46,"context_line":"        IRONIC_VM_SPECS_RAM: 384"},{"line_number":47,"context_line":"        IRONIC_DEFAULT_DEPLOY_INTERFACE: iscsi"},{"line_number":48,"context_line":"        IRONIC_DEFAULT_RESCUE_INTERFACE: agent"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        Q_AGENT: openvswitch"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_4dc4220e","line":47,"updated":"2018-07-21 21:53:47.000000000","message":"Same as above.","commit_id":"70b7e1cc571d0bba0dccee7464534ec1fed7d3bb"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"e3c6acd3e3067a82b78e2f83a4daf264498b0c88","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        IRONIC_VM_EPHEMERAL_DISK: 1"},{"line_number":45,"context_line":"        IRONIC_VM_LOG_DIR: \u0027{{ devstack_base_dir }}/ironic-bm-logs\u0027"},{"line_number":46,"context_line":"        IRONIC_VM_SPECS_RAM: 384"},{"line_number":47,"context_line":"        IRONIC_DEFAULT_DEPLOY_INTERFACE: iscsi"},{"line_number":48,"context_line":"        IRONIC_DEFAULT_RESCUE_INTERFACE: agent"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        Q_AGENT: openvswitch"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_e315f03f","line":47,"in_reply_to":"5f7c97a3_4dc4220e","updated":"2018-07-23 11:36:29.000000000","message":"This is similar, 6 of the legacy jobs had it explicitly set too \"direct\" and 5 too \"iscsi\". And the default is dependent on the value of $IRONIC_DEPLOY_DRIVER.","commit_id":"70b7e1cc571d0bba0dccee7464534ec1fed7d3bb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5516d74025b2be224d0ebe88dcd16b010c4ff3fb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        IRONIC_VM_EPHEMERAL_DISK: 1"},{"line_number":45,"context_line":"        IRONIC_VM_LOG_DIR: \u0027{{ devstack_base_dir }}/ironic-bm-logs\u0027"},{"line_number":46,"context_line":"        IRONIC_VM_SPECS_RAM: 384"},{"line_number":47,"context_line":"        IRONIC_DEFAULT_DEPLOY_INTERFACE: iscsi"},{"line_number":48,"context_line":"        IRONIC_DEFAULT_RESCUE_INTERFACE: agent"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        Q_AGENT: openvswitch"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_9999ff6c","line":47,"in_reply_to":"5f7c97a3_e315f03f","updated":"2018-07-23 21:43:53.000000000","message":"Works for me. Thanks!","commit_id":"70b7e1cc571d0bba0dccee7464534ec1fed7d3bb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e3d1b285cce8bc1e2eee7e66a0fee55b506225b1","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    description: ironic-tempest-dsvm-pxe_ipmitool-postgres"},{"line_number":146,"context_line":"    parent: ironic-base"},{"line_number":147,"context_line":"    irrelevant-files:"},{"line_number":148,"context_line":"      - ^driver-requirements.txt$"},{"line_number":149,"context_line":"    vars:"},{"line_number":150,"context_line":"      devstack_localrc:"},{"line_number":151,"context_line":"        IRONIC_IPXE_ENABLED: False"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_ed4deec4","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":33},"updated":"2018-07-21 21:53:47.000000000","message":"We should really add to this list so doc only changes don\u0027t trigger.","commit_id":"70b7e1cc571d0bba0dccee7464534ec1fed7d3bb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5516d74025b2be224d0ebe88dcd16b010c4ff3fb","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    description: ironic-tempest-dsvm-pxe_ipmitool-postgres"},{"line_number":146,"context_line":"    parent: ironic-base"},{"line_number":147,"context_line":"    irrelevant-files:"},{"line_number":148,"context_line":"      - ^driver-requirements.txt$"},{"line_number":149,"context_line":"    vars:"},{"line_number":150,"context_line":"      devstack_localrc:"},{"line_number":151,"context_line":"        IRONIC_IPXE_ENABLED: False"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_79c5033e","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":33},"in_reply_to":"5f7c97a3_633a4098","updated":"2018-07-23 21:43:53.000000000","message":"I\u0027m fairly sure it is not since I\u0027ve seen these new jobs trigger on unrelated changes. :\\ I guess there is only one way to find out though, a test change.","commit_id":"70b7e1cc571d0bba0dccee7464534ec1fed7d3bb"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"7e1f7419559a837179385b854fb0f5a6c0501da1","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    description: ironic-tempest-dsvm-pxe_ipmitool-postgres"},{"line_number":146,"context_line":"    parent: ironic-base"},{"line_number":147,"context_line":"    irrelevant-files:"},{"line_number":148,"context_line":"      - ^driver-requirements.txt$"},{"line_number":149,"context_line":"    vars:"},{"line_number":150,"context_line":"      devstack_localrc:"},{"line_number":151,"context_line":"        IRONIC_IPXE_ENABLED: False"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_b0c07c4c","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":33},"in_reply_to":"5f7c97a3_79c5033e","updated":"2018-07-24 13:44:14.000000000","message":"test patch confirmed it, the list isn\u0027t merged with the parent, I\u0027ll fix it up.","commit_id":"70b7e1cc571d0bba0dccee7464534ec1fed7d3bb"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"e3c6acd3e3067a82b78e2f83a4daf264498b0c88","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    description: ironic-tempest-dsvm-pxe_ipmitool-postgres"},{"line_number":146,"context_line":"    parent: ironic-base"},{"line_number":147,"context_line":"    irrelevant-files:"},{"line_number":148,"context_line":"      - ^driver-requirements.txt$"},{"line_number":149,"context_line":"    vars:"},{"line_number":150,"context_line":"      devstack_localrc:"},{"line_number":151,"context_line":"        IRONIC_IPXE_ENABLED: False"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_633a4098","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":33},"in_reply_to":"5f7c97a3_ed4deec4","updated":"2018-07-23 11:36:29.000000000","message":"The parent above has a more comprehensive list, but for the legacy jobs I\u0027m trying to replicate the list was slightly different for \"ironic-dsvm-standalone\". All of the entries were common except that \"ironic-dsvm-standalone\" contained \"^test-requirements.txt$\" all the other jobs contained \"\n^driver-requirements.txt$\". \n\nIn the migrated jobs the \"ironic-base\" contains the common files, then ironic-dsvm-standalone contains \"^test-requirements.txt$\" and all the others contain \"^driver-requirements.txt$\", assuming these lists are merged then it will replicate the config from legacy jobs.\n\nYes, I am assuming the list is merged(based on the fact that devstack_services is merged), I\u0027ll verify this is the case.","commit_id":"70b7e1cc571d0bba0dccee7464534ec1fed7d3bb"}]}