)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a9f78bb0c8b6260956e2a9a3e847299c258c4031","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            # TODO(deva): Determine what value will be passed by API when"},{"line_number":137,"context_line":"            #             instance_uuid needs to be unset, and handle it."},{"line_number":138,"context_line":"            if \u0027instance_uuid\u0027 in delta:"},{"line_number":139,"context_line":"                task.driver.power.validate(node_obj)"},{"line_number":140,"context_line":"                node_obj[\u0027power_state\u0027] \u003d \\"},{"line_number":141,"context_line":"                        task.driver.power.get_power_state(task, node_id)"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2BW%2BQ%3D","side":"PARENT","line":139,"updated":"2013-11-26 23:34:10.000000000","message":"The use of node_obj instead of task.node may not be quite right, but I think it is outside the scope of this particular change. [Between the time that node_obj was created, to this context, the node could have changed.]","commit_id":"8e2c7a106f6ef56676967673ade0ef424b166a4a"}],"ironic/drivers/modules/fake.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"6a9ebe88f6f190bade567e061c8a2deb8809bc52","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        return True"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_power_state(self, task, node):"},{"line_number":33,"context_line":"        # Return node object\u0027s power state"},{"line_number":34,"context_line":"        return node.get(\u0027power_state\u0027, states.NOSTATE)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def set_power_state(self, task, node, power_state):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BeLQ%3D","line":33,"updated":"2013-11-25 18:18:17.000000000","message":"I dont think this comment is necessary. It\u0027s obvious what the following line is doing.","commit_id":"c8da68539b539e1b3379531ce1cccb062604b337"}],"ironic/tests/drivers/test_fake.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"a6342bdf1c0ce3d65de32e286b146f7485e1c41e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\"\"\"Test class for Fake driver.\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from ironic.openstack.common import context"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from ironic.common import exception"},{"line_number":24,"context_line":"from ironic.common import states"},{"line_number":25,"context_line":"from ironic.conductor import task_manager"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2BbeQ%3D","line":22,"updated":"2013-11-26 07:33:20.000000000","message":"Chris, I think this line is not required, we should sort all the ironic import in one single group together.","commit_id":"f732bf55f129d9a00cec97a24b952a8fd35cc508"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"198f8e5130ef5cba81c2abea21162f144c291a3f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\"\"\"Test class for Fake driver.\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from ironic.openstack.common import context"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from ironic.common import exception"},{"line_number":24,"context_line":"from ironic.common import states"},{"line_number":25,"context_line":"from ironic.conductor import task_manager"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2BaRA%3D","line":22,"in_reply_to":"AAAATn%2F%2BbeQ%3D","updated":"2013-11-26 11:59:53.000000000","message":"Just to add a bit more information here, the grouping should goes like:\n\n* * standard library imports\n* * related third party imports\n* * local application/library specific imports\n\nref: http://www.python.org/dev/peps/pep-0008/#imports","commit_id":"f732bf55f129d9a00cec97a24b952a8fd35cc508"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"a6342bdf1c0ce3d65de32e286b146f7485e1c41e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from ironic.drivers import base as driver_base"},{"line_number":28,"context_line":"from ironic.tests import base"},{"line_number":29,"context_line":"from ironic.tests.db import utils as db_utils"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from ironic.tests.conductor import utils as mgr_utils"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2BbeM%3D","line":30,"updated":"2013-11-26 07:33:20.000000000","message":"ditto","commit_id":"f732bf55f129d9a00cec97a24b952a8fd35cc508"},{"author":{"_account_id":7774,"name":"Kui Shi","email":"skuicloud@gmail.com","username":"Kui"},"change_message_id":"de3ea221397da207404aec911233475d26ca1569","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from ironic.drivers import base as driver_base"},{"line_number":28,"context_line":"from ironic.tests import base"},{"line_number":29,"context_line":"from ironic.tests.db import utils as db_utils"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from ironic.tests.conductor import utils as mgr_utils"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Bapk%3D","line":30,"in_reply_to":"AAAATn%2F%2BbeM%3D","updated":"2013-11-26 10:50:10.000000000","message":"It is used in following code for self.driver assignment.\n\nShould this \"import\" line be added in alphabetical order ?","commit_id":"f732bf55f129d9a00cec97a24b952a8fd35cc508"}]}