)]}'
{"ironic/drivers/modules/snmp.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a62340f835fefbd5bfab0d0f24946efe1a24e299","unresolved":false,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        vals \u003d []"},{"line_number":330,"context_line":"        for (error_indication, error_status, error_index,"},{"line_number":331,"context_line":"                var_bind_table) in snmp_gen:"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"            if error_indication:"},{"line_number":334,"context_line":"                # SNMP engine-level error."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_92456d75","line":331,"range":{"start_line":331,"start_character":16,"end_line":331,"end_character":30},"updated":"2018-07-23 08:54:49.000000000","message":"nit: semantically, this variable should better be named `var_bind_table_row` or may be just `var_binds`\n\n    http://snmplabs.com/pysnmp/docs/hlapi/asyncore/sync/manager/cmdgen/nextcmd.html#getnext-command","commit_id":"83fd9a38d81b68db2ba39cf70707f944b75c389a"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"1883db926fb97a9a347d47855b35d271c93ac6b2","unresolved":false,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        vals \u003d []"},{"line_number":330,"context_line":"        for (error_indication, error_status, error_index,"},{"line_number":331,"context_line":"                var_bind_table) in snmp_gen:"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"            if error_indication:"},{"line_number":334,"context_line":"                # SNMP engine-level error."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a5a4c5b9","line":331,"range":{"start_line":331,"start_character":16,"end_line":331,"end_character":30},"in_reply_to":"5f7c97a3_92456d75","updated":"2018-07-24 06:58:36.000000000","message":"Done","commit_id":"83fd9a38d81b68db2ba39cf70707f944b75c389a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a62340f835fefbd5bfab0d0f24946efe1a24e299","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                raise exception.SNMPFailure(operation\u003d\"GET_NEXT\","},{"line_number":341,"context_line":"                                            error\u003derror_status.prettyPrint())"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"            vals.extend([val for name, val in var_bind_table])"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        return vals"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_8d946c9a","line":343,"range":{"start_line":343,"start_character":12,"end_line":343,"end_character":23},"updated":"2018-07-23 08:54:49.000000000","message":"nit: for as long as the single var-bind is queried (#323), the response will always contain a single var-bind.\n\nThus this can be a simplification:\n\n    # this is not a table, but a table row \n    # e.g. 1-D array of tuples\n    name, val \u003d var_bind_table[0]\n    vals.append(val)","commit_id":"83fd9a38d81b68db2ba39cf70707f944b75c389a"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"1883db926fb97a9a347d47855b35d271c93ac6b2","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                raise exception.SNMPFailure(operation\u003d\"GET_NEXT\","},{"line_number":341,"context_line":"                                            error\u003derror_status.prettyPrint())"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"            vals.extend([val for name, val in var_bind_table])"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        return vals"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c5a9c18f","line":343,"range":{"start_line":343,"start_character":12,"end_line":343,"end_character":23},"in_reply_to":"5f7c97a3_8d946c9a","updated":"2018-07-24 06:58:36.000000000","message":"Done","commit_id":"83fd9a38d81b68db2ba39cf70707f944b75c389a"}]}