)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"183e9234ab87525ab9211ef11817bd52b1e4fcd5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This changes will remove old sentence about executing"},{"line_number":10,"context_line":"periodic tasks during maintainance mode. The periodic tasks still"},{"line_number":11,"context_line":"works normal in maintainance mode."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If4b1757e29d316f462d70883e6a84a48be9c2cad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_79ef181d","line":11,"updated":"2018-09-26 12:00:00.000000000","message":"I don\u0027t find this change quite helpful for users. Most periodic tasks skip nodes in maintenance mode. Operators in my company told me they wanted to know what happens when a node is put into maintenance mode because they don\u0027t know what is a \u0027periodic task\u0027. For example, they didn\u0027t understand power syncing didn\u0027t work on a node in maintenance.","commit_id":"cf66027a0897ca3df11dc7a2489eab44de448b08"}],"doc/source/admin/troubleshooting.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38caf5b448f73092dbdb027b822b97f10287ad69","unresolved":false,"context_lines":[{"line_number":351,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"Thought to maintainance mode, we will mention to ``Provision State`` and"},{"line_number":354,"context_line":"``Maintainance`` columns in ``Node`` list."},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"This is node info when we perform `openstack barmetal node list` command:"},{"line_number":357,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_5b44b21a","line":354,"updated":"2018-07-24 08:31:00.000000000","message":"Sorry, I don\u0027t quite get this phrase. What are you trying to say here? Something like \"This section describes the maintenance mode\"? Then you need some details on what this mode is and why it is used.","commit_id":"b7b5b0447998243cb3934a234d49fe21caea086f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38caf5b448f73092dbdb027b822b97f10287ad69","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"* If the node shows empty table or ``Maintenance`` is `True`, or"},{"line_number":374,"context_line":"  ``Provision State`` is `manageable` or `enroll`, there was a problem during"},{"line_number":375,"context_line":"  node enrolling and introspection."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"  Let check the actual cause using the following command:"},{"line_number":378,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_7b416e08","line":375,"updated":"2018-07-24 08:31:00.000000000","message":"Introspection does not result in maintenance mode, nor does it result in manageable or enroll on failure. Enrolling also does not result in maintenance, nodes in enroll don\u0027t participare in power state sync.","commit_id":"b7b5b0447998243cb3934a234d49fe21caea086f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38caf5b448f73092dbdb027b822b97f10287ad69","unresolved":false,"context_lines":[{"line_number":387,"context_line":"  .. code-block:: bash"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    $ openstack baremetal node provide \u003cNODE_NAME\u003e"},{"line_number":390,"context_line":"    $ openstack baremetal node maintenance unset \u003cNODE_UUID\u003e"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"* To change into ready node for new instance from `clean failed` status,"},{"line_number":393,"context_line":"  we need to perform following commands:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_1b4e3a39","line":390,"updated":"2018-07-24 08:31:00.000000000","message":"before recommending it, you need to explain how to fix the reason of getting into maintenance mode. I think it\u0027s already explained in one of the previous sections though","commit_id":"b7b5b0447998243cb3934a234d49fe21caea086f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38caf5b448f73092dbdb027b822b97f10287ad69","unresolved":false,"context_lines":[{"line_number":390,"context_line":"    $ openstack baremetal node maintenance unset \u003cNODE_UUID\u003e"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"* To change into ready node for new instance from `clean failed` status,"},{"line_number":393,"context_line":"  we need to perform following commands:"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"  .. code-block:: bash"},{"line_number":396,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_3b4bf628","line":393,"updated":"2018-07-24 08:31:00.000000000","message":"again, they need to fix the reason why cleaning failed first. otherwise the provide action will fail again","commit_id":"b7b5b0447998243cb3934a234d49fe21caea086f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38caf5b448f73092dbdb027b822b97f10287ad69","unresolved":false,"context_lines":[{"line_number":393,"context_line":"  we need to perform following commands:"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"  .. code-block:: bash"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    $ openstack baremetal node manage \u003cNODE_NAME\u003e"},{"line_number":398,"context_line":"    $ openstack baremetal node provide \u003cNODE_NAME\u003e"},{"line_number":399,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_db59a200","line":396,"updated":"2018-07-24 08:31:00.000000000","message":"you don\u0027t mention unsetting the maintenance mode here","commit_id":"b7b5b0447998243cb3934a234d49fe21caea086f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38caf5b448f73092dbdb027b822b97f10287ad69","unresolved":false,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"* If ``Provision State`` is `wait call-back` or `clean wait`, then bare metal"},{"line_number":401,"context_line":"  deployment is not finished for this node yet. We may want to wait until"},{"line_number":402,"context_line":"  the status changes."},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"* To remove old node which still operate under `clean wait` status,"},{"line_number":405,"context_line":"  we need to perform some following commands:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_fb5edee6","line":402,"updated":"2018-07-24 08:31:00.000000000","message":"If we\u0027re in maintenance mode, heartbeating is disabled, so a node is unlikely to leave these states.","commit_id":"b7b5b0447998243cb3934a234d49fe21caea086f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38caf5b448f73092dbdb027b822b97f10287ad69","unresolved":false,"context_lines":[{"line_number":402,"context_line":"  the status changes."},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"* To remove old node which still operate under `clean wait` status,"},{"line_number":405,"context_line":"  we need to perform some following commands:"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"  .. code-block:: bash"},{"line_number":408,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_9b532adf","line":405,"updated":"2018-07-24 08:31:00.000000000","message":"Why would anyone do it? I don\u0027t think we should recommend something like that.","commit_id":"b7b5b0447998243cb3934a234d49fe21caea086f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38caf5b448f73092dbdb027b822b97f10287ad69","unresolved":false,"context_lines":[{"line_number":406,"context_line":""},{"line_number":407,"context_line":"  .. code-block:: bash"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    $ sudo systemctl restart devstack@ir-*"},{"line_number":410,"context_line":"    $ openstack baremetal node maintenance set \u003cNODE_UUID\u003e"},{"line_number":411,"context_line":"    $ openstack baremetal node delete \u003cNODE_NAME\u003e"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_bb5866f9","line":409,"updated":"2018-07-24 08:31:00.000000000","message":"this is for devstack, we should not mention it in the admin docs","commit_id":"b7b5b0447998243cb3934a234d49fe21caea086f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38caf5b448f73092dbdb027b822b97f10287ad69","unresolved":false,"context_lines":[{"line_number":410,"context_line":"    $ openstack baremetal node maintenance set \u003cNODE_UUID\u003e"},{"line_number":411,"context_line":"    $ openstack baremetal node delete \u003cNODE_NAME\u003e"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"* If maintainance is `True` then we cannot perform provision any instances,"},{"line_number":414,"context_line":"  thus we need to change into `False`:"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"  .. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_5b6d9298","line":413,"updated":"2018-07-24 08:31:00.000000000","message":"nit: s/perform//","commit_id":"b7b5b0447998243cb3934a234d49fe21caea086f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38caf5b448f73092dbdb027b822b97f10287ad69","unresolved":false,"context_lines":[{"line_number":411,"context_line":"    $ openstack baremetal node delete \u003cNODE_NAME\u003e"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"* If maintainance is `True` then we cannot perform provision any instances,"},{"line_number":414,"context_line":"  thus we need to change into `False`:"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"  .. code-block:: bash"},{"line_number":417,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_7b6ace82","line":414,"updated":"2018-07-24 08:31:00.000000000","message":"this duplicates bullet point #2","commit_id":"b7b5b0447998243cb3934a234d49fe21caea086f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38caf5b448f73092dbdb027b822b97f10287ad69","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    $ openstack baremetal node maintenance unset \u003cNODE_NAME\u003e"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"* If ``Provision State`` is `clean failed`, then bare metal deployment has"},{"line_number":421,"context_line":"  failed for this node. Look at the last_error field via following command:"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"  .. code-block:: bash"},{"line_number":424,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_1b671abb","line":421,"updated":"2018-07-24 08:31:00.000000000","message":"This should go to earlier bullet point as well","commit_id":"b7b5b0447998243cb3934a234d49fe21caea086f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38caf5b448f73092dbdb027b822b97f10287ad69","unresolved":false,"context_lines":[{"line_number":425,"context_line":"    $ openstack baremetal node show \u003cNODE_NAME\u003e -f value -c last_error"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"* If ``Provision State`` is `active` and ``Maintenance`` is `True`, then"},{"line_number":428,"context_line":"  bare metal deployment has finished successfully. Check node status via"},{"line_number":429,"context_line":"  command:"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"  .. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_3b6456b3","line":428,"updated":"2018-07-24 08:31:00.000000000","message":"yes, but it\u0027s still not normal","commit_id":"b7b5b0447998243cb3934a234d49fe21caea086f"}],"doc/source/install/troubleshooting.rst":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b905d38a3ab11c4d5bf7da301d9ada94534d596c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"Maintenance mode"},{"line_number":93,"context_line":"----------------"},{"line_number":94,"context_line":"Maintenance mode may be used if you need to take a node out of the resource"},{"line_number":95,"context_line":"pool. Putting a node in maintenance mode will prevent Bare Metal service from"},{"line_number":96,"context_line":"executing periodic tasks associated with the node. This means power state is"},{"line_number":97,"context_line":"not synced while a node is in this mode. This will also prevent"},{"line_number":98,"context_line":"Compute service from placing a tenant instance on the node by not exposing"},{"line_number":99,"context_line":"the node to the nova scheduler. Nodes can be placed into maintenance mode"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_c415ee9d","line":96,"range":{"start_line":95,"start_character":6,"end_line":96,"end_character":49},"updated":"2018-08-10 03:06:13.000000000","message":"I think this is also not quite correct, though in many cases, we check maintenance mode at the entrance of a periodic task, that doesn\u0027t mean we are not executing periodic tasks. They are just filtered out due to conditional check.\n\nBesides, we have exceptions, take _send_sensor_data for example, it doesn\u0027t consider maintenance mode at all.\n\nSo, what I\u0027m trying to say is they are not the same concepts.","commit_id":"124735383f2332017eba58a7d5afd282c8a19581"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"51ca80a73efdc00533c275f1a5799819cc49ac9e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"Maintenance mode"},{"line_number":93,"context_line":"----------------"},{"line_number":94,"context_line":"Maintenance mode may be used if you need to take a node out of the resource"},{"line_number":95,"context_line":"pool. Putting a node in maintenance mode will prevent Bare Metal service from"},{"line_number":96,"context_line":"executing periodic tasks associated with the node. This means power state is"},{"line_number":97,"context_line":"not synced while a node is in this mode. This will also prevent"},{"line_number":98,"context_line":"Compute service from placing a tenant instance on the node by not exposing"},{"line_number":99,"context_line":"the node to the nova scheduler. Nodes can be placed into maintenance mode"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_68e816de","line":96,"range":{"start_line":95,"start_character":6,"end_line":96,"end_character":49},"in_reply_to":"3f79a3b5_476b20b6","updated":"2018-09-07 09:01:27.000000000","message":"Yeah. I have removed this sentence for fixing.","commit_id":"124735383f2332017eba58a7d5afd282c8a19581"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"0ae4ffda1a453f6d6d150faa69b7c389611e7523","unresolved":false,"context_lines":[{"line_number":92,"context_line":"Maintenance mode"},{"line_number":93,"context_line":"----------------"},{"line_number":94,"context_line":"Maintenance mode may be used if you need to take a node out of the resource"},{"line_number":95,"context_line":"pool. Putting a node in maintenance mode will prevent Bare Metal service from"},{"line_number":96,"context_line":"executing periodic tasks associated with the node. This means power state is"},{"line_number":97,"context_line":"not synced while a node is in this mode. This will also prevent"},{"line_number":98,"context_line":"Compute service from placing a tenant instance on the node by not exposing"},{"line_number":99,"context_line":"the node to the nova scheduler. Nodes can be placed into maintenance mode"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_476b20b6","line":96,"range":{"start_line":95,"start_character":6,"end_line":96,"end_character":49},"in_reply_to":"3f79a3b5_c415ee9d","updated":"2018-08-10 03:35:27.000000000","message":"After some digging, I should revise the comment above, _send_sensor_data will not collect data for nodes in maintenance, but we still spawn tasks to do so. Let\u0027s say, it\u0027s partially executed.\n\nBut I think the principal is unchanged, because we support periodic tasks from hardware interfaces, furthermore there are out-of-tree drivers may have their own periodic tasks implementation, we cannot assure this statement always stands.\n\nYou know, I can always enumerate another example, the state synchronization task at inspector driver only considers provision state instead of maintenance, if a node is put to maintenance during inspecting state, the periodic task will not stop.","commit_id":"124735383f2332017eba58a7d5afd282c8a19581"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b905d38a3ab11c4d5bf7da301d9ada94534d596c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Maintenance mode may be used if you need to take a node out of the resource"},{"line_number":95,"context_line":"pool. Putting a node in maintenance mode will prevent Bare Metal service from"},{"line_number":96,"context_line":"executing periodic tasks associated with the node. This means power state is"},{"line_number":97,"context_line":"not synced while a node is in this mode. This will also prevent"},{"line_number":98,"context_line":"Compute service from placing a tenant instance on the node by not exposing"},{"line_number":99,"context_line":"the node to the nova scheduler. Nodes can be placed into maintenance mode"},{"line_number":100,"context_line":"with the following command."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_c4908e46","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":10},"updated":"2018-08-10 03:06:13.000000000","message":"Sorry, this is not true after power fault recovery is supported. When a node entered maintenance mode due to power failure, the recovery periodic task still checks power status, when succeeded, moves node out of maintenance and updates power state.","commit_id":"124735383f2332017eba58a7d5afd282c8a19581"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"50d7e3601a08e181862c73fa402db2babe515785","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Maintenance mode may be used if you need to take a node out of the resource"},{"line_number":95,"context_line":"pool. Putting a node in maintenance mode will prevent Bare Metal service from"},{"line_number":96,"context_line":"executing periodic tasks associated with the node. This means power state is"},{"line_number":97,"context_line":"not synced while a node is in this mode. This will also prevent"},{"line_number":98,"context_line":"Compute service from placing a tenant instance on the node by not exposing"},{"line_number":99,"context_line":"the node to the nova scheduler. Nodes can be placed into maintenance mode"},{"line_number":100,"context_line":"with the following command."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_2e9038ed","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":10},"in_reply_to":"3f79a3b5_c4908e46","updated":"2018-08-10 12:51:37.000000000","message":"I concur, this should be clarified for the reader.","commit_id":"124735383f2332017eba58a7d5afd282c8a19581"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"51ca80a73efdc00533c275f1a5799819cc49ac9e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Maintenance mode may be used if you need to take a node out of the resource"},{"line_number":95,"context_line":"pool. Putting a node in maintenance mode will prevent Bare Metal service from"},{"line_number":96,"context_line":"executing periodic tasks associated with the node. This means power state is"},{"line_number":97,"context_line":"not synced while a node is in this mode. This will also prevent"},{"line_number":98,"context_line":"Compute service from placing a tenant instance on the node by not exposing"},{"line_number":99,"context_line":"the node to the nova scheduler. Nodes can be placed into maintenance mode"},{"line_number":100,"context_line":"with the following command."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_08bde2d6","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":10},"in_reply_to":"3f79a3b5_c4908e46","updated":"2018-09-07 09:01:27.000000000","message":"Right. I have removed this sentence.","commit_id":"124735383f2332017eba58a7d5afd282c8a19581"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c9f0cc07f9ddae160a5dbce440eab5e726cb2ee9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"Maintenance mode"},{"line_number":93,"context_line":"----------------"},{"line_number":94,"context_line":"Maintenance mode may be used if you need to take a node out of the resource"},{"line_number":95,"context_line":"pool. Putting a node in maintenance mode will allow to remove the node."},{"line_number":96,"context_line":"This will also prevent Compute service from placing a tenant instance on"},{"line_number":97,"context_line":"the node by not exposing the node to the nova scheduler. Nodes can be placed"},{"line_number":98,"context_line":"into maintenance mode with the following command."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_94a1d9ab","line":95,"updated":"2018-09-23 13:21:00.000000000","message":"+1 I also disagree with this change. You can use maintenance mode to bypass provision state check when removing a node (e.g. you can remove an active node). An available node, however, can be just removed.","commit_id":"0e911c678157c5b8049e2b4f12a1d099059245ef"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"a7c5331fa2ae31440cdf0e9f12c7515659738e32","unresolved":false,"context_lines":[{"line_number":92,"context_line":"Maintenance mode"},{"line_number":93,"context_line":"----------------"},{"line_number":94,"context_line":"Maintenance mode may be used if you need to take a node out of the resource"},{"line_number":95,"context_line":"pool. Putting a node in maintenance mode will allow to remove the node."},{"line_number":96,"context_line":"This will also prevent Compute service from placing a tenant instance on"},{"line_number":97,"context_line":"the node by not exposing the node to the nova scheduler. Nodes can be placed"},{"line_number":98,"context_line":"into maintenance mode with the following command."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_5be882dd","line":95,"range":{"start_line":95,"start_character":6,"end_line":95,"end_character":70},"updated":"2018-09-07 09:48:06.000000000","message":"This slightly changed the meaning of the original text, which is not quite true. A node can be removed if it is not holding an instance, despite of it\u0027s maintenance mode.","commit_id":"0e911c678157c5b8049e2b4f12a1d099059245ef"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"ee8434146029d48f78a33b14f9a81e63df86156c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"Maintenance mode"},{"line_number":93,"context_line":"----------------"},{"line_number":94,"context_line":"Maintenance mode may be used if you need to take a node out of the resource"},{"line_number":95,"context_line":"pool. Putting a node in maintenance mode will allow to remove the node."},{"line_number":96,"context_line":"This will also prevent Compute service from placing a tenant instance on"},{"line_number":97,"context_line":"the node by not exposing the node to the nova scheduler. Nodes can be placed"},{"line_number":98,"context_line":"into maintenance mode with the following command."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_e56e592b","line":95,"range":{"start_line":95,"start_character":6,"end_line":95,"end_character":70},"in_reply_to":"3f79a3b5_5be882dd","updated":"2018-09-24 04:00:42.000000000","message":"Yep. remove exist sentence with my sentence will correct meaning for maitainace mode. Thanks","commit_id":"0e911c678157c5b8049e2b4f12a1d099059245ef"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"ee8434146029d48f78a33b14f9a81e63df86156c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"Maintenance mode"},{"line_number":93,"context_line":"----------------"},{"line_number":94,"context_line":"Maintenance mode may be used if you need to take a node out of the resource"},{"line_number":95,"context_line":"pool. Putting a node in maintenance mode will allow to remove the node."},{"line_number":96,"context_line":"This will also prevent Compute service from placing a tenant instance on"},{"line_number":97,"context_line":"the node by not exposing the node to the nova scheduler. Nodes can be placed"},{"line_number":98,"context_line":"into maintenance mode with the following command."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_45570d5c","line":95,"in_reply_to":"3f79a3b5_94a1d9ab","updated":"2018-09-24 04:00:42.000000000","message":"Yep. Just be removed with active/avaiable node. I will remove this sentence and exist sentence for clear.","commit_id":"0e911c678157c5b8049e2b4f12a1d099059245ef"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"c6e7cd1e21d9ce2fb0fcbd1247a65d8a333afa06","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Maintenance mode may be used if you need to take a node out of the resource"},{"line_number":95,"context_line":"pool. This will also prevent Compute service from placing a tenant instance on"},{"line_number":96,"context_line":"the node by not exposing the node to the nova scheduler. Nodes can be placed"},{"line_number":97,"context_line":"into maintenance mode with the following command."},{"line_number":98,"context_line":"::"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    $ openstack baremetal node maintenance set $NODE_UUID"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_e255ba1f","line":97,"updated":"2018-09-26 06:05:52.000000000","message":"TBO it\u0027s a valid change, so I am going to +1 on it, but I don\u0027t think this can help users troubleshooting maintenance related issues.\n\nFrom my points of view, ideally the context here could be:\n* Several cases a node would enter maintenance, set by ironic, set by user etc.\n* How to troubleshoot each type of maintenance, we could refer to other docs as well.\n* Removing a node by setting it\u0027s maintenance mode will lead to resource leaks, users may want to know how to do a manual clean up before doing this, for example, deleting vif ports created at neutron, cleaning pxe config files at conductor nodes, etc.\n\nThat would be a good addition I think.","commit_id":"cf66027a0897ca3df11dc7a2489eab44de448b08"}]}