)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4623be0cb0f89e81680f09de008b4c6e02a10c62","unresolved":false,"context_lines":[{"line_number":11,"context_line":"so when automated cleanup is enabled generally, all the"},{"line_number":12,"context_line":"nodes will be cleaned. If some node needs to be skipped,"},{"line_number":13,"context_line":"automated_cleanup needs to be change to False."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I47f4c4097f849472be54d2be81e1440b8f349edb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_a0280698","line":14,"updated":"2018-07-25 18:17:53.000000000","message":"story #?","commit_id":"616d9f5d9863e66152d9e1f625ac2c9d5d299847"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"026095213caf89eaa5bdd4b105866693ebe66440","unresolved":false,"context_lines":[{"line_number":13,"context_line":"automated_cleanup needs to be change to False."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I47f4c4097f849472be54d2be81e1440b8f349edb"},{"line_number":16,"context_line":"Story: #2002161"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3f79a3b5_75bfa2a9","line":16,"updated":"2018-08-14 08:47:14.000000000","message":"nit: missing a task number","commit_id":"a7b6e4981b9652af451a68cdaa969bc2b7d39c31"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"968fc8b51a515fa1f87cfd5ed5c1e8c90b46f7ea","unresolved":false,"context_lines":[{"line_number":10,"context_line":"will be enabled on the node. The default will be true,"},{"line_number":11,"context_line":"so when automated cleanup is enabled generally, all the"},{"line_number":12,"context_line":"nodes will be cleaned. If some node needs to be skipped,"},{"line_number":13,"context_line":"automated_cleanup needs to be change to False."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I47f4c4097f849472be54d2be81e1440b8f349edb"},{"line_number":16,"context_line":"Story: #2002161"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3f79a3b5_04c394ee","line":13,"updated":"2018-08-25 11:20:13.000000000","message":"I think everything here is incorrect: the default matches the configuration default, and some core folks object to accepting False. Still, the code change itself is correct, so I\u0027m fine with approving it.","commit_id":"94f0cedc98a1e21442633906a43c83b33b7c8702"}],"ironic/db/sqlalchemy/alembic/versions/d2b036ae9378_add_automated_clean_field.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"66169e721a3aa44e90669124c8d6080c75447c3e","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def upgrade():"},{"line_number":30,"context_line":"    # ### commands auto generated by Alembic - please adjust! ###"},{"line_number":31,"context_line":"    op.add_column(\u0027nodes\u0027, sa.Column(\u0027automated_clean\u0027, sa.Boolean(),"},{"line_number":32,"context_line":"                                     nullable\u003dTrue))"},{"line_number":33,"context_line":"    # ### end Alembic commands ###"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_c76b931b","line":30,"updated":"2018-08-11 14:46:14.000000000","message":"nit: remove","commit_id":"0f57e042252a64c9465c660cc62b2516b245ebef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"66169e721a3aa44e90669124c8d6080c75447c3e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    # ### commands auto generated by Alembic - please adjust! ###"},{"line_number":31,"context_line":"    op.add_column(\u0027nodes\u0027, sa.Column(\u0027automated_clean\u0027, sa.Boolean(),"},{"line_number":32,"context_line":"                                     nullable\u003dTrue))"},{"line_number":33,"context_line":"    # ### end Alembic commands ###"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_6774fffe","line":33,"updated":"2018-08-11 14:46:14.000000000","message":"ditto","commit_id":"0f57e042252a64c9465c660cc62b2516b245ebef"}],"ironic/db/sqlalchemy/models.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4623be0cb0f89e81680f09de008b4c6e02a10c62","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    inspection_finished_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":176,"context_line":"    inspection_started_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":177,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"},{"line_number":178,"context_line":"    automated_clean \u003d Column(Boolean, default\u003dTrue)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    bios_interface \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":181,"context_line":"    boot_interface \u003d Column(String(255), nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e01efe73","line":178,"updated":"2018-07-25 18:17:53.000000000","message":"Ideally this should be None, and then we just fallback on the conductor\u0027s default setting.","commit_id":"616d9f5d9863e66152d9e1f625ac2c9d5d299847"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"5651c89d438705fbfbf86d875c0633032c20bf72","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    inspection_finished_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":176,"context_line":"    inspection_started_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":177,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"},{"line_number":178,"context_line":"    automated_clean \u003d Column(Boolean, default\u003dTrue)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    bios_interface \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":181,"context_line":"    boot_interface \u003d Column(String(255), nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f0dc8244","line":178,"in_reply_to":"5f7c97a3_b04a8a21","updated":"2018-07-26 07:11:13.000000000","message":"we discussed the options and we are not going to negate it. If we set automated_clean\u003dTrue here , the node will perform the clean. It will combine the option with the ones of the default config, and this will take priority...","commit_id":"616d9f5d9863e66152d9e1f625ac2c9d5d299847"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"7b769f195cfe3a644bd57c8b3d64b8c73c89bfdf","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    inspection_finished_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":176,"context_line":"    inspection_started_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":177,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"},{"line_number":178,"context_line":"    automated_clean \u003d Column(Boolean, default\u003dTrue)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    bios_interface \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":181,"context_line":"    boot_interface \u003d Column(String(255), nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b04a8a21","line":178,"in_reply_to":"5f7c97a3_e01efe73","updated":"2018-07-26 07:05:19.000000000","message":"++ something like skip_automated_clean","commit_id":"616d9f5d9863e66152d9e1f625ac2c9d5d299847"}]}