)]}'
{"ironic/drivers/modules/irmc/raid.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"00e80dac2b8d14fe2a7982d72bcaefb9f510e760","unresolved":false,"context_lines":[{"line_number":503,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def _resume_cleaning(self, task):"},{"line_number":506,"context_line":"        raid_common.update_raid_info(task.node, task.node.raid_config)"},{"line_number":507,"context_line":"        manager_utils.notify_conductor_resume_clean(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_8dfdf00a","line":506,"range":{"start_line":506,"start_character":8,"end_line":506,"end_character":70},"updated":"2018-07-26 10:36:21.000000000","message":"This call is already being done at L482 before calling _resume_cleaning().","commit_id":"1e34f1aa2cb37b704430e6d6c34b8b89ad805b49"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"515eac7896a552e91cd0b1b6c58cc01fc4b4871e","unresolved":false,"context_lines":[{"line_number":503,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def _resume_cleaning(self, task):"},{"line_number":506,"context_line":"        raid_common.update_raid_info(task.node, task.node.raid_config)"},{"line_number":507,"context_line":"        manager_utils.notify_conductor_resume_clean(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4759e326","line":506,"range":{"start_line":506,"start_character":8,"end_line":506,"end_character":70},"in_reply_to":"5f7c97a3_8dfdf00a","updated":"2018-07-27 01:26:29.000000000","message":"Right. I will fix them. Thanks","commit_id":"1e34f1aa2cb37b704430e6d6c34b8b89ad805b49"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"00e80dac2b8d14fe2a7982d72bcaefb9f510e760","unresolved":false,"context_lines":[{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def _resume_cleaning(self, task):"},{"line_number":506,"context_line":"        raid_common.update_raid_info(task.node, task.node.raid_config)"},{"line_number":507,"context_line":"        manager_utils.notify_conductor_resume_clean(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_6045fb43","line":507,"range":{"start_line":507,"start_character":8,"end_line":507,"end_character":57},"updated":"2018-07-26 10:36:21.000000000","message":"As I understand RAID operation needs reboot. Dont we need to update the same fix here as done for BIOS in [1]?\n\n[1] https://review.openstack.org/#/c/585936/1/ironic/drivers/modules/irmc/bios.py","commit_id":"1e34f1aa2cb37b704430e6d6c34b8b89ad805b49"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"515eac7896a552e91cd0b1b6c58cc01fc4b4871e","unresolved":false,"context_lines":[{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def _resume_cleaning(self, task):"},{"line_number":506,"context_line":"        raid_common.update_raid_info(task.node, task.node.raid_config)"},{"line_number":507,"context_line":"        manager_utils.notify_conductor_resume_clean(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e77eef6b","line":507,"range":{"start_line":507,"start_character":8,"end_line":507,"end_character":57},"in_reply_to":"5f7c97a3_6045fb43","updated":"2018-07-27 01:26:29.000000000","message":"yep. RAID operation in irmc driver doesn\u0027t require to reboot node/ BM. Thus we don\u0027t need fix them in same way of BIOS operation. I also have tested video in following: https://www.youtube.com/playlist?list\u003dPLVMnqzl_peRG6Y4vvjK4_z7OMbaOPB9Yr","commit_id":"1e34f1aa2cb37b704430e6d6c34b8b89ad805b49"}]}