)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4f5b965bd0c36a8b5f5fb0dcd95c1f9f0dc41252","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yolanda Robla \u003cyroblamo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-20 12:06:55 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add functionality for individual cleanup on nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Story: #2002161"},{"line_number":10,"context_line":"Task: #24579"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3f79a3b5_e4645824","line":7,"updated":"2018-08-25 11:24:54.000000000","message":"nit: s/cleanup/cleaning/","commit_id":"2622e59dd1ce1cdf7082dcf74753bfe5f83936cc"}],"ironic/common/release_mappings.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f3ea62c0bad876d4ef05df5dac1f3b99a8f3ae28","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        \u0027api\u0027: \u00271.46\u0027,"},{"line_number":135,"context_line":"        \u0027rpc\u0027: \u00271.47\u0027,"},{"line_number":136,"context_line":"        \u0027objects\u0027: {"},{"line_number":137,"context_line":"            \u0027Node\u0027: [\u00271.28\u0027, \u00271.27\u0027],"},{"line_number":138,"context_line":"            \u0027Conductor\u0027: [\u00271.3\u0027],"},{"line_number":139,"context_line":"            \u0027Chassis\u0027: [\u00271.3\u0027],"},{"line_number":140,"context_line":"            \u0027Port\u0027: [\u00271.8\u0027],"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_8888f921","line":137,"range":{"start_line":137,"start_character":29,"end_line":137,"end_character":35},"updated":"2018-10-04 05:53:39.000000000","message":"\u00271.27\u0027 is not necessary. This list should contain only added versions in the current release.","commit_id":"8dc2f5e2ae83f8506bc5e6e5d83c888313464801"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a0bd76a5346f083d4eb42ed8dab62498e3d7b5f6","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        \u0027api\u0027: \u00271.46\u0027,"},{"line_number":135,"context_line":"        \u0027rpc\u0027: \u00271.47\u0027,"},{"line_number":136,"context_line":"        \u0027objects\u0027: {"},{"line_number":137,"context_line":"            \u0027Node\u0027: [\u00271.28\u0027, \u00271.27\u0027],"},{"line_number":138,"context_line":"            \u0027Conductor\u0027: [\u00271.3\u0027],"},{"line_number":139,"context_line":"            \u0027Chassis\u0027: [\u00271.3\u0027],"},{"line_number":140,"context_line":"            \u0027Port\u0027: [\u00271.8\u0027],"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_2b919f9a","line":137,"range":{"start_line":137,"start_character":29,"end_line":137,"end_character":35},"in_reply_to":"3f79a3b5_8888f921","updated":"2018-10-04 05:55:44.000000000","message":"+1","commit_id":"8dc2f5e2ae83f8506bc5e6e5d83c888313464801"}],"ironic/conductor/manager.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"f53e43bfbb815b49534d3dfeb93777617570ba32","unresolved":false,"context_lines":[{"line_number":1200,"context_line":"        LOG.debug(\u0027Starting %(type)s cleaning for node %(node)s\u0027,"},{"line_number":1201,"context_line":"                  {\u0027type\u0027: clean_type, \u0027node\u0027: node.uuid})"},{"line_number":1202,"context_line":""},{"line_number":1203,"context_line":"        # NOTE(yolanda): if we are not doing a manual cleanup and..."},{"line_number":1204,"context_line":"        # and the individual automated cleanup on the node is disabled"},{"line_number":1205,"context_line":"        # or the general automated cleanup is disabled and the individual"},{"line_number":1206,"context_line":"        # automated cleanup in the node is not enabled"},{"line_number":1207,"context_line":"        if (not manual_clean and"},{"line_number":1208,"context_line":"                (node.automated_clean is False or"},{"line_number":1209,"context_line":"                 (not CONF.conductor.automated_clean and"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_f3b6678a","line":1206,"range":{"start_line":1203,"start_character":62,"end_line":1206,"end_character":54},"updated":"2018-08-14 14:07:38.000000000","message":"nit: may be the bullet points would help readers to comprehend the logic?","commit_id":"d6de6e4fdcd5a8019647fee4127e287a3f17d739"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"f53e43bfbb815b49534d3dfeb93777617570ba32","unresolved":false,"context_lines":[{"line_number":1205,"context_line":"        # or the general automated cleanup is disabled and the individual"},{"line_number":1206,"context_line":"        # automated cleanup in the node is not enabled"},{"line_number":1207,"context_line":"        if (not manual_clean and"},{"line_number":1208,"context_line":"                (node.automated_clean is False or"},{"line_number":1209,"context_line":"                 (not CONF.conductor.automated_clean and"},{"line_number":1210,"context_line":"                  node.automated_clean is not True))):"},{"line_number":1211,"context_line":"            # Skip cleaning, move to AVAILABLE."}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_737577f9","line":1208,"range":{"start_line":1208,"start_character":38,"end_line":1208,"end_character":39},"updated":"2018-08-14 14:07:38.000000000","message":"I vaguely remember a discussion on a tri-state logic somethere in ironic. Is this it?\n\nIf not, why not `not node.automated_clean`?","commit_id":"d6de6e4fdcd5a8019647fee4127e287a3f17d739"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"c9a90476942da3fff5759ee5c57f68d0ae8179db","unresolved":false,"context_lines":[{"line_number":1205,"context_line":"        # or the general automated cleanup is disabled and the individual"},{"line_number":1206,"context_line":"        # automated cleanup in the node is not enabled"},{"line_number":1207,"context_line":"        if (not manual_clean and"},{"line_number":1208,"context_line":"                (node.automated_clean is False or"},{"line_number":1209,"context_line":"                 (not CONF.conductor.automated_clean and"},{"line_number":1210,"context_line":"                  node.automated_clean is not True))):"},{"line_number":1211,"context_line":"            # Skip cleaning, move to AVAILABLE."}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_f333b8a9","line":1208,"range":{"start_line":1208,"start_character":38,"end_line":1208,"end_character":39},"in_reply_to":"3f79a3b5_737577f9","updated":"2018-08-15 02:10:01.000000000","message":"Yeah, there is discussion at storyboard, Dmitry proposed a tri-state field, ``None`` for global configuration option, so this can\u0027t be ``not node.automated_clean`` because ``not None`` is True.\n\nBut I feel this conditional check is a bit complex, would like to see it separated :)","commit_id":"d6de6e4fdcd5a8019647fee4127e287a3f17d739"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"35719411124574a8315ce665b7f7f0da8cdb9604","unresolved":false,"context_lines":[{"line_number":1205,"context_line":"        # or the general automated cleanup is disabled and the individual"},{"line_number":1206,"context_line":"        # automated cleanup in the node is not enabled"},{"line_number":1207,"context_line":"        if (not manual_clean and"},{"line_number":1208,"context_line":"                (node.automated_clean is False or"},{"line_number":1209,"context_line":"                 (not CONF.conductor.automated_clean and"},{"line_number":1210,"context_line":"                  node.automated_clean is not True))):"},{"line_number":1211,"context_line":"            # Skip cleaning, move to AVAILABLE."}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_45c27feb","line":1208,"range":{"start_line":1208,"start_character":38,"end_line":1208,"end_character":39},"in_reply_to":"3f79a3b5_737577f9","updated":"2018-09-20 10:06:16.000000000","message":"this is to compare with False, and to avoid mistakes with None","commit_id":"d6de6e4fdcd5a8019647fee4127e287a3f17d739"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"f53e43bfbb815b49534d3dfeb93777617570ba32","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"        if (not manual_clean and"},{"line_number":1208,"context_line":"                (node.automated_clean is False or"},{"line_number":1209,"context_line":"                 (not CONF.conductor.automated_clean and"},{"line_number":1210,"context_line":"                  node.automated_clean is not True))):"},{"line_number":1211,"context_line":"            # Skip cleaning, move to AVAILABLE."},{"line_number":1212,"context_line":"            node.clean_step \u003d None"},{"line_number":1213,"context_line":"            node.save()"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_f35ae780","line":1210,"range":{"start_line":1210,"start_character":18,"end_line":1210,"end_character":50},"updated":"2018-08-14 14:07:38.000000000","message":"Can it be `not node.automated_clean`?","commit_id":"d6de6e4fdcd5a8019647fee4127e287a3f17d739"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"ef9ad1ea117f7ca0ed357aeacd115d88159dc845","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"        if (not manual_clean and"},{"line_number":1208,"context_line":"                (node.automated_clean is False or"},{"line_number":1209,"context_line":"                 (not CONF.conductor.automated_clean and"},{"line_number":1210,"context_line":"                  node.automated_clean is not True))):"},{"line_number":1211,"context_line":"            # Skip cleaning, move to AVAILABLE."},{"line_number":1212,"context_line":"            node.clean_step \u003d None"},{"line_number":1213,"context_line":"            node.save()"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_45991f1d","line":1210,"range":{"start_line":1210,"start_character":18,"end_line":1210,"end_character":50},"in_reply_to":"3f79a3b5_f35ae780","updated":"2018-08-20 09:58:13.000000000","message":"no, it can be False or None","commit_id":"d6de6e4fdcd5a8019647fee4127e287a3f17d739"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4f5b965bd0c36a8b5f5fb0dcd95c1f9f0dc41252","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"        if (not manual_clean and"},{"line_number":1208,"context_line":"                (node.automated_clean is False or"},{"line_number":1209,"context_line":"                 (not CONF.conductor.automated_clean and"},{"line_number":1210,"context_line":"                  node.automated_clean in [False, None]))):"},{"line_number":1211,"context_line":"            # Skip cleaning, move to AVAILABLE."},{"line_number":1212,"context_line":"            node.clean_step \u003d None"},{"line_number":1213,"context_line":"            node.save()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_a46ae0e9","line":1210,"updated":"2018-08-25 11:24:54.000000000","message":"++ for a helper, and for now we agreed to not accept False, only True and None. This is because there is strong objection to allow disabling cleaning, especially without the ability to properly audit such changes.","commit_id":"2622e59dd1ce1cdf7082dcf74753bfe5f83936cc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"11e8644f30117ea650c8f1a71000d8d015b54a5b","unresolved":false,"context_lines":[{"line_number":1205,"context_line":"        # or the general automated cleanup is disabled and the individual"},{"line_number":1206,"context_line":"        # automated cleanup in the node is not enabled"},{"line_number":1207,"context_line":"        if (not manual_clean and"},{"line_number":1208,"context_line":"                (node.automated_clean is False or"},{"line_number":1209,"context_line":"                 (not CONF.conductor.automated_clean and"},{"line_number":1210,"context_line":"                  node.automated_clean in [False, None]))):"},{"line_number":1211,"context_line":"            # Skip cleaning, move to AVAILABLE."},{"line_number":1212,"context_line":"            node.clean_step \u003d None"},{"line_number":1213,"context_line":"            node.save()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_cc0aac24","line":1210,"range":{"start_line":1208,"start_character":17,"end_line":1210,"end_character":56},"updated":"2018-08-24 20:37:16.000000000","message":"I think we need to put this in a utility helper...\n\nAlso, discussion as of Thursday in IRC regarding this. My mind is a little too fried from this week to correctly summarize, but each path is valid I think.","commit_id":"2622e59dd1ce1cdf7082dcf74753bfe5f83936cc"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"35719411124574a8315ce665b7f7f0da8cdb9604","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"        if (not manual_clean and"},{"line_number":1208,"context_line":"                (node.automated_clean is False or"},{"line_number":1209,"context_line":"                 (not CONF.conductor.automated_clean and"},{"line_number":1210,"context_line":"                  node.automated_clean in [False, None]))):"},{"line_number":1211,"context_line":"            # Skip cleaning, move to AVAILABLE."},{"line_number":1212,"context_line":"            node.clean_step \u003d None"},{"line_number":1213,"context_line":"            node.save()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_33a8fb1e","line":1210,"in_reply_to":"3f79a3b5_a46ae0e9","updated":"2018-09-20 10:06:16.000000000","message":"If we do not accept false, it will mean that when introspection is enabled, we cannot disable at node level?","commit_id":"2622e59dd1ce1cdf7082dcf74753bfe5f83936cc"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"c4351828f77faaccea19c9099e7038426d5c0686","unresolved":false,"context_lines":[{"line_number":1184,"context_line":"                self._do_next_clean_step,"},{"line_number":1185,"context_line":"                task, next_step_index)"},{"line_number":1186,"context_line":""},{"line_number":1187,"context_line":"    def _skip_node_clean(self, node, manual_clean):"},{"line_number":1188,"context_line":"        # we skip node cleaning if we are not doing a manual cleanup"},{"line_number":1189,"context_line":"        # and the general node cleanup is disabled, and also the individual"},{"line_number":1190,"context_line":"        # node cleanup is not enabled"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_65127fff","line":1187,"range":{"start_line":1187,"start_character":4,"end_line":1187,"end_character":51},"updated":"2018-09-20 09:05:05.000000000","message":"this could be a function instead of instance method, and probably more suitable to put into conductor.utils\n\nI\u0027d suggest to move manual_clean outside, so that cases like oneview can share the common helper.","commit_id":"3c5ac811f0955e3ff00d17bed27804ff089ab5f5"}],"ironic/conductor/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9173f5ef1efadb954d20ca4107e69c4a6e0aeffd","unresolved":false,"context_lines":[{"line_number":992,"context_line":"                                       \u0027continue_node_deploy\u0027)"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"def node_clean_needs_to_be_skipped(node):"},{"line_number":996,"context_line":"    \"\"\"Checks if node cleaning needs to be skipped for an specific node."},{"line_number":997,"context_line":""},{"line_number":998,"context_line":"    :param node: the node to consider"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_717ad277","line":995,"updated":"2018-09-26 09:39:05.000000000","message":"nit: I\u0027d call it \"skip_automated_cleaning\"","commit_id":"5a082a17cb14b766997e4647833f21eaa9eabdac"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9173f5ef1efadb954d20ca4107e69c4a6e0aeffd","unresolved":false,"context_lines":[{"line_number":997,"context_line":""},{"line_number":998,"context_line":"    :param node: the node to consider"},{"line_number":999,"context_line":"    \"\"\""},{"line_number":1000,"context_line":"    if not CONF.conductor.automated_clean and not node.automated_clean:"},{"line_number":1001,"context_line":"        return True"},{"line_number":1002,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_917d2e6f","line":1000,"updated":"2018-09-26 09:39:05.000000000","message":"nit:\n\n return not CONF.conductor.automated_clean and not node.automated_clean","commit_id":"5a082a17cb14b766997e4647833f21eaa9eabdac"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1c2849c4e8c1d984d339dbb58b7a6318e13728c8","unresolved":false,"context_lines":[{"line_number":997,"context_line":""},{"line_number":998,"context_line":"    :param node: the node to consider"},{"line_number":999,"context_line":"    \"\"\""},{"line_number":1000,"context_line":"    if not CONF.conductor.automated_clean and not node.automated_clean:"},{"line_number":1001,"context_line":"        return True"},{"line_number":1002,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_2a6d2766","line":1000,"updated":"2018-10-03 16:57:38.000000000","message":"nit:\n\n return not CONF.conductor.automated_clean and not node.automated_clean","commit_id":"8dc2f5e2ae83f8506bc5e6e5d83c888313464801"}],"ironic/conf/iscsi.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9173f5ef1efadb954d20ca4107e69c4a6e0aeffd","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    cfg.BoolOpt(\u0027convert_options\u0027,"},{"line_number":27,"context_line":"                default\u003dNone,"},{"line_number":28,"context_line":"                help\u003d_(\u0027The convert options to specify when executing the dd \u0027"},{"line_number":29,"context_line":"                       \u0027copy from the original image to the disk.\u0027)),"},{"line_number":30,"context_line":"]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_d183a654","line":29,"updated":"2018-09-26 09:39:05.000000000","message":"This sneaked in from an unrelated patch","commit_id":"5a082a17cb14b766997e4647833f21eaa9eabdac"}],"ironic/drivers/modules/oneview/deploy.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"62d8611ba911f9185fe926b43044b5fc2d7719b1","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        # teardown if automated clean is disabled on the node"},{"line_number":245,"context_line":"        # or if general automated clean is not enabled generally"},{"line_number":246,"context_line":"        # and not on the node as well"},{"line_number":247,"context_line":"        if task.node.automated_clean \u003d\u003d False or \\"},{"line_number":248,"context_line":"                (not CONF.conductor.automated_clean and"},{"line_number":249,"context_line":"                 task.node.automated_clean !\u003d True):"},{"line_number":250,"context_line":"            deploy_utils.tear_down(task)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_84aa8b17","line":247,"range":{"start_line":247,"start_character":49,"end_line":247,"end_character":50},"updated":"2018-07-27 15:17:47.000000000","message":"nit: we can also do the parenthesis instead of `\\`","commit_id":"077bc5fdda08b1450567a0432da1a0a2e207c5a6"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"62d8611ba911f9185fe926b43044b5fc2d7719b1","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        # teardown if automated clean is disabled on the node"},{"line_number":245,"context_line":"        # or if general automated clean is not enabled generally"},{"line_number":246,"context_line":"        # and not on the node as well"},{"line_number":247,"context_line":"        if task.node.automated_clean \u003d\u003d False or \\"},{"line_number":248,"context_line":"                (not CONF.conductor.automated_clean and"},{"line_number":249,"context_line":"                 task.node.automated_clean !\u003d True):"},{"line_number":250,"context_line":"            deploy_utils.tear_down(task)"},{"line_number":251,"context_line":"        return super(OneViewIscsiDeploy, self).tear_down(task)"},{"line_number":252,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_246e172d","line":249,"range":{"start_line":247,"start_character":8,"end_line":249,"end_character":52},"updated":"2018-07-27 15:17:47.000000000","message":"I guess explicit comparison with `True` and `False` is somehow connected with the 3-state logic discussed on the channel.\n\nMay be a comment explaining this curious situation. ;-)","commit_id":"077bc5fdda08b1450567a0432da1a0a2e207c5a6"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"f53e43bfbb815b49534d3dfeb93777617570ba32","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        # teardown if automated clean is disabled on the node"},{"line_number":245,"context_line":"        # or if general automated clean is not enabled generally"},{"line_number":246,"context_line":"        # and not on the node as well"},{"line_number":247,"context_line":"        if task.node.automated_clean is False or \\"},{"line_number":248,"context_line":"                (not CONF.conductor.automated_clean and"},{"line_number":249,"context_line":"                 task.node.automated_clean is not True):"},{"line_number":250,"context_line":"            deploy_utils.tear_down(task)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_1348c384","line":247,"range":{"start_line":247,"start_character":11,"end_line":247,"end_character":45},"updated":"2018-08-14 14:07:38.000000000","message":"Line #295 has this condition differently. I\u0027d say that #295 form is more Pythonic","commit_id":"d6de6e4fdcd5a8019647fee4127e287a3f17d739"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"11e8644f30117ea650c8f1a71000d8d015b54a5b","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    def tear_down(self, task):"},{"line_number":244,"context_line":"        # teardown if automated clean is disabled on the node"},{"line_number":245,"context_line":"        # or if general automated clean is not enabled generally"},{"line_number":246,"context_line":"        # and not on the node as well"},{"line_number":247,"context_line":"        if task.node.automated_clean is False or \\"},{"line_number":248,"context_line":"                (not CONF.conductor.automated_clean and"},{"line_number":249,"context_line":"                 task.node.automated_clean in [None, False]):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_472af57e","line":246,"updated":"2018-08-24 20:37:16.000000000","message":"Reminds me I can remove this soon-ish.","commit_id":"2622e59dd1ce1cdf7082dcf74753bfe5f83936cc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0f23bc1062a5e303b0244e93ffeb310b3b538610","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        # teardown if automated clean is disabled on the node"},{"line_number":246,"context_line":"        # or if general automated clean is not enabled generally"},{"line_number":247,"context_line":"        # and not on the node as well"},{"line_number":248,"context_line":"        if utils.skip_automated_cleaning(task.node):"},{"line_number":249,"context_line":"            deploy_utils.tear_down(task)"},{"line_number":250,"context_line":"        return super(OneViewIscsiDeploy, self).tear_down(task)"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_aecb441b","line":248,"updated":"2018-10-07 15:17:26.000000000","message":"This is un-necessary, the oneview interfaces will be removed soon.","commit_id":"869b86e0c3edc0d285502d1a9c2cb4c76d4c7e2c"}],"ironic/objects/node.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"10240614d718af8ad16eb38270675ed2f656d2c1","unresolved":false,"context_lines":[{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    # NOTE (yolanda): new method created to avoid repeating code in"},{"line_number":534,"context_line":"    # _convert_to_version, and to avoid pep8 too complex error"},{"line_number":535,"context_line":"    def _adjust_field_to_version(self, field_name, field_default_value,"},{"line_number":536,"context_line":"                                 target_version, major, minor,"},{"line_number":537,"context_line":"                                 remove_unavailable_fields):"},{"line_number":538,"context_line":"        field_is_set \u003d self.obj_attr_is_set(field_name)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_cf1e850c","line":535,"updated":"2018-09-27 12:08:11.000000000","message":"it might make sense to move this into base class.","commit_id":"5a082a17cb14b766997e4647833f21eaa9eabdac"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9173f5ef1efadb954d20ca4107e69c4a6e0aeffd","unresolved":false,"context_lines":[{"line_number":587,"context_line":"        # Convert the different fields depending on version"},{"line_number":588,"context_line":"        fields \u003d [(\u0027rescue_interface\u0027, 1, 22), (\u0027traits\u0027, 1, 23),"},{"line_number":589,"context_line":"                  (\u0027bios_interface\u0027, 1, 24), (\u0027automated_clean\u0027, 1, 28)]"},{"line_number":590,"context_line":"        for field in fields:"},{"line_number":591,"context_line":"            self._adjust_field_to_version(field[0], None, target_version,"},{"line_number":592,"context_line":"                                          field[1], field[2],"},{"line_number":593,"context_line":"                                          remove_unavailable_fields)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_31945a8c","line":590,"updated":"2018-09-26 09:39:05.000000000","message":"better:\n\n for name, major, minor in fields:\n\ngiven that major is always 1, you can skip it as well\n\n for name, minor in fields:","commit_id":"5a082a17cb14b766997e4647833f21eaa9eabdac"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"ec11bc316ad251b65e3982dddbf2ff29b6c0bb3b","unresolved":false,"context_lines":[{"line_number":587,"context_line":"        # Convert the different fields depending on version"},{"line_number":588,"context_line":"        fields \u003d [(\u0027rescue_interface\u0027, 1, 22), (\u0027traits\u0027, 1, 23),"},{"line_number":589,"context_line":"                  (\u0027bios_interface\u0027, 1, 24), (\u0027automated_clean\u0027, 1, 28)]"},{"line_number":590,"context_line":"        for field in fields:"},{"line_number":591,"context_line":"            self._adjust_field_to_version(field[0], None, target_version,"},{"line_number":592,"context_line":"                                          field[1], field[2],"},{"line_number":593,"context_line":"                                          remove_unavailable_fields)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_67641ce6","line":590,"in_reply_to":"3f79a3b5_31945a8c","updated":"2018-09-28 13:40:28.000000000","message":"It is a list of lists , cannot iterate like you said, gives syntax error","commit_id":"5a082a17cb14b766997e4647833f21eaa9eabdac"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"95569d3731e72db4aaa84598a22067df09bb357b","unresolved":false,"context_lines":[{"line_number":587,"context_line":"        # Convert the different fields depending on version"},{"line_number":588,"context_line":"        fields \u003d [(\u0027rescue_interface\u0027, 1, 22), (\u0027traits\u0027, 1, 23),"},{"line_number":589,"context_line":"                  (\u0027bios_interface\u0027, 1, 24), (\u0027automated_clean\u0027, 1, 28)]"},{"line_number":590,"context_line":"        for field in fields:"},{"line_number":591,"context_line":"            self._adjust_field_to_version(field[0], None, target_version,"},{"line_number":592,"context_line":"                                          field[1], field[2],"},{"line_number":593,"context_line":"                                          remove_unavailable_fields)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_9802f507","line":590,"in_reply_to":"3f79a3b5_67641ce6","updated":"2018-09-28 13:44:44.000000000","message":"http://paste.openstack.org/show/731101/","commit_id":"5a082a17cb14b766997e4647833f21eaa9eabdac"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"ea4781af4f394acf493cd9dc7e05ead50efa0bae","unresolved":false,"context_lines":[{"line_number":587,"context_line":"        # Convert the different fields depending on version"},{"line_number":588,"context_line":"        fields \u003d [(\u0027rescue_interface\u0027, 1, 22), (\u0027traits\u0027, 1, 23),"},{"line_number":589,"context_line":"                  (\u0027bios_interface\u0027, 1, 24), (\u0027automated_clean\u0027, 1, 28)]"},{"line_number":590,"context_line":"        for field in fields:"},{"line_number":591,"context_line":"            self._adjust_field_to_version(field[0], None, target_version,"},{"line_number":592,"context_line":"                                          field[1], field[2],"},{"line_number":593,"context_line":"                                          remove_unavailable_fields)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_cfa5c9b5","line":590,"in_reply_to":"3f79a3b5_9802f507","updated":"2018-10-02 10:43:27.000000000","message":"nit: can be a `tuple` which is in theory cheaper than list:\n\n\u003e\u003e\u003e fields \u003d (\u0027rescue_interface\u0027, 1, 22), (\u0027traits\u0027, 1, 23), (\u0027bios_interface\u0027, 1, 24), (\u0027automated_clean\u0027, 1, 28)","commit_id":"5a082a17cb14b766997e4647833f21eaa9eabdac"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"ea4781af4f394acf493cd9dc7e05ead50efa0bae","unresolved":false,"context_lines":[{"line_number":589,"context_line":"                  (\u0027bios_interface\u0027, 1, 24), (\u0027automated_clean\u0027, 1, 28)]"},{"line_number":590,"context_line":"        for field in fields:"},{"line_number":591,"context_line":"            self._adjust_field_to_version(field[0], None, target_version,"},{"line_number":592,"context_line":"                                          field[1], field[2],"},{"line_number":593,"context_line":"                                          remove_unavailable_fields)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        self._convert_fault_field(target_version, remove_unavailable_fields)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_8f7cb120","line":592,"range":{"start_line":592,"start_character":42,"end_line":592,"end_character":50},"updated":"2018-10-02 10:43:27.000000000","message":"nit: This value seems to be a constant e.g. `1`. Could we remove it from `fields`?","commit_id":"5a082a17cb14b766997e4647833f21eaa9eabdac"}],"ironic/tests/unit/api/utils.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f2aba6fd513cad9adbd742a252563e87911a6854","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        node.pop(\u0027resource_class\u0027)"},{"line_number":114,"context_line":"    if \u0027fault\u0027 not in kw:"},{"line_number":115,"context_line":"        node.pop(\u0027fault\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    internal \u003d node_controller.NodePatchType.internal_attrs()"},{"line_number":118,"context_line":"    return remove_internal(node, internal)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_56b59e7b","line":116,"updated":"2018-10-04 07:25:14.000000000","message":"It would be pop \u0027automated_clean\u0027 here with a similar condition above because this can be used for a POST request with the next patch.","commit_id":"8dc2f5e2ae83f8506bc5e6e5d83c888313464801"}],"ironic/tests/unit/conductor/test_manager.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"10240614d718af8ad16eb38270675ed2f656d2c1","unresolved":false,"context_lines":[{"line_number":3309,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.network.flat.FlatNetwork.validate\u0027,"},{"line_number":3310,"context_line":"                autospec\u003dTrue)"},{"line_number":3311,"context_line":"    def test__do_node_clean_automated_disabled_individual_enabled("},{"line_number":3312,"context_line":"            self, mock_validate, mock_network):"},{"line_number":3313,"context_line":"        self.config(automated_clean\u003dFalse, group\u003d\u0027conductor\u0027)"},{"line_number":3314,"context_line":""},{"line_number":3315,"context_line":"        self._start_service()"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_afe8e9de","line":3312,"range":{"start_line":3312,"start_character":18,"end_line":3312,"end_character":45},"updated":"2018-09-27 12:08:11.000000000","message":"the order of arguments is incorrect here","commit_id":"5a082a17cb14b766997e4647833f21eaa9eabdac"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"10240614d718af8ad16eb38270675ed2f656d2c1","unresolved":false,"context_lines":[{"line_number":3324,"context_line":"        self._stop_service()"},{"line_number":3325,"context_line":"        node.refresh()"},{"line_number":3326,"context_line":""},{"line_number":3327,"context_line":"        # Assert that the node clean was called"},{"line_number":3328,"context_line":"        self.assertTrue(mock_validate.called)"},{"line_number":3329,"context_line":"        self.assertIn(\u0027clean_steps\u0027, node.driver_internal_info)"},{"line_number":3330,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_4fb915ea","line":3327,"range":{"start_line":3327,"start_character":31,"end_line":3327,"end_character":36},"updated":"2018-09-27 12:08:11.000000000","message":"next line asserts call of ironic.drivers.modules.network.flat.FlatNetwork.validate","commit_id":"5a082a17cb14b766997e4647833f21eaa9eabdac"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"10240614d718af8ad16eb38270675ed2f656d2c1","unresolved":false,"context_lines":[{"line_number":3382,"context_line":"                autospec\u003dTrue)"},{"line_number":3383,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.network.flat.FlatNetwork.validate\u0027,"},{"line_number":3384,"context_line":"                autospec\u003dTrue)"},{"line_number":3385,"context_line":"    def test__do_node_clean_automated_enabled_individual_enabled("},{"line_number":3386,"context_line":"            self, mock_validate, mock_network):"},{"line_number":3387,"context_line":"        self.config(automated_clean\u003dTrue, group\u003d\u0027conductor\u0027)"},{"line_number":3388,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_cfcc458c","line":3385,"updated":"2018-09-27 12:08:11.000000000","message":"same comments for this test","commit_id":"5a082a17cb14b766997e4647833f21eaa9eabdac"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"ec11bc316ad251b65e3982dddbf2ff29b6c0bb3b","unresolved":false,"context_lines":[{"line_number":3382,"context_line":"                autospec\u003dTrue)"},{"line_number":3383,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.network.flat.FlatNetwork.validate\u0027,"},{"line_number":3384,"context_line":"                autospec\u003dTrue)"},{"line_number":3385,"context_line":"    def test__do_node_clean_automated_enabled_individual_enabled("},{"line_number":3386,"context_line":"            self, mock_validate, mock_network):"},{"line_number":3387,"context_line":"        self.config(automated_clean\u003dTrue, group\u003d\u0027conductor\u0027)"},{"line_number":3388,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_ad445574","line":3385,"in_reply_to":"3f79a3b5_cfcc458c","updated":"2018-09-28 13:40:28.000000000","message":"good catch","commit_id":"5a082a17cb14b766997e4647833f21eaa9eabdac"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1774f28e0869502d94be7df150f08368922631f7","unresolved":false,"context_lines":[{"line_number":3406,"context_line":"                autospec\u003dTrue)"},{"line_number":3407,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.network.flat.FlatNetwork.validate\u0027,"},{"line_number":3408,"context_line":"                autospec\u003dTrue)"},{"line_number":3409,"context_line":"    def test__do_node_clean_automated_enabled_individual_none("},{"line_number":3410,"context_line":"            self, mock_validate, mock_network):"},{"line_number":3411,"context_line":"        self.config(automated_clean\u003dTrue, group\u003d\u0027conductor\u0027)"},{"line_number":3412,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_e003790b","line":3409,"updated":"2018-10-08 14:36:14.000000000","message":"++","commit_id":"869b86e0c3edc0d285502d1a9c2cb4c76d4c7e2c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"eb8a75500dcc397dec6d6b3196c8476c2d59a796","unresolved":false,"context_lines":[{"line_number":3406,"context_line":"                autospec\u003dTrue)"},{"line_number":3407,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.network.flat.FlatNetwork.validate\u0027,"},{"line_number":3408,"context_line":"                autospec\u003dTrue)"},{"line_number":3409,"context_line":"    def test__do_node_clean_automated_enabled_individual_none("},{"line_number":3410,"context_line":"            self, mock_validate, mock_network):"},{"line_number":3411,"context_line":"        self.config(automated_clean\u003dTrue, group\u003d\u0027conductor\u0027)"},{"line_number":3412,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_d3a980de","line":3409,"range":{"start_line":3409,"start_character":8,"end_line":3409,"end_character":61},"updated":"2018-10-08 06:27:26.000000000","message":"The following 4 testcases are for similar behavior, with difference in value for value of config \u0027automated_clean\u0027 and/or value of \u0027automated_clean\u0027 attribute on node. May be we could have a common testcase that accepts these as arguments and use it in these test cases.\n1. test__do_node_clean_automated_disabled_individual_enabled\n2. test__do_node_clean_automated_enabled\n3. test__do_node_clean_automated_enabled_individual_enabled\n4. test__do_node_clean_automated_enabled_individual_none","commit_id":"869b86e0c3edc0d285502d1a9c2cb4c76d4c7e2c"}],"releasenotes/notes/automated_clean_per_node-f3f7f3e3d8b173ad.yaml":[{"author":{"_account_id":18480,"name":"zhengy","email":"zhengy23@163.com","username":"zhengyong"},"change_message_id":"e2f923b5200e8d9bef56929dcf650060ae768e3e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the feature of enabling automated cleanup per node. If automated"},{"line_number":5,"context_line":"    cleanup is disabled but enabled on the node, it still will be performed on"},{"line_number":6,"context_line":"    it. Also, if the automated cleanup is disabled but enabled on the node,"},{"line_number":7,"context_line":"    it will be performed."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_28f7d3d3","line":6,"range":{"start_line":6,"start_character":42,"end_line":6,"end_character":54},"updated":"2018-07-27 06:54:09.000000000","message":"enabled and ?","commit_id":"2eb7277cf5f81db05c350f762599895844062914"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"f53e43bfbb815b49534d3dfeb93777617570ba32","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the feature of enabling automated cleanup per node. If automated"},{"line_number":5,"context_line":"    cleanup is disabled but enabled on the node, it still will be performed on"},{"line_number":6,"context_line":"    it. Also, if the automated cleanup is disabled but enabled on the node,"},{"line_number":7,"context_line":"    it will be performed."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_133d23dc","line":6,"range":{"start_line":5,"start_character":48,"end_line":6,"end_character":6},"updated":"2018-08-14 14:07:38.000000000","message":"`it` two times - may be rephrase?","commit_id":"d6de6e4fdcd5a8019647fee4127e287a3f17d739"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"f53e43bfbb815b49534d3dfeb93777617570ba32","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds the feature of enabling automated cleanup per node. If automated"},{"line_number":5,"context_line":"    cleanup is disabled but enabled on the node, it still will be performed on"},{"line_number":6,"context_line":"    it. Also, if the automated cleanup is disabled but enabled on the node,"},{"line_number":7,"context_line":"    it will be performed."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_93285397","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":6},"updated":"2018-08-14 14:07:38.000000000","message":"may be `the clean up`?","commit_id":"d6de6e4fdcd5a8019647fee4127e287a3f17d739"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4f5b965bd0c36a8b5f5fb0dcd95c1f9f0dc41252","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds the feature of enabling automated cleanup per node. If automated"},{"line_number":5,"context_line":"    cleanup is disabled but enabled on the node, it still will be performed."},{"line_number":6,"context_line":"    Also, if the automated cleanup is disabled but enabled on the node,"},{"line_number":7,"context_line":"    the clean up will be performed."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_046874f2","line":7,"updated":"2018-08-25 11:24:54.000000000","message":"There is another release note in the API patch. I suggest this patch is moved before the API patch, and the release note is only left there.","commit_id":"2622e59dd1ce1cdf7082dcf74753bfe5f83936cc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9173f5ef1efadb954d20ca4107e69c4a6e0aeffd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the feature of enabling automated cleanup per node. A new"},{"line_number":5,"context_line":"    automated_clean field has been created on the node object, that allows to"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3f79a3b5_518f9675","line":2,"updated":"2018-09-26 09:39:05.000000000","message":"The whole release note should be moved to the API patch.","commit_id":"5a082a17cb14b766997e4647833f21eaa9eabdac"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9173f5ef1efadb954d20ca4107e69c4a6e0aeffd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the feature of enabling automated cleanup per node. A new"},{"line_number":5,"context_line":"    automated_clean field has been created on the node object, that allows to"},{"line_number":6,"context_line":"    override general automated_clean field. When automated_clean is disabled at"},{"line_number":7,"context_line":"    global level, but enabled at node level, the automated clean will be"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3f79a3b5_f18d827c","line":4,"updated":"2018-09-26 09:39:05.000000000","message":"\"Allows enabling automated cleaning per node if it is disabled globally.\"","commit_id":"5a082a17cb14b766997e4647833f21eaa9eabdac"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9173f5ef1efadb954d20ca4107e69c4a6e0aeffd","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the feature of enabling automated cleanup per node. A new"},{"line_number":5,"context_line":"    automated_clean field has been created on the node object, that allows to"},{"line_number":6,"context_line":"    override general automated_clean field. When automated_clean is disabled at"},{"line_number":7,"context_line":"    global level, but enabled at node level, the automated clean will be"},{"line_number":8,"context_line":"    performed only on those nodes."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3f79a3b5_11891e6e","line":5,"updated":"2018-09-26 09:39:05.000000000","message":"nit: ``automated_clean``","commit_id":"5a082a17cb14b766997e4647833f21eaa9eabdac"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9173f5ef1efadb954d20ca4107e69c4a6e0aeffd","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the feature of enabling automated cleanup per node. A new"},{"line_number":5,"context_line":"    automated_clean field has been created on the node object, that allows to"},{"line_number":6,"context_line":"    override general automated_clean field. When automated_clean is disabled at"},{"line_number":7,"context_line":"    global level, but enabled at node level, the automated clean will be"},{"line_number":8,"context_line":"    performed only on those nodes."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3f79a3b5_b1e5ca40","line":6,"updated":"2018-09-26 09:39:05.000000000","message":"if you apply the suggestion change above, \"that allows ...\" can be removed.\n\nre next sentence: a field cannot be disabled, so \"When automated cleaning is disabled\"","commit_id":"5a082a17cb14b766997e4647833f21eaa9eabdac"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9173f5ef1efadb954d20ca4107e69c4a6e0aeffd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    automated_clean field has been created on the node object, that allows to"},{"line_number":6,"context_line":"    override general automated_clean field. When automated_clean is disabled at"},{"line_number":7,"context_line":"    global level, but enabled at node level, the automated clean will be"},{"line_number":8,"context_line":"    performed only on those nodes."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3f79a3b5_d1e88616","line":8,"updated":"2018-09-26 09:39:05.000000000","message":"\"When automated cleaning is disabled globally it will only be performed on nodes with the ``automated_clean`` field set to ``True``.\"","commit_id":"5a082a17cb14b766997e4647833f21eaa9eabdac"}]}
