)]}'
{"ironic/api/config.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5d9ab8a9f0f022b7222d20d88cd6c32ada0042bf","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \u0027acl_public_routes\u0027: [\u0027/\u0027, \u0027/v1\u0027],"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# WSME config to allow @wsme_pecan.wsexpose use response \u0027debuginfo\u0027 field."},{"line_number":36,"context_line":"wsme \u003d {"},{"line_number":37,"context_line":"    \u0027debug\u0027: cfg.CONF.debug,"},{"line_number":38,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BTSU%3D","line":35,"updated":"2013-11-27 16:59:23.000000000","message":"It took me awhile to understand this comment. If, in the future, there are additional configs for WSME, this comment won\u0027t be true, so would it be useful to put something like eg \"WSME Configurations. debug - allows @wsme_pecan.wsexpose to include exception tracebacks in the response\u0027s \u0027debuginfo\u0027 field\"? [Or is it too verbose, wrong?]","commit_id":"e1ab38c456946b4ef0ff383250aeb9f93dfdd178"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"90d638d3378ee5e0c2505e1bd8256038e0dbbe98","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \u0027acl_public_routes\u0027: [\u0027/\u0027, \u0027/v1\u0027],"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# WSME config to allow @wsme_pecan.wsexpose use response \u0027debuginfo\u0027 field."},{"line_number":36,"context_line":"wsme \u003d {"},{"line_number":37,"context_line":"    \u0027debug\u0027: cfg.CONF.debug,"},{"line_number":38,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BSsU%3D","line":35,"in_reply_to":"AAAATn%2F%2BTP0%3D","updated":"2013-11-27 19:35:27.000000000","message":"You could move the config comment inside the dict.","commit_id":"e1ab38c456946b4ef0ff383250aeb9f93dfdd178"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"495141d46c7a8aa2ed2aca2244ad54d1a6587180","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \u0027acl_public_routes\u0027: [\u0027/\u0027, \u0027/v1\u0027],"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# WSME config to allow @wsme_pecan.wsexpose use response \u0027debuginfo\u0027 field."},{"line_number":36,"context_line":"wsme \u003d {"},{"line_number":37,"context_line":"    \u0027debug\u0027: cfg.CONF.debug,"},{"line_number":38,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BTP0%3D","line":35,"in_reply_to":"AAAATn%2F%2BTSU%3D","updated":"2013-11-27 17:08:18.000000000","message":"True. I\u0027ll try to improove, TY :)\n\nInitially config was picked from here https://github.com/stackforge/wsme/blob/22787cd8d00e6b9b4cf9fb37d21534d2dda2d0cf/doc/integrate.rst#pecan\n\nbut yes, there could probably be more in future, so the comment will be outdated","commit_id":"e1ab38c456946b4ef0ff383250aeb9f93dfdd178"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f66f2659d000425d1d050a4af890860b10a66d1e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo.config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Server Specific Configurations"},{"line_number":20,"context_line":"server \u003d {"},{"line_number":21,"context_line":"    \u0027port\u0027: \u00276385\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BPNY%3D","line":18,"updated":"2013-11-28 13:34:42.000000000","message":"Just to be consistent should we add links to the documentation for the other options as well?","commit_id":"6dadf629c8d5f04b2f5dbc947ba5727daaef1058"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"e1393506da1d6e2a605933544e46d9156f415eee","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo.config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Server Specific Configurations"},{"line_number":20,"context_line":"server \u003d {"},{"line_number":21,"context_line":"    \u0027port\u0027: \u00276385\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BPJE%3D","line":18,"in_reply_to":"AAAATn%2F%2BPNY%3D","updated":"2013-11-28 13:51:04.000000000","message":"Yep, good idea, I\u0027ll add","commit_id":"6dadf629c8d5f04b2f5dbc947ba5727daaef1058"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f66f2659d000425d1d050a4af890860b10a66d1e","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo.config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Server Specific Configurations"},{"line_number":20,"context_line":"server \u003d {"},{"line_number":21,"context_line":"    \u0027port\u0027: \u00276385\u0027,"},{"line_number":22,"context_line":"    \u0027host\u0027: \u00270.0.0.0\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BPNw%3D","line":19,"updated":"2013-11-28 13:34:42.000000000","message":"https://pecan.readthedocs.org/en/latest/configuration.html#server-configuration","commit_id":"6dadf629c8d5f04b2f5dbc947ba5727daaef1058"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"1c2e9b444db60872f8521a0aa0f90b798a286c8f","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo.config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Server Specific Configurations"},{"line_number":20,"context_line":"server \u003d {"},{"line_number":21,"context_line":"    \u0027port\u0027: \u00276385\u0027,"},{"line_number":22,"context_line":"    \u0027host\u0027: \u00270.0.0.0\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BOxQ%3D","line":19,"in_reply_to":"AAAATn%2F%2BPNw%3D","updated":"2013-11-28 15:31:28.000000000","message":"Done","commit_id":"6dadf629c8d5f04b2f5dbc947ba5727daaef1058"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f66f2659d000425d1d050a4af890860b10a66d1e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \u0027host\u0027: \u00270.0.0.0\u0027"},{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Pecan Application Configurations"},{"line_number":26,"context_line":"app \u003d {"},{"line_number":27,"context_line":"    \u0027root\u0027: \u0027ironic.api.controllers.root.RootController\u0027,"},{"line_number":28,"context_line":"    \u0027modules\u0027: [\u0027ironic.api\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BPN0%3D","line":25,"updated":"2013-11-28 13:34:42.000000000","message":"https://pecan.readthedocs.org/en/latest/configuration.html#application-configuration","commit_id":"6dadf629c8d5f04b2f5dbc947ba5727daaef1058"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"1c2e9b444db60872f8521a0aa0f90b798a286c8f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \u0027host\u0027: \u00270.0.0.0\u0027"},{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Pecan Application Configurations"},{"line_number":26,"context_line":"app \u003d {"},{"line_number":27,"context_line":"    \u0027root\u0027: \u0027ironic.api.controllers.root.RootController\u0027,"},{"line_number":28,"context_line":"    \u0027modules\u0027: [\u0027ironic.api\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BOxU%3D","line":25,"in_reply_to":"AAAATn%2F%2BPN0%3D","updated":"2013-11-28 15:31:28.000000000","message":"Done","commit_id":"6dadf629c8d5f04b2f5dbc947ba5727daaef1058"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bf626a3ca6a9645374bf31d6d71a231c599ff5cb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from oslo.config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Server Specific Configurations"},{"line_number":20,"context_line":"# See https://pecan.readthedocs.org/en/latest/configuration.html#server-configuration # noqa"},{"line_number":21,"context_line":"server \u003d {"},{"line_number":22,"context_line":"    \u0027port\u0027: \u00276385\u0027,"},{"line_number":23,"context_line":"    \u0027host\u0027: \u00270.0.0.0\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BG%2FY%3D","line":20,"updated":"2013-12-02 14:37:42.000000000","message":"Dumb question. Why do you need to put \u0027# noqa\u0027 at the end of this (and also at line 27)","commit_id":"b10f08d0cff99f67639f5b9acdeb0c9dedc66968"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"e951c7d3f0c7d2f00728204051165dd29e2e1943","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from oslo.config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Server Specific Configurations"},{"line_number":20,"context_line":"# See https://pecan.readthedocs.org/en/latest/configuration.html#server-configuration # noqa"},{"line_number":21,"context_line":"server \u003d {"},{"line_number":22,"context_line":"    \u0027port\u0027: \u00276385\u0027,"},{"line_number":23,"context_line":"    \u0027host\u0027: \u00270.0.0.0\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BGr8%3D","line":20,"in_reply_to":"AAAATn%2F%2BG%2FY%3D","updated":"2013-12-02 15:23:02.000000000","message":"#noqa just because these lines are longer than 79 chars and I didn\u0027t want to split them into 2 lines \u003d) # noqa tells flake8 checker to omit the line","commit_id":"b10f08d0cff99f67639f5b9acdeb0c9dedc66968"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bf626a3ca6a9645374bf31d6d71a231c599ff5cb","unresolved":false,"context_lines":[{"line_number":37,"context_line":"# WSME Configurations"},{"line_number":38,"context_line":"# See https://wsme.readthedocs.org/en/latest/integrate.html#configuration"},{"line_number":39,"context_line":"wsme \u003d {"},{"line_number":40,"context_line":"    \u0027debug\u0027: cfg.CONF.debug,"},{"line_number":41,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BG%2BM%3D","line":40,"updated":"2013-12-02 14:37:42.000000000","message":"Your first patch had a comment about why this was needed. I thought it was useful, but maybe it wasn\u0027t? (Just want to make sure it wasn\u0027t unintentionally dropped.)","commit_id":"b10f08d0cff99f67639f5b9acdeb0c9dedc66968"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"e951c7d3f0c7d2f00728204051165dd29e2e1943","unresolved":false,"context_lines":[{"line_number":37,"context_line":"# WSME Configurations"},{"line_number":38,"context_line":"# See https://wsme.readthedocs.org/en/latest/integrate.html#configuration"},{"line_number":39,"context_line":"wsme \u003d {"},{"line_number":40,"context_line":"    \u0027debug\u0027: cfg.CONF.debug,"},{"line_number":41,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BGnY%3D","line":40,"in_reply_to":"AAAATn%2F%2BG%2BM%3D","updated":"2013-12-02 15:23:02.000000000","message":"No, this was intentionally. As I added links to docs I decided to not to provide inline explanations - all this info can be found in docs.","commit_id":"b10f08d0cff99f67639f5b9acdeb0c9dedc66968"}]}