)]}'
{"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"a1ae65aebabd79304d5914548f8fda2b86d83b78","unresolved":false,"context_lines":[{"line_number":422,"context_line":""},{"line_number":423,"context_line":"# Url of Ironic API service. If not set Ironic can get current"},{"line_number":424,"context_line":"# value from Keystone service catalog. (string value)"},{"line_number":425,"context_line":"#api_url\u003d\u003cNone\u003e"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"# Seconds between conductor heart beats. (integer value)"},{"line_number":428,"context_line":"#heartbeat_interval\u003d10"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAATn%2F99kY%3D","line":425,"updated":"2013-12-03 23:47:12.000000000","message":"Do we need this? Wouldn\u0027t getting it from keystone always be better? This doesn\u0027t seem related to the conductor heartbeat feature. Oh, I see its a stale sample config being fixed up. Nevermind.","commit_id":"1d861582167758caa03212a5475ab2c2407882f2"}],"ironic/api/controllers/v1/driver.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"45345dc5456161e7ea31e8fd0036a754b92466f4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    def get_all(self):"},{"line_number":64,"context_line":"        \"\"\"Retrieve a list of drivers.\"\"\""},{"line_number":65,"context_line":"        drivers \u003d pecan.request.dbapi.list_active_conductor_drivers("},{"line_number":66,"context_line":"                                     interval\u003dCONF.conductor.heartbeat_timeout)"},{"line_number":67,"context_line":"        return DriverList.convert(drivers)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F90Yk%3D","line":66,"updated":"2013-12-05 15:57:43.000000000","message":"I didn\u0027t notice and the tests didn\u0027t captured that, but this patch broke it because now the options is registered in the manager.py and so the API can\u0027t access it.","commit_id":"1d861582167758caa03212a5475ab2c2407882f2"}],"ironic/conductor/manager.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"05dd7d2c645bcc925becf5747fd1602633b3f8e1","unresolved":false,"context_lines":[{"line_number":65,"context_line":"]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"CONF \u003d cfg.CONF"},{"line_number":68,"context_line":"CONF.register_opts(conductor_opts, \u0027conductor\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class ConductorManager(service.PeriodicService):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9%2FJU%3D","line":68,"updated":"2013-12-03 18:44:31.000000000","message":"We already have a \u0027conductor\u0027 option group in the rpcapi.py file, I think we should put all the options of the same group together to make it easy to find them. Just move these options to the rpcapi.py file or move the option from there to here.\n\nhttps://github.com/openstack/ironic/blob/master/ironic/conductor/rpcapi.py#L33","commit_id":"6e057389451415aab155eca55ed4ddb11d9329f6"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8489345da325634543ba82e4db5c5f75efbebc0c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"CONF \u003d cfg.CONF"},{"line_number":68,"context_line":"CONF.register_opts(conductor_opts, \u0027conductor\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class ConductorManager(service.PeriodicService):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9%2B3g%3D","line":68,"in_reply_to":"AAAATn%2F9%2FJU%3D","updated":"2013-12-03 19:50:07.000000000","message":"Yes. I had already planned on moving (and renaming) that option group to this file, but it seemed more logical to do that in another patch. \n\nhttps://review.openstack.org/#/c/58895/\n\nI will refactor these patches to consolidate the options in this patch, instead of a later one.","commit_id":"6e057389451415aab155eca55ed4ddb11d9329f6"}],"ironic/tests/drivers/test_pxe.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"05dd7d2c645bcc925becf5747fd1602633b3f8e1","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        instance_uuid \u003d \u0027instance_uuid_123\u0027"},{"line_number":249,"context_line":"        CONF.set_default(\u0027pxe_append_params\u0027, \u0027test_param\u0027, group\u003d\u0027pxe\u0027)"},{"line_number":250,"context_line":"        CONF.set_default(\u0027api_url\u0027, \u0027http://192.168.122.184:6385\u0027,"},{"line_number":251,"context_line":"                group\u003d\u0027conductor\u0027)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        template \u003d \u0027ironic/tests/drivers/pxe_config.template\u0027"},{"line_number":254,"context_line":"        pxe_config_template \u003d open(template, \u0027r\u0027).read()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9%2FHA%3D","line":251,"updated":"2013-12-03 18:44:31.000000000","message":"nit: indentation","commit_id":"6e057389451415aab155eca55ed4ddb11d9329f6"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8489345da325634543ba82e4db5c5f75efbebc0c","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        instance_uuid \u003d \u0027instance_uuid_123\u0027"},{"line_number":249,"context_line":"        CONF.set_default(\u0027pxe_append_params\u0027, \u0027test_param\u0027, group\u003d\u0027pxe\u0027)"},{"line_number":250,"context_line":"        CONF.set_default(\u0027api_url\u0027, \u0027http://192.168.122.184:6385\u0027,"},{"line_number":251,"context_line":"                group\u003d\u0027conductor\u0027)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        template \u003d \u0027ironic/tests/drivers/pxe_config.template\u0027"},{"line_number":254,"context_line":"        pxe_config_template \u003d open(template, \u0027r\u0027).read()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9%2B3c%3D","line":251,"in_reply_to":"AAAATn%2F9%2FHA%3D","updated":"2013-12-03 19:50:07.000000000","message":"Done","commit_id":"6e057389451415aab155eca55ed4ddb11d9329f6"}]}