)]}'
{"ironic/drivers/modules/irmc/boot.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ada0850e9a909328b6592d69fab85591abc2c5b3","unresolved":false,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        deploy_iso_filename \u003d _get_iso_name(task.node, label\u003d\u0027deploy\u0027)"},{"line_number":291,"context_line":"        deploy_iso \u003d (\u0027file://\u0027 + os.path.join("},{"line_number":292,"context_line":"            CONF.irmc.remote_image_share_root, deploy_iso_filename))"},{"line_number":293,"context_line":"        boot_mode \u003d boot_mode_utils.get_boot_mode_for_deploy(task.node)"},{"line_number":294,"context_line":"        kernel_params \u003d CONF.pxe.pxe_append_params"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_c38984ca","side":"PARENT","line":292,"updated":"2018-08-09 06:34:22.000000000","message":"It seems this intends to reuse a file fetched in prepare_ramdisk(). However, this file is removed[1].\n\n[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/irmc/boot.py#L1012","commit_id":"989f87077847eef762e922bfe43ec44708404b91"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"58a4b5fc2f5679e28546b7c941b7eefb3df4433b","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        deploy_iso \u003d os.path.join("},{"line_number":292,"context_line":"            CONF.irmc.remote_image_share_root, deploy_iso_filename)"},{"line_number":293,"context_line":"        # Fetch deploy image before iso image creating"},{"line_number":294,"context_line":"        images.fetch(task.context, deploy_info[\u0027irmc_deploy_iso\u0027], deploy_iso)"},{"line_number":295,"context_line":"        deploy_iso \u003d \u0027file://\u0027 + deploy_iso"},{"line_number":296,"context_line":"        boot_mode \u003d boot_mode_utils.get_boot_mode_for_deploy(task.node)"},{"line_number":297,"context_line":"        kernel_params \u003d CONF.pxe.pxe_append_params"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_18229053","line":294,"updated":"2018-08-08 20:19:21.000000000","message":"This seems wrong. If we are in this else block, that means deploy_info[\u0027irmc_deploy_iso\u0027] is empty or missing. The second argument to fetch() is the href to fetch. What image is fetch() downloading?\n\nIs it image_href we want to fetch instead?","commit_id":"bf5a9db0abb3f0f88feed42d724d24aba10ea466"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"7c0b17c8634f5017fa40bab0c197521b6b93413a","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        deploy_iso \u003d os.path.join("},{"line_number":292,"context_line":"            CONF.irmc.remote_image_share_root, deploy_iso_filename)"},{"line_number":293,"context_line":"        # Fetch deploy image before iso image creating"},{"line_number":294,"context_line":"        images.fetch(task.context, deploy_info[\u0027irmc_deploy_iso\u0027], deploy_iso)"},{"line_number":295,"context_line":"        deploy_iso \u003d \u0027file://\u0027 + deploy_iso"},{"line_number":296,"context_line":"        boot_mode \u003d boot_mode_utils.get_boot_mode_for_deploy(task.node)"},{"line_number":297,"context_line":"        kernel_params \u003d CONF.pxe.pxe_append_params"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_24ade530","line":294,"in_reply_to":"3f79a3b5_18229053","updated":"2018-08-09 01:02:58.000000000","message":"Could you provide detail info why deploy[\u0027irmc_deploy_iso\u0027] is empty or missing? We are missing deploy[\u0027irmc_boot_iso\u0027] thus we will use deploy[\u0027irmc_deploy_iso\u0027] to create irmc_boot_iso. irmc_deploy_iso exist in deploy_info which use for deploy booting. In L267, we are checking irmc_boot_iso.\nimage_href is partition image (uec file), I am not sure it will be working with this image.","commit_id":"bf5a9db0abb3f0f88feed42d724d24aba10ea466"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"6cc6d4ac94a7f173eac1b72b03559e77cb7b69a7","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        deploy_iso \u003d os.path.join("},{"line_number":292,"context_line":"            CONF.irmc.remote_image_share_root, deploy_iso_filename)"},{"line_number":293,"context_line":"        # Fetch deploy image before iso image creating"},{"line_number":294,"context_line":"        images.fetch(task.context, deploy_info[\u0027irmc_deploy_iso\u0027], deploy_iso)"},{"line_number":295,"context_line":"        deploy_iso \u003d \u0027file://\u0027 + deploy_iso"},{"line_number":296,"context_line":"        boot_mode \u003d boot_mode_utils.get_boot_mode_for_deploy(task.node)"},{"line_number":297,"context_line":"        kernel_params \u003d CONF.pxe.pxe_append_params"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_9f8d2233","line":294,"in_reply_to":"3f79a3b5_24ade530","updated":"2018-08-09 02:01:48.000000000","message":"I once tested the irmc-virtual-media boot, I think the irmc_deploy_iso exists at this point.","commit_id":"bf5a9db0abb3f0f88feed42d724d24aba10ea466"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"a5427005c51a5ee93c492675e08e7c005e8aa0d2","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        deploy_iso \u003d os.path.join("},{"line_number":292,"context_line":"            CONF.irmc.remote_image_share_root, deploy_iso_filename)"},{"line_number":293,"context_line":"        # Fetch deploy image before iso image creating"},{"line_number":294,"context_line":"        images.fetch(task.context, deploy_info[\u0027irmc_deploy_iso\u0027], deploy_iso)"},{"line_number":295,"context_line":"        deploy_iso \u003d \u0027file://\u0027 + deploy_iso"},{"line_number":296,"context_line":"        boot_mode \u003d boot_mode_utils.get_boot_mode_for_deploy(task.node)"},{"line_number":297,"context_line":"        kernel_params \u003d CONF.pxe.pxe_append_params"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d67295e3","line":294,"in_reply_to":"3f79a3b5_9f8d2233","updated":"2018-08-09 14:25:58.000000000","message":"Oops, I misread the if statement above. I thought it was `if deploy_info.get(\u0027irmc_deploy_iso\u0027):`. Sorry!","commit_id":"bf5a9db0abb3f0f88feed42d724d24aba10ea466"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ada0850e9a909328b6592d69fab85591abc2c5b3","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        images.create_boot_iso(task.context, boot_iso_fullpathname,"},{"line_number":304,"context_line":"                               kernel_href, ramdisk_href,"},{"line_number":305,"context_line":"                               deploy_iso, root_uuid,"},{"line_number":306,"context_line":"                               kernel_params, boot_mode)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        driver_internal_info[\u0027irmc_boot_iso\u0027] \u003d boot_iso_filename"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_43f1f46a","line":305,"range":{"start_line":305,"start_character":31,"end_line":305,"end_character":41},"updated":"2018-08-09 06:34:22.000000000","message":"Isn\u0027t it enough to pass deploy_info[\u0027iso_deploy_iso\u0027] here? The ISO will be fetched in create_boot_iso().","commit_id":"bf5a9db0abb3f0f88feed42d724d24aba10ea466"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"7c1b17ab95d898818348763f4df8acae657d466d","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        images.create_boot_iso(task.context, boot_iso_fullpathname,"},{"line_number":304,"context_line":"                               kernel_href, ramdisk_href,"},{"line_number":305,"context_line":"                               deploy_iso, root_uuid,"},{"line_number":306,"context_line":"                               kernel_params, boot_mode)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        driver_internal_info[\u0027irmc_boot_iso\u0027] \u003d boot_iso_filename"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_baa7c54f","line":305,"range":{"start_line":305,"start_character":31,"end_line":305,"end_character":41},"in_reply_to":"3f79a3b5_43f1f46a","updated":"2018-08-09 10:10:18.000000000","message":"Yeah. This change will fetch direct from Glance to tmp folder without pass into remote_image_share_root folder before fetch into tmp folder. Thanks.","commit_id":"bf5a9db0abb3f0f88feed42d724d24aba10ea466"}],"ironic/tests/unit/drivers/modules/irmc/test_boot.py":[{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"6cc6d4ac94a7f173eac1b72b03559e77cb7b69a7","unresolved":false,"context_lines":[{"line_number":482,"context_line":"        image_props_mock.return_value \u003d {\u0027kernel_id\u0027: \u0027kernel_uuid\u0027,"},{"line_number":483,"context_line":"                                         \u0027ramdisk_id\u0027: \u0027ramdisk_uuid\u0027}"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        CONF.irmc.remote_image_share_name \u003d \u0027/remote_image_share_root\u0027"},{"line_number":486,"context_line":"        boot_mode_mock.return_value \u003d \u0027uefi\u0027"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_198dc47a","line":485,"updated":"2018-08-09 02:01:48.000000000","message":"This seems incorrect. It should be CONF.irmc.remote_image_share_root. The assignment is already in the setUp(). So I suggest you remove this and some similar places by another patch.","commit_id":"bf5a9db0abb3f0f88feed42d724d24aba10ea466"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"d94abc4ec4c48aa217a2074a4c1e8a8b08e85683","unresolved":false,"context_lines":[{"line_number":482,"context_line":"        image_props_mock.return_value \u003d {\u0027kernel_id\u0027: \u0027kernel_uuid\u0027,"},{"line_number":483,"context_line":"                                         \u0027ramdisk_id\u0027: \u0027ramdisk_uuid\u0027}"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        CONF.irmc.remote_image_share_name \u003d \u0027/remote_image_share_root\u0027"},{"line_number":486,"context_line":"        boot_mode_mock.return_value \u003d \u0027uefi\u0027"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d5ddb270","line":485,"in_reply_to":"3f79a3b5_198dc47a","updated":"2018-08-09 13:26:54.000000000","message":"Done","commit_id":"bf5a9db0abb3f0f88feed42d724d24aba10ea466"}]}