)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0753cafdd8f283995bcb7d5d9d67c4f109797b0c","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"If no block devices are available the deployment should be aborted"},{"line_number":12,"context_line":"immediately and the provision state of the node should be set as"},{"line_number":13,"context_line":"DEPLOYFAIL."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Id1a23578b0e6c7f69bbf6e5a76f3e42f37980ba6"},{"line_number":16,"context_line":"Partial-Bug: #1251525"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2BERM%3D","line":13,"updated":"2013-12-02 21:48:25.000000000","message":"Hmm. If I understand it, the code (conductor/manager.py) sets the node\u0027s provision_state to ERROR, not DEPLOYFAIL. Not sure which it should be. Since you\u0027re porting the fix from baremetal, maybe it has changed in ironic, to ERROR?","commit_id":"aaf8ce68f14a07b6aaaa0216b4387b06fdbfbfe6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d1b4c03d0fb2885310151e0ada2a5d3f9903f6b8","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"If no block devices are available the deployment should be aborted"},{"line_number":12,"context_line":"immediately and the provision state of the node should be set as"},{"line_number":13,"context_line":"DEPLOYFAIL."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Id1a23578b0e6c7f69bbf6e5a76f3e42f37980ba6"},{"line_number":16,"context_line":"Partial-Bug: #1251525"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2BBgM%3D","line":13,"in_reply_to":"AAAATn%2F%2BERM%3D","updated":"2013-12-03 10:54:57.000000000","message":"/me thinks that DEPLOYFAIL state makes more sense in this case. But, after the inclusion of the \u0027last_error\u0027 field maybe having only one ERROR state might be enough :/\n\nI will just remove that part of the commit message, since it\u0027s not that relevant for this change and at first glance we might need a new patch up to sort iron out this thing about having diff types of error states.\n\nI will give it some thought.\n\nThanks Ruby for pointing that out :)","commit_id":"aaf8ce68f14a07b6aaaa0216b4387b06fdbfbfe6"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0753cafdd8f283995bcb7d5d9d67c4f109797b0c","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    except processutils.ProcessExecutionError as err:"},{"line_number":200,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":201,"context_line":"            # Log output if there was a error"},{"line_number":202,"context_line":"            LOG.error(_(\"Deploy to address %s failed.\") % address)"},{"line_number":203,"context_line":"            LOG.error(_(\"Command: %s\") % err.cmd)"},{"line_number":204,"context_line":"            LOG.error(_(\"StdOut: %r\") % err.stdout)"},{"line_number":205,"context_line":"            LOG.error(_(\"StdErr: %r\") % err.stderr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BEVM%3D","side":"PARENT","line":202,"updated":"2013-12-02 21:48:25.000000000","message":"To be consistent, do you also want to log this string in the error for InstanceDeployFailure below? (If you feel like it, maybe remove the comment above this line; it doesn\u0027t add much value.)","commit_id":"7393c49931f0f20dc2a3fcb0d29338399372dd05"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d1b4c03d0fb2885310151e0ada2a5d3f9903f6b8","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    except processutils.ProcessExecutionError as err:"},{"line_number":200,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":201,"context_line":"            # Log output if there was a error"},{"line_number":202,"context_line":"            LOG.error(_(\"Deploy to address %s failed.\") % address)"},{"line_number":203,"context_line":"            LOG.error(_(\"Command: %s\") % err.cmd)"},{"line_number":204,"context_line":"            LOG.error(_(\"StdOut: %r\") % err.stdout)"},{"line_number":205,"context_line":"            LOG.error(_(\"StdErr: %r\") % err.stderr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BBiI%3D","side":"PARENT","line":202,"in_reply_to":"AAAATn%2F%2BEVM%3D","updated":"2013-12-03 10:54:57.000000000","message":"haha makes sense to me, will do :)\n\nThanks","commit_id":"7393c49931f0f20dc2a3fcb0d29338399372dd05"}]}