)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5a39437a6d384bb2bbc831a2ed580ebe8008edc1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Strip \u0027/\u0027 from api_url string for PXE driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Because ironic_api_url PXE option used in hardcoded script for posting"},{"line_number":10,"context_line":"callback data we should use only url string without \u0027/\u0027 on the end."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iddd237e8aa90fd17f836cfd2060468f34e0de232"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9vDo%3D","line":10,"updated":"2013-12-06 15:32:26.000000000","message":"Hey buddy, can you give it a bit more insight?\n\nIs it related to https://review.openstack.org/#/c/59770/2/elements/deploy-ironic/init.d/80-deploy-ironic (line 44) ?\n\nI gave that ^^^ a try and yes it looks like a WSME bug: http://paste.openstack.org/show/54600/\n\nMy suggestion is: Could file a bug against WSME and link it with this patch? (or if there\u0027s a bug already just link it)\n\nBecause just by reading the commit message its unclear why the \u0027/\u0027 needs to be removed, it says shouldn\u0027t not have a \u0027/\u0027 but it\u0027s missing why.\n\nThank you!","commit_id":"415ef00732673c5d3721a6d277ac46351181570c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"abe5fb64326a002c67dd71838b399dc6f74f27f3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Strip \u0027/\u0027 from api_url string for PXE driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Because ironic_api_url PXE option used in hardcoded script for posting"},{"line_number":10,"context_line":"callback data we should use only url string without \u0027/\u0027 on the end."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iddd237e8aa90fd17f836cfd2060468f34e0de232"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9QuE%3D","line":10,"in_reply_to":"AAAATn%2F9UUM%3D","updated":"2013-12-13 11:34:42.000000000","message":"Right thanks guys for the explanation. I agree it\u0027s not a bug and also that having double slash in the URL is an error in the code. I just called attention on that because seems that most servers seems to ignore the extra slash that\u0027s why I thought wsme/pecan should as well.","commit_id":"415ef00732673c5d3721a6d277ac46351181570c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"ed8e5222d0ca94d90f70be9712dfa30efcdeb962","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Strip \u0027/\u0027 from api_url string for PXE driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Because ironic_api_url PXE option used in hardcoded script for posting"},{"line_number":10,"context_line":"callback data we should use only url string without \u0027/\u0027 on the end."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iddd237e8aa90fd17f836cfd2060468f34e0de232"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9iYs%3D","line":10,"in_reply_to":"AAAATn%2F9i%2FM%3D","updated":"2013-12-10 13:45:16.000000000","message":"Lucas, if this is WSME/Pecan bug this bug only minor. In paths based on filesystem hierarchy aaa/bbb and aaa//bbb is the same file, and webservers work like this. But Pecan not linked to filesystem hierarchy and can to process // as empty value. And AFAIK \u0027//\u0027 case in path is not standardized in RFCs.","commit_id":"415ef00732673c5d3721a6d277ac46351181570c"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"5b15f94d8fbf45bc3bc4102094f011bca11d03fe","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Strip \u0027/\u0027 from api_url string for PXE driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Because ironic_api_url PXE option used in hardcoded script for posting"},{"line_number":10,"context_line":"callback data we should use only url string without \u0027/\u0027 on the end."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iddd237e8aa90fd17f836cfd2060468f34e0de232"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9UUM%3D","line":10,"in_reply_to":"AAAATn%2F9iYs%3D","updated":"2013-12-12 18:02:18.000000000","message":"In filesystem and many web-based systems, /path/to/foo and /path/to/foo/ are validly different resources. That WSME treats these differently is not a bug, IMHO (whether the error message is accurate or not is another story...).","commit_id":"415ef00732673c5d3721a6d277ac46351181570c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fc6c98075f4d2d523c805609c42e9dd0ba2956f7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Strip \u0027/\u0027 from api_url string for PXE driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Because ironic_api_url PXE option used in hardcoded script for posting"},{"line_number":10,"context_line":"callback data we should use only url string without \u0027/\u0027 on the end."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iddd237e8aa90fd17f836cfd2060468f34e0de232"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9i%2FM%3D","line":10,"in_reply_to":"AAAATn%2F9p7k%3D","updated":"2013-12-10 11:36:08.000000000","message":"That\u0027s what the paste shows. The first request (without the \u0027/\u0027) it\u0027s grand, returns saying that the method is not supported, that\u0027s a fine response.\n\nBut the second I just added the \u0027/\u0027 (http://127.0.0.1:6385//v1...) at the end of the URL and I got a complete different response.\n\n{\"error_message\": \"{\\\"debuginfo\\\": null, \\\"faultcode\\\": \\\"Client\\\", \\\"faultstring\\\": \\\"Expected an uuid or int but received None.\\\"}\"}\n\n... Now why I think it\u0027s a bug is because that extra should be ignore, just like other URLs, for e.g\n\nThe URL for this commit message:\n\nhttps://review.openstack.org:443/#/c/60205/1//COMMIT_MSG\n\nWith an extra \u0027/\u0027 it won\u0027t give you any weird error, it will simple ignore the empty resource and take u to the same place. Not give you an error saying it\u0027s expect a paramater. That\u0027s why I think it\u0027s a WSME/Pecan bug.\n\nhttps://review.openstack.org:443//#/c/60205/1//COMMIT_MSG","commit_id":"415ef00732673c5d3721a6d277ac46351181570c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"06755195fa01d8334e982f2ec6904a401f79eb86","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Strip \u0027/\u0027 from api_url string for PXE driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Because ironic_api_url PXE option used in hardcoded script for posting"},{"line_number":10,"context_line":"callback data we should use only url string without \u0027/\u0027 on the end."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iddd237e8aa90fd17f836cfd2060468f34e0de232"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9p7k%3D","line":10,"in_reply_to":"AAAATn%2F9vDo%3D","updated":"2013-12-09 08:33:06.000000000","message":"\u0027Is it related to ...\u0027 - yes.\nLucas, IMO this not a WSME bug. In your example we have 1) OK, \u0027fake\u0027 driver does not support \u0027pass_deploy_info\u0027 method. 2) Bad URL. Admin can set api url option manually http://127.0.0.1:6385 or http://127.0.0.1:6385/, in last case right \u0027/\u0027 should be stripped.","commit_id":"415ef00732673c5d3721a6d277ac46351181570c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"97ff033672ff06d2fdbbb86497a686e822b3a1d4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Strip \u0027/\u0027 from api_url string for PXE driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Because ironic_api_url PXE option used in hardcoded script for posting"},{"line_number":10,"context_line":"callback data we should use only url string without \u0027/\u0027 on the end."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iddd237e8aa90fd17f836cfd2060468f34e0de232"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9vAo%3D","line":10,"in_reply_to":"AAAATn%2F9vDo%3D","updated":"2013-12-06 15:33:56.000000000","message":"Sorry, by \"link with this path\" I mean to add a Relate-Bug: # tag on the commit message","commit_id":"415ef00732673c5d3721a6d277ac46351181570c"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5a39437a6d384bb2bbc831a2ed580ebe8008edc1","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            \u0027deployment_aki_path\u0027: pxe_info[\u0027deploy_kernel\u0027][1],"},{"line_number":163,"context_line":"            \u0027deployment_ari_path\u0027: pxe_info[\u0027deploy_ramdisk\u0027][1],"},{"line_number":164,"context_line":"            \u0027aki_path\u0027: pxe_info[\u0027kernel\u0027][1],"},{"line_number":165,"context_line":"            \u0027ari_path\u0027: pxe_info[\u0027ramdisk\u0027][1],"},{"line_number":166,"context_line":"            \u0027ironic_api_url\u0027: ironic_api.rstrip(\u0027/\u0027),"},{"line_number":167,"context_line":"            \u0027pxe_append_params\u0027: CONF.pxe.pxe_append_params,"},{"line_number":168,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9vDE%3D","line":165,"updated":"2013-12-06 15:32:26.000000000","message":"I think a briefly NOTE here + the link for the bug would be good","commit_id":"415ef00732673c5d3721a6d277ac46351181570c"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"b00e2f0d2039b827ec4b7265a8090b8d1b2bef2a","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    :returns: A formated string with the file content."},{"line_number":147,"context_line":"    \"\"\""},{"line_number":148,"context_line":"    LOG.debug(_(\"Building PXE config for deployment %s.\") % node[\u0027id\u0027])"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    ironic_api \u003d CONF.conductor.api_url or keystone.get_service_url()"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    deploy_key \u003d utils.random_alnum(32)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9UTA%3D","line":149,"updated":"2013-12-12 18:05:06.000000000","message":"I think it would be more readable if you moved the rstrip(\u0027/\u0027) call up to here, and added an inline comment explaining why it is necessary.","commit_id":"63eb36b0ca74ed815084b2d00b65e046fa9efcd8"}],"ironic/tests/drivers/test_pxe.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5a39437a6d384bb2bbc831a2ed580ebe8008edc1","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    def test__build_pxe_config(self):"},{"line_number":248,"context_line":"        instance_uuid \u003d \u0027instance_uuid_123\u0027"},{"line_number":249,"context_line":"        CONF.set_default(\u0027pxe_append_params\u0027, \u0027test_param\u0027, group\u003d\u0027pxe\u0027)"},{"line_number":250,"context_line":"        # NOTE: right \u0027/\u0027 should be removed from url string"},{"line_number":251,"context_line":"        CONF.set_default(\u0027api_url\u0027, \u0027http://192.168.122.184:6385/\u0027,"},{"line_number":252,"context_line":"                group\u003d\u0027conductor\u0027)"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9vCw%3D","line":250,"updated":"2013-12-06 15:32:26.000000000","message":"If we add a NOTE at the pxe.py with the link for the bug I think this NOTE here can be removed.","commit_id":"415ef00732673c5d3721a6d277ac46351181570c"}]}